qiurui
/
uvgrtp-base
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

multiplex: Improve comments in reception_flow

This commit is contained in:
Heikki Tampio 2023-07-25 08:00:13 +03:00
parent 5e13a1140e
commit c5472ca9b9
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/reception_flow.cc
View File

@ -554,7 +554,7 @@ void uvgrtp::reception_flow::process_packet(int rce_flags)
uint8_t version = (*(uint8_t*)&ptr[0] >> 6) & 0x3; uint8_t version = (*(uint8_t*)&ptr[0] >> 6) & 0x3;
if (handlers != nullptr) { if (handlers != nullptr) {
/* SSRC match is found -> call handlers */ /* SSRC match or SSRC 0 is found -> call handlers */
rtp_error_t retval; rtp_error_t retval;
uvgrtp::frame::rtp_frame* frame = nullptr; uvgrtp::frame::rtp_frame* frame = nullptr;
@ -587,10 +587,11 @@ void uvgrtp::reception_flow::process_packet(int rce_flags)
retval = handlers->rtp.handler(nullptr, rce_flags, &ptr[0], size, &frame); retval = handlers->rtp.handler(nullptr, rce_flags, &ptr[0], size, &frame);
} }
else { else {
/* This should only happen when ZRTP is enabled. If the remote stream is done first, they start sending /* Received a packet but RTP handler is not installed.
* This should only happen when ZRTP is enabled. If the remote stream is done first, they start sending
* media already before we have handled the last ZRTP ConfACK packet. This should not be a problem * media already before we have handled the last ZRTP ConfACK packet. This should not be a problem
* as we only lose the first frame or a few at worst. If this causes issues, the sender * as we only lose the first frame or a few at worst. If this causes issues, the sender
* may, for example, sleep for 50 or so milliseconds to give us time to complete ZRTP. */ * may, for example, sleep for 50 or so milliseconds to give us time to complete ZRTP negotiation. */
UVG_LOG_DEBUG("RTP handler is not (yet?) installed"); UVG_LOG_DEBUG("RTP handler is not (yet?) installed");
} }