From af1b94adbe3a5020891542e8611fa2edf4a3c953 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Joni=20R=C3=A4s=C3=A4nen?= <joni.rasanen@iki.fi>
Date: Mon, 11 Jul 2022 14:42:47 +0300
Subject: [PATCH] rtcp: Remove duplicate function from API to set SDES items

---
 include/uvgrtp/rtcp.hh | 5 ++---
 src/rtcp.cc            | 4 ++++
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/include/uvgrtp/rtcp.hh b/include/uvgrtp/rtcp.hh
index 15559b9..d6303e8 100644
--- a/include/uvgrtp/rtcp.hh
+++ b/include/uvgrtp/rtcp.hh
@@ -121,9 +121,6 @@ namespace uvgrtp {
              */
             rtp_error_t send_sdes_packet(const std::vector<uvgrtp::frame::rtcp_sdes_item>& items);
 
-
-            rtp_error_t set_sdes_items(const std::vector<uvgrtp::frame::rtcp_sdes_item>& items);
-
             /**
              * \brief Send an RTCP APP packet
              *
@@ -293,6 +290,8 @@ namespace uvgrtp {
 
         private:
 
+            rtp_error_t set_sdes_items(const std::vector<uvgrtp::frame::rtcp_sdes_item>& items);
+
             /* read the header values from rtcp packet */
             void read_rtcp_header(const uint8_t* buffer, size_t& read_ptr, 
                 uvgrtp::frame::rtcp_header& header);
diff --git a/src/rtcp.cc b/src/rtcp.cc
index 09226e4..96e965b 100644
--- a/src/rtcp.cc
+++ b/src/rtcp.cc
@@ -1555,6 +1555,10 @@ rtp_error_t uvgrtp::rtcp::send_sdes_packet(const std::vector<uvgrtp::frame::rtcp
         return RTP_INVALID_VALUE;
     }
 
+    /* TODO: the SDES should be sent later in a compound packets, this saves it, but until the padding has
+     * been implemented, the sending cannot be implemented. */
+    set_sdes_items(items);
+
     size_t rtcp_packet_size = get_sdes_packet_size(items);
     uint8_t* frame = new uint8_t[rtcp_packet_size];
     memset(frame, 0, rtcp_packet_size);