qiurui
/
uvgrtp-base
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rtcp: Remove duplicate function from API to set SDES items

This commit is contained in:
Joni Räsänen 2022-07-11 14:42:47 +03:00
parent 97baf19437
commit af1b94adbe
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/uvgrtp/rtcp.hh
View File

@ -121,9 +121,6 @@ namespace uvgrtp {
*/
rtp_error_t send_sdes_packet(const std::vector<uvgrtp::frame::rtcp_sdes_item>& items);
rtp_error_t set_sdes_items(const std::vector<uvgrtp::frame::rtcp_sdes_item>& items);
/**
* \brief Send an RTCP APP packet
*
@ -293,6 +290,8 @@ namespace uvgrtp {
private:
rtp_error_t set_sdes_items(const std::vector<uvgrtp::frame::rtcp_sdes_item>& items);
/* read the header values from rtcp packet */
void read_rtcp_header(const uint8_t* buffer, size_t& read_ptr,
uvgrtp::frame::rtcp_header& header);

4
src/rtcp.cc
View File

@ -1555,6 +1555,10 @@ rtp_error_t uvgrtp::rtcp::send_sdes_packet(const std::vector<uvgrtp::frame::rtcp
return RTP_INVALID_VALUE;
}
/* TODO: the SDES should be sent later in a compound packets, this saves it, but until the padding has
* been implemented, the sending cannot be implemented. */
set_sdes_items(items);
size_t rtcp_packet_size = get_sdes_packet_size(items);
uint8_t* frame = new uint8_t[rtcp_packet_size];
memset(frame, 0, rtcp_packet_size);