qiurui
/
uvgrtp-base
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

multiplex: Improve documentation in reception_flow.cc

This commit is contained in:
Heikki Tampio 2023-06-22 13:16:12 +03:00
parent 89cd3fa1d0
commit 7d15cb52f8
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/reception_flow.cc
View File

@ -596,7 +596,11 @@ void uvgrtp::reception_flow::process_packet(int rce_flags)
retval = handlers->rtp.handler(nullptr, rce_flags, &ptr[0], size, &frame);
}
else {
UVG_LOG_INFO("RTP handler is null");
/* This should only happen when ZRTP is enabled. If the remote stream is done first, they start sending
* media already before we have handled the last ZRTP ConfACK packet. This should not be a problem
* as we only lose the first frame or a few at worst. If this causes issues, the sender
* may, for example, sleep for 50 or so milliseconds to give us time to complete ZRTP. */
UVG_LOG_DEBUG("RTP handler is not (yet?) installed");
}
/* If SRTP is enabled -> send through SRTP handler */
@ -634,9 +638,11 @@ void uvgrtp::reception_flow::process_packet(int rce_flags)
}
/* -------------------- Holepuncher check -------------------------- */
else {
// No functionality needed
UVG_LOG_INFO("Holepuncher packet");
else if (version == 0x00) {
/* In uvgRTP, holepuncher packets are packets with a payload of 0x00, as in RFC 6263 4.1
* This can be changed to other alternatives specified in the RFC if current
* implementation causes problems with user packets. */
UVG_LOG_DEBUG("Holepuncher packet");
break;
}
}

2
src/session.cc
View File

@ -152,7 +152,7 @@ uvgrtp::media_stream* uvgrtp::session::create_stream(uint16_t src_port, uint16_t
return nullptr;
}
} else if (rce_flags & RCE_SRTP_KMNGMNT_USER) {
//UVG_LOG_DEBUG("SRTP with user-managed keys enabled, postpone initialization");
UVG_LOG_DEBUG("SRTP with user-managed keys enabled, postpone initialization");
if (stream->init() != RTP_OK) {
UVG_LOG_ERROR("Failed to initialize media stream %s:%d/%d", remote_address_.c_str(), src_port, dst_port);
delete stream;

2
src/zrtp.cc
View File

@ -407,7 +407,7 @@ rtp_error_t uvgrtp::zrtp::begin_session()
/* Copy interesting information from receiver's
* message buffer to remote capabilities struct for later use */
hello.parse_msg(hello_, session_, hello_len_);
UVG_LOG_INFO("ZRTP Hello parsed");
UVG_LOG_DEBUG("ZRTP Hello parsed");
if (session_.capabilities.version != ZRTP_VERSION) {
/* Section 4.1.1: