rv1126-uboot/cmd
Tom Rini c9bf1d5a23 UPSTREAM: cmd/pxe.c: Rework bootargs construction to clarify string checks
As the code currently stands, we first check that the length of the
given command line, along with ip_str/mac_str along with an additional 1
for the NULL termination will fit within the buffer we have, and if not,
we return an error.  The way this code was originally written however
left Coverity "unhappy" due to using strcat rather than strncat.
Switching this to strncat however causes clang to be unhappy that we
aren't enforcing the "1" portion within strncat.  Rather than further
re-work the code to include a "- 1" in this case as well, make the
strcat code only be done within the else side of the length test.  This
keeps both clang and Coverity happy.

Fixes: 48ee0a87bc46 ("cmd/pxe.c: Rework initrd and bootargs handling slightly")
Change-Id: I6a3d3ea54d6b7e1f3c2aed200b2f706f42d570d4
Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit 59ee8f83b6e77550d5697fced4899e9b5173981f)
2018-01-17 15:27:28 +08:00
..
fastboot Add support for fastboot command over UDP 2017-11-14 10:55:44 +08:00
mvebu env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
.gitignore cmd: rework "license" command 2017-02-08 15:56:28 -05:00
Kconfig UPSTREAM: cmd: Make CMD_LZMA / CMD_UNZIP default y if CMD_BOOTI 2018-01-17 15:27:28 +08:00
Makefile cmd: bootrkp: add a cmd for rockchip rkimg bootloader 2017-12-08 18:13:25 +08:00
aes.c Rename aes.h to uboot_aes.h 2017-04-12 13:28:27 -04:00
android_ab_select.c android: Fix off-by-one error when joining strings 2017-11-14 10:55:47 +08:00
android_cmds.c android: Implement A/B slot select. 2017-11-14 10:55:46 +08:00
armflash.c
bdinfo.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
bedbug.c powerpc: remove 4xx support 2017-07-03 17:35:28 -04:00
blk_common.c UPSTREAM: cmd: blk: Use LBAFU in the common block command 2018-01-16 18:16:48 +08:00
blkcache.c cmd: blkcache: simplify sub-command handling 2016-04-11 12:44:38 -04:00
blob.c crypto/fsl: Update blob cmd to accept 64bit addresses 2016-08-02 09:45:39 -07:00
bmp.c dm: Use uclass_first_device_err() where it is useful 2016-03-14 15:34:50 -06:00
boot.c
boot_android.c cmd: boot_android: support legacy aosp image from rockchip 2017-12-08 18:13:25 +08:00
bootefi.c UPSTREAM: efi_loader: bootefi hello should use loadaddr 2018-01-16 18:16:48 +08:00
booti.c arm64: booti: allow to place kernel image anywhere in physical memory 2017-03-14 20:40:23 -04:00
bootm.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
bootmenu.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
bootrkp.c rockchip: bootrkp: add log when boot from recovery 2018-01-12 15:40:12 +08:00
bootstage.c
bootz.c bootz/booti: relocate ramdisk if CONFIG_SYS_BOOT_RAMDISK_HIGH set 2017-01-24 10:35:55 -05:00
cache.c
cbfs.c env: Rename common functions related to setenv() 2017-08-16 08:23:32 -04:00
charge.c cmd: charge: support command parameter 2017-12-05 09:34:48 +08:00
clk.c
config.c cmd: add a new command "config" to show .config contents 2017-02-08 15:56:26 -05:00
console.c
cpu.c cmd: cpu: refactor to ensure devices are probed and improve code style 2017-05-10 16:16:09 +02:00
cramfs.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
cros_ec.c dm: core: Add flags parameter to device_remove() 2017-04-04 20:15:10 -06:00
dataflash_mmc_mux.c
date.c
demo.c
dfu.c common: dfu: saperate the dfu common functionality 2016-09-27 23:30:18 +02:00
diag.c
disk.c cmd: Rework disk.c usage 2016-09-09 15:53:14 -04:00
display.c
echo.c
eeprom.c Convert CONFIG_CMD_EEPROM et al to Kconfig 2017-05-22 09:33:49 -04:00
efi.c
elf.c env: Rename some other getenv()-related functions 2017-08-16 08:31:11 -04:00
ethsw.c cmd: ethsw: Fix out-of-bounds error 2017-06-16 10:11:42 -04:00
exit.c
ext2.c
ext4.c
fastboot.c treewide: replace with error() with pr_err() 2018-01-17 15:27:28 +08:00
fat.c cmd/fat: Do not crash on write when <bytes> is not specified 2016-09-23 08:55:58 -04:00
fdc.c Fix spelling of "occurred". 2016-05-02 18:37:09 -04:00
fdt.c UPSTREAM: fdt: Switch to using the verbose overlay application method 2018-01-16 18:16:48 +08:00
fitupd.c
flash.c UPSTREAM: Drop CONFIG_HAS_DATAFLASH 2018-01-17 15:27:28 +08:00
fpga.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
fpgad.c
fs.c efi_loader: Pass file path to payload 2016-04-18 17:11:36 -04:00
fs_uuid.c
fuse.c treewide: replace #include <asm/errno.h> with <linux/errno.h> 2016-09-23 17:55:42 -04:00
gettime.c
gpio.c gpio: Report errors when GPIOs cannot be read 2016-03-17 21:27:37 -06:00
gpt.c UPSTREAM: cmd/gpt.c, cmd/nvedit.c, tools/fit_image.c: Rework recent fixes for Coverity 2018-01-17 15:27:28 +08:00
hash.c
help.c Drop command-processing code when CONFIG_CMDLINE is disabled 2016-04-01 17:17:40 -04:00
host.c cmd/host: add missing \n in help text 2017-01-20 09:15:24 -05:00
i2c.c i2c: Set default I2C bus number 2017-03-28 06:27:54 +02:00
ide.c cmd: ide: Make the first device the default one 2017-09-10 12:27:43 -04:00
ini.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
io.c cmd/io.c: Fix comparison of unsigned expression warning 2017-05-12 08:37:38 -04:00
iotrace.c
irq.c
itest.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
jffs2.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
led.c cmd/led.c: Remove unnecessary check on 'cmd' value 2017-05-12 08:37:38 -04:00
legacy_led.c led: Mark existing driver as legacy 2017-04-14 19:38:57 -06:00
license.c cmd: rework "license" command 2017-02-08 15:56:28 -05:00
load.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
load_android.c Move Android Image loading logic to image-android.c 2017-11-14 10:55:46 +08:00
log.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
lzmadec.c env: Rename common functions related to setenv() 2017-08-16 08:23:32 -04:00
mac.c
md5sum.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
mdio.c common: miiphyutil: Work and report phy address in hex in mdio cmd 2016-12-02 14:36:02 +01:00
mem.c UPSTREAM: Drop CONFIG_HAS_DATAFLASH 2018-01-17 15:27:28 +08:00
mfsl.c
mii.c
misc.c cmd: misc: Add support for fractions in sleep 2016-07-25 12:00:05 -04:00
mmc.c UPSTREAM: blk: Remove various places that do flush cache after read 2018-01-16 18:16:48 +08:00
mmc_spi.c dm: block: Rename device number member dev to devnum 2016-03-14 15:34:50 -06:00
mp.c
mtdparts.c mtdparts: Fix uninitialized scalar usage 2017-08-26 16:59:24 -04:00
nand.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
net.c Add support for fastboot command over UDP 2017-11-14 10:55:44 +08:00
nvedit.c UPSTREAM: env: Drop CONFIG_ENV_IS_IN_DATAFLASH 2018-01-17 15:27:28 +08:00
nvme.c nvme: Adjust the 'nvme' command to use blk_common_cmd() 2017-08-28 07:17:15 -04:00
onenand.c cmd/onenand.c: block align warning 2016-10-06 20:57:42 -04:00
part.c env: Rename setenv() to env_set() 2017-08-16 08:22:18 -04:00
pci.c Kconfig: Drop CONFIG_CMD_PCI_ENUM 2017-08-11 15:41:51 -04:00
pcmcia.c powerpc, 8xx: remove support for 8xx 2017-06-12 08:37:55 -04:00
pmic.c
pxe.c UPSTREAM: cmd/pxe.c: Rework bootargs construction to clarify string checks 2018-01-17 15:27:28 +08:00
qfw.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
read.c cmd/read.c: Fix checking blk_dread return value 2017-08-20 09:54:30 -04:00
reginfo.c powerpc: Remove unneccessary #ifdefs in reginfo 2017-07-22 22:22:49 -04:00
regulator.c treewide: replace with error() with pr_err() 2018-01-17 15:27:28 +08:00
reiser.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
remoteproc.c
rknand.c drivers: rknand: add nand flash drivers for Rockchip SoC 2017-10-20 08:59:10 +08:00
rockusb.c treewide: replace with error() with pr_err() 2018-01-17 15:27:28 +08:00
sata.c dm: sata: Support driver model with the 'sata' command 2017-08-17 16:44:17 +09:00
scsi.c dm: scsi: Adjust the 'scsi' command to use blk_common_cmd() 2017-08-17 16:44:16 +09:00
setexpr.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
sf.c dm: core: Add flags parameter to device_remove() 2017-04-04 20:15:10 -06:00
sha1sum.c
sound.c
source.c env: Rename getenv_hex(), getenv_yesno(), getenv_ulong() 2017-08-16 08:30:32 -04:00
spi.c cmd: spi: check return value of strdup 2016-03-27 09:12:55 -04:00
spl.c UPSTREAM: cmd: spl: fix compiling error when CONFIG_CMD_SPL_WRITE_SIZE not defined 2018-01-17 15:27:28 +08:00
strings.c
terminal.c
test.c
thordown.c treewide: replace with error() with pr_err() 2018-01-17 15:27:28 +08:00
time.c UPSTREAM: cmd/time.c: Initialize 'repeatable' variable 2018-01-17 15:27:28 +08:00
tpm.c env: Rename common functions related to setenv() 2017-08-16 08:23:32 -04:00
tpm_test.c treewide: replace with error() with pr_err() 2018-01-17 15:27:28 +08:00
trace.c env: Rename getenv_hex(), getenv_yesno(), getenv_ulong() 2017-08-16 08:30:32 -04:00
tsi148.c
ubi.c cmd: ubi: remove unnecessary logical constraint 2017-04-18 06:08:32 +02:00
ubifs.c
universe.c
unzip.c env: Rename common functions related to setenv() 2017-08-16 08:23:32 -04:00
usb.c dm: usb: Adjust the 'usb' command to use blk_common_cmd() 2017-08-17 16:44:16 +09:00
usb_gadget_sdp.c treewide: replace with error() with pr_err() 2018-01-17 15:27:28 +08:00
usb_mass_storage.c treewide: replace with error() with pr_err() 2018-01-17 15:27:28 +08:00
version.c display_options: Refactor to allow obtaining the banner 2017-07-11 10:08:19 -06:00
ximg.c env: Rename getenv_hex(), getenv_yesno(), getenv_ulong() 2017-08-16 08:30:32 -04:00
yaffs2.c
zfs.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
zip.c env: Rename common functions related to setenv() 2017-08-16 08:23:32 -04:00