Commit Graph

1418 Commits

Author SHA1 Message Date
Joseph Chen eaa66b0d6a tools: fit: add "/totalsize" property for itb size
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
Change-Id: I1aa87d5c0e1dd39762c470b134c4d8a57cab4f29
2020-05-25 14:57:18 +08:00
Joseph Chen 4405dc8ff2 Revert "tools: fit_image: add -Wno-unit_address_vs_reg"
This reverts commit 75e20461a6.

Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
Change-Id: If549e8a3129569b82c625b0afb0b453f4ad56f60
2020-05-18 16:22:31 +08:00
Yifeng Zhao c64e256218 tools: add pack kernel tool for rv1108
Change-Id: I9a8e1b2884bcc26144162e3ca838750bef69907a
Signed-off-by: Yifeng Zhao <zyf@rock-chips.com>
Signed-off-by: Zhichao Yu <zhichao.yu@rock-chips.com>
2020-04-29 15:44:35 +08:00
zain wang 5033bc62fe tools: trust_merger: copy ImageSize from Component to ComponentData
rk3399_miniloader_v1.25 read ImageSize from ComponentData first now.
So copy ImageSize to ComponentData (named LoadSize).

For other chips, ComponentDate->LoadSize is reserved area, it no
inflence on other chips.

Signed-off-by: zain wang <wzz@rock-chips.com>
Change-Id: I51468aa3fad90d8999c1943ab9c720f7c90cefc1
2020-04-24 14:54:31 +08:00
Joseph Chen 75e20461a6 tools: fit_image: add -Wno-unit_address_vs_reg
It seems this check is default enabled in high version DTC,
so let's force disable this noisy check since we don't care
about "reg" property for fit image.

<stdout>: Warning (unit_address_vs_reg): Node /images/uboot@1 has a unit name, but no reg property
<stdout>: Warning (unit_address_vs_reg): Node /images/uboot@1/hash@1 has a unit name, but no reg property
<stdout>: Warning (unit_address_vs_reg): Node /images/optee@1 has a unit name, but no reg property
<stdout>: Warning (unit_address_vs_reg): Node /images/optee@1/hash@1 has a unit name, but no reg property
<stdout>: Warning (unit_address_vs_reg): Node /images/fdt@1 has a unit name, but no reg property
<stdout>: Warning (unit_address_vs_reg): Node /images/fdt@1/hash@1 has a unit name, but no reg property
<stdout>: Warning (unit_address_vs_reg): Node /configurations/conf@1 has a unit name, but no reg property
......

Change-Id: I7d934bce66742c76397c004def1919bf4c6e7672
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2020-04-12 11:03:47 +08:00
Joseph Chen cdd8fbe39e tools: fit_info: add END address of property
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
Change-Id: Icf988f3620d261f7742ee3db4e427e1783211f13
2020-03-31 18:20:47 +08:00
Jeffy Chen 68c4faa3f8 rockchip: mkimage: support packing optional second level boot-loader
Support packing optional second level boot-loader:

$ ./tools/mkimage -n rk3399 -T rksd -d \
  rk3399_ddr_800MHz_v1.24.bin:rk3399_miniloader_v1.19.bin out -v
Adding Image rk3399_ddr_800MHz_v1.24.bin
Size 116492(pad to 116736)
Adding Image rk3399_miniloader_v1.19.bin
Size 88060(pad to 88064)
Image Type:   Rockchip RK33 (SD/MMC) boot image
Init Data Size: 116736 bytes
Boot Data Size: 88064 bytes

Mainly parse init file and boot file from datafile option, copy them to
the image, and padding each one to 2KB boundary.

NOTE:
I don't know much about rknand.c, and there's no way to verify it now.
The output image is unchanged though (with a few extra padding).

Haven't got any feedback from upstream yet...But whatever, let's do this!

Change-Id: I0ce98a44634cfcd8acfe9a3e2cfbe3ee0107fba4
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
2020-03-30 14:52:08 +08:00
Joseph Chen 96f5441ec8 common: fit: support spl fit image check by tools/fit_check_sign
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
Change-Id: I0e03a90d50290e18c6fb2cd44516c352f3695290
2020-03-29 09:57:04 +08:00
Joseph Chen 40d08d0f10 tools: mkimage: support pack empty file for multi image
Muilt image bootflow requires ramdisk as a mandory component,
so that we have to pack a empty ramdisk into multi image at
some time.

Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
Change-Id: I551ae832fbc68514ead0a3337148593e3113394f
2020-03-27 18:02:55 +08:00
Joseph Chen 3a183b396d tools: image-host: support add all images of sub list into hash list
Like the image list assigned by "loadables" = ...

configurations {
	default = "config@1";
	config@1 {
		...
		loadables = "uboot@1", "atf@2", "atf@3";
		signature@1 {
			algo = "sha1,rsa2048";
			key-name-hint = "dev";
			sign-images = "fdt", "firmware", "loadables";
		};
	};
};

Assuming the maximum sub image count is 5.

Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
Change-Id: I0454f6ad108342b5d85e831f7920baac642fb01a
2020-03-16 11:42:38 +08:00
Joseph Chen f63c73dbcf tools: image-host: not allow keys to be missing
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
Change-Id: Ibae5d152244721926189fa3873d113bde212b4fb
2020-03-16 11:42:38 +08:00
Joseph Chen f965884c36 tools: fit image: fix external image sign fail issue
Extract external data before adding verification data (must)
with '-p' args, and shrink fdt blob to minimum size excluding
the external data size.

Add more space for device tree to avoid failed when insert new
contents.

Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
Change-Id: I202cba2b25306eb1023861bf8660d7ce6a1e4a34
2020-03-16 11:42:38 +08:00
Joseph Chen acd4329027 common: fit: unify fit image align size
Set 512 as default align size in order to access any image
by block unit.

Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
Change-Id: I372ca7ff567816cb8369aff9d1fbe9865fa6d933
2020-03-16 11:42:38 +08:00
Jon Lin 6520ac9cab rockchip: rkcommon: don't set image head for signed image
Reserve "RSAK" tag

Change-Id: Ibfe2e6d83bd89ce75dfa0b7fc97038037a181cab
Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
2019-12-13 15:16:21 +08:00
Joseph Chen 467d16db4b tools: rockchip: resource_tool: independent on other files
Merge all codes into resource_tool.c

Sync from kernel-4.4:
(0787850 rk: scripts/resource_tool: add sha1 for file entry)

Change-Id: Iff379458086f1623e7e5126dcb532b178d94c684
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-11-12 19:32:12 +08:00
Joseph Chen 5e817a0ea4 tools: rockchip: resource_tool: add sha1 for file entry
Change-Id: If7bd80d68019f6ea5ad737793ed996d47134b568
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-11-07 08:55:31 +08:00
Joseph Chen 3aff587f06 tools: rockchip: remove useless checksum
Change-Id: I0b40f0b0677920abfe873fd6b8db23475f113a78
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-11-05 12:25:19 +08:00
Jason Zhu a3ded4d4a1 rockchip: mkimage: add support for RK1808
Reserve 8K sram for maskrom.

Change-Id: I890d93b6c9a8f4ca50a2c0b30de9b07816e68e8f
Signed-off-by: Jason Zhu <jason.zhu@rock-chips.com>
2019-09-12 15:06:43 +08:00
Joseph Chen 24f9e652a5 tools: rockchip: boot_merger: add option to enable rc4 flag
The legacy chips like rk3188 maskrom require all IDB data with RC4,
the boot_merger pack the loader with a rc4 flag in header,
and the upgrade_tool will write the data with rc4 to IDB area.

usage:
boot_merger --rc4 RKBOOT/RK310BMINIALL.ini

and you can see log below if success with RC4:
* enable RC4 for IDB data(both ddr and preloader)

Test on rk3188.

Change-Id: If221a32a462bb43bef67aae802adff5e1e8436ac
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-06-25 08:30:37 +08:00
Joseph Chen 52243bce13 tools: rockchip: loaderimage: add "--prepath" support
Add prefix path of binary path.

Change-Id: I30fe03e0614c7724f452ad8b9d3800acd92db02c
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-06-25 08:30:37 +08:00
Joseph Chen 5f0203b772 tools: rockchip: boot_merger: ignore "--prepath" for output path
Change-Id: I89335926cc161c484e813fbd8a699935762f1a34
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-06-25 08:30:37 +08:00
Joseph Chen 2e6f3f4c09 tool: rockchip: boot/trust_merger: ignore prepath when it's already exist
Change-Id: I33b1b14ba7b68ab08e1e61bf98e476da3b13b56a
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-05-27 11:15:19 +08:00
Joseph Chen e311da2458 tools: rockchip: boot/trust_merger: add "--prepath" support
Add prefix path of binary path.

Change-Id: I576b9fa40f88a1ee0701f1ff776d25d4e3ed747b
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-05-23 18:19:46 +08:00
Andy Yan 912343c03a rockchip: mkimage: add support for RK3308
Usage:

 (1) tools/mkimage -n rk3308 -T rksd -d tpl/u-boot-tpl.bin idbloader.img
 (2) cat spl/u-boot-spl.bin >> idbloader.img
 (3) upgrade_tool wl 0x40 idbloader.img

Note:
  When use a ddr binary from rkbin as tpl, use it replace u-boot-tpl.bin in (1)

Change-Id: Ia6694754ed70d2d5cce04f62dcfac538291f7386
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
2019-05-09 16:48:47 +08:00
Joseph Chen 9ad3008a7c tools: rockchip: boot/trust_merger: fix prefix append error
- still append prefix if not match legacy prefix;
- ignore append prefix for output;

Change-Id: I1a8fc77ce73cbf169af49ce40ce3a0731861c617
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-04-11 14:28:27 +08:00
Joseph Chen 45c2a034cd tools: rockchip: boot/trust_merge: fix '--replace" missing append new path
Change-Id: Icddfb2ce9c7ba6f4b4e558eb5833ba79d0e7b976
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-04-11 12:15:20 +08:00
Joseph Chen 2bbbd780f8 tools: rockchip: loaderimage: print file size with KB
load addr is 0x600000!
pack input ./u-boot.bin
pack file size: 484551(473 KB)
crc = 0xfef42a0e
uboot version: U-Boot 2017.09-02804-ge3e39ee-dirty (Apr 10 2019 - 14:11:39)

Change-Id: If8fbdd943e328db41523ded47deeedfe8c6bde0e
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-04-11 12:13:41 +08:00
Joseph Chen 7582895812 tools: rockchip: trust_merger: support "--ignore-bl32"
Change-Id: Ia8385dc1b41893d475b4f14c222dca98c9d52aba
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2019-02-13 16:54:03 +08:00
Masahiro Yamada 0e00a84cde UPSTREAM: libfdt: move headers to <linux/libfdt.h> and <linux/libfdt_env.h>
Thomas reported U-Boot failed to build host tools if libfdt-devel
package is installed because tools include libfdt headers from
/usr/include/ instead of using internal ones.

This commit moves the header code:
  include/libfdt.h         -> include/linux/libfdt.h
  include/libfdt_env.h     -> include/linux/libfdt_env.h

and replaces include directives:
  #include <libfdt.h>      -> #include <linux/libfdt.h>
  #include <libfdt_env.h>  -> #include <linux/libfdt_env.h>

Change-Id: I6c0f7e50e8b571106627f25ddac008a62bd2994e
Reported-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
2018-12-24 17:20:37 +08:00
Paul Kocialkowski fe47e2a1d2 UPSTREAM: tools: Include U-Boot libfdt headers from their actual path
There are no headers for libfdt in lib/libfdt, as they are instead
located in scripts/dtc/libfdt. Specifying lib/libfdt for headers
inclusion in host tools results in using the system libfdt headers,
which is not what we want. Change this to the proper path.

Change-Id: I3ad1329f563d1083828ce168e2c4ee791b553da8
Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
2018-12-24 17:20:37 +08:00
Masahiro Yamada 4e2c3b8c76 UPSTREAM: libfdt: migrate fdt_rw.c to a wrapper of scripts/dtc/libfdt/fdt_rw.c
The only difference between scripts/dtc/libfdt/fdt_rw.c and
lib/libfdt/fdt_rw.c is fdt_remove_unused_strings().

It is only used by fdtgrep, so we do not need to compile it for U-Boot
image.  Move it to tools/libfdt/fdw_rw.c so that lib/libfdt/fdt_rw.c
can be a wrapper of scripts/dtc/libfdt/fdt_rw.c.

Change-Id: I6e2578d4bfdf75438d3aa1cb51f270f34527d37d
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
2018-12-24 17:20:37 +08:00
Masahiro Yamada 9862beb6eb UPSTREAM: tools: include necessary headers explicitly
Several host-tools use "bool" type without including <stdbool.h>.
This relies on the crappy header inclusion chain.

tools/Makefile has the following line:

  HOST_EXTRACFLAGS += -include $(srctree)/include/libfdt_env.h \

All host-tools are forced to include libfdt_env.h even if they are
totally unrelated to FDT.  Then, <stdbool.h> is indirectly included
as follows:

     include/libfdt_env.h
  -> include/linux/types.h
  -> <stdbool.h>

I am fixing this horrible crap.  In advance, I need to add necessary
include directives explicitly.  tools/fdtgrep.c needs more; <fctl.h>
for open() and <errno.h> for errno.

Change-Id: Ic2b0e0d4c417841f7eeb152e486d63fdfd1a4eff
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
2018-12-24 17:20:37 +08:00
Masahiro Yamada fbedfcfba2 UPSTREAM: libfdt: migrate include/libfdt_env.h to a wrapper
libfdt_env.h is supposed to provide system-dependent defines.

scripts/dtc/libfdt/libfdt_env.h from upstream DTC is suitable
for user-space, so we should use this for USE_HOSTCC case.

For compiling U-Boot, we need to override such system-dependent
defines, so use <linux/libfdt_env.h> imported from Linux.

<libfdt.h> selects a proper one.  Maybe, we should split header
inclusion completely, but I do not want too many patches at one.

I can rip off the include/libfdt_env.h from HOST_EXTRACFLAGS.

Change-Id: I6f5ea1067cd3ada1c8ece0c39b7bf43382c58ff6
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
2018-12-24 17:20:37 +08:00
Joseph Chen 23ba6841cc tools: rockchip: support hostprogs for pack tools
- include: boot_merge/trust_merge/loaderimage/resource_tool/checksum;
- porting from rkdevelop and base on commit 8fd1d8f
  (resource: get resource primary from boot partition);
- clean generated binary file when execute clean command;

Change-Id: I41c1893c2da0a0f25c2d39dbbd933f89fbb04948
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2018-09-28 10:12:53 +08:00
Kever Yang cab28f403d tool: rkcommon: add support for px30
PX30 have 10K sram available.

Change-Id: I67c565c84d00bc0141d79c437035993746ea9245
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
2018-09-27 17:07:56 +08:00
Joseph Chen 0d889c3a8d tools: env: make fw_printenv statically linked
this makes sure fw_printenv works normally on most
platforms without care about C library.

Change-Id: If3b942d2fadb293eeeb00695a10b708847a827ad
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
2018-07-09 20:09:20 +08:00
Masahiro Yamada 70b70db64a UPSTREAM: libfdt: migrate fdt_wip.c to a wrapper of scripts/dtc/libfdt/fdt_wip.c
Now, lib/libfdt/fdt_wip.c is the same as scripts/dtc/libfdt/fdt_wip.c

Change the former to a wrapper of the latter.

Change-Id: Ifce4c63db38146297c14218ef94d226bf6e3bb27
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit 26e961c8cfdff00c5c9389d301d9a2eb10eb844c)
2018-01-17 15:27:28 +08:00
Michal Simek 008a6da324 UPSTREAM: tools: mkimage: Extend mkimage to also include pmufw
The patch is adding external pmufw "Platform Management Unit firmware"
to boot.bin image. Boot.bin is a Xilinx format which bootrom is capable
to read and boot the system. pmufw is copied to the header data section
follows by u-boot-spl.bin. pmufw is consumed by PMU unit (Microblaze)
and SPL runs on a53-0.

This is generated command line when PMUFW_INIT_FILE is setup.

./tools/mkimage -T zynqmpimage -R ./"" -n
./"board/xilinx/zynqmp/pmufw.bin" -d spl/u-boot-spl.bin spl/boot.bin

Change-Id: I74fc17513dd99b876ab9c08ded6ad41a7b0cd3de
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit c85a6b79d10ed8a098997370cbc4fb233ddcb13b)
2018-01-17 15:27:28 +08:00
Simon Glass e71e2ceacf UPSTREAM: dtoc: Fix up tests
The tool has changed slightly since it was originally written. Update the
tests to suit.

Change-Id: I6935a7c4cc16e1a3e5c617133b12d1982e640c74
Signed-off-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit aab660fe18ac24ee859a203f517f939685af5e10)
2018-01-17 15:27:28 +08:00
Simon Glass 3abaad4c1f UPSTREAM: patman: Fix up tests to pass with newest checkpatch
The checkpatch tool was updated but the patman tests were not. Fix this.

Change-Id: Ia5ff7589c32205754eb9818ddd2ecafcc6b2b3c1
Signed-off-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit 6c328f29752224f15b7f098d8676f9eeed269a85)
2018-01-17 15:27:28 +08:00
Masahiro Yamada 141b078475 UPSTREAM: tools: use files from scripts/dtc/libfdt where possible
Prior to this commit, tools/Makefile pulls all libfdt files from
lib/libfdt.

lib/libfdt/ and scripts/dtc/libfdt have the same copies for the
followings 6 files:
  fdt.c fdt_addresses.c fdt_empty_tree.c fdt_overlay.c fdt_strerr.c
  fdt_sw.c

This commit changes them to #include ones from scripts/dtc/libfdt.

Unfortunately, U-Boot locally modified the following 3 files:
  fdt_ro.c fdt_wip.c fdt_rw.c

I did not touch them in order to avoid unpredictable impact.

The fdt_region.c is U-Boot own file.  This is also borrowed from
lib/libfdt/.

Change-Id: I3e8fcd9f84cda502a0eca504896ab29d7f840d16
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit b38ad663a4b4ccd91a43b12e2d65179dbd2b40cb)
2018-01-17 15:27:28 +08:00
Masahiro Yamada 815366520a UPSTREAM: pylibfdt: move pylibfdt to scripts/dtc/pylibfdt and refactor makefile
The pylibfdt is used by dtoc (and, indirectly by binman), but there
is no reason why it must be generated in the tools/ directory.

Recently, U-Boot switched over to the bundled DTC, and the directory
structure under scripts/dtc/ now mirrors the upstream DTC project.
So, scripts/dtc/pylibfdt is the best location.

I also rewrote the Makefile in a cleaner Kbuild style.

The scripts from the upstream have been moved as follows:

  lib/libfdt/pylibfdt/setup.py -> scripts/dtc/pylibfdt/setup.py
  lib/libfdt/pylibfdt/libfdt.i -> scripts/dtc/pylibfdt/libfdt.i_shipped

The .i_shipped is coped to .i during building because the .i must be
located in the objtree when we build it out of tree.

Change-Id: I48233cbae93794809397b7160234469f66fa11dc
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit 15b97f5c5e6d88e0560c6928f3acd01c999a494d)
2018-01-17 15:27:28 +08:00
Jan Kundrát d8bee3a4c9 UPSTREAM: Do not attempt to use the systemwide libfdt
U-Boot bundles a patched copy of libfdt, so it's wrong to attempt to
include it <like/this>. This breaks the build for me when I have dtc
fully installed in my host -- as happened earlier tonight with
Buildroot, for example.

There are several other occurrences throughout the code where '<libfdt'
matches. I'm not modifying these because I have no clue why the
<systemwide> include style is being used -- IMHO wrongly.

Change-Id: Ie733b1454f8d76439abee770af54eca3699323f7
Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit b95a5190ba9284a06f9d0c56589bcb4080b4710a)
2018-01-17 15:27:28 +08:00
Stefan Agner adf9b6dead UPSTREAM: tools: env: allow to print U-Boot version
The fw_env utility family has a default environment compiled in
which ties it quite strongly to the U-Boot source/config it has
been built with. Allow to display the U-Boot version it has been
built with using the -v/--version argument.

Change-Id: Iba67d9f520d9315874758ddafe9d277610719c9d
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit 84d46e7e8948780d7ca20c24dfc7b653b900f728)
2018-01-17 15:27:28 +08:00
Masahiro Yamada 710f83a718 UPSTREAM: tools: image: fix node name of signature node in FIT
Both "conf_name" and "sig_name" point to the name of config node.
The latter should be the name of the signature node.

Change-Id: I2be3ce4c9644a9dd6814d63cbc49f6e9348490d5
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit 16067e6b87293eeb1fc4bac3edc0fd675b94d1a8)
2018-01-17 15:27:28 +08:00
Bin Meng 18a87e935e UPSTREAM: tools: env: Add embedded.c to .gitignore
Change-Id: I81b0fec8fef268598f054103e859250315218ef9
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit 3b306c37cdf7488254d078ce63f508eaedb2be41)
2018-01-17 15:27:28 +08:00
Tuomas Tynkkynen 9a544e36a8 UPSTREAM: env: Drop CONFIG_ENV_IS_IN_DATAFLASH
Last user of this option went away in commit:

fdc7718999 ("board: usb_a9263: Update to support DT and DM")

Change-Id: Ie6cec28e4daf26b669f3f35db026427bdb47a5b6
Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit 7b7341d7f3ee915c89a7f8ab7054e39872057d90)
2018-01-17 15:27:28 +08:00
Mirza, Taimoor 8cc080c024 UPSTREAM: tools/mkimage: Fix DTC run command to handle file names with space
fit_handle_file function does not quote input and output files while preparing
command to run DTC to convert .its to .itb. This results in a failure if input
or output files contain spaces in their names. Quote input and output files in
DTC command to avoid this failure.

Change-Id: I866d740ef8e2c9f28059c55757bbcbdb017cd74a
Signed-off-by: Mirza, Taimoor <Taimoor_Mirza@mentor.com>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit a6e9810495bc929b6beafb88f557cdaadf87fc83)
2018-01-17 15:27:28 +08:00
Tom Rini 017aad0449 UPSTREAM: cmd/gpt.c, cmd/nvedit.c, tools/fit_image.c: Rework recent fixes for Coverity
The recent changes to these files did not completely fix the previous
issues, or introduced different (minor) issues.  In cmd/gpt.c we need to
dereference str_disk_guid to be sure that malloc worked.  In
cmd/nvedit.c we need to be careful that we can also fit in that leading
space when adding to the string.  And in tools/fit_image.c we need to
re-work the error handling slightly in fit_import_data() so that we only
call munmap() once.  We have two error paths here, one where we have an
fd to close and one where we do not.  Adjust labels to match this.

Change-Id: I66fafd0ed8d1c290a7773bba5ece8d11bfc15b50
Reported-by: Coverity (CID: 167366, 167367, 167370)
Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit bf52fcdef4aac242b5e6b6b9827acf6d69ce1951)
2018-01-17 15:27:28 +08:00
Tom Rini 0757e90bee UPSTREAM: tools/fit_image.c: Update some return code paths
Coverity has found some problems with the return paths in parts of this
code.  We have a case where we were going to the wrong part of the
unwind (open() failed so we cannot close the fd), a case where we were
only free()ing our buf on the error path and finally a case where we did
not munmap in the failure path.

Change-Id: I31ee7b7099b7f2a4ec0c11c247029df5eb9d8552
Reported-by: Coverity (CID: 138492, 138495, 143064)
Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit 3c2dff5490831f85f06aa78aad5ef537b661cecf)
2018-01-17 15:27:28 +08:00