qiurui
/
rv1126-uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

UPSTREAM: usb: ulpi: kconfig: Remove meaningless choice default 

'default' on a choice refers to the symbol selected by default, not to
the choice mode, so 'default n' is meaningless.

No functional changes. Optional choices implicitly default to n mode
(and there is no way to make them default to another mode).

Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
which prints the following warning:

	warning: the default selection n (undefined) of <choice> (defined at drivers/usb/ulpi/Kconfig:3) is not contained in the choice

I've added a corresponding warning to the C tools too, which is
currently in linux-next: https://patchwork.kernel.org/patch/9983667/

Change-Id: Ie3ab0ee0a9b4bb6112ebe348adca240daca3c066
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
(cherry picked from commit a43aebee89acf57b4e22018f401cffc9fef4fd85)
This commit is contained in:
Ulf Magnusson 2018-01-30 14:07:05 +01:00 committed by Frank Wang
parent b3c55b569e
commit 9a4089eeb7
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/usb/ulpi/Kconfig
View File

@ -3,7 +3,6 @@ comment "ULPI drivers"
choice choice
prompt "ULPI Viewport type" prompt "ULPI Viewport type"
optional optional
default n
help help
Select ULPI viewport (SoC-side interface to ULPI) implementation Select ULPI viewport (SoC-side interface to ULPI) implementation
appropriate for the device if you want to communicate with appropriate for the device if you want to communicate with