qiurui
/
rv1126-uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

UPSTREAM: phy: Fix possible NULL pointer deference 

It is possible that users of generic_phy_*() APIs may pass a valid
struct phy pointer but phy->dev can be NULL, leading to NULL pointer
deference in phy_dev_ops().

So call generic_phy_valid() to verify that phy and phy->dev are both
valid.

Change-Id: I0d19180ae8524eb240f4afd6ea55d5d0f2907798
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Wyon Bi <bivvy.bi@rock-chips.com>
(cherry picked from commit 64b69f8c89352975c25730bcca4bf8af2296297f)
This commit is contained in:
Vignesh Raghavendra 2020-05-20 22:35:41 +05:30 committed by Jianhong Chen
parent 1bac1f3947
commit 37a5e4d859
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/phy/phy-uclass.c
View File

@ -100,7 +100,7 @@ int generic_phy_init(struct phy *phy)
{
struct phy_ops const *ops;
if (!phy)
if (!generic_phy_valid(phy))
return 0;
ops = phy_dev_ops(phy->dev);
@ -111,7 +111,7 @@ int generic_phy_reset(struct phy *phy)
{
struct phy_ops const *ops;
if (!phy)
if (!generic_phy_valid(phy))
return 0;
ops = phy_dev_ops(phy->dev);
@ -122,7 +122,7 @@ int generic_phy_exit(struct phy *phy)
{
struct phy_ops const *ops;
if (!phy)
if (!generic_phy_valid(phy))
return 0;
ops = phy_dev_ops(phy->dev);
@ -133,7 +133,7 @@ int generic_phy_power_on(struct phy *phy)
{
struct phy_ops const *ops;
if (!phy)
if (!generic_phy_valid(phy))
return 0;
ops = phy_dev_ops(phy->dev);
@ -144,7 +144,7 @@ int generic_phy_power_off(struct phy *phy)
{
struct phy_ops const *ops;
if (!phy)
if (!generic_phy_valid(phy))
return 0;
ops = phy_dev_ops(phy->dev);