The primary image, in the case of multi-image sources, may not
necessarily be the first image.
Test images produced with patched version of enc-heif that
allowed overriding the primary image. The correct primary
image is green, while the other image is red.
Pick-to: 6.10
Change-Id: Iba26b13fdb4898d7babc5fb173ad38b16f864e80
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
No apparent reason for this to suddenly start failing while all the
similar ones pass, so blacklist it to unblock CI while investigating.
Task-number: QTBUG-130617
Change-Id: I1112f39b75b3d54d5d612ea95e010a5ad31c062b
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
The canRead() function is supposed to check for the presence of a 12
byte magic number (header). It used qstrncmp() for this, but as the
byte sequence starts with 0 values, the comparison would end after the
first byte, and any data also starting with a 0 value would be taken
as matching.
This would make QImageReader mis-identify the image format of image
data where an explicit suffix or data format was lacking, resulting in
image reading failures. The macheif autotest would hit this issue and
fail erroneously.
Pick-to: 6.8 6.7 6.5
Change-Id: I39b1ba9a344478fe1255c89f19488f0bc54d2ec1
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
This work has been kindly sponsored by the QGIS project
(https://qgis.org/).
Change-Id: I09cf744f1b8c907a296a8525ec11a4980282d743
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
According to QUIP-18 [1], all test files should be
LicenseRef-Qt-Commercial OR GPL-3.0-only
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.7
Task-number: QTBUG-121787
Change-Id: I9cf2eefe287996e7cc75fbde3832d4692797522e
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
We've been requiring C++17 since Qt 6.0, and our qAsConst use finally
starts to bother us (QTBUG-99313), so time to port away from it
now.
Since qAsConst has exactly the same semantics as std::as_const (down
to rvalue treatment, constexpr'ness and noexcept'ness), there's really
nothing more to it than a global search-and-replace.
Task-number: QTBUG-99313
Change-Id: Ie5b276174d8446a6ddbca11a6a8e3e07d3bca675
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
The original image stopped working on macOS 13 Ventura, both with our
image plugin and in Preview. It's unclear why the original image works
fine in Preview on macOS 12, but that's an Apple bug, and our image
plugin tests should not have to worry about platform differences like
that.
Task-number: QTBUG-104210
Pick-to: 6.4 6.2
Change-Id: If57fce379a2d9bcb92757e3f2f7e903b079e700b
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
is set, so that integrations don't fail.
In the future we might add build-only tests like we have in qtbase.
Pick-to: 6.4
Task-number: QTBUG-96056
Change-Id: I84ccc93eb02b807702117b814d4969ccec62ffe2
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
CMakeLists.txt and .cmake files of significant size
(more than 2 lines according to our check in tst_license.pl)
now have the copyright and license header.
Existing copyright statements remain intact
Task-number: QTBUG-88621
Change-Id: Ifbf0be4c6f03259f9d084bbef4cf44fa60bf3fde
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
License files are organized under LICENSES directory.
Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I775d4a0c07b2b82a097d36649203e7f6223fdc51
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
- There is no possibility to use file system on our INTEGRITY test device.
Add test sciping
Task-number: QTBUG-99123
Pick-to: 6.2 6.3
Change-Id: Icb84eb73b6010d4aa4ca19a4d3a0ecaa02216a6f
Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io>
[ChangeLog][TIFF] Read/write support for floating point image
formats added.
Change-Id: Ib952ef9bfe7e38426f018515a5f92ed56c732a6f
Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io>
This includes removal of the corresponding .prev_CMakeLists.txt files.
Pick-to: 6.1
Task-number: QTBUG-88742
Change-Id: I43bd344cd515aa2f671d012c64f281e8fc4793c9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Modify special case locations to use the new API as well.
Task-number: QTBUG-86815
Change-Id: I045015a4f3b78f15570ea401d2b99ea1b75ec414
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
A few changes happened since last update:
- CMake target names are now consistent with Qt 5 names
- ZLIB handling
- TIFF 3rd party handling
- Standalone tests simplification
- Updates in the SUBDIRS project
- Other minor changes
Change-Id: I85cca79d38feca44c5b78dae48c79779ae05e288
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
All recent versions of libtiff has support for the 64bit-indexed
BigTIFF format. Allow reading it by recognizing its magic number.
[ChangeLog][TIFF] Add support for reading BigTIFF
Fixes: QTBUG-80538
Change-Id: I7fcb72d77e4a0bdcb38ab96e9f6cfaff7cf4ad49
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Adds reading and writing of embedded color spaces on the TIFF plugin.
Change-Id: I53e8a16ff65f7986e9d51a5b543335e27b43e346
Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io>
Bumped version.
Adjusted code for removal of the TransformedByDefault enum.
The enum is removed in Qt6 code, so existing tests need to be adapted
to call setAutoTransform() for plugins that usually had autoTransform
enabled by default.
The new Qt6 default is that all plugins have autoTransform disabled
by default.
Change-Id: Ifa45375a4bc42ba1d863cb96af16776ea6dd0632
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Port 90% of imageformats to be built with CMake.
Missing support for mng plugin and documentation.
Change-Id: I1d7e4b93c6f8446468f00dbf0663a6a4ec8c9774
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
The mac heic handler lacked support for any meta-data i/o. Most
notably, the image orientation proprty was ignored, so images read in
could be wrongly oriented.
Fixes: QTBUG-73415
Change-Id: I779f91dc28c7441b124aab4557e1abcd3e69fde9
Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
TIFF is one of the primary formats for HDR images.
Change-Id: I5310b5c9a625fd3e759e5120be6ba547c633c81c
Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io>
Webp files can be with or without alpha channel. The handler would
ignore this and read all as Format_ARGB32 images, and write all as
having alpha, in both cases losing that important bit of information.
As a driveby, simplify the endianness handling in write(). By always
converting the source image to an endianness-independent QImage
format, no special handling is required.
Task-number: QTBUG-48628
Change-Id: I624ed72b18a8b59a542979efcb4e8ff81214e0d7
Reviewed-by: Liang Qi <liang.qi@qt.io>
Adds basic support for still images encoded with the HEIF standard
introduced in macOS Sierra and IOS 11.
Uses the Core Graphics Image I/O Framework as codec backend.
Reuses the helper class from the macjp2 handler.
Change-Id: I5f0c7891b189a916cccd2c27eacbac12416ce209
Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
This commit extends the recently added support for tiled tiff images
of color index format to also cover grayscale and mono images. RGB
images were already covered, since the libtiff API used for those
handles tiled images transparently.
This commit also simplifies the tiff read() function by sharing
common code among the different formats.
[ChangeLog][TIFF] Extend support for tiled tiff files to all color formats
Change-Id: I13f94bbca65dd6a35384a415906034e245ad8b79
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Tor Arne Vestbø
Eirik Aavitsland
Giuseppe D'Angelo
Lucie Gérard
Friedemann Kleint
Marc Mutz
Alexandru Croitor
Robert Löhning
Tatiana Borisova
Joerg Bornemann
Allan Sandfeld Jensen
Liang Qi
Jarek Kobus
Qt Forward Merge Bot
Simon Hausmann
Marc Mutz
J-P Nurmi