qiurui
/
qthttpserver
mirror of https://github.com/qt/qthttpserver.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix tst_QAbstractHttpServer::request 

We have undefined behavior when we check server.method.
Because HttpServer::method was uninitialized.

Also start checking a return value from QTcpServer::listen.

Change-Id: Ib7c31f33be956582a6ef264743ca9e44d4de24b1
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
This commit is contained in:
Mikhail Svetkin 2018-12-20 14:59:07 +01:00
parent 0763423618
commit 9a41ddd648
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/auto/qabstracthttpserver/tst_qabstracthttpserver.cpp
View File

@ -95,7 +95,7 @@ void tst_QAbstractHttpServer::request()
{
QUrl url;
QByteArray body;
QHttpServerRequest::Method method;
QHttpServerRequest::Method method = QHttpServerRequest::Method::Unknown;
quint8 padding[4];
bool handleRequest(const QHttpServerRequest &request, QTcpSocket *) override
@ -107,7 +107,7 @@ void tst_QAbstractHttpServer::request()
}
} server;
auto tcpServer = new QTcpServer;
tcpServer->listen();
QVERIFY(tcpServer->listen());
server.bind(tcpServer);
QNetworkAccessManager networkAccessManager;
QUrl url(QStringLiteral("http://%1:%2%3")