From 62eda140266c00aaaa951fe93a441ff63c60ac47 Mon Sep 17 00:00:00 2001 From: Ievgenii Meshcheriakov Date: Wed, 9 Feb 2022 16:16:07 +0100 Subject: [PATCH] Remove explicit move of a QHttpServerResponse temporary MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This move causes a warning on macOS 12 (treated as error): src/httpserver/qhttpserver.cpp:170:20: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] response = std::move(afterRequestHandler(std::move(response), request)); ^ src/httpserver/qhttpserver.cpp:170:20: note: remove std::move call here response = std::move(afterRequestHandler(std::move(response), request)); ^~~~~~~~~~ ~ Note: QHttpServerResponse does not have a copy constructor, so the move is done anyway. Change-Id: I9d411895323c2601cb3a1596de488c8d7f40e46b Reviewed-by: Mårten Nordheim --- src/httpserver/qhttpserver.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/httpserver/qhttpserver.cpp b/src/httpserver/qhttpserver.cpp index fb0b67b..b971235 100644 --- a/src/httpserver/qhttpserver.cpp +++ b/src/httpserver/qhttpserver.cpp @@ -167,7 +167,7 @@ void QHttpServer::sendResponse(QHttpServerResponse &&response, { Q_D(QHttpServer); for (auto afterRequestHandler : d->afterRequestHandlers) - response = std::move(afterRequestHandler(std::move(response), request)); + response = afterRequestHandler(std::move(response), request); response.write(makeResponder(request, socket)); }