qiurui
/
qthttpserver
mirror of https://github.com/qt/qthttpserver.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
qthttpserver/tests/auto/qhttpserverrouter/tst_qhttpserverrouter.cpp

479 lines
19 KiB
C++
Raw Normal View History

Use SPDX license identifiers Replace the current license disclaimer in files by a SPDX-License-Identifier. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I657c36f679b9448ec68d411a492171bc39df1411 Reviewed-by: Jesus Fernandez <jsfdez@gmail.com>
2022-06-22 12:54:22 +00:00
// Copyright (C) 2019 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
Introduce QHttpServerRouter Provide simple API for routing, parsing, capture and call callback Change-Id: Ibd7c37282d00bd56f96d841db92b473a65a2bf5c Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
2018-12-20 11:23:41 +00:00
#include <QtHttpServer/qhttpserverresponder.h>
#include <QtHttpServer/qabstracthttpserver.h>
#include <QtHttpServer/qhttpserverrouter.h>
#include <QtHttpServer/qhttpserverrouterrule.h>
#include <QtTest/qsignalspy.h>
#include <QtTest/qtest.h>
#include <QtNetwork/qnetworkaccessmanager.h>
Fix build on Windows Change-Id: I7bb287dedfc146ba717a69170cec529d7ef7fadb Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-02-28 10:05:02 +00:00
#include <QtNetwork/qtcpsocket.h>
Introduce QHttpServerRouter Provide simple API for routing, parsing, capture and call callback Change-Id: Ibd7c37282d00bd56f96d841db92b473a65a2bf5c Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
2018-12-20 11:23:41 +00:00
Q_DECLARE_METATYPE(QNetworkAccessManager::Operation);
Fix several build issues and fix the unit tests It is required to have continuous integration enabled in the repository. Change-Id: I71728a6e89841640e77c50a05cf59f34d697f897 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
2019-01-30 15:21:43 +00:00
QT_BEGIN_NAMESPACE
Introduce QHttpServerRouter Provide simple API for routing, parsing, capture and call callback Change-Id: Ibd7c37282d00bd56f96d841db92b473a65a2bf5c Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
2018-12-20 11:23:41 +00:00
struct HttpServer : QAbstractHttpServer {
QHttpServerRouter router;
HttpServer()
: QAbstractHttpServer()
{
connect(this, &QAbstractHttpServer::missingHandler,
[] (const QHttpServerRequest &request, QTcpSocket *socket) {
makeResponder(request, socket).write(QHttpServerResponder::StatusCode::NotFound);
});
}
template<typename ViewHandler>
void route(const char *path, const QHttpServerRequest::Methods methods, ViewHandler &&viewHandler)
{
QHttpServerRouter: use unqiue_ptr to accept rules They're already stored in unique_ptr internally, so use the more expressive pass-unique_ptr-by-value idiom to express ownership transfer, so the docs don't need to mention it anymore. Also fixes a theoretical memleak on failed vector::emplace_back(). Pick-to: 6.4 Task-number: QTBUG-100868 Change-Id: I32e386378fe177e4890deea44f0e937c8054c1c6 Reviewed-by: Jesus Fernandez <jsfdez@gmail.com> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Ievgenii Meshcheriakov <ievgenii.meshcheriakov@qt.io>
2022-06-22 08:04:38 +00:00
auto rule = std::make_unique<QHttpServerRouterRule>(
Fix std::forward uses - in route() implementations, the viewHandler was passed by universal reference, however, it was then captured either by value (copying, which some viewHandlers may not support) or - yuck - by reference, creating a dangling pointer in case a temporary was passed. This error was also present in the example implementations in the docs and the test. To fix, std::forward the viewHandler into the mutable lambda and std::move() it inside the lambda into route.bindCaptured(). - One more case of RouterHandler being passed by rvalue ref and then std::forward()ed, fixed by taking by value and std::move()ing instead. Pick-to: 6.4 Task-number: QTBUG-100868 Change-Id: I729f7e0c8fd0838679bcefc141fd5cea333d276b Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Jesus Fernandez <jsfdez@gmail.com>
2022-06-21 20:58:10 +00:00
path, methods, [this, viewHandler = std::forward<ViewHandler>(viewHandler)]
(const QRegularExpressionMatch &match,
Introduce QHttpServerRouter Provide simple API for routing, parsing, capture and call callback Change-Id: Ibd7c37282d00bd56f96d841db92b473a65a2bf5c Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
2018-12-20 11:23:41 +00:00
const QHttpServerRequest &request,
Fix std::forward uses - in route() implementations, the viewHandler was passed by universal reference, however, it was then captured either by value (copying, which some viewHandlers may not support) or - yuck - by reference, creating a dangling pointer in case a temporary was passed. This error was also present in the example implementations in the docs and the test. To fix, std::forward the viewHandler into the mutable lambda and std::move() it inside the lambda into route.bindCaptured(). - One more case of RouterHandler being passed by rvalue ref and then std::forward()ed, fixed by taking by value and std::move()ing instead. Pick-to: 6.4 Task-number: QTBUG-100868 Change-Id: I729f7e0c8fd0838679bcefc141fd5cea333d276b Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Jesus Fernandez <jsfdez@gmail.com>
2022-06-21 20:58:10 +00:00
QTcpSocket *socket) mutable {
Introduce QHttpServerRouter Provide simple API for routing, parsing, capture and call callback Change-Id: Ibd7c37282d00bd56f96d841db92b473a65a2bf5c Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
2018-12-20 11:23:41 +00:00
auto boundViewHandler = router.bindCaptured<ViewHandler>(
std::forward<ViewHandler>(viewHandler), match);
boundViewHandler(makeResponder(request, socket));
});
QHttpServerRouter: use unqiue_ptr to accept rules They're already stored in unique_ptr internally, so use the more expressive pass-unique_ptr-by-value idiom to express ownership transfer, so the docs don't need to mention it anymore. Also fixes a theoretical memleak on failed vector::emplace_back(). Pick-to: 6.4 Task-number: QTBUG-100868 Change-Id: I32e386378fe177e4890deea44f0e937c8054c1c6 Reviewed-by: Jesus Fernandez <jsfdez@gmail.com> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Ievgenii Meshcheriakov <ievgenii.meshcheriakov@qt.io>
2022-06-22 08:04:38 +00:00
router.addRule<ViewHandler>(std::move(rule));
Introduce QHttpServerRouter Provide simple API for routing, parsing, capture and call callback Change-Id: Ibd7c37282d00bd56f96d841db92b473a65a2bf5c Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
2018-12-20 11:23:41 +00:00
}
template<typename ViewHandler>
void route(const char *path, ViewHandler &&viewHandler)
{
QHttpServerRequest: Cleanup Method enum Add a value for TRACE method from RFC 7231. Rename value All to AnyKnown. Document the enum. Fixes: QTBUG-105306 Task-number: QTBUG-100868 Pick-to: 6.4 Change-Id: Ibfc41d006df3dd7f2620cd9b2395b6b1b8ce6384 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2022-08-09 10:44:12 +00:00
route(path, QHttpServerRequest::Method::AnyKnown, std::forward<ViewHandler>(viewHandler));
Introduce QHttpServerRouter Provide simple API for routing, parsing, capture and call callback Change-Id: Ibd7c37282d00bd56f96d841db92b473a65a2bf5c Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
2018-12-20 11:23:41 +00:00
}
bool handleRequest(const QHttpServerRequest &request, QTcpSocket *socket) override {
return router.handleRequest(request, socket);
}
};
class tst_QHttpServerRouter : public QObject
{
Q_OBJECT
private slots:
void initTestCase();
void routerRule_data();
void routerRule();
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
void viewHandlerNoArg();
void viewHandlerOneArg();
void viewHandlerTwoArgs();
void viewHandlerResponder();
void viewHandlerRequest();
void viewHandlerLastTwoSpecials();
Introduce QHttpServerRouter Provide simple API for routing, parsing, capture and call callback Change-Id: Ibd7c37282d00bd56f96d841db92b473a65a2bf5c Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
2018-12-20 11:23:41 +00:00
private:
HttpServer httpserver;
QString urlBase;
};
void tst_QHttpServerRouter::initTestCase()
{
Allow supplying non-temporary handler lambdas Adjust one test case to use such a lambda. Fixes: QTBUG-104481 Task-number: QTBUG-100868 Pick-to: 6.4 Change-Id: I96e30fd167b8c2f8240316bff9c283efdb910541 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2022-07-14 09:59:46 +00:00
auto pageHandler = [] (const quint64 &page, QHttpServerResponder &&responder) {
Introduce QHttpServerRouter Provide simple API for routing, parsing, capture and call callback Change-Id: Ibd7c37282d00bd56f96d841db92b473a65a2bf5c Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
2018-12-20 11:23:41 +00:00
responder.write(QString("page: %1").arg(page).toUtf8(), "text/plain");
Allow supplying non-temporary handler lambdas Adjust one test case to use such a lambda. Fixes: QTBUG-104481 Task-number: QTBUG-100868 Pick-to: 6.4 Change-Id: I96e30fd167b8c2f8240316bff9c283efdb910541 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2022-07-14 09:59:46 +00:00
};
httpserver.route("/page/", pageHandler);
Introduce QHttpServerRouter Provide simple API for routing, parsing, capture and call callback Change-Id: Ibd7c37282d00bd56f96d841db92b473a65a2bf5c Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
2018-12-20 11:23:41 +00:00
httpserver.route("/post-only", QHttpServerRequest::Method::Post,
[] (QHttpServerResponder &&responder) {
responder.write(QString("post-test").toUtf8(), "text/plain");
});
httpserver.route("/get-only", QHttpServerRequest::Method::Get,
[] (QHttpServerResponder &&responder) {
responder.write(QString("get-test").toUtf8(), "text/plain");
});
urlBase = QStringLiteral("http://localhost:%1%2").arg(httpserver.listen());
}
void tst_QHttpServerRouter::routerRule_data()
{
QTest::addColumn<QString>("url");
QTest::addColumn<int>("code");
QTest::addColumn<QString>("type");
QTest::addColumn<QString>("body");
QTest::addColumn<QNetworkAccessManager::Operation>("replyType");
QTest::addRow("/page/1")
<< "/page/1"
<< 200
<< "text/plain"
<< "page: 1"
<< QNetworkAccessManager::GetOperation;
QTest::addRow("/page/-1")
<< "/page/-1"
<< 404
<< "application/x-empty"
<< ""
<< QNetworkAccessManager::GetOperation;
QTest::addRow("/post-only [GET]")
<< "/post-only"
<< 404
<< "application/x-empty"
<< ""
<< QNetworkAccessManager::GetOperation;
QTest::addRow("/post-only [DELETE]")
<< "/post-only"
<< 404
<< "application/x-empty"
<< ""
<< QNetworkAccessManager::DeleteOperation;
QTest::addRow("/post-only [POST]")
<< "/post-only"
<< 200
<< "text/plain"
<< "post-test"
<< QNetworkAccessManager::PostOperation;
QTest::addRow("/get-only [GET]")
<< "/get-only"
<< 200
<< "text/plain"
<< "get-test"
<< QNetworkAccessManager::GetOperation;
QTest::addRow("/get-only [POST]")
<< "/get-only"
<< 404
<< "application/x-empty"
<< ""
<< QNetworkAccessManager::PostOperation;
QTest::addRow("/get-only [DELETE]")
<< "/get-only"
<< 404
<< "application/x-empty"
<< ""
<< QNetworkAccessManager::DeleteOperation;
}
void tst_QHttpServerRouter::routerRule()
{
QFETCH(QString, url);
QFETCH(int, code);
QFETCH(QString, type);
QFETCH(QString, body);
QFETCH(QNetworkAccessManager::Operation, replyType);
QNetworkAccessManager networkAccessManager;
QNetworkReply *reply;
QNetworkRequest request(QUrl(urlBase.arg(url)));
switch (replyType) {
case QNetworkAccessManager::GetOperation:
reply = networkAccessManager.get(request);
break;
case QNetworkAccessManager::PostOperation:
request.setHeader(QNetworkRequest::ContentTypeHeader, type);
reply = networkAccessManager.post(request, QByteArray("post body"));
break;
case QNetworkAccessManager::DeleteOperation:
reply = networkAccessManager.deleteResource(request);
break;
default:
QFAIL("The replyType does not supported");
}
QTRY_VERIFY(reply->isFinished());
QCOMPARE(reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt(), code);
QCOMPARE(reply->header(QNetworkRequest::ContentTypeHeader), type);
QCOMPARE(reply->readAll(), body);
}
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
void tst_QHttpServerRouter::viewHandlerNoArg()
{
auto viewNonArg = [] () {
};
using ViewTraits = QHttpServerRouterViewTraits<decltype(viewNonArg), true>;
using Args = typename ViewTraits::Arguments;
static_assert(Args::Count == 0,
"viewNonArg: Args::Count == 0");
static_assert(Args::CapturableCount == 0,
"viewNonArg: Args::CapturableCount == 0");
static_assert(Args::PlaceholdersCount == 0,
"viewNonArg: Args::PlaceholdersCount == 0");
static_assert(Args::Valid, "viewNonArg: Args::Valid");
static_assert(Args::StaticAssert, "viewNonArg: Args::StaticAssert");
}
void tst_QHttpServerRouter::viewHandlerOneArg()
{
auto view = [] (const quint64 &) {
};
using ViewTraits = QHttpServerRouterViewTraits<decltype(view), true>;
using Args = typename ViewTraits::Arguments;
static_assert(Args::Count == 1,
"viewOneArg: Args::Count == 1");
static_assert(Args::CapturableCount == 1,
"viewOneArg: Args::CapturableCount == 1");
static_assert(Args::PlaceholdersCount == 0,
"viewOneArg: Args::PlaceholdersCount == 0");
static_assert(Args::Last::IsRequest::Value == 0,
"viewOneArg: Args::Last::IsRequest::Value == 0");
static_assert(Args::Last::IsRequest::Valid == 0,
"viewOneArg: Args::Last::IsRequest::Valid == 0");
static_assert(Args::Last::IsResponder::Value == 0,
"viewOneArg: Args::Last::IsResponder::Value == 0");
static_assert(Args::Last::IsResponder::Valid == 0,
"viewOneArg: Args::Last::IsResponder::Valid == 0");
static_assert(Args::Last::IsSpecial::Value == 0,
"viewOneArg: Args::Last::IsSpecial::Value == 0");
static_assert(Args::Last::IsSpecial::Valid == 0,
"viewOneArg: Args::Last::IsSpecial::Valid == 0");
static_assert(Args::Last::IsSimple::Value,
"viewOneArg: Args::Last::IsSimple::Value");
static_assert(Args::Last::IsSimple::Valid,
"viewOneArg: Args::Last::IsSimple::Valid");
static_assert(Args::Last::Valid,
"viewOneArg: Args::Last::Valid");
static_assert(Args::Last::StaticAssert,
"viewOneArg: Args::Last::StaticAssert");
Add QHttpServer::afterRequest This function allows to register a function to be run after each request. Task-number: QTBUG-77090 Change-Id: I40dd4c1e9a447fbe034149ffc1923c7c814cf0e9 Reviewed-by: Mikhail Svetkin <mikhail.svetkin@gmail.com>
2020-04-29 20:06:00 +00:00
static_assert(std::is_same<Args::Last::Type, const quint64 &>::value,
"viewNonArg: std::is_same<Args::Last::Type, const quint64 &>");
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
static_assert(Args::Valid, "viewOneArg: Args::Valid");
static_assert(Args::StaticAssert, "viewOneArg: Args::StaticAssert");
}
void tst_QHttpServerRouter::viewHandlerTwoArgs()
{
auto view = [] (const quint64 &, const QHttpServerResponder &) {
};
using ViewTraits = QHttpServerRouterViewTraits<decltype(view), true>;
using Args = typename ViewTraits::Arguments;
static_assert(Args::Count == 2,
"viewTwoArgs: Args::Count == 2");
static_assert(Args::CapturableCount == 1,
"viewTwoArgs: Args::CapturableCount == 1");
static_assert(Args::PlaceholdersCount == 1,
"viewTwoArgs: Args::PlaceholdersCount == 0");
using Arg0 = typename Args::template Arg<0>;
static_assert(Arg0::IsRequest::Value == 0,
"viewTwoArgs: Args::Arg0::IsRequest::Value == 0");
static_assert(Arg0::IsRequest::Valid == 0,
"viewTwoArgs: Args::Arg0::IsRequest::Valid == 0");
static_assert(Arg0::IsResponder::Value == 0,
"viewTwoArgs: Args::Arg0::IsResponder::Value == 0");
static_assert(Arg0::IsResponder::Valid == 0,
"viewTwoArgs: Args::Arg0::IsResponder::Valid == 0");
static_assert(Arg0::IsSpecial::Value == 0,
"viewTwoArgs: Args::Arg0::IsSpecial::Value == 0");
static_assert(Arg0::IsSpecial::Valid == 0,
"viewTwoArgs: Args::Arg0::IsSpecial::Valid == 0");
static_assert(Arg0::IsSimple::Value,
"viewTwoArgs: Args::Arg0::IsSimple::Value");
static_assert(Arg0::IsSimple::Valid,
"viewTwoArgs: Args::Arg0::IsSimple::Valid");
static_assert(Arg0::Valid,
"viewTwoArgs: Args::Arg0::Valid");
static_assert(Arg0::StaticAssert,
"viewTwoArgs: Args::Arg0::StaticAssert");
Add QHttpServer::afterRequest This function allows to register a function to be run after each request. Task-number: QTBUG-77090 Change-Id: I40dd4c1e9a447fbe034149ffc1923c7c814cf0e9 Reviewed-by: Mikhail Svetkin <mikhail.svetkin@gmail.com>
2020-04-29 20:06:00 +00:00
static_assert(std::is_same<Arg0::Type, const quint64 &>::value,
"viewNonArg: std::is_same<Args::Arg0::Type, const quint64>");
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
using Arg1 = typename Args::template Arg<1>;
static_assert(Arg1::IsRequest::Value == 0,
"viewTwoArgs: Args::Arg1::IsRequest::Value == 0");
static_assert(Arg1::IsRequest::Valid == 0,
"viewTwoArgs: Args::Arg1::IsRequest::Valid == 0");
static_assert(Arg1::IsResponder::Value,
"viewTwoArgs: Args::Arg1::IsResponder::Value");
static_assert(Arg1::IsResponder::Valid == 0,
"viewTwoArgs: Args::Arg1::IsResponder::Valid == 0");
static_assert(Arg1::IsSpecial::Value == 1,
"viewTwoArgs: Args::Arg1::IsSpecial::Value");
static_assert(Arg1::IsSpecial::Valid == 0,
"viewTwoArgs: Args::Arg1::IsSpecial::Valid == 0");
static_assert(Arg1::IsSimple::Value == 0,
"viewTwoArgs: Args::Arg1::IsSimple::Value == 0");
static_assert(Arg1::IsSimple::Valid == 0,
"viewTwoArgs: Args::Arg1::IsSimple::Valid == 0");
static_assert(Arg1::Valid == 0,
"viewTwoArgs: Args::Arg1::Valid");
// StaticAssert is disabled in tests
static_assert(Arg1::StaticAssert,
"viewOneArg: Args::Arg1::StaticAssert");
Add QHttpServer::afterRequest This function allows to register a function to be run after each request. Task-number: QTBUG-77090 Change-Id: I40dd4c1e9a447fbe034149ffc1923c7c814cf0e9 Reviewed-by: Mikhail Svetkin <mikhail.svetkin@gmail.com>
2020-04-29 20:06:00 +00:00
static_assert(std::is_same<Arg1::Type, const QHttpServerResponder &>::value,
"viewTwoArgs: std::is_same<Args::Arg1::Type, const QHttpServerResponder &>)");
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
static_assert(Args::Valid == 0, "viewTwoArgs: Args::Valid == 0");
// StaticAssert is disabled in tests
static_assert(Args::StaticAssert, "viewTwoArgs: Args::StaticAssert");
}
void tst_QHttpServerRouter::viewHandlerResponder()
{
auto view = [] (QHttpServerResponder &&) {
};
using ViewTraits = QHttpServerRouterViewTraits<decltype(view), true>;
using Args = typename ViewTraits::Arguments;
static_assert(Args::Count == 1,
"viewResponder: Args::Count == 1");
static_assert(Args::CapturableCount == 0,
"viewResponder: Args::CapturableCount == 0");
static_assert(Args::PlaceholdersCount == 1,
"viewResponder: Args::PlaceholdersCount == 1");
static_assert(Args::Last::IsRequest::Value == 0,
"viewResponder: Args::Last::IsRequest::Value == 0");
static_assert(Args::Last::IsRequest::Valid == 0,
"viewResponder: Args::Last::IsRequest::Valid == 0");
static_assert(Args::Last::IsResponder::Value,
"viewResponder: Args::Last::IsResponder::Value");
static_assert(Args::Last::IsResponder::Valid,
"viewResponder: Args::Last::IsResponder::Valid");
static_assert(Args::Last::IsSpecial::Value,
"viewResponder: Args::Last::IsSpecial::Value");
static_assert(Args::Last::IsSpecial::Valid,
"viewResponder: Args::Last::IsSpecial::Valid");
static_assert(Args::Last::IsSimple::Value == 0,
"viewResponder: Args::Last::IsSimple::Value == 0");
static_assert(Args::Last::IsSimple::Valid == 0,
"viewResponder: Args::Last::IsSimple::Valid == 0");
static_assert(Args::Last::Valid,
"viewResponder: Args::Last::Valid");
static_assert(Args::Last::StaticAssert,
"viewResponder: Args::Last::StaticAssert");
Add QHttpServer::afterRequest This function allows to register a function to be run after each request. Task-number: QTBUG-77090 Change-Id: I40dd4c1e9a447fbe034149ffc1923c7c814cf0e9 Reviewed-by: Mikhail Svetkin <mikhail.svetkin@gmail.com>
2020-04-29 20:06:00 +00:00
static_assert(std::is_same<Args::Last::Type, QHttpServerResponder &&>::value,
"viewNonArg: std::is_same<Args::Last::Type, QHttpServerResponder &&>");
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
static_assert(Args::Valid, "viewResponder: Args::Valid");
static_assert(Args::StaticAssert, "viewResponder: Args::StaticAssert");
}
void tst_QHttpServerRouter::viewHandlerRequest()
{
auto view = [] (const QHttpServerRequest &) {
};
using ViewTraits = QHttpServerRouterViewTraits<decltype(view), true>;
using Args = typename ViewTraits::Arguments;
static_assert(Args::Count == 1,
"viewResponder: Args::Count == 1");
static_assert(Args::CapturableCount == 0,
"viewResponder: Args::CapturableCount == 0");
static_assert(Args::PlaceholdersCount == 1,
"viewResponder: Args::PlaceholdersCount == 1");
static_assert(Args::Last::IsRequest::Value,
"viewResponder: Args::Last::IsRequest::Value");
static_assert(Args::Last::IsRequest::Valid,
"viewResponder: Args::Last::IsRequest::Valid");
static_assert(Args::Last::IsResponder::Value == 0,
"viewResponder: Args::Last::IsResponder::Value == 0");
static_assert(Args::Last::IsResponder::Valid == 0,
"viewResponder: Args::Last::IsResponder::Valid == 0");
static_assert(Args::Last::IsSpecial::Value,
"viewResponder: Args::Last::IsSpecial::Value");
static_assert(Args::Last::IsSpecial::Valid,
"viewResponder: Args::Last::IsSpecial::Valid");
static_assert(Args::Last::IsSimple::Value == 0,
"viewResponder: Args::Last::IsSimple::Value == 0");
static_assert(Args::Last::IsSimple::Valid == 0,
"viewResponder: Args::Last::IsSimple::Valid == 0");
static_assert(Args::Last::Valid,
"viewResponder: Args::Last::Valid");
static_assert(Args::Last::StaticAssert,
"viewResponder: Args::Last::StaticAssert");
Add QHttpServer::afterRequest This function allows to register a function to be run after each request. Task-number: QTBUG-77090 Change-Id: I40dd4c1e9a447fbe034149ffc1923c7c814cf0e9 Reviewed-by: Mikhail Svetkin <mikhail.svetkin@gmail.com>
2020-04-29 20:06:00 +00:00
static_assert(std::is_same<Args::Last::Type, const QHttpServerRequest &>::value,
"viewNonArg: std::is_same<Args::Last::Type, const QHttpServerRequest &>");
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
static_assert(Args::Valid, "viewResponder: Args::Valid");
static_assert(Args::StaticAssert, "viewResponder: Args::StaticAssert");
}
void tst_QHttpServerRouter::viewHandlerLastTwoSpecials()
{
auto view = [] (const QHttpServerRequest &, QHttpServerResponder &&) {
};
using ViewTraits = QHttpServerRouterViewTraits<decltype(view), true>;
using Args = typename ViewTraits::Arguments;
static_assert(Args::Count == 2,
"viewTwoSpecialArgs: Args::Count == 2");
static_assert(Args::CapturableCount == 0,
"viewTwoSpecialArgs: Args::CapturableCount == 1");
static_assert(Args::PlaceholdersCount == 2,
"viewTwoSpecialArgs: Args::PlaceholdersCount == 0");
using Arg0 = typename Args::template Arg<0>;
static_assert(Arg0::IsRequest::Value,
"viewTwoSpecialArgs: Args::Arg0::IsRequest::Value");
Allow using QHttpServerRequest/Responder at the same time Fixes: QTBUG-77088 Change-Id: I2208cee290d086339aba705f959c57e0f6a73a87 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-09-01 19:33:22 +00:00
static_assert(Arg0::IsRequest::Valid,
"viewTwoSpecialArgs: Args::Arg0::IsRequest::Valid");
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
static_assert(Arg0::IsResponder::Value == 0,
"viewTwoSpecialArgs: Args::Arg0::IsResponder::Value == 0");
static_assert(Arg0::IsResponder::Valid == 0,
"viewTwoSpecialArgs: Args::Arg0::IsResponder::Valid == 0");
static_assert(Arg0::IsSpecial::Value,
"viewTwoSpecialArgs: Args::Arg0::IsSpecial::Value");
Allow using QHttpServerRequest/Responder at the same time Fixes: QTBUG-77088 Change-Id: I2208cee290d086339aba705f959c57e0f6a73a87 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-09-01 19:33:22 +00:00
static_assert(Arg0::IsSpecial::Valid,
"viewTwoSpecialArgs: Args::Arg0::IsSpecial::Valid");
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
static_assert(Arg0::IsSimple::Value == 0,
"viewTwoSpecialArgs: Args::Arg0::IsSimple::Value == 0");
static_assert(Arg0::IsSimple::Valid == 0,
"viewTwoSpecialArgs: Args::Arg0::IsSimple::Valid == 0");
Allow using QHttpServerRequest/Responder at the same time Fixes: QTBUG-77088 Change-Id: I2208cee290d086339aba705f959c57e0f6a73a87 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-09-01 19:33:22 +00:00
static_assert(Arg0::Valid,
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
"viewTwoSpecialArgs: Args::Arg0::Valid");
// StaticAssert is disabled in tests
static_assert(Arg0::StaticAssert,
"viewTwoSpecialArgs: Args::Arg0::StaticAssert");
Add QHttpServer::afterRequest This function allows to register a function to be run after each request. Task-number: QTBUG-77090 Change-Id: I40dd4c1e9a447fbe034149ffc1923c7c814cf0e9 Reviewed-by: Mikhail Svetkin <mikhail.svetkin@gmail.com>
2020-04-29 20:06:00 +00:00
static_assert(std::is_same<Arg0::Type, const QHttpServerRequest &>::value,
"viewNonArg: std::is_same<Args::Arg0::Type, const QHttpServerRequest &>");
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
using Arg1 = typename Args::template Arg<1>;
static_assert(Arg1::IsRequest::Value == 0,
"viewTwoSpecialArgs: Args::Arg1::IsRequest::Value == 0");
static_assert(Arg1::IsRequest::Valid == 0,
"viewTwoSpecialArgs: Args::Arg1::IsRequest::Valid == 0");
static_assert(Arg1::IsResponder::Value,
"viewTwoSpecialArgs: Args::Arg1::IsResponder::Value");
static_assert(Arg1::IsResponder::Valid,
"viewTwoSpecialArgs: Args::Arg1::IsResponder::Valid");
static_assert(Arg1::IsSpecial::Value,
"viewTwoSpecialArgs: Args::Arg1::IsSpecial::Value");
static_assert(Arg1::IsSpecial::Valid,
"viewTwoSpecialArgs: Args::Arg1::IsSpecial::Valid");
static_assert(Arg1::IsSimple::Value == 0,
"viewTwoSpecialArgs: Args::Arg1::IsSimple::Value == 0");
static_assert(Arg1::IsSimple::Valid == 0,
"viewTwoSpecialArgs: Args::Arg1::IsSimple::Valid == 0");
static_assert(Arg1::Valid,
"viewTwoSpecialArgs: Args::Arg1::Valid");
static_assert(Arg1::StaticAssert,
"viewTwoSpecialArgs: Args::Arg1::StaticAssert");
Add QHttpServer::afterRequest This function allows to register a function to be run after each request. Task-number: QTBUG-77090 Change-Id: I40dd4c1e9a447fbe034149ffc1923c7c814cf0e9 Reviewed-by: Mikhail Svetkin <mikhail.svetkin@gmail.com>
2020-04-29 20:06:00 +00:00
static_assert(std::is_same<Arg1::Type, QHttpServerResponder &&>::value,
"viewTwoSpecialArgs: std::is_same<Args::Arg1::Type, QHttpServerResponder &&>");
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
Allow using QHttpServerRequest/Responder at the same time Fixes: QTBUG-77088 Change-Id: I2208cee290d086339aba705f959c57e0f6a73a87 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-09-01 19:33:22 +00:00
static_assert(Args::Valid, "viewTwoSpecialArgs: Args::Valid");
QHttpServerRouterViewTraits: Make it simpler and testable Currently QHttpServerRouterViewTraits contains all helpers and tools inside itself. It is hard to read and extend. This patch: - Moves all helper and tools to QtPrivate namespace - Tries to "simplify" template magic - Adds support for unit test Change-Id: I6aa443b286c4c896b8dbfee85fffb638328868ad Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
2019-08-30 21:14:31 +00:00
// StaticAssert is disabled in tests
static_assert(Args::StaticAssert, "viewTwoSpecialArgs: Args::StaticAssert");
}
Introduce QHttpServerRouter Provide simple API for routing, parsing, capture and call callback Change-Id: Ibd7c37282d00bd56f96d841db92b473a65a2bf5c Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
2018-12-20 11:23:41 +00:00
QT_END_NAMESPACE
QTEST_MAIN(tst_QHttpServerRouter)
#include "tst_qhttpserverrouter.moc"