Mark deleted rvalue-this overloads as const

These functions are not callable. Declaring them const allows them
to match more calls (specifically, const rvalues, which before would
have given "no matching overload" instead of "deleted" errors).

Pick-to: 6.10
Change-Id: I3d074d561456cf98fccacabea68204c92b7a4b38
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
This commit is contained in:
Dennis Oberst 2025-06-26 17:41:05 +02:00
parent 8c8c100d51
commit e7e50fe1e1
6 changed files with 7 additions and 7 deletions

View File

@ -34,7 +34,7 @@ public:
[[nodiscard]] virtual std::shared_ptr<QAbstractProtobufSerializer> serializer() const = 0; [[nodiscard]] virtual std::shared_ptr<QAbstractProtobufSerializer> serializer() const = 0;
[[nodiscard]] const QGrpcChannelOptions &channelOptions() const & noexcept; [[nodiscard]] const QGrpcChannelOptions &channelOptions() const & noexcept;
void channelOptions() && = delete; void channelOptions() const && = delete;
void setChannelOptions(const QGrpcChannelOptions &options); void setChannelOptions(const QGrpcChannelOptions &options);
void setChannelOptions(QGrpcChannelOptions &&options); void setChannelOptions(QGrpcChannelOptions &&options);

View File

@ -61,7 +61,7 @@ protected:
{ {
return const_cast<QGrpcOperationContext &>(std::as_const(*this).context()); return const_cast<QGrpcOperationContext &>(std::as_const(*this).context());
} }
void context() && = delete; void context() const && = delete;
private: private:
Q_DISABLE_COPY_MOVE(QGrpcOperation) Q_DISABLE_COPY_MOVE(QGrpcOperation)

View File

@ -36,10 +36,10 @@ public:
[[nodiscard]] QLatin1StringView service() const noexcept; [[nodiscard]] QLatin1StringView service() const noexcept;
[[nodiscard]] QByteArrayView argument() const noexcept; [[nodiscard]] QByteArrayView argument() const noexcept;
void callOptions() && = delete; void callOptions() const && = delete;
[[nodiscard]] const QGrpcCallOptions &callOptions() const & noexcept; [[nodiscard]] const QGrpcCallOptions &callOptions() const & noexcept;
void serverMetadata() && = delete; void serverMetadata() const && = delete;
[[nodiscard]] const QHash<QByteArray, QByteArray> &serverMetadata() const & noexcept; [[nodiscard]] const QHash<QByteArray, QByteArray> &serverMetadata() const & noexcept;
void setServerMetadata(const QHash<QByteArray, QByteArray> &metadata); void setServerMetadata(const QHash<QByteArray, QByteArray> &metadata);
void setServerMetadata(QHash<QByteArray, QByteArray> &&metadata); void setServerMetadata(QHash<QByteArray, QByteArray> &&metadata);

View File

@ -34,7 +34,7 @@ public:
~QQmlGrpcCallOptions() override; ~QQmlGrpcCallOptions() override;
const QGrpcCallOptions &options() const & noexcept; const QGrpcCallOptions &options() const & noexcept;
void options() && = delete; void options() const && = delete;
qint64 deadlineTimeout() const; qint64 deadlineTimeout() const;
void setDeadlineTimeout(qint64 value); void setDeadlineTimeout(qint64 value);

View File

@ -53,7 +53,7 @@ public:
~QQmlGrpcChannelOptions() override; ~QQmlGrpcChannelOptions() override;
const QGrpcChannelOptions &options() const & noexcept; const QGrpcChannelOptions &options() const & noexcept;
void options() && = delete; void options() const && = delete;
qint64 deadlineTimeout() const; qint64 deadlineTimeout() const;
void setDeadlineTimeout(qint64 value); void setDeadlineTimeout(qint64 value);

View File

@ -38,7 +38,7 @@ public:
~QQmlGrpcMetadata() override; ~QQmlGrpcMetadata() override;
const QMultiHash<QByteArray, QByteArray> &metadata() const & noexcept { return m_metadata; } const QMultiHash<QByteArray, QByteArray> &metadata() const & noexcept { return m_metadata; }
void metadata() && = delete; void metadata() const && = delete;
const QVariantMap &data() const { return m_variantdata; } const QVariantMap &data() const { return m_variantdata; }
void setData(const QVariantMap &data); void setData(const QVariantMap &data);