From bd1fccb26aaa9504c6271a2a4ae9c1b1f8e053a2 Mon Sep 17 00:00:00 2001
From: Dennis Oberst <dennis.oberst@qt.io>
Date: Fri, 1 Aug 2025 13:42:27 +0200
Subject: [PATCH] grpc benchmarks: fix compiler warnings

Fix unused variables and add missing include

Pick-to: 6.10 6.9 6.8
Change-Id: Idc756938daa63a9cfd4d336598c7919de999a888
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
---
 .../grpc/benchmarks/asyncbenchserver/asyncbenchserver.cpp   | 6 +++---
 .../bench_async_ref_client/bench_async_ref_client.cpp       | 2 +-
 .../benchmarks/bench_qtgrpcclient/bench_qtgrpcclient.cpp    | 2 +-
 tests/manual/grpc/benchmarks/qrpcbench_common.h             | 1 +
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/tests/manual/grpc/benchmarks/asyncbenchserver/asyncbenchserver.cpp b/tests/manual/grpc/benchmarks/asyncbenchserver/asyncbenchserver.cpp
index 1cb22303..1c864b15 100644
--- a/tests/manual/grpc/benchmarks/asyncbenchserver/asyncbenchserver.cpp
+++ b/tests/manual/grpc/benchmarks/asyncbenchserver/asyncbenchserver.cpp
@@ -77,10 +77,10 @@ public:
                 new BiDiStreaming(cq.get(), &mService);
             }
         }
-        // Two threads per CQ for reducing bursts in queries.
+
         for (auto& cq : mCompletionQueues) {
-            mThreads.emplace_back([this, cq = cq.get()] { processRPCs(cq); });
-            // mThreads.emplace_back([this, cq = cq.get()] { processRPCs(cq); });
+            mThreads.emplace_back([cq = cq.get()] { processRPCs(cq); });
+            // Add more threads for parallel RPC processing.
         }
     }
 
diff --git a/tests/manual/grpc/benchmarks/bench_async_ref_client/bench_async_ref_client.cpp b/tests/manual/grpc/benchmarks/bench_async_ref_client/bench_async_ref_client.cpp
index cd1fa086..b1101d3f 100644
--- a/tests/manual/grpc/benchmarks/bench_async_ref_client/bench_async_ref_client.cpp
+++ b/tests/manual/grpc/benchmarks/bench_async_ref_client/bench_async_ref_client.cpp
@@ -322,7 +322,7 @@ void AsyncGrpcClientBenchmark::bidiStreaming()
         }
         return false;
     };
-    call->callHandler = [this, call](bool ok) {
+    call->callHandler = [call](bool ok) {
         if (ok) {
             call->stream->Finish(&call->status, &call->finishHandler);
             call->stream->Read(&call->response, &call->readHandler);
diff --git a/tests/manual/grpc/benchmarks/bench_qtgrpcclient/bench_qtgrpcclient.cpp b/tests/manual/grpc/benchmarks/bench_qtgrpcclient/bench_qtgrpcclient.cpp
index d9f84801..881ef353 100644
--- a/tests/manual/grpc/benchmarks/bench_qtgrpcclient/bench_qtgrpcclient.cpp
+++ b/tests/manual/grpc/benchmarks/bench_qtgrpcclient/bench_qtgrpcclient.cpp
@@ -233,7 +233,7 @@ void QtGrpcClientBenchmark::bidiStreaming()
     });
 
     QObject::connect(streamPtr, &QGrpcBidiStream::messageReceived, this,
-                     [this, stream = streamPtr, &response, &request, &benchData]() {
+                     [this, stream = streamPtr, &response, &benchData]() {
                          if (stream->read(&response)) {
                              if (response.hasPayload())
                                  benchData.receivedBytes += response.payload().size();
diff --git a/tests/manual/grpc/benchmarks/qrpcbench_common.h b/tests/manual/grpc/benchmarks/qrpcbench_common.h
index 354717de..07effd00 100644
--- a/tests/manual/grpc/benchmarks/qrpcbench_common.h
+++ b/tests/manual/grpc/benchmarks/qrpcbench_common.h
@@ -14,6 +14,7 @@
 #include <concepts>
 #include <cstdlib>
 #include <format>
+#include <iomanip>
 #include <iostream>
 #include <ranges>
 #include <string_view>