From 7b565c1d13c7165a7397dec9addc4aceacede059 Mon Sep 17 00:00:00 2001
From: Alexey Edelev <alexey.edelev@qt.io>
Date: Fri, 9 Dec 2022 15:32:00 +0100
Subject: [PATCH] grpc: Minor test updates
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Minimize incrementing and check of the iterator variables. Replaces
hardcoded test values with constants.

Change-Id: I5ae4c5e1ab8db62b5744e62f62a5124536686342
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Konrad Kujawa <konrad.kujawa@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
---
 tests/auto/grpc/client/tst_grpc_client.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/auto/grpc/client/tst_grpc_client.cpp b/tests/auto/grpc/client/tst_grpc_client.cpp
index 36307041..a6b4fc95 100644
--- a/tests/auto/grpc/client/tst_grpc_client.cpp
+++ b/tests/auto/grpc/client/tst_grpc_client.cpp
@@ -291,9 +291,8 @@ void QtGrpcClientTest::StreamStringAndAbortTest()
     int i = 0;
     QObject::connect(stream.get(), &QGrpcStream::messageReceived, this, [&result, &i, stream]() {
         SimpleStringMessage ret = stream->read<SimpleStringMessage>();
-        ++i;
         result.setTestFieldString(result.testFieldString() + ret.testFieldString());
-        if (i == ExpectedMessageCount)
+        if (++i == ExpectedMessageCount)
             stream->abort();
     });
 
@@ -578,11 +577,14 @@ void QtGrpcClientTest::MultipleStreamsCancelTest()
 
 void QtGrpcClientTest::CallNonCompatibleArgRetTest()
 {
+    const QtProtobuf::sint32 TestValue = 2048;
+    const QString TestValueString = QString::number(TestValue);
+
     SimpleIntMessage request;
-    request.setTestField(2048);
+    request.setTestField(TestValue);
     auto result = QSharedPointer<SimpleStringMessage>::create();
     QCOMPARE_EQ(_client->testMethodNonCompatibleArgRet(request, result.get()), QGrpcStatus::Ok);
-    QCOMPARE_EQ(result->testFieldString(), "2048");
+    QCOMPARE_EQ(result->testFieldString(), TestValueString);
 }
 
 void QtGrpcClientTest::CallStringThreadTest()
@@ -658,10 +660,8 @@ void QtGrpcClientTest::StreamStringThreadTest()
                              SimpleStringMessage ret = stream->read<SimpleStringMessage>();
                              result.setTestFieldString(result.testFieldString()
                                                        + ret.testFieldString());
-                             ++i;
-                             if (i == 4) {
+                             if (++i == 4)
                                  waiter.quit();
-                             }
                          });
 
         waiter.exec();