As in other baseline test implementations, exit with a fatal
message when the reference file cannot be opened.
Change-Id: I112f3ed3bfa57af17eab91357dd0056e7b5c5585
Reviewed-by: Jonas Karlsson <jonas.karlsson@qt.io>
(cherry picked from commit 8092e44167)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
The scene grabber uses QUnifiedTimer from the private QtCore API.
Change-Id: I6dd4354b3acaa6e35be239b6aefb86b481b2492d
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
(cherry picked from commit cceb78d130)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This includes:
- turning VERIFY_SOURCE_SBOM ON
- adding rules to the licenseRule.json files
- correcting the licensing given via REUSE.toml files
A lot of files are skipped during the license test,
but all are present in the source SBOM.
This is why corrections are needed before turning the
source SBOM check on.
Task-number: QTBUG-131434
Pick-to: 6.8
Change-Id: I2d6c923ba92379056876f78a854a09de5fc148be
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
(cherry picked from commit 4bccad3f9e)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Also adds support for rootNode scaling
Fixes: QTBUG-132925
Change-Id: If9be83def9532779762da2aab89d411705bfba7d
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
(cherry picked from commit f318db38b7)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Custom object scaling had a bug before 6.9 which made them
2 times too small by default. Adjust scaling in the example
to take that into account.
Change-Id: I0b3bfa4fe8606394765372d96d19f4c82e63087e
Reviewed-by: Sakaria Pouke <sakaria.pouke@qt.io>
Reviewed-by: Niko Korkala <niko.korkala@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
(cherry picked from commit 772873717a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
There is no QML type `VariantAnimation`. Resolves
(qdoc) warning: Unknown base 'VariantAnimation' for QML type
'GraphAnimation'.
Pick-to: 6.8
Change-Id: I696cbf87a4917f8a4f402da1b12fa3edf909f884
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
(cherry picked from commit 5703548d49)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
QtGraphs has inherited the approach of creating foreign types from
the QtDataVisualization module. QtDataVis3D was divided
into two modules: QtDataVisualization and QtDataVisualizationQml.
The first one used the widget framework and contained everything needed
for describing graphs. The latter QtDataVisualizationQml used
the Quick framework and exposed mandatory classes from
QtDataVisualization as foreign types to QML.
QtGraphs, on the other hand, has a hard dependency on
the Quick framework through Quick3D. Therefore, these foreign types
can be removed from QtGraphs. This patch removes the foreign types
and exposes the needed types directly.
Fixes: QTBUG-133054
Change-Id: I86de22a675cc961f8934dd219103fbd61741e746
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Sakaria Pouke <sakaria.pouke@qt.io>
Reviewed-by: Kaj Grönholm <kaj.gronholm@qt.io>
(cherry picked from commit 0f7f77c3fc)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Datavis and Graphs have many duplicated files with same include guards.
Because QtGraphs has inherited many of its classes
from QtDataVisualization, the modules have many classes with the same
name. Therefore, mixing QtDataVisualization and QtGraphs headers in
the same TU violates ODR. This patch includes the check for that and
fails compilation with an error message.
Change-Id: I245c71c3fc5661ce0c33d5cd751ffb2a04754ad1
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
(cherry picked from commit 80a5704ac0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
It usually isn't necessary. It was when this class was created because
of a mistake in the swap() member function, which means we must continue
to export the symbol in question until 7.0.
Fixes: QTBUG-128656
Change-Id: Id680c7852fb6cb1e5780fffd44171e4699c9ddad
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
(cherry picked from commit 6ae7164a54)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
qdoc will soon warn about C++ types in QML property documentation.
This change fixes existing documentation to prevent warnings.
Pick-to: 6.8
Change-Id: I3030049c26ea0c91f5af84b8961030c51055897e
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
(cherry picked from commit d4cb49beb9)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
If axis visibility is set false,
use the whole window space for the graph.
Pick-to: 6.8
Fixes: QTBUG-132611
Change-Id: I732ffde3520d9f12d304e1fa5361052ac77cc78f
Reviewed-by: Kaj Grönholm <kaj.gronholm@qt.io>
(cherry picked from commit 61e6219283)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
qsplineseries.h includes a QtWidgets header without actually depending
on any its content (no does the library bring Qt::Widgets as
dependency). Seems to be unused and can be removed.
Pick-to: 6.8
Change-Id: Ied0dbefef1b8d0ea2e278ab91eb27f14c2de6cb6
Reviewed-by: Kaj Grönholm <kaj.gronholm@qt.io>
(cherry picked from commit 664543983a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
While 2×3×float won't be passed in registers in most ABIs, it's not
worse than passing by cref (objects are spilled onto the stack and
their addresses passed), but the compiler is much happier because
these objects now can't alias anything anymore.
Found is API-review.
The public Q3DGraphsWidgetItem also passes QColor and QPoint by value,
so uses the more modern appoach, and thus this also increases the
internal consistency of the API (though I note that it also has a
function that passes a QFlags by cref...).
Amends 1530321fda.
Change-Id: I6f2911697055d3bff6984a1726a27c65a7a9db27
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
(cherry picked from commit 7580c2ca1d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Also fixing wrong type in spline looping property doc
Change-Id: I398a009b85c73ccb1b6f6ccfe9ee7645ab87deb1
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
(cherry picked from commit 027ebfbef0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
plotAreaBackgroundVisibility was completely ignored by AxisRenderer.
This patch fixes it.
Fixes: QTBUG-132596
Pick-to: 6.8
Change-Id: I61ced5c05941f99d3516e478549e4b457c67ae83
Reviewed-by: Kaj Grönholm <kaj.gronholm@qt.io>
(cherry picked from commit 5dd5c394cb)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
barSetsChanged is now emitted when we append, remove, clear, take, insert or replace
countChanged is now emitted when we append, remove, clear or insert
X and Y axisChanged are now emitted when its setter function is called
Fixes: QTBUG-129425
Pick-to: 6.8
Change-Id: Id7b21592ec38441bec100963cece0ceca33ed5c1
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
(cherry picked from commit 9a057632b7)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Also fixed style customization warnings by switching style to basic instead of using the native one
Task-number: QTBUG-119683
Change-Id: I818b37cb9d8f4edfa2d1583f38897c2190a53e0c
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
(cherry picked from commit e71ccde8d5)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Qt Submodule Update Bot
Volker Hilsheimer
Lucie Gérard
Sakaria Pouke
Tomi Korpipaa
Topi Reinio
Niko Korkala
Sami Varanka
Thiago Macieira
David Boddie
Tim Blechmann
Owais Akhtar
Jere Tuliniemi
Marc Mutz