When an area series had consecutive points on the y=0 axis,
the renderer would draw a horizontal line segment which caused
visual glitches when filled.
This change avoids filling that problematic segment on the y=0
axis, which fixes the improper fill.
Pick-to: 6.8
Fixes: QTBUG-139112
Change-Id: I4461cbf80af9b059ccfcc714234fed5039d0cd43
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Jere Tuliniemi <jere.tuliniemi@qt.io>
(cherry picked from commit 52c5d1d3ec)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit c0829ec48a)
Reviewed-by: Kwanghyo Park <kwanghyo.park@qt.io>
Adding the same axis to multiple graphs is not supported. It will result
to crash since graphsview destructor tries to set axis' associated graph
to nullptr.
Fixes: QTBUG-138822
Pick-to: 6.8
Change-Id: If306e415f87f2366ae0d82f6fd5c9a9a5e356f85
Reviewed-by: Kaj Grönholm <kaj.gronholm@qt.io>
Reviewed-by: Alexei Cazacov <alexei.cazacov@qt.io>
(cherry picked from commit 818613a0ee)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 2cca8ce8c5)
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
Calling data() on mutable objects forces a detach, which voids the
optimization attempted by comparing data pointers of QList
specializations, such as QSurfaceDataArray or QBarDataArray. Test
with isSharedWith instead; the pointer returned by data() can only be
the same if the two lists are shared copies of each other.
Pick-to: 6.8
Change-Id: I3b4707c6e44ed9b7f08f76086ade4f08465b7653
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
(cherry picked from commit 0320e79022)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 66cfed3b2c)
QtQuick3D was listed as a required module in dependencies. However,
you should be able to build QtGraphs without 3D features. In that case,
it is not necessary to have Quick3D. Therefore, the Quick3D required
field should be false in the dependencies. In addition, the baseline
tests must be turned off if 3D features are unavailable, as they link
to Quick3D.
Pick-to: 6.8
Change-Id: I6c45fde93d75d54b4adf89471441d989452b0245
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
(cherry picked from commit 6300f5af2f)
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
(cherry picked from commit e486f98cbc)
Removes logic that caused setPieSize() and setHoleSize() to implicitly
modify each other. The setters now only affect their own respective
properties.
Pick-to: 6.8
Fixes: QTBUG-134003
Change-Id: I2d7b3e36d692248cd2de19dc6daa9d09a61c8158
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Kaj Grönholm <kaj.gronholm@qt.io>
(cherry picked from commit e2def3779a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 39c5cdc6f8)
When series is created outside of graphsview and then added into
a graphsview, the app crashes while closing. This seems to be because
it ends up calling pure virtual type function from the QAbstractSeries
in the getSeriesRendererIndex. This patch adds type variable to
QAbstractSeriesPrivate. The variable is set by QAbstractSeriesPrivate
constructor. The getSeriesRendererIndex function checks the value of
that variable instead of calling the virtual type().
Pick-to: 6.8
Fixes: QTBUG-138506
Change-Id: I7aca4970c38cbf83413818b0a77e7cf5d76195b6
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Kaj Grönholm <kaj.gronholm@qt.io>
(cherry picked from commit 630b38b3ee)
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
(cherry picked from commit 43ccf20e67)
Doing it this way should not break unity build, unlike
the previous attempt.
Change-Id: Ibe7f305ba9e41d1465bad7bbb7fb61860b225a98
Reviewed-by: Tim Blechmann <tim.blechmann@qt.io>
Reviewed-by: Kwanghyo Park <kwanghyo.park@qt.io>
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
(cherry picked from commit 4b815129c6)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 786c7b2c7f)
This broke unity build, so it has to be reverted in this form.
This reverts commit 6ba5d8f00c.
Change-Id: I58719cd79c53af764e973b47e115e0f4f02af917
Reviewed-by: Kwanghyo Park <kwanghyo.park@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
(cherry picked from commit ee46f585d9)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 35939f0732)
The QAbstractseries::graph() function returned a private type
QGraphView which was mistakenly exposed in public documentation.
Added \internal to the doc comment to hide the function from public
API docs. Fixes the documentation leak of the private class.
Pick-to: 6.8
Task-number: QTBUG-138456
Change-Id: I4f2af5e43ada043788f841e570df1911351dcdbb
Reviewed-by: Sze Howe Koh <szehowe.koh@gmail.com>
(cherry picked from commit 16b5a594e6)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit b00358a33d)
If data has been inserted with flipped order (filling Z axis
before X axis), detect it and print out a warning.
Pick-to: 6.8
Fixes: QTBUG-124738
Change-Id: I17bad88cdc8f0b8e336dc5fa18990cfd6afa46e0
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
Reviewed-by: Kwanghyo Park <kwanghyo.park@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
(cherry picked from commit 0a647dded3)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 191214ccc6)
Floor was updated in each sync, triggering some dirty flags
being set. Update floor only if something affecting it changes.
Fixes: QTBUG-136174
Change-Id: I172a8b443fd6d65f9cac3390071329f95a731f47
Reviewed-by: Sakaria Pouke <sakaria.pouke@qt.io>
Reviewed-by: Kwanghyo Park <kwanghyo.park@qt.io>
(cherry picked from commit f62322d262)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 7a25a45ced)
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Only call updateCamera if camera properties have changed.
Task-number: QTBUG-136174
Change-Id: I94f6c80e4c9e9e36a6399058bdd74866d2c0b202
Reviewed-by: Sakaria Pouke <sakaria.pouke@qt.io>
Reviewed-by: Kwanghyo Park <kwanghyo.park@qt.io>
(cherry picked from commit 7deeaa5196)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit aadd8fd9e7)
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
This does not fix the continous synchData completely, but removes
the unnecessary label updates.
Another patch is needed to take care of the endless sync loop.
Task-number: QTBUG-136174
Change-Id: I222deb86c25a4fafde73c550b0ae7151047a66e2
Reviewed-by: Kwanghyo Park <kwanghyo.park@qt.io>
Reviewed-by: Sakaria Pouke <sakaria.pouke@qt.io>
(cherry picked from commit f9fe3c37ee)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 4c96f4b0c4)
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
qmatrix4x4.h will lose its qquaternion.h include, so include
qquaternion.h explicitly in all files that mention 'QQuaternion',
unless, for a foo.cpp, the own foo.h has already included it.
Also add forward declarations, where needed.
Amends the start of this module's history.
Pick-to: 6.8
Change-Id: I605bf742be5bb92a676704f12d738d241bd9b0da
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
(cherry picked from commit 6a44c5fe57)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit e23fb8de70)
Qt Submodule Update Bot
Sami Varanka
Kwanghyo Park
Volker Hilsheimer
Alexey Edelev
Sakaria Pouke
Jani Heikkinen
Tomi Korpipaa
Dheerendra Purohit
Alexei Cazacov
Marc Mutz