We generally need to guess value types since there are value types
without metaobjects of their own, such as QRectF and QSizeF. However, if
they have upper case element names, they are clearly not in that
category. Guessing those as value types will make further tools produce
follow-up mistakes.
Fixes: QTBUG-111986
Change-Id: Ic15ef8c726eb3913c87eb4a300794f321f59fafa
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit c2fd73b516)
* Remove \generatelist example[files|images] commands, they do not
produce any output, only warnings.
* Add missing full stop to \brief descriptions.
Change-Id: I90c67b8c3f3bbe901fa083f781e9056da7763671
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
(cherry picked from commit 9c8a63b6c0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
The SliderHandle was changed in 0ac8eb67ea
to display the current value of the slider, while the SliderHandle was
being pressed.
This feature should be optional, and we currently don't have a nice API
for hiding it.
Let's look for a way to introduce this feature in Qt 6.6 instead.
Task-number: QTBUG-111355
Change-Id: I3c3f240839d1b69c0fea32d59c8abc8e64e1a184
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 2fcb336698)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This QML module, part of the Qt Quick Effects submodule, is not very
visible across the Qt Quick pages. Also, inform that this QML type
is the successor to the Qt Graphical Effects from Qt 5.
Fixes: QTBUG-111481
Change-Id: I933bcc196a292a08135bcf77b397b5f7ff5d4827
Reviewed-by: Kaj Grönholm <kaj.gronholm@qt.io>
(cherry picked from commit da4e62d07a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
The example should use &engine, not &app.
Fixes: QTBUG-111881
Change-Id: I434fc602a9f945f3e18b5289f548864c2e9f27e5
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 8ab0cd63b8)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
The current implementation of SelectedTapped allowed
the user to start editing when tapping on the _current_ cell.
This is not correct, SelectedTapped is supposed to (like
the name suggests) let the user start editing when tapping
on a _selected_ cell.
This patch will change the implementation so that
the user can tap on a selected cell to edit it.
Change-Id: Ice5de9250c23f5f57e71077d4f46d1a3f31e9b80
Reviewed-by: Santhosh Kumar <santhosh.kumar.selvaraj@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit bf12f5efa4)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
If the component has an error or was clear()'d its CU will be null.
Since isBound() is a public method, it should take that into account
rather than just crash.
Change-Id: I4a3e7417da3c87f6ce7dbb615f984815bc2b0b0b
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
(cherry picked from commit 51c6db3f3d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Guard the callers of the deprecated APIs with proper macros,
otherwise they will case compilation errors when deprecated APIs
from qtbase are disabled.
Change-Id: Ie25e7424aaccf7175c839ecddbd326a7a5649709
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit e70706de7d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
The current implementation would start a multi-selection when
holding down the Shift modifier. This is not correct. Holding
down Shift is normally done to extend an already active selection.
The correct way to do a multi-selection is to hold down Control.
Amends 52cbcd947d
Change-Id: I5dbb7c88702266e8a396dd0bdcd4fb68ffbbb0c2
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit 2da7c0441a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
We cannot assume anything about the accumulator register after calling
PushCallContext::call(). Also add a note about not needing to re-load
the accumulator on ThrowException.
Fixes: QTBUG-111935
Change-Id: I7196585e1d2697c215f4fe87d8d7ac9b98b622a3
Reviewed-by: <carl@carlschwan.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 15ec024152)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Subclasses of QSGRenderContext are responsible for releasing the
resource tracked by the render context on invalidate. I'm not sure the
software context will ever have any other resources than QSGTextures,
but it doesn't hurt to try and release everything anyway.
Fixes: QTBUG-106968
Change-Id: I58902e1a33c0d3d101e39af3e5f0a18d6820ce98
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
(cherry picked from commit f1b188df13)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
So far we did not completely restore aliases in inline components. This
was masked by the fact that until recently we failed to load inline
components from the disk cache and always loaded them from source
instead.
To fix this, refactor QQmlComponentAndAliasResolver to work for both,
QmlIR and QV4::CompiledData. With QmlIR, it populates the relevant data
structures. With QV4::CompiledData, it sanity-checks them. The
sanity-checks do incur some overhead, but given recent events, we
should err on the side of caution here.
Since QQmlComponentAndAliasResolver has received all the fixes we've
applied to make inline components work, this should lead to inline
components loaded from cache files to work the same way as those
compiled from source.
In turn, we can drop some methods of QQmlPropertyCacheAliasCreator.
Amends commit 131db085a7
Fixes: QTBUG-111766
Fixes: QTBUG-111857
Change-Id: I9cc75e700a5fe5810a866e9aa930b9811368b1b4
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 2d7fe23b41)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Many of the inherited docs were inappropriate or insufficiently specific
to PointHandler. Now we have more snippets with more ideas for how it
can be used.
As a drive-by, fix a typo in the docs for
PointerDeviceHandler::acceptedPointerTypes and add a link to the new
PointerDevice page added in e283c05af7
Fixes: QTBUG-74020
Fixes: QTBUG-106878
Change-Id: I028e1577ac5d4ef0b927c94259d6ab25b6028885
Reviewed-by: Doris Verria <doris.verria@qt.io>
(cherry picked from commit 4c6d0b2bf0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
...while also specifying 300 es in order to fix some of these shaders on
WebGL. If dynamic indexing is rejected in WebGL 1 and WebGL 2 with 100
es shaders, then the only option is to use 300 es shaders with WebGL 2.
Fixes: QTBUG-111227
Change-Id: I506aa0a7aa6870b888c0f55ad97b99c3e26c31c0
Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
(cherry picked from commit 15662b6a1a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
It's mainly intended for QML use cases: both MouseArea and WheelHandler
have wheel(QQuickWheelEvent *) signals. But the QML compiler generates
C++, and other use cases are possible. For the signals to be useful in
C++, their arguments need to be exported. Besides, the other classes in
this file are exported the same way (for example
21b3b74c99e2ee8dedb711ba448066eb308979dc; some were made private in
83e820ba76).
QQuickWheelEvent was added in f2e1be963f
Fixes: QTBUG-111230
Change-Id: I448aa633c7e7deb2e5f12e29bcb1c449be00a63d
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
(cherry picked from commit c6558b3c09)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Provides the NO_COMPILER_RUNTIME boolean option to
qt_generate_deploy_qml_app_script(), which forwards to
qt_deploy_runtime_dependencies().
On Windows, this option prevents the deployment of compiler runtimes.
[ChangeLog][CMake] Added the option NO_COMPILER_RUNTIME to
qt_generate_deploy_qml_app_script.
Task-number: QTBUG-111741
Change-Id: Ic51fc5430e21b8c5aba201d4675a37c9c220a3f2
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Amir Masoud Abdol <amir.abdol@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
(cherry picked from commit 0a0f777821)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
QQuickCalendarModelPrivate::getCount() was kludgey and wrong.
Rewrite it to use QCalendar::partsFromDate(), thereby bypassing repeat
calls to calendrical calculations, document what it's meant to be
doing and do that.
Fixes: QTBUG-111634
Change-Id: I3bdf0233fc1b170eaeb1948ba74e93f636a29bd7
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 17d0bf258b)
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Update the example by our coding conventions from our official
documentation.
- Fix qmllint warning.
- string are translated.
- JS statements no longer end with semi-colon.
Change-Id: Ibdf6879e6474a976bbcff5d5e3c28c98db55e9e0
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 26446d3b7e)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Hopefully this reduces flakiness in CI, following the suggestion from
the error message:
Unable to use getContext() at this time, please wait for available: true
Task-number: QTBUG-41043
Change-Id: I3710163cb197170e590f8fd7d188fa62f32ea649
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 223f1d45cc)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
We did not document it anywhere, the code is rather dated, and if we
want to promote QML as a scripting engine/an interpreter, we would need
to invest quite a bit more effort into a showcase.
Thus, remove the example for now.
Task-number: QTBUG-110649
Change-Id: Ie23b26379e7ea72271d793a6928a3757cde2cb12
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit e0c4a5ecf9)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
- Fix all qmllint warnings.
(except for main.qml, interactive.qml, and sampling.qml)
- Translate user facing strings when it makes sense to do so.
- Mark readonly properties as 'readonly'.
- Avoid binding on multiple properties on a single line.
(except for tiger.qml).
Change-Id: Idbf8a472ca5ba5385d1368aadd608e95231a07f0
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit e61d555a6d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This causes an alias to break when QML_DISABLE_DISK_CACHE is not set
(the default). Although it probably should work regardless, it doesn't
make sense for the inline component to be in the Page.
Amends d648235777.
Task-number: QTBUG-111857
Change-Id: I58d7234ad8f4e439093eb4ee60c7c9461660568a
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
(cherry picked from commit 92c220812c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
The test function is rather flaky in CI at the moment.
The problem appears to be related to the TextInput not
receiving keyboard focus correctly.
Calling forceActiveFocus() should be more reliable than
setFocus(true), and will hopefully be enough to stabilize
the test.
Change-Id: I4aeda581fc36e8b796c315b147a7e12acb032eba
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
(cherry picked from commit 8ec8133aa2)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
- mark readonly properties as readonly.
- Use qsTr() on user facing strings that would be sensible to localize.
- Removed unused lines of code.
- Separate lines with multiple bindings into multiple lines instead.
Change-Id: I9664cc2291be2f642dc2d9d27b6c356880a491c7
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit ba79f20f31)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Rewrite using the current style and add links to the translation
functions.
Change-Id: I8257d6e371b508e1ab23b0887eaa6316d2240ee0
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io>
(cherry picked from commit ab897f8e19)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
QML Loader creates multiple object of same component during initial
loading, if sourceComponent is assigned within state configuration
and it evaluates to be true. This happens due to the effect of
evaluating stage change (here in this case, setting loader source
component) during component completion which internally creates
component object and makes loader status be ready, even before
Loader instantiates object.
This patch adds a guard to check loader status and avoids object
creation if status is already ready.
Fixes: QTBUG-111559
Change-Id: I6c3456cd3bc35a717c139fbd3670c305304f480a
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit 492dc98a28)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
- reserve the borderBlink feedback for these signals: the flashAnimation
feedback is enough to show the regular tapped signal
- make the flashing border more obvious: wider on a lighter background
- make the border even wider for a double-tap
- just blink once; the 3-blink animation looked nice, like classic
macOS, but was a bit disorienting if you are tapping multiple times
and trying to count which signals got emitted
- stop the animation before starting the double-tap animation, to avoid
missing it: usually the double-click interval is less than 500ms
Followup to d3f2c6ac42
Task-number: QTBUG-65088
Task-number: QTBUG-107264
Change-Id: Ia2f78a7d1e758fc717078b6aa44a0f6716afd227
Reviewed-by: Matthias Rauter <matthias.rauter@qt.io>
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
(cherry picked from commit 9677fcf9aa)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Follow the convention that we link to qt6_ prefixed functions, but refer
to them in the documentation with only a qt_ prefix and trailing
parenths.
Change-Id: Icd0d5e51d1147f159aaaa4cc7f7faac6dfea5df5
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
(cherry picked from commit 87d06eac15)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
The loadImages() function has been waiting already since
6318560eca); but test_url() was not
waiting, which could result in CI flakiness. Anyway tryVerify is better
than waiting 200ms every time it's slow, and will give us a failure
message about isImageLoaded() if it fails.
Task-number: QTBUG-41043
Change-Id: I0bb552d3452d85342d2ffa3b6becded5b01177a8
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit e37d2dac8a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
A left-click followed by right-click was interpreted as a double-click.
This is different from what I am used to and different
from what I expect. This patch changes the behavior such that only
clicks of the same button are interpreted as double click.
Fixes: QTBUG-111557
Change-Id: Id0d83ca66944497710d8f659ed5a6d1e4260a2d9
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit d3c1813563)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Replace qt6_ prefix with qt_. Also refer to cmake functions as such in
the text.
Change-Id: I848a43fc64bd0ed18ce89ca1b720f8dea1f75e6c
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
(cherry picked from commit 57905da94f)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Ulf Hermann
Andreas Eliasson
Topi Reinio
Laszlo Agocs
Bumjoon Park
Oliver Eftevaag
Mitch Curtis
Richard Moe Gustavsen
Qt Submodule Update Bot
Yuhang Zhao
Andy Nichols
Shawn Rutledge
Christian Heimlich
Edward Welbourne
Olivier De Cannière
Fabian Kosmale
Leena Miettinen
Santhosh Kumar
Volker Hilsheimer
Matthias Rauter