qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix tst_qmltyperegistrar::singletonVersions 

We don't want to leak memory there and it had a typo.

Amends commit ad01abe1a6.

Change-Id: Id2ca7d1c11df54221aef95015d023cbcab0454b9
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io>
(cherry picked from commit 8dc1b08a5a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit d77a350d78)
This commit is contained in:
Ulf Hermann 2023-11-13 17:41:21 +01:00 committed by Qt Cherry-pick Bot
parent 83cc248141
commit d0ab1d4a92
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.cpp
View File

@ -566,7 +566,7 @@ void tst_qmltyperegistrar::uncreatable()
qmlRegisterTypesAndRevisions<GoodUncreatableExtended>("A", 1); qmlRegisterTypesAndRevisions<GoodUncreatableExtended>("A", 1);
} }
void tst_qmltyperegistrar::singletonVesions() void tst_qmltyperegistrar::singletonVersions()
{ {
QQmlEngine engine; QQmlEngine engine;
qmlRegisterTypesAndRevisions<SingletonVesion0>("A", 0); qmlRegisterTypesAndRevisions<SingletonVesion0>("A", 0);
@ -581,7 +581,7 @@ void tst_qmltyperegistrar::singletonVesions()
" property QtObject v1: SingletonVesion1\n" " property QtObject v1: SingletonVesion1\n"
"}", QUrl()); "}", QUrl());
QVERIFY2(c.isReady(), qPrintable(c.errorString())); QVERIFY2(c.isReady(), qPrintable(c.errorString()));
auto obj = c.create(); QScopedPointer<QObject> obj(c.create());
QVERIFY2(!obj->property("v0").isNull(), "Singleton version 0 is not registered"); QVERIFY2(!obj->property("v0").isNull(), "Singleton version 0 is not registered");
QVERIFY2(!obj->property("v1").isNull(), "Singleton version 1 is not registered"); QVERIFY2(!obj->property("v1").isNull(), "Singleton version 1 is not registered");
} }

2
tests/auto/qml/qmltyperegistrar/tst_qmltyperegistrar.h
View File

@ -593,7 +593,7 @@ private slots:
void methodReturnType(); void methodReturnType();
void hasIsConstantInParameters(); void hasIsConstantInParameters();
void uncreatable(); void uncreatable();
void singletonVesions(); void singletonVersions();
#ifdef QT_QUICK_LIB #ifdef QT_QUICK_LIB
void foreignRevisionedProperty(); void foreignRevisionedProperty();