qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tst_buttongroup: fail on warnings 

Enable fail on warnings for all tests in init() method.
Also, as a drive-by change, replace 'var' with 'let'

Task-number: QTBUG-98718
Change-Id: I4e23722a6c0e9e4afdc723bb11b9c518e764a54c
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 0e88c3e032)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 5c1e12d6d7)
This commit is contained in:
Vladimir Belyavsky 2023-11-20 20:56:18 +03:00 committed by Qt Cherry-pick Bot
parent 6c7e1b0737
commit c201787599
1 changed files with 39 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
tests/auto/quickcontrols/controls/data/tst_buttongroup.qml
View File

@ -28,14 +28,6 @@ TestCase {
SignalSpy { } SignalSpy { }
} }
function test_null() {
var group = createTemporaryObject(buttonGroup, testCase)
verify(group)
group.addButton(null)
group.removeButton(null)
}
Component { Component {
id: button id: button
Button { } Button { }
@ -46,10 +38,12 @@ TestCase {
QtObject { } QtObject { }
} }
function test_defaults() { function init() {
failOnWarning(/.?/) failOnWarning(/.?/)
}
var group = createTemporaryObject(buttonGroup, testCase) function test_defaults() {
let group = createTemporaryObject(buttonGroup, testCase)
verify(group) verify(group)
compare(group.buttons.length, 0) compare(group.buttons.length, 0)
compare(group.checkedButton, null) compare(group.checkedButton, null)
@ -57,17 +51,25 @@ TestCase {
compare(group.checkState, Qt.Unchecked) compare(group.checkState, Qt.Unchecked)
} }
function test_current() { function test_null() {
var group = createTemporaryObject(buttonGroup, testCase) let group = createTemporaryObject(buttonGroup, testCase)
verify(group) verify(group)
var checkedButtonSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "checkedButtonChanged"}) group.addButton(null)
group.removeButton(null)
}
function test_current() {
let group = createTemporaryObject(buttonGroup, testCase)
verify(group)
let checkedButtonSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "checkedButtonChanged"})
verify(checkedButtonSpy.valid) verify(checkedButtonSpy.valid)
verify(!group.checkedButton) verify(!group.checkedButton)
var button1 = createTemporaryObject(button, testCase, {checked: true}) let button1 = createTemporaryObject(button, testCase, {checked: true})
var button2 = createTemporaryObject(button, testCase, {checked: false}) let button2 = createTemporaryObject(button, testCase, {checked: false})
var button3 = createTemporaryObject(button, testCase, {checked: true, objectName: "3"}) let button3 = createTemporaryObject(button, testCase, {checked: true, objectName: "3"})
// add checked // add checked
group.addButton(button1) group.addButton(button1)
@ -127,17 +129,17 @@ TestCase {
} }
function test_buttons() { function test_buttons() {
var group = createTemporaryObject(buttonGroup, testCase) let group = createTemporaryObject(buttonGroup, testCase)
verify(group) verify(group)
var buttonsSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "buttonsChanged"}) let buttonsSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "buttonsChanged"})
verify(buttonsSpy.valid) verify(buttonsSpy.valid)
compare(group.buttons.length, 0) compare(group.buttons.length, 0)
compare(group.checkedButton, null) compare(group.checkedButton, null)
var button1 = createTemporaryObject(button, testCase, {checked: true}) let button1 = createTemporaryObject(button, testCase, {checked: true})
var button2 = createTemporaryObject(button, testCase, {checked: false}) let button2 = createTemporaryObject(button, testCase, {checked: false})
group.buttons = [button1, button2] group.buttons = [button1, button2]
compare(group.buttons.length, 2) compare(group.buttons.length, 2)
@ -146,7 +148,7 @@ TestCase {
compare(group.checkedButton, button1) compare(group.checkedButton, button1)
compare(buttonsSpy.count, 2) compare(buttonsSpy.count, 2)
var button3 = createTemporaryObject(button, testCase, {checked: true}) let button3 = createTemporaryObject(button, testCase, {checked: true})
group.addButton(button3) group.addButton(button3)
compare(group.buttons.length, 3) compare(group.buttons.length, 3)
@ -177,14 +179,14 @@ TestCase {
} }
function test_clicked(data) { function test_clicked(data) {
var group = createTemporaryObject(buttonGroup, testCase, {exclusive: data.exclusive}) let group = createTemporaryObject(buttonGroup, testCase, {exclusive: data.exclusive})
verify(group) verify(group)
var clickedSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "clicked"}) let clickedSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "clicked"})
verify(clickedSpy.valid) verify(clickedSpy.valid)
var button1 = createTemporaryObject(button, testCase) let button1 = createTemporaryObject(button, testCase)
var button2 = createTemporaryObject(button, testCase) let button2 = createTemporaryObject(button, testCase)
group.addButton(button1) group.addButton(button1)
group.addButton(button2) group.addButton(button2)
@ -252,7 +254,7 @@ TestCase {
} }
function test_controls(data) { function test_controls(data) {
var container = createTemporaryObject(data.component, testCase) let container = createTemporaryObject(data.component, testCase)
verify(container) verify(container)
verify(!container.group.checkedButton) verify(!container.group.checkedButton)
@ -277,13 +279,13 @@ TestCase {
} }
function test_buttonDestroyed() { function test_buttonDestroyed() {
var group = createTemporaryObject(buttonGroup, testCase) let group = createTemporaryObject(buttonGroup, testCase)
verify(group) verify(group)
var buttonsSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "buttonsChanged"}) let buttonsSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "buttonsChanged"})
verify(buttonsSpy.valid) verify(buttonsSpy.valid)
var button1 = createTemporaryObject(button, testCase, {objectName: "button1", checked: true}) let button1 = createTemporaryObject(button, testCase, {objectName: "button1", checked: true})
group.addButton(button1) group.addButton(button1)
compare(group.buttons.length, 1) compare(group.buttons.length, 1)
@ -316,7 +318,7 @@ TestCase {
} }
function test_repeater() { function test_repeater() {
var container = createTemporaryObject(repeater, testCase) let container = createTemporaryObject(repeater, testCase)
verify(container) verify(container)
verify(container.group.checkedButton) verify(container.group.checkedButton)
@ -324,25 +326,25 @@ TestCase {
} }
function test_nonExclusive() { function test_nonExclusive() {
var group = createTemporaryObject(nonExclusiveGroup, testCase) let group = createTemporaryObject(nonExclusiveGroup, testCase)
verify(group) verify(group)
compare(group.checkState, Qt.Unchecked) compare(group.checkState, Qt.Unchecked)
var button1 = createTemporaryObject(button, testCase, {checked: true}) let button1 = createTemporaryObject(button, testCase, {checked: true})
group.addButton(button1) group.addButton(button1)
compare(button1.checked, true) compare(button1.checked, true)
compare(group.checkedButton, null) compare(group.checkedButton, null)
compare(group.checkState, Qt.Checked) compare(group.checkState, Qt.Checked)
var button2 = createTemporaryObject(button, testCase, {checked: true}) let button2 = createTemporaryObject(button, testCase, {checked: true})
group.addButton(button2) group.addButton(button2)
compare(button1.checked, true) compare(button1.checked, true)
compare(button2.checked, true) compare(button2.checked, true)
compare(group.checkedButton, null) compare(group.checkedButton, null)
compare(group.checkState, Qt.Checked) compare(group.checkState, Qt.Checked)
var button3 = createTemporaryObject(button, testCase, {checked: false}) let button3 = createTemporaryObject(button, testCase, {checked: false})
group.addButton(button3) group.addButton(button3)
compare(button1.checked, true) compare(button1.checked, true)
compare(button2.checked, true) compare(button2.checked, true)
@ -401,7 +403,7 @@ TestCase {
model: ListModel { model: ListModel {
id: listModel id: listModel
Component.onCompleted: { Component.onCompleted: {
for (var i = 0; i < 10; ++i) for (let i = 0; i < 10; ++i)
append({text: i}) append({text: i})
} }
} }
@ -410,7 +412,7 @@ TestCase {
} }
function test_checkedButtonDestroyed() { function test_checkedButtonDestroyed() {
var column = createTemporaryObject(checkedButtonColumn, testCase) let column = createTemporaryObject(checkedButtonColumn, testCase)
verify(column) verify(column)
waitForRendering(column) waitForRendering(column)
@ -452,7 +454,7 @@ TestCase {
} }
function test_resetButtonGroup() { function test_resetButtonGroup() {
var container = createTemporaryObject(buttonGroupComp, testCase) let container = createTemporaryObject(buttonGroupComp, testCase)
verify(container) verify(container)
// Check for initial buttons assigned to button group // Check for initial buttons assigned to button group