qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tst_actiongroup: fail on warnings 

Enable fail on warnings for all tests in init() method.
Also, as a drive-by change, replace 'var' with 'let'

Task-number: QTBUG-98718
Change-Id: Ie07ee1cccfeb22f29d6a27e50dfb810b99a94db5
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 71b62a4e57)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 0625712e76)
This commit is contained in:
Vladimir Belyavsky 2023-11-17 22:48:30 +03:00 committed by Qt Cherry-pick Bot
parent ee05413e7c
commit a22a8ed914
1 changed files with 34 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
tests/auto/quickcontrols/controls/data/tst_actiongroup.qml
View File

@ -37,8 +37,12 @@ TestCase {
SignalSpy { } SignalSpy { }
} }
function init() {
failOnWarning(/.?/)
}
function test_null() { function test_null() {
var group = createTemporaryObject(actionGroup, testCase) let group = createTemporaryObject(actionGroup, testCase)
verify(group) verify(group)
group.addAction(null) group.addAction(null)
@ -51,9 +55,7 @@ TestCase {
} }
function test_defaults() { function test_defaults() {
failOnWarning(/.?/) let group = createTemporaryObject(actionGroup, testCase)
var group = createTemporaryObject(actionGroup, testCase)
verify(group) verify(group)
compare(group.actions.length, 0) compare(group.actions.length, 0)
compare(group.checkedAction, null) compare(group.checkedAction, null)
@ -61,16 +63,16 @@ TestCase {
} }
function test_current() { function test_current() {
var group = createTemporaryObject(actionGroup, testCase) let group = createTemporaryObject(actionGroup, testCase)
verify(group) verify(group)
var checkedActionSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "checkedActionChanged"}) let checkedActionSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "checkedActionChanged"})
verify(checkedActionSpy.valid) verify(checkedActionSpy.valid)
verify(!group.checkedAction) verify(!group.checkedAction)
var action1 = createTemporaryObject(action, testCase, {checked: true}) let action1 = createTemporaryObject(action, testCase, {checked: true})
var action2 = createTemporaryObject(action, testCase, {checked: false}) let action2 = createTemporaryObject(action, testCase, {checked: false})
var action3 = createTemporaryObject(action, testCase, {checked: true, objectName: "3"}) let action3 = createTemporaryObject(action, testCase, {checked: true, objectName: "3"})
// add checked // add checked
group.addAction(action1) group.addAction(action1)
@ -130,17 +132,17 @@ TestCase {
} }
function test_actions() { function test_actions() {
var group = createTemporaryObject(actionGroup, testCase) let group = createTemporaryObject(actionGroup, testCase)
verify(group) verify(group)
var actionsSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "actionsChanged"}) let actionsSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "actionsChanged"})
verify(actionsSpy.valid) verify(actionsSpy.valid)
compare(group.actions.length, 0) compare(group.actions.length, 0)
compare(group.checkedAction, null) compare(group.checkedAction, null)
var action1 = createTemporaryObject(action, testCase, {checked: true}) let action1 = createTemporaryObject(action, testCase, {checked: true})
var action2 = createTemporaryObject(action, testCase, {checked: false}) let action2 = createTemporaryObject(action, testCase, {checked: false})
group.actions = [action1, action2] group.actions = [action1, action2]
compare(group.actions.length, 2) compare(group.actions.length, 2)
@ -149,7 +151,7 @@ TestCase {
compare(group.checkedAction, action1) compare(group.checkedAction, action1)
compare(actionsSpy.count, 2) compare(actionsSpy.count, 2)
var action3 = createTemporaryObject(action, testCase, {checked: true}) let action3 = createTemporaryObject(action, testCase, {checked: true})
group.addAction(action3) group.addAction(action3)
compare(group.actions.length, 3) compare(group.actions.length, 3)
@ -173,7 +175,7 @@ TestCase {
} }
function test_declarative() { function test_declarative() {
var group = createTemporaryObject(declarativeGroup, testCase) let group = createTemporaryObject(declarativeGroup, testCase)
verify(group) verify(group)
compare(group.actions.length, 3) compare(group.actions.length, 3)
@ -190,14 +192,14 @@ TestCase {
} }
function test_triggered(data) { function test_triggered(data) {
var group = createTemporaryObject(actionGroup, testCase, {exclusive: data.exclusive}) let group = createTemporaryObject(actionGroup, testCase, {exclusive: data.exclusive})
verify(group) verify(group)
var triggeredSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "triggered"}) let triggeredSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "triggered"})
verify(triggeredSpy.valid) verify(triggeredSpy.valid)
var action1 = createTemporaryObject(action, testCase) let action1 = createTemporaryObject(action, testCase)
var action2 = createTemporaryObject(action, testCase) let action2 = createTemporaryObject(action, testCase)
group.addAction(action1) group.addAction(action1)
group.addAction(action2) group.addAction(action2)
@ -222,7 +224,7 @@ TestCase {
} }
function test_attached() { function test_attached() {
var container = createTemporaryObject(attachedGroup, testCase) let container = createTemporaryObject(attachedGroup, testCase)
verify(container) verify(container)
verify(!container.group.checkedAction) verify(!container.group.checkedAction)
@ -247,13 +249,13 @@ TestCase {
} }
function test_actionDestroyed() { function test_actionDestroyed() {
var group = createTemporaryObject(actionGroup, testCase) let group = createTemporaryObject(actionGroup, testCase)
verify(group) verify(group)
var actionsSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "actionsChanged"}) let actionsSpy = createTemporaryObject(signalSpy, testCase, {target: group, signalName: "actionsChanged"})
verify(actionsSpy.valid) verify(actionsSpy.valid)
var action1 = createTemporaryObject(action, testCase, {objectName: "action1", checked: true}) let action1 = createTemporaryObject(action, testCase, {objectName: "action1", checked: true})
group.addAction(action1) group.addAction(action1)
compare(group.actions.length, 1) compare(group.actions.length, 1)
@ -269,15 +271,15 @@ TestCase {
} }
function test_nonExclusive() { function test_nonExclusive() {
var group = createTemporaryObject(nonExclusiveGroup, testCase) let group = createTemporaryObject(nonExclusiveGroup, testCase)
verify(group) verify(group)
var action1 = createTemporaryObject(action, testCase, {checked: true}) let action1 = createTemporaryObject(action, testCase, {checked: true})
group.addAction(action1) group.addAction(action1)
compare(action1.checked, true) compare(action1.checked, true)
compare(group.checkedAction, null) compare(group.checkedAction, null)
var action2 = createTemporaryObject(action, testCase, {checked: true}) let action2 = createTemporaryObject(action, testCase, {checked: true})
group.addAction(action2) group.addAction(action2)
compare(action1.checked, true) compare(action1.checked, true)
compare(action2.checked, true) compare(action2.checked, true)
@ -305,18 +307,18 @@ TestCase {
} }
function test_enabled() { function test_enabled() {
var group = createTemporaryObject(actionGroup, testCase) let group = createTemporaryObject(actionGroup, testCase)
verify(group) verify(group)
compare(group.enabled, true) compare(group.enabled, true)
var action1 = createTemporaryObject(action, testCase) let action1 = createTemporaryObject(action, testCase)
var action2 = createTemporaryObject(action, testCase) let action2 = createTemporaryObject(action, testCase)
compare(action1.enabled, true) compare(action1.enabled, true)
compare(action2.enabled, true) compare(action2.enabled, true)
var action1Spy = createTemporaryObject(signalSpy, testCase, {target: action1, signalName: "enabledChanged"}) let action1Spy = createTemporaryObject(signalSpy, testCase, {target: action1, signalName: "enabledChanged"})
var action2Spy = createTemporaryObject(signalSpy, testCase, {target: action2, signalName: "enabledChanged"}) let action2Spy = createTemporaryObject(signalSpy, testCase, {target: action2, signalName: "enabledChanged"})
verify(action1Spy.valid && action2Spy.valid) verify(action1Spy.valid && action2Spy.valid)
group.addAction(action1) group.addAction(action1)
@ -392,7 +394,7 @@ TestCase {
} }
function test_controls(data) { function test_controls(data) {
var container = createTemporaryObject(data.component, testCase) let container = createTemporaryObject(data.component, testCase)
verify(container) verify(container)
verify(!container.group.checkedAction) verify(!container.group.checkedAction)