qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix uninitialized read in Qt Quick Shapes 

Found when running valgrind on tests/auto/quick/examples:
In QQuickShapeGenericRenderer::setFillColor() and
QQuickShapeGenericRenderer::setStrokeColor() we read the
current color's alpha value for a dirty flag. When no
color had yet been set, this value was uninitialized.

Change-Id: I3826030619b048058e866ca7b04aac64828293b7
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
This commit is contained in:
Eskil Abrahamsen Blomfeldt 2023-11-10 10:50:29 +01:00
parent d0cb311e0d
commit 8b022182d2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/quickshapes/qquickshapegenericrenderer_p.h
View File

@ -97,8 +97,8 @@ private:
struct ShapePathData {
float strokeWidth;
QPen pen;
Color4ub strokeColor;
Color4ub fillColor;
Color4ub strokeColor = { uchar(0), uchar(0), uchar(0), uchar(0) };
Color4ub fillColor = { uchar(0), uchar(0), uchar(0), uchar(0) };
Qt::FillRule fillRule;
QPainterPath path;
FillGradientType fillGradientActive;