From 810a329983d2d26101881eb58a9faf0cf6d78399 Mon Sep 17 00:00:00 2001 From: Shawn Rutledge Date: Tue, 13 Jun 2023 09:06:36 +0200 Subject: [PATCH] Move textselection example to manual test Apparently it's always been incomplete, a relic from Nokia: there's no means of entering the "menu" state, and nothing to detect a long-press as the text says you can do. On mobile platforms, the platform input method provides selection handles; on embedded platforms, Qt Virtual Keyboard does it. So this is generally unnecessary, but perhaps it could be revamped into a demonstration of an alternative way to add text-selection handles. Pick-to: 6.6 6.5 Change-Id: I231db14e5fbb4e82e8d732153e3d3843a080b409 Reviewed-by: Oliver Eftevaag --- examples/quick/text/CMakeLists.txt | 5 ----- examples/quick/text/text.qrc | 5 ----- .../manual}/textselection/pics/endHandle.png | Bin .../manual}/textselection/pics/endHandle.sci | 0 .../manual}/textselection/pics/startHandle.png | Bin .../manual}/textselection/pics/startHandle.sci | 0 .../manual}/textselection/textselection.qml | 0 7 files changed, 10 deletions(-) rename {examples/quick/text => tests/manual}/textselection/pics/endHandle.png (100%) rename {examples/quick/text => tests/manual}/textselection/pics/endHandle.sci (100%) rename {examples/quick/text => tests/manual}/textselection/pics/startHandle.png (100%) rename {examples/quick/text => tests/manual}/textselection/pics/startHandle.sci (100%) rename {examples/quick/text => tests/manual}/textselection/textselection.qml (100%) diff --git a/examples/quick/text/CMakeLists.txt b/examples/quick/text/CMakeLists.txt index e4b7af6901..63ace74b53 100644 --- a/examples/quick/text/CMakeLists.txt +++ b/examples/quick/text/CMakeLists.txt @@ -42,7 +42,6 @@ qt_add_qml_module(textexample "imgtag/imgtag.qml" "styledtext-layout.qml" "text.qml" - "textselection/textselection.qml" RESOURCES "fonts/content/fonts/tarzeau_ocr_a.ttf" "imgtag/images/face-sad.png" @@ -51,10 +50,6 @@ qt_add_qml_module(textexample "imgtag/images/heart200.png" "imgtag/images/qtlogo.png" "imgtag/images/starfish_2.png" - "textselection/pics/endHandle.png" - "textselection/pics/endHandle.sci" - "textselection/pics/startHandle.png" - "textselection/pics/startHandle.sci" ) install(TARGETS textexample diff --git a/examples/quick/text/text.qrc b/examples/quick/text/text.qrc index a59d66fdbe..8d727c2831 100644 --- a/examples/quick/text/text.qrc +++ b/examples/quick/text/text.qrc @@ -13,11 +13,6 @@ imgtag/images/heart200.png imgtag/images/qtlogo.png imgtag/images/starfish_2.png - textselection/textselection.qml - textselection/pics/endHandle.png - textselection/pics/endHandle.sci - textselection/pics/startHandle.png - textselection/pics/startHandle.sci styledtext-layout.qml imgtag/TextWithImage.qml diff --git a/examples/quick/text/textselection/pics/endHandle.png b/tests/manual/textselection/pics/endHandle.png similarity index 100% rename from examples/quick/text/textselection/pics/endHandle.png rename to tests/manual/textselection/pics/endHandle.png diff --git a/examples/quick/text/textselection/pics/endHandle.sci b/tests/manual/textselection/pics/endHandle.sci similarity index 100% rename from examples/quick/text/textselection/pics/endHandle.sci rename to tests/manual/textselection/pics/endHandle.sci diff --git a/examples/quick/text/textselection/pics/startHandle.png b/tests/manual/textselection/pics/startHandle.png similarity index 100% rename from examples/quick/text/textselection/pics/startHandle.png rename to tests/manual/textselection/pics/startHandle.png diff --git a/examples/quick/text/textselection/pics/startHandle.sci b/tests/manual/textselection/pics/startHandle.sci similarity index 100% rename from examples/quick/text/textselection/pics/startHandle.sci rename to tests/manual/textselection/pics/startHandle.sci diff --git a/examples/quick/text/textselection/textselection.qml b/tests/manual/textselection/textselection.qml similarity index 100% rename from examples/quick/text/textselection/textselection.qml rename to tests/manual/textselection/textselection.qml