qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tst_action: fail on warnings 

Enable fail on warnings for all tests in init() method.
Also, as a drive-by change, replace 'var' with 'let'

Task-number: QTBUG-98718
Change-Id: I24d1488220dc2ef60c32cc3e5e5637f620bbbad9
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 1717695187)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 94a0e7416f)
This commit is contained in:
Vladimir Belyavsky 2023-11-17 22:44:15 +03:00 committed by Qt Cherry-pick Bot
parent ed55007697
commit 76c5fb6039
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tests/auto/quickcontrols/controls/data/tst_action.qml
View File

@ -24,18 +24,20 @@ TestCase {
SignalSpy { }
}
function test_empty() {
function init() {
failOnWarning(/.?/)
}
function test_empty() {
let control = createTemporaryObject(component, testCase)
verify(control)
}
function test_enabled() {
var action = createTemporaryObject(component, testCase)
let action = createTemporaryObject(component, testCase)
verify(action)
var spy = createTemporaryObject(signalSpy, testCase, {target: action, signalName: "triggered"})
let spy = createTemporaryObject(signalSpy, testCase, {target: action, signalName: "triggered"})
verify(spy.valid)
action.trigger()
@ -89,7 +91,7 @@ TestCase {
}
function test_shared() {
var container = createTemporaryObject(buttonAndMenu, testCase)
let container = createTemporaryObject(buttonAndMenu, testCase)
verify(container)
keyClick(Qt.Key_B, Qt.ControlModifier)
@ -126,10 +128,10 @@ TestCase {
}
function test_repeater() {
var container = createTemporaryObject(actionAndRepeater, testCase)
let container = createTemporaryObject(actionAndRepeater, testCase)
verify(container)
var spy = signalSpy.createObject(container, {target: container.action, signalName: "triggered"})
let spy = signalSpy.createObject(container, {target: container.action, signalName: "triggered"})
verify(spy.valid)
keyClick(Qt.Key_A, Qt.ControlModifier)
@ -160,7 +162,7 @@ TestCase {
}
function test_shortcutBinding() {
var container = createTemporaryObject(shortcutBinding, testCase);
let container = createTemporaryObject(shortcutBinding, testCase);
verify(container)
compare(container.indirect.nativeText, container.direct.nativeText);
}
@ -188,7 +190,7 @@ TestCase {
function test_shortcutCleanup() {
{
var container = createTemporaryObject(shortcutCleanup, testCase);
let container = createTemporaryObject(shortcutCleanup, testCase);
verify(container)
container.action.shortcut = "Delete"
container.menu.open()