qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
qtdeclarative/tests/auto/quickcontrols/qquickapplicationwindow/tst_qquickapplicationwindow...

1207 lines
48 KiB
C++
Raw Normal View History

Use SPDX license identifiers Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2022-05-13 13:12:05 +00:00
// Copyright (C) 2017 The Qt Company Ltd.
Correct license for test files According to QUIP-18 [1], all test files should be LicenseRef-Qt-Commercial OR GPL-3.0-only [1]: https://contribute.qt-project.org/quips/18 Pick-to: 6.7 Task-number: QTBUG-121787 Change-Id: I26d72e8de04d4c7c57b3b7838af5d033265de5ba Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Kai Köhne <kai.koehne@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2024-02-22 14:51:16 +00:00
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
#include <qtest.h>
Skip tests that use graphical effects on Win 7 It's not clear why these fail, but we can live without the test on Windows 7. Fixes: QTBUG-84443 Change-Id: Ib18dfc8e12528c5086d07d6018cda93fb6e8d30c Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2020-05-26 08:16:34 +00:00
#include <QtCore/qoperatingsystemversion.h>
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
#include <QtTest/QSignalSpy>
#include <QtQml/qqmlengine.h>
#include <QtQml/qqmlcomponent.h>
#include <QtQml/qqmlcontext.h>
#include <QtQuick/qquickview.h>
#include <QtQuick/private/qquickitem_p.h>
Fix broken hover in ApplicationWindow's background 8fb643f6d63813a5a8df5e829e4ddeb357e0348d fixed ComboBox not being hoverable by setting QQuickApplicationWindowPrivate::control's hoverEnabled property to true. By doing so, it ensured that only that control and its parent chain could get hover events, breaking hover for e.g. background. The correct fix is to adapt QQuickControlPrivate::calcHoverEnabled to skip the property("hoverEnabled") == true check for QQuickApplicationWindowPrivate::control, resulting in it falling back to the global checks. - Remove code added in 8fb643f6d63813a5a8df5e829e4ddeb357e0348d. - Move QQuickApplicationWindowPrivate declaration into its own header so that code outside the .cpp file (qquickcontrol.cpp, in this case) can use it. - Document behavior of hover flags in void QQuickItem::setAcceptHoverEvents. - Move the check done in tst_QQuickControl::hoverEnabledDefault() into the new tst_QQuickApplicationWindow::hoverInBackground() since they're closely related. - Add initial starting position argument to PointLerper's constructor since it wasn't previously possible to set it. - Remove unused headers in qquickapplicationwindow.cpp. Fixes: QTBUG-133886 Fixes: QTBUG-136031 Pick-to: 6.9 Change-Id: Ic32f902be6433c1c9dc9f4610c5715ce1537e605 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2025-04-17 02:34:11 +00:00
#include <QtQuick/private/qquickmousearea_p.h>
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
#include <QtQuickTest/quicktest.h>
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
#include <QtQuickTestUtils/private/qmlutils_p.h>
#include <QtQuickTestUtils/private/visualtestutils_p.h>
QQuickApplicationWindow: resolve the default system theme font Change-Id: I6927ee293e5126abc037a3eb9f86a67825732679 Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
2016-01-28 10:13:46 +00:00
#include <QtGui/private/qguiapplication_p.h>
ApplicationWindow: respect explicitly set background size 4a2466ea075676e8953ac7e9729492a0ace02c32 made ApplicationWindow explicitly set the background's width and height if they hadn't already been explicitly set. However, in certain cases widthValid() and heightValid() were checked before background's deferred execution had completed. This meant that the user's width and height bindings hadn't been evaluated yet, and hence widthValid and heightValid were false. Fix this by waiting until execution has finished before checking. Fixes: QTBUG-124744 Pick-to: 6.5 6.6 6.7 Change-Id: I1007f638a60c1ae4e0b07dbf91d5583bbfdcf8fb Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2024-04-26 02:41:38 +00:00
#include <QtQuickTemplates2/private/qquickabstractbutton_p.h>
Templates: rename the C++ module to qtquicktemplates2 Change-Id: I146da903b46f5c2caf865e37291c25376b49021a Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-13 13:59:53 +00:00
#include <QtQuickTemplates2/private/qquickapplicationwindow_p.h>
#include <QtQuickTemplates2/private/qquickoverlay_p.h>
#include <QtQuickTemplates2/private/qquickcontrol_p.h>
Fix broken hover in ApplicationWindow's background 8fb643f6d63813a5a8df5e829e4ddeb357e0348d fixed ComboBox not being hoverable by setting QQuickApplicationWindowPrivate::control's hoverEnabled property to true. By doing so, it ensured that only that control and its parent chain could get hover events, breaking hover for e.g. background. The correct fix is to adapt QQuickControlPrivate::calcHoverEnabled to skip the property("hoverEnabled") == true check for QQuickApplicationWindowPrivate::control, resulting in it falling back to the global checks. - Remove code added in 8fb643f6d63813a5a8df5e829e4ddeb357e0348d. - Move QQuickApplicationWindowPrivate declaration into its own header so that code outside the .cpp file (qquickcontrol.cpp, in this case) can use it. - Document behavior of hover flags in void QQuickItem::setAcceptHoverEvents. - Move the check done in tst_QQuickControl::hoverEnabledDefault() into the new tst_QQuickApplicationWindow::hoverInBackground() since they're closely related. - Add initial starting position argument to PointLerper's constructor since it wasn't previously possible to set it. - Remove unused headers in qquickapplicationwindow.cpp. Fixes: QTBUG-133886 Fixes: QTBUG-136031 Pick-to: 6.9 Change-Id: Ic32f902be6433c1c9dc9f4610c5715ce1537e605 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2025-04-17 02:34:11 +00:00
#include <QtQuickTemplates2/private/qquickcontrol_p_p.h>
Templates: rename the C++ module to qtquicktemplates2 Change-Id: I146da903b46f5c2caf865e37291c25376b49021a Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-13 13:59:53 +00:00
#include <QtQuickTemplates2/private/qquicklabel_p.h>
Fix focus handling for popups When a popup is closed, if there are multiple popups open, restore focus to the next popup in chain instead of transferring focus to the window content. This allows us to cleanup the custom focus handling for sub-menus in dev. There is no more need to manually transfer focus to the parent menu or to a sub-menu, but calling open() or close() is enough and the focus is automatically transferred as expected. Change-Id: I54406c7c6b8dd25af261e00ebb1ae00ccbea8b9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 14:48:07 +00:00
#include <QtQuickTemplates2/private/qquickmenu_p.h>
#include <QtQuickTemplates2/private/qquickpopup_p.h>
Templates: rename the C++ module to qtquicktemplates2 Change-Id: I146da903b46f5c2caf865e37291c25376b49021a Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-13 13:59:53 +00:00
#include <QtQuickTemplates2/private/qquicktextarea_p.h>
#include <QtQuickTemplates2/private/qquicktextfield_p.h>
Rename QQuickTheme::current to instance Avoid giving a wrong impression that the theme instance could be changed on the fly. Change-Id: Ifb5078422385d2f15da6a416d89cc9d6f46b0f40 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2018-05-15 21:29:46 +00:00
#include <QtQuickTemplates2/private/qquicktheme_p_p.h>
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
#include <QtQuickControls2/qquickstyle.h>
ApplicationWindow: explicitly set background size if not explicitly set 41eb033fa2585b3644a545b75a414d4d3efa8b2c addressed QTBUG-118779 by documenting that certain items like Image would need to have their size explicitly set to the size of the window. This isn't in line with the background-resizing behavior of Control, which explicitly sets the size of the background if it hasn't been set (see 7e3c882d9a5cd6a25f547091a4ece786f516f2a4). This patch partially reverts 41eb033fa2585b3644a545b75a414d4d3efa8b2c by removing the change to the documentation. The relevant code in the wearable example has since been changed, so there's nothing to revert there. [ChangeLog][Controls][Important Behavior Changes] ApplicationWindow now explicitly sets the width and height of its background if no size was explicitly set by the user. This matches the behavior of Control, and ensures that if e.g. an Image is used as a window's background, any changes in its implicit size (e.g. after a source change) won't affect its actual size. Fixes: QTBUG-121466 Pick-to: 6.5 6.6 6.7 Change-Id: I0fbe029626d736b4b96acce1a2ca450660a47271 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-11 05:03:30 +00:00
#include <QtQuickControlsTestUtils/private/controlstestutils_p.h>
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
using namespace QQuickVisualTestUtils;
ApplicationWindow: explicitly set background size if not explicitly set 41eb033fa2585b3644a545b75a414d4d3efa8b2c addressed QTBUG-118779 by documenting that certain items like Image would need to have their size explicitly set to the size of the window. This isn't in line with the background-resizing behavior of Control, which explicitly sets the size of the background if it hasn't been set (see 7e3c882d9a5cd6a25f547091a4ece786f516f2a4). This patch partially reverts 41eb033fa2585b3644a545b75a414d4d3efa8b2c by removing the change to the documentation. The relevant code in the wearable example has since been changed, so there's nothing to revert there. [ChangeLog][Controls][Important Behavior Changes] ApplicationWindow now explicitly sets the width and height of its background if no size was explicitly set by the user. This matches the behavior of Control, and ensures that if e.g. an Image is used as a window's background, any changes in its implicit size (e.g. after a source change) won't affect its actual size. Fixes: QTBUG-121466 Pick-to: 6.5 6.6 6.7 Change-Id: I0fbe029626d736b4b96acce1a2ca450660a47271 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-11 05:03:30 +00:00
using namespace QQuickControlsTestUtils;
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
class tst_QQuickApplicationWindow : public QQmlDataTest
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
{
Q_OBJECT
Make tests explicitly use Basic where necessary The previous commit changes the how the default style is set, and since the tests all assumed that Basic was the default, we now need to ensure it is explicitly set. If we want to, we can revert this patch (or file-by-file) later and ensure that these tests work with all styles. For now, just keep things working as they used to. Tests that use QTEST_QUICKCONTROLS_MAIN are not changed, as they already run with all built-in styles. Tests that don't use types that will cause issues, like tst_qquickcolor, do not need to be changed. tst_snippets can be run manually to produce screenshots, so we specify its style in a qtquickcontrols2.conf file to allow it to be overridden by e.g. application arguments (QQuickStyle::setStyle() takes precedence over all other approaches of setting a style). Change-Id: Ifae7e959f89a41a757c170272038fad139bba04f Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-09-30 12:22:42 +00:00
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
public:
Make tests explicitly use Basic where necessary The previous commit changes the how the default style is set, and since the tests all assumed that Basic was the default, we now need to ensure it is explicitly set. If we want to, we can revert this patch (or file-by-file) later and ensure that these tests work with all styles. For now, just keep things working as they used to. Tests that use QTEST_QUICKCONTROLS_MAIN are not changed, as they already run with all built-in styles. Tests that don't use types that will cause issues, like tst_qquickcolor, do not need to be changed. tst_snippets can be run manually to produce screenshots, so we specify its style in a qtquickcontrols2.conf file to allow it to be overridden by e.g. application arguments (QQuickStyle::setStyle() takes precedence over all other approaches of setting a style). Change-Id: Ifae7e959f89a41a757c170272038fad139bba04f Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-09-30 12:22:42 +00:00
tst_QQuickApplicationWindow();
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
private slots:
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
void qmlCreation();
void activeFocusOnTab1();
void activeFocusOnTab2();
void defaultFocus();
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
void implicitFill();
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
void attachedProperties();
QQuickApplicationWindow: add font property Change-Id: I6f946994f789704aa2efa94aaea0129d0d73d005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-03 12:23:27 +00:00
void font();
QQuickApplicationWindow: resolve the default system theme font Change-Id: I6927ee293e5126abc037a3eb9f86a67825732679 Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
2016-01-28 10:13:46 +00:00
void defaultFont();
QQuickApplicationWindow: add locale property Change-Id: I1292d1fb856710e38add8d77ae6e3dac28137cd9 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-21 11:26:02 +00:00
void locale();
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
void activeFocusControl_data();
void activeFocusControl();
Popup: restore focus to contentItem of ApplicationWindow when closing In Controls2, Popup and normal content are in same window, then we should maintain the focus restore work. Task-number: QTBUG-53275 Change-Id: I57f5aaf3febf1b7d2071c1734d8561932f95c699 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 10:44:15 +00:00
void focusAfterPopupClosed();
Fix a crash with focus handling when destructing QQAppWindow Because QQuickApplicationWindow connected SIGNAL(activeFocusItemChanged()) to SLOT(_q_updateActiveFocus())); it would enter _q_updateActiveFocus() from the dtor of QQuickWindow (because dtor of QQuickWindow would emit activeFocusItemChanged()). At that point the QQuickApplicationWindow object for the member function _q_updateActiveFocus() was already destroyed, so we would crash. Instead, make sure we clear the focus as early as possible, and then disconnect in case activeFocusItemChanged() is emitted after QQuickApplicationWindow is destroyed. Task-number: QTBUG-57846 Change-Id: I4b1999e647b970394436a2d462b7f352f1c8a811 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-01-03 12:46:46 +00:00
void clearFocusOnDestruction();
AppWindow: take header & footer visibility into account in relayout() Task-number: QTBUG-55143 Change-Id: I2acf8ca720df33a0417d850b5b0410ec9166dc89 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-08-08 18:50:13 +00:00
void layout();
Add recursion guard to QQuickApplicationWindowPrivate::relayout() relayout() might change the size of the header, footer or contentitem When one of those items changes, QQuickApplicationWindowPrivate will get notified by that through QQuickApplicationWindowPrivate::itemGeometryChanged(). itemGeometryChanged() will then call relayout()... (*recursed*). Pick-to: 5.15 6.2 Task-number: QTBUG-87708 Change-Id: I9403952e776afb2be37d009642c65b5520c79341 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2021-06-11 14:31:30 +00:00
void layoutLayout();
Fix QQuickApplicationWindow::isComponentComplete() It has to default to true to ensure that a QQuickApplicationWindow instantiated in C++ is not stuck to false forever. When instantiated by the QML engine, it is set to false during the QML component initialization phase from classBegin() to componentComple(). Change-Id: Ieba2bbfb8fc0296b8cb28df91b12bcc55dd31bf4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-04-21 05:45:13 +00:00
void componentComplete();
Register C++ types declaratively Adapt to the new way of registering C++ types. The types need to be seen at compile time so that code can be generated that invokes them. This patch: - Adds QML_* macros where applicable. - Adapts the build system files to the new way of registering modules. - Splits up the QtQuick.Controls[.*].impl files into their own plugins, as we can only register one QML module per .pro file. - Removes C++ type registration calls in every plugin. - Moves private types from src/quickcontrols2/quickcontrols2.pro to src/quickcontrols2/impl/quickcontrols2-impl.pro. Some of these types need to be exposed to QML, but quickcontrols2.pro is already in use to declare the QtQuick.Controls import (and also provides the public C++ QQuickStyle API), and the new QML_IMPORT_NAME/VERSION syntax only allows one module per project. As some of the types that need to be exposed to QML are also referenced by some C++ code (e.g. tests, etc.), we just move all of the private types to the new library. Follow-up patches will register the QML types declaratively. Task-number: QTBUG-82922 Change-Id: Iaf9ee106237d61701d57a8896f3822304c8151a6 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2020-03-27 10:17:35 +00:00
void opacity();
ApplicationWindow: explicitly set background size if not explicitly set 41eb033fa2585b3644a545b75a414d4d3efa8b2c addressed QTBUG-118779 by documenting that certain items like Image would need to have their size explicitly set to the size of the window. This isn't in line with the background-resizing behavior of Control, which explicitly sets the size of the background if it hasn't been set (see 7e3c882d9a5cd6a25f547091a4ece786f516f2a4). This patch partially reverts 41eb033fa2585b3644a545b75a414d4d3efa8b2c by removing the change to the documentation. The relevant code in the wearable example has since been changed, so there's nothing to revert there. [ChangeLog][Controls][Important Behavior Changes] ApplicationWindow now explicitly sets the width and height of its background if no size was explicitly set by the user. This matches the behavior of Control, and ensures that if e.g. an Image is used as a window's background, any changes in its implicit size (e.g. after a source change) won't affect its actual size. Fixes: QTBUG-121466 Pick-to: 6.5 6.6 6.7 Change-Id: I0fbe029626d736b4b96acce1a2ca450660a47271 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-11 05:03:30 +00:00
void backgroundSize();
ApplicationWindow: respect explicitly set background size 4a2466ea075676e8953ac7e9729492a0ace02c32 made ApplicationWindow explicitly set the background's width and height if they hadn't already been explicitly set. However, in certain cases widthValid() and heightValid() were checked before background's deferred execution had completed. This meant that the user's width and height bindings hadn't been evaluated yet, and hence widthValid and heightValid were false. Fix this by waiting until execution has finished before checking. Fixes: QTBUG-124744 Pick-to: 6.5 6.6 6.7 Change-Id: I1007f638a60c1ae4e0b07dbf91d5583bbfdcf8fb Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2024-04-26 02:41:38 +00:00
void explicitBackgroundSizeBinding();
Teach ApplicationWindow about safe area margins If the window has non-safe areas, as reflected by the window's safe area margins, ApplicationWindow will now automatically pad the content item accordingly, ensuring that the content item is within the safe area of the window. To implement this we piggy-back on QQuickControl, letting the control manage the size and position of the content item. This allows us to use the built in padding of QQuickControl to inset the content. Internally the item hierarchy of ApplicationWindow no longer represents the header, footer, and menu bar as children of the ApplicationWindow's content item, but rather as sibling items in the QQuickWindow content item, similar to the window's background item. Doing this is a slight behavior change, but for something that should have been an implementation detail as far as users are concerned. The content control and header, footer and menu bar now all live within the same root QQuickWindow::contentItem, which is a focus scope on its own. End users can override the automatic padding that we do for the contentItem by setting any of the four new padding properties that we expose, mirroring the properties on QQuickControl. [ChangeLog][Important Behavior Changes] The contentItem of ApplicationWindow is now automatically padded to account for safe area margins. To override the automatic padding, set the padding explicitly, via e.g. `topPadding: 0`. Task-number: QTBUG-125373 Change-Id: I986e425a7f316db244c7fc86283b8b333978e3ad Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-11-17 14:35:26 +00:00
void safeArea();
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
void paintOrderChildItems();
Fix tst_qquickapplicationwindow compilation when hover is disabled Task-number: QTBUG-136101 Pick-to: 6.9 6.8 Change-Id: I38ffaa60219cb4432ca7444d8b560a9daa22c935 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2025-04-25 07:25:25 +00:00
#if QT_CONFIG(quicktemplates2_hover)
Fix broken hover in ApplicationWindow's background 8fb643f6d63813a5a8df5e829e4ddeb357e0348d fixed ComboBox not being hoverable by setting QQuickApplicationWindowPrivate::control's hoverEnabled property to true. By doing so, it ensured that only that control and its parent chain could get hover events, breaking hover for e.g. background. The correct fix is to adapt QQuickControlPrivate::calcHoverEnabled to skip the property("hoverEnabled") == true check for QQuickApplicationWindowPrivate::control, resulting in it falling back to the global checks. - Remove code added in 8fb643f6d63813a5a8df5e829e4ddeb357e0348d. - Move QQuickApplicationWindowPrivate declaration into its own header so that code outside the .cpp file (qquickcontrol.cpp, in this case) can use it. - Document behavior of hover flags in void QQuickItem::setAcceptHoverEvents. - Move the check done in tst_QQuickControl::hoverEnabledDefault() into the new tst_QQuickApplicationWindow::hoverInBackground() since they're closely related. - Add initial starting position argument to PointLerper's constructor since it wasn't previously possible to set it. - Remove unused headers in qquickapplicationwindow.cpp. Fixes: QTBUG-133886 Fixes: QTBUG-136031 Pick-to: 6.9 Change-Id: Ic32f902be6433c1c9dc9f4610c5715ce1537e605 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2025-04-17 02:34:11 +00:00
void hoverInBackground();
Fix tst_qquickapplicationwindow compilation when hover is disabled Task-number: QTBUG-136101 Pick-to: 6.9 6.8 Change-Id: I38ffaa60219cb4432ca7444d8b560a9daa22c935 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2025-04-25 07:25:25 +00:00
#endif
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
};
Make tests explicitly use Basic where necessary The previous commit changes the how the default style is set, and since the tests all assumed that Basic was the default, we now need to ensure it is explicitly set. If we want to, we can revert this patch (or file-by-file) later and ensure that these tests work with all styles. For now, just keep things working as they used to. Tests that use QTEST_QUICKCONTROLS_MAIN are not changed, as they already run with all built-in styles. Tests that don't use types that will cause issues, like tst_qquickcolor, do not need to be changed. tst_snippets can be run manually to produce screenshots, so we specify its style in a qtquickcontrols2.conf file to allow it to be overridden by e.g. application arguments (QQuickStyle::setStyle() takes precedence over all other approaches of setting a style). Change-Id: Ifae7e959f89a41a757c170272038fad139bba04f Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-09-30 12:22:42 +00:00
tst_QQuickApplicationWindow::tst_QQuickApplicationWindow()
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
: QQmlDataTest(QT_QMLTEST_DATADIR)
Make tests explicitly use Basic where necessary The previous commit changes the how the default style is set, and since the tests all assumed that Basic was the default, we now need to ensure it is explicitly set. If we want to, we can revert this patch (or file-by-file) later and ensure that these tests work with all styles. For now, just keep things working as they used to. Tests that use QTEST_QUICKCONTROLS_MAIN are not changed, as they already run with all built-in styles. Tests that don't use types that will cause issues, like tst_qquickcolor, do not need to be changed. tst_snippets can be run manually to produce screenshots, so we specify its style in a qtquickcontrols2.conf file to allow it to be overridden by e.g. application arguments (QQuickStyle::setStyle() takes precedence over all other approaches of setting a style). Change-Id: Ifae7e959f89a41a757c170272038fad139bba04f Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-09-30 12:22:42 +00:00
{
Menu, MenuBar: remove requestNative and rely solely on app attributes It was decided that we'll have two attributes: - AA_DontUseNativeMenuBar - AA_DontUseNativeMenuWindows Setting AA_DontUseNativeMenuWindows only affects windows we create (context menus, combobox menus, menus of non-native menu bars). So, setting AA_DontUseNativeMenuWindows restores Qt to today's behavior. But we can't control the windows of native menu bars, so if you don't want those to be native, you have to set AA_DontUseNativeMenuBar just like today. By removing requestNative, we also effectively default to native menus and menu bars, as the attributes are not set by default. [ChangeLog][Controls][Important Behavior Changes] Menu and MenuBar now use native menus by default on platforms where they're supported. Task-number: QTBUG-69558 Change-Id: Ia917c2f820634def0cf815aa8ca8895ca79db75d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-14 03:36:06 +00:00
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuWindows);
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuBar);
Make tests explicitly use Basic where necessary The previous commit changes the how the default style is set, and since the tests all assumed that Basic was the default, we now need to ensure it is explicitly set. If we want to, we can revert this patch (or file-by-file) later and ensure that these tests work with all styles. For now, just keep things working as they used to. Tests that use QTEST_QUICKCONTROLS_MAIN are not changed, as they already run with all built-in styles. Tests that don't use types that will cause issues, like tst_qquickcolor, do not need to be changed. tst_snippets can be run manually to produce screenshots, so we specify its style in a qtquickcontrols2.conf file to allow it to be overridden by e.g. application arguments (QQuickStyle::setStyle() takes precedence over all other approaches of setting a style). Change-Id: Ifae7e959f89a41a757c170272038fad139bba04f Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-09-30 12:22:42 +00:00
QQuickStyle::setStyle("Basic");
}
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::qmlCreation()
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("basicapplicationwindow.qml"));
QObject* created = component.create();
QScopedPointer<QObject> cleanup(created);
QVERIFY(created);
QQuickWindow* window = qobject_cast<QQuickWindow*>(created);
QVERIFY(window);
QVERIFY(!window->isVisible());
QCOMPARE(created->property("title"), QVariant("Test Application Window"));
QQuickItem* statusBar = qvariant_cast<QQuickItem*>(created->property("statusBar"));
QVERIFY(!statusBar);
QQuickItem* header = qvariant_cast<QQuickItem*>(created->property("header"));
QVERIFY(!header);
QQuickItem* footer = qvariant_cast<QQuickItem*>(created->property("footer"));
QVERIFY(!footer);
}
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::activeFocusOnTab1()
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("activefocusontab.qml"));
QObject* created = component.create();
QScopedPointer<QObject> cleanup(created);
QVERIFY(created);
QQuickWindow* window = qobject_cast<QQuickWindow*>(created);
QVERIFY(window);
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
QVERIFY(QGuiApplication::focusWindow() == window);
QQuickItem* contentItem = window->contentItem();
QVERIFY(contentItem);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(contentItem);
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
QQuickItem* item = findItem<QQuickItem>(window->contentItem(), "sub1");
QVERIFY(item);
QVERIFY(!item->hasActiveFocus());
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
// Tab: contentItem->menuBar
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
{
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::NoModifier);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
item = qobject_cast<QQuickApplicationWindow *>(window)->menuBar();
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QVERIFY(item);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(item);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
}
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
// Tab: menuBar->header
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
{
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::NoModifier);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
item = qobject_cast<QQuickApplicationWindow *>(window)->header();
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QVERIFY(item);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(item);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
}
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
// Tab: header->sub1
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
{
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::NoModifier);
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
item = findItem<QQuickItem>(window->contentItem(), "sub1");
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
QVERIFY(item);
QVERIFY_ACTIVE_FOCUS(item);
}
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
// Tab: sub1->sub2
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
{
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::NoModifier);
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
item = findItem<QQuickItem>(window->contentItem(), "sub2");
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
QVERIFY(item);
QVERIFY_ACTIVE_FOCUS(item);
}
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
// Tab: sub2->footer
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
{
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::NoModifier);
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
item = qobject_cast<QQuickApplicationWindow *>(window)->footer();
QVERIFY(item);
QVERIFY_ACTIVE_FOCUS(item);
}
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
// Tab: footer->menuBar
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
{
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::NoModifier);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
item = findItem<QQuickItem>(window->contentItem(), "sub1");
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
item = qobject_cast<QQuickApplicationWindow *>(window)->menuBar();
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QVERIFY(item);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(item);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
}
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
}
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::activeFocusOnTab2()
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("activefocusontab.qml"));
QObject* created = component.create();
QScopedPointer<QObject> cleanup(created);
QVERIFY(created);
QQuickWindow* window = qobject_cast<QQuickWindow*>(created);
QVERIFY(window);
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
QVERIFY(QGuiApplication::focusWindow() == window);
QQuickItem* contentItem = window->contentItem();
QVERIFY(contentItem);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(contentItem);
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
QQuickItem* item = findItem<QQuickItem>(window->contentItem(), "sub2");
QVERIFY(item);
QVERIFY(!item->hasActiveFocus());
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
// BackTab: contentItem->footer
{
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::ShiftModifier);
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
item = qobject_cast<QQuickApplicationWindow *>(window)->footer();
QVERIFY(item);
QVERIFY_ACTIVE_FOCUS(item);
}
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
// BackTab: footer->sub2
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
{
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::ShiftModifier);
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
item = findItem<QQuickItem>(window->contentItem(), "sub2");
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
QVERIFY(item);
QVERIFY_ACTIVE_FOCUS(item);
}
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
// BackTab: sub2->sub1
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
{
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::ShiftModifier);
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
item = findItem<QQuickItem>(window->contentItem(), "sub1");
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
QVERIFY(item);
QVERIFY_ACTIVE_FOCUS(item);
}
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
// BackTab: sub1->header
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
{
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::ShiftModifier);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
item = qobject_cast<QQuickApplicationWindow *>(window)->header();
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QVERIFY(item);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(item);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
}
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
// BackTab: header->menuBar
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
{
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::ShiftModifier);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
item = qobject_cast<QQuickApplicationWindow *>(window)->menuBar();
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QVERIFY(item);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(item);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
}
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
Change order of menuBar/header/footer to match visual order Currently, the tab navigation order is confusing as the footer is focused before the actual content of the ApplicationWindow. By adjusting the stack order, the tab navigation now matches the visual order. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: Ibe6fe9305181fe7ed42d7f8ca2da689b1b6ccf41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:47:29 +00:00
// BackTab: menuBar->footer
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
{
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::ShiftModifier);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QGuiApplication::sendEvent(window, &key);
QVERIFY(key.isAccepted());
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
item = qobject_cast<QQuickApplicationWindow *>(window)->footer();
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
QVERIFY(item);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(item);
Don't copy or assign QKeyEvent instances Change-Id: Id16f972a7f2c0f3c9c9d2fe1d14b9e0830a85a0a Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2020-11-11 13:51:05 +00:00
}
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
}
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::defaultFocus()
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
{
Revert "Make ApplicationWindow's content item the fallback focused item on startup" This reverts commit 71f687111b45a1d391c05fa26ef1cc72c75c9781. The application window's content item having focus on startup prior to 83d90845527799c78366c2b89e9c14bc35e88695 was a side- effect of the item being a focus scope. In that situation any parented item into the content item with focus will keep its focus if no other item in the content item has focus at that point. However in the new setup the application window's content item is not a focus scope (the root QQuickWindow content item is), so giving it focus will prevent parented items from keeping their focus. The workaround in the reverted patch of setting the focus on completion instead of classBegin only worked for the simple case where the focused item is part of the initial object hierarchy. If an item is inserted after the app window is completed this would still fail. Change-Id: I129d8d8a7c048222d1af220bc209b4c7f20b97ca Pick-to: 6.9 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2024-12-10 19:16:14 +00:00
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("defaultFocus.qml"));
QObject* created = component.create();
QScopedPointer<QObject> cleanup(created);
Q_UNUSED(cleanup);
QVERIFY(created);
Make ApplicationWindow's content item the fallback focused item on startup If no other item has requested focus. This matches the behavior from when the app window's content item was the parent of the header, footer and menu bar, and was a focus scope. Pick-to: 6.9 Change-Id: Ibaeda833ca979a1dceb775f8740e1eb87d208bc4 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Doris Verria <doris.verria@qt.io>
2024-12-09 11:29:27 +00:00
Revert "Make ApplicationWindow's content item the fallback focused item on startup" This reverts commit 71f687111b45a1d391c05fa26ef1cc72c75c9781. The application window's content item having focus on startup prior to 83d90845527799c78366c2b89e9c14bc35e88695 was a side- effect of the item being a focus scope. In that situation any parented item into the content item with focus will keep its focus if no other item in the content item has focus at that point. However in the new setup the application window's content item is not a focus scope (the root QQuickWindow content item is), so giving it focus will prevent parented items from keeping their focus. The workaround in the reverted patch of setting the focus on completion instead of classBegin only worked for the simple case where the focused item is part of the initial object hierarchy. If an item is inserted after the app window is completed this would still fail. Change-Id: I129d8d8a7c048222d1af220bc209b4c7f20b97ca Pick-to: 6.9 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2024-12-10 19:16:14 +00:00
QQuickWindow* window = qobject_cast<QQuickWindow*>(created);
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
QVERIFY(window);
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
QVERIFY(QGuiApplication::focusWindow() == window);
QQuickItem* contentItem = window->contentItem();
QVERIFY(contentItem);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(contentItem);
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
Revert "Make ApplicationWindow's content item the fallback focused item on startup" This reverts commit 71f687111b45a1d391c05fa26ef1cc72c75c9781. The application window's content item having focus on startup prior to 83d90845527799c78366c2b89e9c14bc35e88695 was a side- effect of the item being a focus scope. In that situation any parented item into the content item with focus will keep its focus if no other item in the content item has focus at that point. However in the new setup the application window's content item is not a focus scope (the root QQuickWindow content item is), so giving it focus will prevent parented items from keeping their focus. The workaround in the reverted patch of setting the focus on completion instead of classBegin only worked for the simple case where the focused item is part of the initial object hierarchy. If an item is inserted after the app window is completed this would still fail. Change-Id: I129d8d8a7c048222d1af220bc209b4c7f20b97ca Pick-to: 6.9 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2024-12-10 19:16:14 +00:00
// A single item in an ApplicationWindow with focus: true should receive focus.
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
QQuickItem* item = findItem<QQuickItem>(window->contentItem(), "item");
QVERIFY(item);
Revert "Make ApplicationWindow's content item the fallback focused item on startup" This reverts commit 71f687111b45a1d391c05fa26ef1cc72c75c9781. The application window's content item having focus on startup prior to 83d90845527799c78366c2b89e9c14bc35e88695 was a side- effect of the item being a focus scope. In that situation any parented item into the content item with focus will keep its focus if no other item in the content item has focus at that point. However in the new setup the application window's content item is not a focus scope (the root QQuickWindow content item is), so giving it focus will prevent parented items from keeping their focus. The workaround in the reverted patch of setting the focus on completion instead of classBegin only worked for the simple case where the focused item is part of the initial object hierarchy. If an item is inserted after the app window is completed this would still fail. Change-Id: I129d8d8a7c048222d1af220bc209b4c7f20b97ca Pick-to: 6.9 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2024-12-10 19:16:14 +00:00
QVERIFY(item->hasFocus());
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(item);
Enable tst_applicationwindow The issue was fixed by 2f902694656d67d671d9a8616060d598a478e7b7. Change-Id: I5f4cb0ca8d968ce02f7e9e36070e34b3d887e9c0 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-10-12 22:01:17 +00:00
}
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::implicitFill()
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("fill.qml"));
QObject* created = component.create();
QScopedPointer<QObject> cleanup(created);
QVERIFY(created);
tst_QQuickApplicationWindow: Base expected element size on content item Now that Android takes safe area margins into account on startup, as of qtbase e96a4b84e136d065054600c07bf5fae17f3049ce, we can't assume the size of elements placed into the content item is the same size as the screen's available size. What these tests seem to test is that the root elements of a window fill the available space in the window correctly, which we can check by comparing the size to that of the content item, which is automatically inset based on the window's safe area margins. Pick-to: 6.9 Fixes: QTBUG-137285 Change-Id: I6f40ba824426f0acec73e50cdc9984c05a44bf91 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2025-05-30 08:56:16 +00:00
QQuickApplicationWindow* window = qobject_cast<QQuickApplicationWindow*>(created);
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
QVERIFY(window);
QVERIFY(!window->isVisible());
QCOMPARE(window->width(), 400);
QCOMPARE(window->height(), 400);
window->show();
Request window activate after show in tst_qquickapplicationwindow The qquickapplicationwindow tests are failing when run locally because the window is not activated after it is shown. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I6c429016a0271b03581d3077f052ad46afbe5b09 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-08-20 10:59:35 +00:00
window->requestActivate();
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
QVERIFY(QTest::qWaitForWindowActive(window));
tst_QQuickApplicationWindow: Base expected element size on content item Now that Android takes safe area margins into account on startup, as of qtbase e96a4b84e136d065054600c07bf5fae17f3049ce, we can't assume the size of elements placed into the content item is the same size as the screen's available size. What these tests seem to test is that the root elements of a window fill the available space in the window correctly, which we can check by comparing the size to that of the content item, which is automatically inset based on the window's safe area margins. Pick-to: 6.9 Fixes: QTBUG-137285 Change-Id: I6f40ba824426f0acec73e50cdc9984c05a44bf91 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2025-05-30 08:56:16 +00:00
const QSizeF expectedSize = window->contentItem()->size();
Android: enable tst_QQuickApplicationWindow Fix the tests that were failing because of window size mismatch. Skip one test that is crashing on Android emulator due to some GLES issues. The skipped test can pass if the emulator is configured to use host OpenGL, but this is not a good option for our CI, where we run the Android emulator on a VM. Fixes: QTBUG-100176 Task-number: QTBUG-100991 Pick-to: 6.3 6.2 Change-Id: I2b77a364eb5758c9d825e3ae02277389355b7588 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-14 16:00:56 +00:00
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
QQuickItem *stackView = window->property("stackView").value<QQuickItem*>();
QVERIFY(stackView);
Android: enable tst_QQuickApplicationWindow Fix the tests that were failing because of window size mismatch. Skip one test that is crashing on Android emulator due to some GLES issues. The skipped test can pass if the emulator is configured to use host OpenGL, but this is not a good option for our CI, where we run the Android emulator on a VM. Fixes: QTBUG-100176 Task-number: QTBUG-100991 Pick-to: 6.3 6.2 Change-Id: I2b77a364eb5758c9d825e3ae02277389355b7588 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-14 16:00:56 +00:00
QCOMPARE(stackView->width(), expectedSize.width());
QCOMPARE(stackView->height(), expectedSize.height());
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
QQuickItem *nextItem = window->property("nextItem").value<QQuickItem*>();
QVERIFY(nextItem);
QVERIFY(QMetaObject::invokeMethod(window, "pushNextItem"));
Android: enable tst_QQuickApplicationWindow Fix the tests that were failing because of window size mismatch. Skip one test that is crashing on Android emulator due to some GLES issues. The skipped test can pass if the emulator is configured to use host OpenGL, but this is not a good option for our CI, where we run the Android emulator on a VM. Fixes: QTBUG-100176 Task-number: QTBUG-100991 Pick-to: 6.3 6.2 Change-Id: I2b77a364eb5758c9d825e3ae02277389355b7588 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-14 16:00:56 +00:00
QCOMPARE(nextItem->width(), expectedSize.width());
QCOMPARE(nextItem->height(), expectedSize.height());
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
}
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::attachedProperties()
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
{
Skip tst_QQuickApplicationWindow::attachedProperties on EGLFS The tst_QQuickApplicationWindow::attachedProperties test uses multiple windows. When on EGLFS, creating multiple windows ends up in a QFATAL error message stating EGLFS: OpenGL windows cannot be mixed with others. Fix the problem by skipping the test when on EGLFS. Task-number: QTBUG-115777 Pick-to: 6.7 Change-Id: I5cf189715af7e64a27980fab238a9dcee20700f1 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2024-04-22 14:04:28 +00:00
if (QGuiApplication::platformName().startsWith(QLatin1String("eglfs"), Qt::CaseInsensitive))
{
QSKIP("This test uses multiple windows and it crashes on EGLFS because of that");
}
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("attachedProperties.qml"));
QScopedPointer<QObject> object(component.create());
QVERIFY2(!object.isNull(), qPrintable(component.errorString()));
QQuickApplicationWindow *window = qobject_cast<QQuickApplicationWindow *>(object.data());
QVERIFY(window);
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QQuickItem *childControl = object->property("childControl").value<QQuickItem *>();
QVERIFY(childControl);
QCOMPARE(childControl->property("attached_window").value<QQuickApplicationWindow *>(), window);
QCOMPARE(childControl->property("attached_contentItem").value<QQuickItem *>(), window->contentItem());
QCOMPARE(childControl->property("attached_activeFocusControl").value<QQuickItem *>(), window->activeFocusControl());
QCOMPARE(childControl->property("attached_header").value<QQuickItem *>(), window->header());
QCOMPARE(childControl->property("attached_footer").value<QQuickItem *>(), window->footer());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QQuickItem *childItem = object->property("childItem").value<QQuickItem *>();
QVERIFY(childItem);
QCOMPARE(childItem->property("attached_window").value<QQuickApplicationWindow *>(), window);
QCOMPARE(childItem->property("attached_contentItem").value<QQuickItem *>(), window->contentItem());
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QCOMPARE(childItem->property("attached_activeFocusControl").value<QQuickItem *>(), window->activeFocusControl());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QCOMPARE(childItem->property("attached_header").value<QQuickItem *>(), window->header());
QCOMPARE(childItem->property("attached_footer").value<QQuickItem *>(), window->footer());
QObject *childObject = object->property("childObject").value<QObject *>();
QVERIFY(childObject);
QVERIFY(!childObject->property("attached_window").value<QQuickApplicationWindow *>());
QVERIFY(!childObject->property("attached_contentItem").value<QQuickItem *>());
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QVERIFY(!childObject->property("attached_activeFocusControl").value<QQuickItem *>());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QVERIFY(!childObject->property("attached_header").value<QQuickItem *>());
QVERIFY(!childObject->property("attached_footer").value<QQuickItem *>());
QQuickWindow *childWindow = object->property("childWindow").value<QQuickWindow *>();
QVERIFY(childWindow);
QVERIFY(!childWindow->property("attached_window").value<QQuickApplicationWindow *>());
QVERIFY(!childWindow->property("attached_contentItem").value<QQuickItem *>());
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QVERIFY(!childWindow->property("attached_activeFocusControl").value<QQuickItem *>());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QVERIFY(!childWindow->property("attached_header").value<QQuickItem *>());
QVERIFY(!childWindow->property("attached_footer").value<QQuickItem *>());
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QQuickItem *childWindowControl = object->property("childWindowControl").value<QQuickItem *>();
QVERIFY(childWindowControl);
QVERIFY(!childWindowControl->property("attached_window").value<QQuickApplicationWindow *>());
QVERIFY(!childWindowControl->property("attached_contentItem").value<QQuickItem *>());
QVERIFY(!childWindowControl->property("attached_activeFocusControl").value<QQuickItem *>());
QVERIFY(!childWindowControl->property("attached_header").value<QQuickItem *>());
QVERIFY(!childWindowControl->property("attached_footer").value<QQuickItem *>());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QQuickItem *childWindowItem = object->property("childWindowItem").value<QQuickItem *>();
QVERIFY(childWindowItem);
QVERIFY(!childWindowItem->property("attached_window").value<QQuickApplicationWindow *>());
QVERIFY(!childWindowItem->property("attached_contentItem").value<QQuickItem *>());
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QVERIFY(!childWindowItem->property("attached_activeFocusControl").value<QQuickItem *>());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QVERIFY(!childWindowItem->property("attached_header").value<QQuickItem *>());
QVERIFY(!childWindowItem->property("attached_footer").value<QQuickItem *>());
QObject *childWindowObject = object->property("childWindowObject").value<QObject *>();
QVERIFY(childWindowObject);
QVERIFY(!childWindowObject->property("attached_window").value<QQuickApplicationWindow *>());
QVERIFY(!childWindowObject->property("attached_contentItem").value<QQuickItem *>());
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QVERIFY(!childWindowObject->property("attached_activeFocusControl").value<QQuickItem *>());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QVERIFY(!childWindowObject->property("attached_header").value<QQuickItem *>());
QVERIFY(!childWindowObject->property("attached_footer").value<QQuickItem *>());
QQuickApplicationWindow *childAppWindow = object->property("childAppWindow").value<QQuickApplicationWindow *>();
QVERIFY(childAppWindow);
QVERIFY(!childAppWindow->property("attached_window").value<QQuickApplicationWindow *>());
QVERIFY(!childAppWindow->property("attached_contentItem").value<QQuickItem *>());
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QVERIFY(!childAppWindow->property("attached_activeFocusControl").value<QQuickItem *>());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QVERIFY(!childAppWindow->property("attached_header").value<QQuickItem *>());
QVERIFY(!childAppWindow->property("attached_footer").value<QQuickItem *>());
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QQuickItem *childAppWindowControl = object->property("childAppWindowControl").value<QQuickItem *>();
QVERIFY(childAppWindowControl);
QCOMPARE(childAppWindowControl->property("attached_window").value<QQuickApplicationWindow *>(), childAppWindow);
QCOMPARE(childAppWindowControl->property("attached_contentItem").value<QQuickItem *>(), childAppWindow->contentItem());
QCOMPARE(childAppWindowControl->property("attached_activeFocusControl").value<QQuickItem *>(), childAppWindow->activeFocusControl());
QCOMPARE(childAppWindowControl->property("attached_header").value<QQuickItem *>(), childAppWindow->header());
QCOMPARE(childAppWindowControl->property("attached_footer").value<QQuickItem *>(), childAppWindow->footer());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QQuickItem *childAppWindowItem = object->property("childAppWindowItem").value<QQuickItem *>();
QVERIFY(childAppWindowItem);
QCOMPARE(childAppWindowItem->property("attached_window").value<QQuickApplicationWindow *>(), childAppWindow);
QCOMPARE(childAppWindowItem->property("attached_contentItem").value<QQuickItem *>(), childAppWindow->contentItem());
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QCOMPARE(childAppWindowItem->property("attached_activeFocusControl").value<QQuickItem *>(), childAppWindow->activeFocusControl());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QCOMPARE(childAppWindowItem->property("attached_header").value<QQuickItem *>(), childAppWindow->header());
QCOMPARE(childAppWindowItem->property("attached_footer").value<QQuickItem *>(), childAppWindow->footer());
QObject *childAppWindowObject = object->property("childAppWindowObject").value<QObject *>();
QVERIFY(childAppWindowObject);
QVERIFY(!childAppWindowObject->property("attached_window").value<QQuickApplicationWindow *>());
QVERIFY(!childAppWindowObject->property("attached_contentItem").value<QQuickItem *>());
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QVERIFY(!childAppWindowObject->property("attached_activeFocusControl").value<QQuickItem *>());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QVERIFY(!childAppWindowObject->property("attached_header").value<QQuickItem *>());
QVERIFY(!childAppWindowObject->property("attached_footer").value<QQuickItem *>());
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QVERIFY(!childControl->hasActiveFocus());
childControl->forceActiveFocus();
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QTRY_VERIFY_ACTIVE_FOCUS(childControl);
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QCOMPARE(window->activeFocusItem(), childControl);
QCOMPARE(childControl->property("attached_activeFocusControl").value<QQuickItem *>(), childControl);
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QQuickItem *header = new QQuickItem;
window->setHeader(header);
QCOMPARE(window->header(), header);
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QCOMPARE(childControl->property("attached_header").value<QQuickItem *>(), header);
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QQuickItem *footer = new QQuickItem;
window->setFooter(footer);
QCOMPARE(window->footer(), footer);
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QCOMPARE(childControl->property("attached_footer").value<QQuickItem *>(), footer);
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
childAppWindow->show();
childAppWindow->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(childAppWindow));
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QVERIFY(!childAppWindowControl->hasActiveFocus());
childAppWindowControl->forceActiveFocus();
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QTRY_VERIFY_ACTIVE_FOCUS(childAppWindowControl);
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QCOMPARE(childAppWindow->activeFocusItem(), childAppWindowControl);
QCOMPARE(childAppWindowControl->property("attached_activeFocusControl").value<QQuickItem *>(), childAppWindowControl);
childControl->setParentItem(childAppWindow->contentItem());
QCOMPARE(childControl->window(), childAppWindow);
QCOMPARE(childControl->property("attached_window").value<QQuickApplicationWindow *>(), childAppWindow);
QCOMPARE(childControl->property("attached_contentItem").value<QQuickItem *>(), childAppWindow->contentItem());
Make ApplicationWindow::activeFocusControl work with plain Window [ChangeLog][Controls][ApplicationWindow] The attached activeFocusControl property has been made functional with a plain QML Window to make the functionality available when using QQuickWindow/View/Widget instead of ApplicationWindow. Task-number: QTBUG-61336 Change-Id: I46b91bca436d58c349c4f9ba8816245ab4ca33a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-24 08:18:43 +00:00
QCOMPARE(childControl->property("attached_activeFocusControl").value<QQuickItem *>(), childAppWindowControl);
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QCOMPARE(childControl->property("attached_header").value<QQuickItem *>(), childAppWindow->header());
QCOMPARE(childControl->property("attached_footer").value<QQuickItem *>(), childAppWindow->footer());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
childItem->setParentItem(childAppWindow->contentItem());
QCOMPARE(childItem->window(), childAppWindow);
QCOMPARE(childItem->property("attached_window").value<QQuickApplicationWindow *>(), childAppWindow);
QCOMPARE(childItem->property("attached_contentItem").value<QQuickItem *>(), childAppWindow->contentItem());
Make ApplicationWindow::activeFocusControl work with plain Window [ChangeLog][Controls][ApplicationWindow] The attached activeFocusControl property has been made functional with a plain QML Window to make the functionality available when using QQuickWindow/View/Widget instead of ApplicationWindow. Task-number: QTBUG-61336 Change-Id: I46b91bca436d58c349c4f9ba8816245ab4ca33a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-24 08:18:43 +00:00
QCOMPARE(childItem->property("attached_activeFocusControl").value<QQuickItem *>(), childAppWindowControl);
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QCOMPARE(childItem->property("attached_header").value<QQuickItem *>(), childAppWindow->header());
QCOMPARE(childItem->property("attached_footer").value<QQuickItem *>(), childAppWindow->footer());
C++11 keywords - Q_NULLPTR -> nullptr - Q_DECL_OVERRIDE -> override Change-Id: I8ee65caafd43ab41b6de43835200cac6c8ffa278 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2016-01-20 16:31:18 +00:00
childControl->setParentItem(nullptr);
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QVERIFY(!childControl->window());
QVERIFY(!childControl->property("attached_window").value<QQuickApplicationWindow *>());
QVERIFY(!childControl->property("attached_contentItem").value<QQuickItem *>());
QVERIFY(!childControl->property("attached_activeFocusControl").value<QQuickItem *>());
QVERIFY(!childControl->property("attached_header").value<QQuickItem *>());
QVERIFY(!childControl->property("attached_footer").value<QQuickItem *>());
C++11 keywords - Q_NULLPTR -> nullptr - Q_DECL_OVERRIDE -> override Change-Id: I8ee65caafd43ab41b6de43835200cac6c8ffa278 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2016-01-20 16:31:18 +00:00
childItem->setParentItem(nullptr);
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QVERIFY(!childItem->window());
QVERIFY(!childItem->property("attached_window").value<QQuickApplicationWindow *>());
QVERIFY(!childItem->property("attached_contentItem").value<QQuickItem *>());
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QVERIFY(!childItem->property("attached_activeFocusControl").value<QQuickItem *>());
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
QVERIFY(!childItem->property("attached_header").value<QQuickItem *>());
QVERIFY(!childItem->property("attached_footer").value<QQuickItem *>());
Attempt to stabilize tst_applicationwindow::attachedProperties() Change-Id: I49539d41d78c2670bcbed1829800a5974f91675b Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 09:28:42 +00:00
childAppWindow->close();
qApp->processEvents();
Make ApplicationWindow::activeFocusControl work with plain Window [ChangeLog][Controls][ApplicationWindow] The attached activeFocusControl property has been made functional with a plain QML Window to make the functionality available when using QQuickWindow/View/Widget instead of ApplicationWindow. Task-number: QTBUG-61336 Change-Id: I46b91bca436d58c349c4f9ba8816245ab4ca33a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-24 08:18:43 +00:00
childWindow->show();
childWindow->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(childWindow));
QVERIFY(!childWindowControl->hasActiveFocus());
childWindowControl->forceActiveFocus();
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QTRY_VERIFY_ACTIVE_FOCUS(childWindowControl);
Make ApplicationWindow::activeFocusControl work with plain Window [ChangeLog][Controls][ApplicationWindow] The attached activeFocusControl property has been made functional with a plain QML Window to make the functionality available when using QQuickWindow/View/Widget instead of ApplicationWindow. Task-number: QTBUG-61336 Change-Id: I46b91bca436d58c349c4f9ba8816245ab4ca33a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-24 08:18:43 +00:00
QCOMPARE(childWindow->activeFocusItem(), childWindowControl);
QCOMPARE(childWindowControl->property("attached_activeFocusControl").value<QQuickItem *>(), childWindowControl);
childControl->setParentItem(childWindow->contentItem());
QCOMPARE(childControl->window(), childWindow);
QVERIFY(!childControl->property("attached_window").value<QQuickWindow *>());
QCOMPARE(childControl->property("attached_activeFocusControl").value<QQuickItem *>(), childWindowControl);
QVERIFY(!childControl->property("attached_contentItem").value<QQuickItem *>());
QVERIFY(!childControl->property("attached_header").value<QQuickItem *>());
QVERIFY(!childControl->property("attached_footer").value<QQuickItem *>());
childItem->setParentItem(childWindow->contentItem());
QCOMPARE(childItem->window(), childWindow);
QVERIFY(!childControl->property("attached_window").value<QQuickWindow *>());
QCOMPARE(childControl->property("attached_activeFocusControl").value<QQuickItem *>(), childWindowControl);
QVERIFY(!childControl->property("attached_contentItem").value<QQuickItem *>());
QVERIFY(!childControl->property("attached_header").value<QQuickItem *>());
QVERIFY(!childControl->property("attached_footer").value<QQuickItem *>());
childControl->setParentItem(nullptr);
QVERIFY(!childControl->window());
QVERIFY(!childControl->property("attached_window").value<QQuickWindow *>());
QVERIFY(!childControl->property("attached_contentItem").value<QQuickItem *>());
QVERIFY(!childControl->property("attached_activeFocusControl").value<QQuickItem *>());
QVERIFY(!childControl->property("attached_header").value<QQuickItem *>());
QVERIFY(!childControl->property("attached_footer").value<QQuickItem *>());
childItem->setParentItem(nullptr);
QVERIFY(!childItem->window());
QVERIFY(!childItem->property("attached_window").value<QQuickWindow *>());
QVERIFY(!childItem->property("attached_contentItem").value<QQuickItem *>());
QVERIFY(!childItem->property("attached_activeFocusControl").value<QQuickItem *>());
QVERIFY(!childItem->property("attached_header").value<QQuickItem *>());
QVERIFY(!childItem->property("attached_footer").value<QQuickItem *>());
Attempt to stabilize tst_applicationwindow::attachedProperties() Change-Id: I49539d41d78c2670bcbed1829800a5974f91675b Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 09:28:42 +00:00
childWindow->close();
ApplicationWindow: introduce attached properties The attached properties provide convenient direct access to an application window and its building blocks. Change-Id: I2d96842d80faec47c875156202c1e33a2af96ad3 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-14 10:47:59 +00:00
}
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::font()
QQuickApplicationWindow: add font property Change-Id: I6f946994f789704aa2efa94aaea0129d0d73d005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-03 12:23:27 +00:00
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("font.qml"));
QObject* created = component.create();
QScopedPointer<QObject> cleanup(created);
QVERIFY(created);
QQuickApplicationWindow* window = qobject_cast<QQuickApplicationWindow*>(created);
QVERIFY(window);
QVERIFY(!window->isVisible());
QCOMPARE(window->width(), 400);
QCOMPARE(window->height(), 400);
window->show();
Request window activate after show in tst_qquickapplicationwindow The qquickapplicationwindow tests are failing when run locally because the window is not activated after it is shown. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I6c429016a0271b03581d3077f052ad46afbe5b09 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-08-20 10:59:35 +00:00
window->requestActivate();
QQuickApplicationWindow: add font property Change-Id: I6f946994f789704aa2efa94aaea0129d0d73d005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-03 12:23:27 +00:00
QVERIFY(QTest::qWaitForWindowActive(window));
QFont font = window->font();
tst_QQuickApplicationWindow: Base expected element size on content item Now that Android takes safe area margins into account on startup, as of qtbase e96a4b84e136d065054600c07bf5fae17f3049ce, we can't assume the size of elements placed into the content item is the same size as the screen's available size. What these tests seem to test is that the root elements of a window fill the available space in the window correctly, which we can check by comparing the size to that of the content item, which is automatically inset based on the window's safe area margins. Pick-to: 6.9 Fixes: QTBUG-137285 Change-Id: I6f40ba824426f0acec73e50cdc9984c05a44bf91 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2025-05-30 08:56:16 +00:00
const QSizeF expectedSize = window->contentItem()->size();
Android: enable tst_QQuickApplicationWindow Fix the tests that were failing because of window size mismatch. Skip one test that is crashing on Android emulator due to some GLES issues. The skipped test can pass if the emulator is configured to use host OpenGL, but this is not a good option for our CI, where we run the Android emulator on a VM. Fixes: QTBUG-100176 Task-number: QTBUG-100991 Pick-to: 6.3 6.2 Change-Id: I2b77a364eb5758c9d825e3ae02277389355b7588 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-14 16:00:56 +00:00
QQuickApplicationWindow: add font property Change-Id: I6f946994f789704aa2efa94aaea0129d0d73d005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-03 12:23:27 +00:00
QQuickControl *mainItem = window->property("mainItem").value<QQuickControl*>();
QVERIFY(mainItem);
Android: enable tst_QQuickApplicationWindow Fix the tests that were failing because of window size mismatch. Skip one test that is crashing on Android emulator due to some GLES issues. The skipped test can pass if the emulator is configured to use host OpenGL, but this is not a good option for our CI, where we run the Android emulator on a VM. Fixes: QTBUG-100176 Task-number: QTBUG-100991 Pick-to: 6.3 6.2 Change-Id: I2b77a364eb5758c9d825e3ae02277389355b7588 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-14 16:00:56 +00:00
QCOMPARE(mainItem->width(), expectedSize.width());
QCOMPARE(mainItem->height(), expectedSize.height());
QQuickApplicationWindow: add font property Change-Id: I6f946994f789704aa2efa94aaea0129d0d73d005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-03 12:23:27 +00:00
QCOMPARE(mainItem->font(), font);
QQuickControl *item2 = mainItem->property("item_2").value<QQuickControl*>();
QVERIFY(item2);
QQuickControl *item3 = mainItem->property("item_3").value<QQuickControl*>();
QVERIFY(item3);
QQuickTextArea *item4 = mainItem->property("item_4").value<QQuickTextArea*>();
QVERIFY(item4);
QQuickTextField *item5 = mainItem->property("item_5").value<QQuickTextField*>();
QVERIFY(item5);
QQuickLabel *item6 = mainItem->property("item_6").value<QQuickLabel*>();
QVERIFY(item6);
QCOMPARE(item2->font(), font);
QCOMPARE(item3->font(), font);
QCOMPARE(item4->font(), font);
QCOMPARE(item5->font(), font);
QCOMPARE(item6->font(), font);
int pointSize = font.pointSize();
font.setPixelSize(pointSize + 5);
window->setFont(font);
QCOMPARE(window->font(), font);
QCOMPARE(mainItem->font(), font);
QCOMPARE(item2->font(), font);
QCOMPARE(item3->font(), font);
QCOMPARE(item4->font(), font);
QCOMPARE(item5->font(), font);
QCOMPARE(item6->font(), font);
}
QQuickApplicationWindow: add locale property Change-Id: I1292d1fb856710e38add8d77ae6e3dac28137cd9 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-21 11:26:02 +00:00
QQuickTheme: don't inherit QPlatformTheme Use QPlatformTheme as a fallback instead of inheriting from it. This way, Qt Quick Controls 2 themes don't mess up the fonts and palettes of Qt Quick Controls 1 and Qt Widgets applications. Note: QQuickTheme::Font and QQuickTheme::Palette enums are copies of the respective enums in QPlatformTheme, for now. This is the simplest first step, but later on, we can have our own set of enums that cover controls, such as Switch, that were previously entirely missing from QPlatformTheme. Task-number: QTBUG-51921 Change-Id: I8efe0ba2d03d65bc12b55b533ba9f2fab5320348 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2018-02-22 22:29:44 +00:00
class TestTheme : public QQuickTheme
QQuickApplicationWindow: resolve the default system theme font Change-Id: I6927ee293e5126abc037a3eb9f86a67825732679 Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
2016-01-28 10:13:46 +00:00
{
public:
Create and init QQuickTheme from QtQuickControls2Plugin Instead of creating and setting the QQuickTheme instance from each style plugin (e.g. QtQuickControls2MaterialStylePlugin), create the QQuickTheme instance in QtQuickControls2Plugin when the style is being resolved, and just pass the instance to be initialized by the style plugin(s). This avoids the problem that QQuickTheme API was virtual, and sub-classes created from plugins would have vtables destroyed before the QQuickTheme was destroyed. Task-number: QTBUG-67062 Task-number: QTBUG-68087 Change-Id: I19e9ced5296b708c2668c30163389cb3da6be7cf Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2018-05-13 17:34:29 +00:00
TestTheme()
QQuickApplicationWindow: resolve the default system theme font Change-Id: I6927ee293e5126abc037a3eb9f86a67825732679 Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
2016-01-28 10:13:46 +00:00
{
QQuickTheme: add setters to make getters non-virtual This allows us to add more themable attributes (on the side of fonts and palettes) after the QQuickTheme API has been made public, because it won't require adding virtuals. Only the resolve() method is virtual. Task-number: QTBUG-67062 Change-Id: I6a5cc8d15aeaa5a9a0fe9b6d2591077f8822daac Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2018-05-16 11:50:35 +00:00
setFont(System, QFont("Courier"));
QQuickApplicationWindow: resolve the default system theme font Change-Id: I6927ee293e5126abc037a3eb9f86a67825732679 Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
2016-01-28 10:13:46 +00:00
}
};
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::defaultFont()
QQuickApplicationWindow: resolve the default system theme font Change-Id: I6927ee293e5126abc037a3eb9f86a67825732679 Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
2016-01-28 10:13:46 +00:00
{
Rename QQuickTheme::current to instance Avoid giving a wrong impression that the theme instance could be changed on the fly. Change-Id: Ifb5078422385d2f15da6a416d89cc9d6f46b0f40 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2018-05-15 21:29:46 +00:00
QQuickThemePrivate::instance.reset(new TestTheme);
QQuickApplicationWindow: resolve the default system theme font Change-Id: I6927ee293e5126abc037a3eb9f86a67825732679 Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
2016-01-28 10:13:46 +00:00
QQmlEngine engine;
QQmlComponent component(&engine);
auto tests: remove all versioning from the test data The problem is that QtQuick.Controls.macos is only available with revision 6.0. And when importing e.g QtQuick.Controls 2.15, we try to load a style with the same revision. But it simply doesn't exist. So remove all versioning from the tests to also support testing newer styles. Change-Id: I666a93ab03ec4c5dcf2055a363547f8cdac8d25e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-09-04 08:38:35 +00:00
component.setData("import QtQuick.Controls; ApplicationWindow { }", QUrl());
QQuickApplicationWindow: resolve the default system theme font Change-Id: I6927ee293e5126abc037a3eb9f86a67825732679 Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
2016-01-28 10:13:46 +00:00
QScopedPointer<QQuickApplicationWindow> window;
window.reset(static_cast<QQuickApplicationWindow *>(component.create()));
QVERIFY(!window.isNull());
QQuickTheme: rename themeFont() and themePalette() We don't have the conflicting virtual getters anymore. Change-Id: Ia20bfa0a0b1aa67c35a23270eb0241018f8e0ada Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2018-05-16 11:57:00 +00:00
QCOMPARE(window->font(), QQuickTheme::font(QQuickTheme::System));
QQuickApplicationWindow: resolve the default system theme font Change-Id: I6927ee293e5126abc037a3eb9f86a67825732679 Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
2016-01-28 10:13:46 +00:00
}
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::locale()
QQuickApplicationWindow: add locale property Change-Id: I1292d1fb856710e38add8d77ae6e3dac28137cd9 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-21 11:26:02 +00:00
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("locale.qml"));
QObject* created = component.create();
QScopedPointer<QObject> cleanup(created);
QVERIFY(created);
QQuickApplicationWindow* window = qobject_cast<QQuickApplicationWindow*>(created);
QVERIFY(window);
QVERIFY(!window->isVisible());
QCOMPARE(window->width(), 400);
QCOMPARE(window->height(), 400);
window->show();
Request window activate after show in tst_qquickapplicationwindow The qquickapplicationwindow tests are failing when run locally because the window is not activated after it is shown. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I6c429016a0271b03581d3077f052ad46afbe5b09 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-08-20 10:59:35 +00:00
window->requestActivate();
QQuickApplicationWindow: add locale property Change-Id: I1292d1fb856710e38add8d77ae6e3dac28137cd9 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-21 11:26:02 +00:00
QVERIFY(QTest::qWaitForWindowActive(window));
QLocale l = window->locale();
tst_QQuickApplicationWindow: Base expected element size on content item Now that Android takes safe area margins into account on startup, as of qtbase e96a4b84e136d065054600c07bf5fae17f3049ce, we can't assume the size of elements placed into the content item is the same size as the screen's available size. What these tests seem to test is that the root elements of a window fill the available space in the window correctly, which we can check by comparing the size to that of the content item, which is automatically inset based on the window's safe area margins. Pick-to: 6.9 Fixes: QTBUG-137285 Change-Id: I6f40ba824426f0acec73e50cdc9984c05a44bf91 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2025-05-30 08:56:16 +00:00
const QSizeF expectedSize = window->contentItem()->size();
Android: enable tst_QQuickApplicationWindow Fix the tests that were failing because of window size mismatch. Skip one test that is crashing on Android emulator due to some GLES issues. The skipped test can pass if the emulator is configured to use host OpenGL, but this is not a good option for our CI, where we run the Android emulator on a VM. Fixes: QTBUG-100176 Task-number: QTBUG-100991 Pick-to: 6.3 6.2 Change-Id: I2b77a364eb5758c9d825e3ae02277389355b7588 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-14 16:00:56 +00:00
QQuickApplicationWindow: add locale property Change-Id: I1292d1fb856710e38add8d77ae6e3dac28137cd9 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-21 11:26:02 +00:00
QQuickControl *mainItem = window->property("mainItem").value<QQuickControl*>();
QVERIFY(mainItem);
Android: enable tst_QQuickApplicationWindow Fix the tests that were failing because of window size mismatch. Skip one test that is crashing on Android emulator due to some GLES issues. The skipped test can pass if the emulator is configured to use host OpenGL, but this is not a good option for our CI, where we run the Android emulator on a VM. Fixes: QTBUG-100176 Task-number: QTBUG-100991 Pick-to: 6.3 6.2 Change-Id: I2b77a364eb5758c9d825e3ae02277389355b7588 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-14 16:00:56 +00:00
QCOMPARE(mainItem->width(), expectedSize.width());
QCOMPARE(mainItem->height(), expectedSize.height());
QQuickApplicationWindow: add locale property Change-Id: I1292d1fb856710e38add8d77ae6e3dac28137cd9 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-21 11:26:02 +00:00
QCOMPARE(mainItem->locale(), l);
QQuickControl *item2 = mainItem->property("item_2").value<QQuickControl*>();
QVERIFY(item2);
QQuickControl *item3 = mainItem->property("item_3").value<QQuickControl*>();
QVERIFY(item3);
QCOMPARE(item2->locale(), l);
QCOMPARE(item3->locale(), l);
l = QLocale("en_US");
window->setLocale(l);
QCOMPARE(window->locale(), l);
QCOMPARE(mainItem->locale(), l);
QCOMPARE(item2->locale(), l);
QCOMPARE(item3->locale(), l);
l = QLocale("ar_EG");
window->setLocale(l);
QCOMPARE(window->locale(), l);
QCOMPARE(mainItem->locale(), l);
QCOMPARE(item2->locale(), l);
QCOMPARE(item3->locale(), l);
}
QQuickApplicationWindow: add font property Change-Id: I6f946994f789704aa2efa94aaea0129d0d73d005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-03 12:23:27 +00:00
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::activeFocusControl_data()
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
{
QTest::addColumn<QByteArray>("containerName");
QTest::addColumn<QByteArray>("activeFocusItemName");
QTest::addColumn<QByteArray>("activeFocusControlName");
QTest::newRow("Column:TextInput") << QByteArray("container_column") << QByteArray("textInput_column") << QByteArray();
QTest::newRow("Column:TextEdit") << QByteArray("container_column") << QByteArray("textEdit_column") << QByteArray();
QTest::newRow("Column:TextField") << QByteArray("container_column") << QByteArray("textField_column") << QByteArray("textField_column");
QTest::newRow("Column:TextArea") << QByteArray("container_column") << QByteArray("textArea_column") << QByteArray("textArea_column");
QTest::newRow("Column:SpinBox") << QByteArray("container_column") << QByteArray("spinContent_column") << QByteArray("spinBox_column");
QTest::newRow("Frame:TextInput") << QByteArray("container_frame") << QByteArray("textInput_frame") << QByteArray("container_frame");
QTest::newRow("Frame:TextEdit") << QByteArray("container_frame") << QByteArray("textEdit_frame") << QByteArray("container_frame");
QTest::newRow("Frame:TextField") << QByteArray("container_frame") << QByteArray("textField_frame") << QByteArray("textField_frame");
QTest::newRow("Frame:TextArea") << QByteArray("container_frame") << QByteArray("textArea_frame") << QByteArray("textArea_frame");
QTest::newRow("Frame:SpinBox") << QByteArray("container_frame") << QByteArray("spinContent_frame") << QByteArray("spinBox_frame");
}
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::activeFocusControl()
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
{
QFETCH(QByteArray, containerName);
QFETCH(QByteArray, activeFocusItemName);
QFETCH(QByteArray, activeFocusControlName);
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("activeFocusControl.qml"));
QScopedPointer<QObject> object(component.create());
QVERIFY(!object.isNull());
QQuickApplicationWindow* window = qobject_cast<QQuickApplicationWindow*>(object.data());
QVERIFY(window);
QVERIFY(!window->isVisible());
QCOMPARE(window->width(), 400);
QCOMPARE(window->height(), 400);
window->show();
Request window activate after show in tst_qquickapplicationwindow The qquickapplicationwindow tests are failing when run locally because the window is not activated after it is shown. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I6c429016a0271b03581d3077f052ad46afbe5b09 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-08-20 10:59:35 +00:00
window->requestActivate();
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QVERIFY(QTest::qWaitForWindowActive(window));
QQuickItem *container = window->property(containerName).value<QQuickItem*>();
QVERIFY(container);
QQuickItem *activeFocusItem = window->property(activeFocusItemName).value<QQuickItem*>();
QVERIFY(activeFocusItem);
activeFocusItem->forceActiveFocus();
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(activeFocusItem);
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
QCOMPARE(window->activeFocusItem(), activeFocusItem);
QQuickItem *activeFocusControl = window->property(activeFocusControlName).value<QQuickItem*>();
if (activeFocusControlName.isEmpty()) {
QVERIFY(!activeFocusControl);
} else {
QVERIFY(activeFocusControl);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(activeFocusControl);
Add ApplicationWindow::activeFocusControl This makes it possible for ApplicationWindow to visualize key focus navigation with a single focus rectangle that follows the currently active focus control. Change-Id: Ief92bcdc64891b7baa3503216137665a8badcd17 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-29 20:56:36 +00:00
}
QCOMPARE(window->activeFocusControl(), activeFocusControl);
}
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::focusAfterPopupClosed()
Popup: restore focus to contentItem of ApplicationWindow when closing In Controls2, Popup and normal content are in same window, then we should maintain the focus restore work. Task-number: QTBUG-53275 Change-Id: I57f5aaf3febf1b7d2071c1734d8561932f95c699 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 10:44:15 +00:00
{
Android: enable tst_QQuickApplicationWindow Fix the tests that were failing because of window size mismatch. Skip one test that is crashing on Android emulator due to some GLES issues. The skipped test can pass if the emulator is configured to use host OpenGL, but this is not a good option for our CI, where we run the Android emulator on a VM. Fixes: QTBUG-100176 Task-number: QTBUG-100991 Pick-to: 6.3 6.2 Change-Id: I2b77a364eb5758c9d825e3ae02277389355b7588 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-14 16:00:56 +00:00
#ifdef Q_OS_ANDROID
QSKIP("This test crashes in Android emulator because of GLES issues (QTBUG-100991)");
#endif
Popup: restore focus to contentItem of ApplicationWindow when closing In Controls2, Popup and normal content are in same window, then we should maintain the focus restore work. Task-number: QTBUG-53275 Change-Id: I57f5aaf3febf1b7d2071c1734d8561932f95c699 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 10:44:15 +00:00
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("focusAfterPopupClosed.qml"));
QScopedPointer<QQuickWindow> window(qobject_cast<QQuickWindow*>(component.create()));
QVERIFY(window);
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window.data()));
QVERIFY(QGuiApplication::focusWindow() == window.data());
QQuickItem* contentItem = window->contentItem();
QVERIFY(contentItem);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(contentItem);
Popup: restore focus to contentItem of ApplicationWindow when closing In Controls2, Popup and normal content are in same window, then we should maintain the focus restore work. Task-number: QTBUG-53275 Change-Id: I57f5aaf3febf1b7d2071c1734d8561932f95c699 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 10:44:15 +00:00
QQuickItem* focusScope = window->property("focusScope").value<QQuickItem*>();
QVERIFY(focusScope);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(focusScope);
Popup: restore focus to contentItem of ApplicationWindow when closing In Controls2, Popup and normal content are in same window, then we should maintain the focus restore work. Task-number: QTBUG-53275 Change-Id: I57f5aaf3febf1b7d2071c1734d8561932f95c699 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 10:44:15 +00:00
Fix focus handling for popups When a popup is closed, if there are multiple popups open, restore focus to the next popup in chain instead of transferring focus to the window content. This allows us to cleanup the custom focus handling for sub-menus in dev. There is no more need to manually transfer focus to the parent menu or to a sub-menu, but calling open() or close() is enough and the focus is automatically transferred as expected. Change-Id: I54406c7c6b8dd25af261e00ebb1ae00ccbea8b9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 14:48:07 +00:00
QSignalSpy focusScopeSpy(window.data(), SIGNAL(focusScopeKeyPressed()));
Popup: restore focus to contentItem of ApplicationWindow when closing In Controls2, Popup and normal content are in same window, then we should maintain the focus restore work. Task-number: QTBUG-53275 Change-Id: I57f5aaf3febf1b7d2071c1734d8561932f95c699 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 10:44:15 +00:00
QTest::keyClick(window.data(), Qt::Key_Space);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(focusScopeSpy.size(), 1);
Popup: restore focus to contentItem of ApplicationWindow when closing In Controls2, Popup and normal content are in same window, then we should maintain the focus restore work. Task-number: QTBUG-53275 Change-Id: I57f5aaf3febf1b7d2071c1734d8561932f95c699 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 10:44:15 +00:00
// Open the menu.
QQuickItem* toolButton = window->property("toolButton").value<QQuickItem*>();
QVERIFY(toolButton);
QTest::mouseClick(window.data(), Qt::LeftButton, Qt::NoModifier,
toolButton->mapFromScene(QPointF(toolButton->width() / 2, toolButton->height() / 2)).toPoint());
QVERIFY(!focusScope->hasActiveFocus());
// The FocusScope shouldn't receive any key events while the menu is open.
QTest::keyClick(window.data(), Qt::Key_Space);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(focusScopeSpy.size(), 1);
Popup: restore focus to contentItem of ApplicationWindow when closing In Controls2, Popup and normal content are in same window, then we should maintain the focus restore work. Task-number: QTBUG-53275 Change-Id: I57f5aaf3febf1b7d2071c1734d8561932f95c699 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 10:44:15 +00:00
// Close the menu. The FocusScope should regain focus.
QTest::keyClick(window.data(), Qt::Key_Escape);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(focusScope);
Popup: restore focus to contentItem of ApplicationWindow when closing In Controls2, Popup and normal content are in same window, then we should maintain the focus restore work. Task-number: QTBUG-53275 Change-Id: I57f5aaf3febf1b7d2071c1734d8561932f95c699 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 10:44:15 +00:00
QTest::keyClick(window.data(), Qt::Key_Space);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(focusScopeSpy.size(), 2);
Fix focus handling for popups When a popup is closed, if there are multiple popups open, restore focus to the next popup in chain instead of transferring focus to the window content. This allows us to cleanup the custom focus handling for sub-menus in dev. There is no more need to manually transfer focus to the parent menu or to a sub-menu, but calling open() or close() is enough and the focus is automatically transferred as expected. Change-Id: I54406c7c6b8dd25af261e00ebb1ae00ccbea8b9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 14:48:07 +00:00
QQuickPopup *focusPopup = window->property("focusPopup").value<QQuickPopup*>();
QVERIFY(focusPopup);
QVERIFY(!focusPopup->hasActiveFocus());
focusPopup->open();
QVERIFY(focusPopup->isVisible());
QSignalSpy focusPopupSpy(window.data(), SIGNAL(focusPopupKeyPressed()));
QTest::keyClick(window.data(), Qt::Key_Space);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(focusPopupSpy.size(), 1);
Fix focus handling for popups When a popup is closed, if there are multiple popups open, restore focus to the next popup in chain instead of transferring focus to the window content. This allows us to cleanup the custom focus handling for sub-menus in dev. There is no more need to manually transfer focus to the parent menu or to a sub-menu, but calling open() or close() is enough and the focus is automatically transferred as expected. Change-Id: I54406c7c6b8dd25af261e00ebb1ae00ccbea8b9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 14:48:07 +00:00
QQuickMenu *fileMenu = window->property("fileMenu").value<QQuickMenu*>();
QVERIFY(fileMenu);
fileMenu->open();
QVERIFY(fileMenu->isVisible());
// The Popup shouldn't receive any key events while the menu is open.
QTest::keyClick(window.data(), Qt::Key_Space);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(focusPopupSpy.size(), 1);
Fix focus handling for popups When a popup is closed, if there are multiple popups open, restore focus to the next popup in chain instead of transferring focus to the window content. This allows us to cleanup the custom focus handling for sub-menus in dev. There is no more need to manually transfer focus to the parent menu or to a sub-menu, but calling open() or close() is enough and the focus is automatically transferred as expected. Change-Id: I54406c7c6b8dd25af261e00ebb1ae00ccbea8b9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 14:48:07 +00:00
// Close the menu. The Popup should regain focus.
QTest::keyClick(window.data(), Qt::Key_Escape);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(focusPopup);
Fix focus handling for popups When a popup is closed, if there are multiple popups open, restore focus to the next popup in chain instead of transferring focus to the window content. This allows us to cleanup the custom focus handling for sub-menus in dev. There is no more need to manually transfer focus to the parent menu or to a sub-menu, but calling open() or close() is enough and the focus is automatically transferred as expected. Change-Id: I54406c7c6b8dd25af261e00ebb1ae00ccbea8b9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 14:48:07 +00:00
QTest::keyClick(window.data(), Qt::Key_Space);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(focusPopupSpy.size(), 2);
Fix focus handling for popups When a popup is closed, if there are multiple popups open, restore focus to the next popup in chain instead of transferring focus to the window content. This allows us to cleanup the custom focus handling for sub-menus in dev. There is no more need to manually transfer focus to the parent menu or to a sub-menu, but calling open() or close() is enough and the focus is automatically transferred as expected. Change-Id: I54406c7c6b8dd25af261e00ebb1ae00ccbea8b9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 14:48:07 +00:00
// Close the popup. The FocusScope should regain focus.
QTest::keyClick(window.data(), Qt::Key_Escape);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(focusScope);
Fix focus handling for popups When a popup is closed, if there are multiple popups open, restore focus to the next popup in chain instead of transferring focus to the window content. This allows us to cleanup the custom focus handling for sub-menus in dev. There is no more need to manually transfer focus to the parent menu or to a sub-menu, but calling open() or close() is enough and the focus is automatically transferred as expected. Change-Id: I54406c7c6b8dd25af261e00ebb1ae00ccbea8b9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 14:48:07 +00:00
QTest::keyClick(window.data(), Qt::Key_Space);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(focusScopeSpy.size(), 3);
Popup: restore focus to contentItem of ApplicationWindow when closing In Controls2, Popup and normal content are in same window, then we should maintain the focus restore work. Task-number: QTBUG-53275 Change-Id: I57f5aaf3febf1b7d2071c1734d8561932f95c699 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 10:44:15 +00:00
}
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::clearFocusOnDestruction()
Fix a crash with focus handling when destructing QQAppWindow Because QQuickApplicationWindow connected SIGNAL(activeFocusItemChanged()) to SLOT(_q_updateActiveFocus())); it would enter _q_updateActiveFocus() from the dtor of QQuickWindow (because dtor of QQuickWindow would emit activeFocusItemChanged()). At that point the QQuickApplicationWindow object for the member function _q_updateActiveFocus() was already destroyed, so we would crash. Instead, make sure we clear the focus as early as possible, and then disconnect in case activeFocusItemChanged() is emitted after QQuickApplicationWindow is destroyed. Task-number: QTBUG-57846 Change-Id: I4b1999e647b970394436a2d462b7f352f1c8a811 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-01-03 12:46:46 +00:00
{
auto tests: remove all versioning from the test data The problem is that QtQuick.Controls.macos is only available with revision 6.0. And when importing e.g QtQuick.Controls 2.15, we try to load a style with the same revision. But it simply doesn't exist. So remove all versioning from the tests to also support testing newer styles. Change-Id: I666a93ab03ec4c5dcf2055a363547f8cdac8d25e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-09-04 08:38:35 +00:00
if (!canImportModule("import QtGraphicalEffects; DropShadow {}"))
Reduce dependencies on QtGraphicalEffects - Make QtGraphicalEffects optional in tests - Mention that QtGraphicalEffects is required for relevant examples Change-Id: I3ac7d06add931e0a10c3df7edc4e458ba5519c75 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2020-05-12 11:46:06 +00:00
QSKIP("Test requires QtGraphicalEffects");
Fix a crash with focus handling when destructing QQAppWindow Because QQuickApplicationWindow connected SIGNAL(activeFocusItemChanged()) to SLOT(_q_updateActiveFocus())); it would enter _q_updateActiveFocus() from the dtor of QQuickWindow (because dtor of QQuickWindow would emit activeFocusItemChanged()). At that point the QQuickApplicationWindow object for the member function _q_updateActiveFocus() was already destroyed, so we would crash. Instead, make sure we clear the focus as early as possible, and then disconnect in case activeFocusItemChanged() is emitted after QQuickApplicationWindow is destroyed. Task-number: QTBUG-57846 Change-Id: I4b1999e647b970394436a2d462b7f352f1c8a811 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-01-03 12:46:46 +00:00
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("clearfocusondestruction.qml"));
QScopedPointer<QQuickWindow> window(qobject_cast<QQuickWindow*>(component.create()));
QVERIFY(window);
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window.data()));
QVERIFY(QGuiApplication::focusWindow() == window.data());
QQuickItem* contentItem = window->contentItem();
QVERIFY(contentItem);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(contentItem);
Fix a crash with focus handling when destructing QQAppWindow Because QQuickApplicationWindow connected SIGNAL(activeFocusItemChanged()) to SLOT(_q_updateActiveFocus())); it would enter _q_updateActiveFocus() from the dtor of QQuickWindow (because dtor of QQuickWindow would emit activeFocusItemChanged()). At that point the QQuickApplicationWindow object for the member function _q_updateActiveFocus() was already destroyed, so we would crash. Instead, make sure we clear the focus as early as possible, and then disconnect in case activeFocusItemChanged() is emitted after QQuickApplicationWindow is destroyed. Task-number: QTBUG-57846 Change-Id: I4b1999e647b970394436a2d462b7f352f1c8a811 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-01-03 12:46:46 +00:00
QQuickItem* focusScope = window->property("textfield").value<QQuickItem*>();
QVERIFY(focusScope);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(focusScope);
Fix a crash with focus handling when destructing QQAppWindow Because QQuickApplicationWindow connected SIGNAL(activeFocusItemChanged()) to SLOT(_q_updateActiveFocus())); it would enter _q_updateActiveFocus() from the dtor of QQuickWindow (because dtor of QQuickWindow would emit activeFocusItemChanged()). At that point the QQuickApplicationWindow object for the member function _q_updateActiveFocus() was already destroyed, so we would crash. Instead, make sure we clear the focus as early as possible, and then disconnect in case activeFocusItemChanged() is emitted after QQuickApplicationWindow is destroyed. Task-number: QTBUG-57846 Change-Id: I4b1999e647b970394436a2d462b7f352f1c8a811 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-01-03 12:46:46 +00:00
QSignalSpy spy(window.data(), SIGNAL(activeFocusControlChanged()));
// destroy the window, do not crash
window.reset();
/*
QQuickWindow::activeFocusItemChanged() is emitted inconsistently and
only for certain use cases. Ideally it should be emitted whenever a
QQuickWindow with a focus item is destroyed, but it doesn't... It might
also be favorable to not emit it for performance reason.
However, activeFocusControlChanged() is emitted more consistently, which
of course makes it inconsistent with the emission of
activeFocusItemChanged()....
Therefore, if you have good reasons to change the behavior (and not emit
it) take the test below with a grain of salt.
*/
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(spy.size(), 1);
Fix a crash with focus handling when destructing QQAppWindow Because QQuickApplicationWindow connected SIGNAL(activeFocusItemChanged()) to SLOT(_q_updateActiveFocus())); it would enter _q_updateActiveFocus() from the dtor of QQuickWindow (because dtor of QQuickWindow would emit activeFocusItemChanged()). At that point the QQuickApplicationWindow object for the member function _q_updateActiveFocus() was already destroyed, so we would crash. Instead, make sure we clear the focus as early as possible, and then disconnect in case activeFocusItemChanged() is emitted after QQuickApplicationWindow is destroyed. Task-number: QTBUG-57846 Change-Id: I4b1999e647b970394436a2d462b7f352f1c8a811 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-01-03 12:46:46 +00:00
}
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::layout()
AppWindow: take header & footer visibility into account in relayout() Task-number: QTBUG-55143 Change-Id: I2acf8ca720df33a0417d850b5b0410ec9166dc89 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-08-08 18:50:13 +00:00
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("layout.qml"));
QScopedPointer<QObject> object(component.create());
QVERIFY(!object.isNull());
QQuickApplicationWindow* window = qobject_cast<QQuickApplicationWindow*>(object.data());
QVERIFY(window);
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickItem *content = window->contentItem();
QVERIFY(content);
Add ApplicationWindow::menuBar A follow-up commit to 66faa149. Change-Id: I94c92752d54ae0ca4878da72915b3d83461a4124 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-08-30 09:28:17 +00:00
QQuickItem *menuBar = window->menuBar();
QVERIFY(menuBar);
AppWindow: take header & footer visibility into account in relayout() Task-number: QTBUG-55143 Change-Id: I2acf8ca720df33a0417d850b5b0410ec9166dc89 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-08-08 18:50:13 +00:00
QQuickItem *header = window->header();
QVERIFY(header);
QQuickItem *footer = window->footer();
QVERIFY(footer);
Add ApplicationWindow::menuBar A follow-up commit to 66faa149. Change-Id: I94c92752d54ae0ca4878da72915b3d83461a4124 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-08-30 09:28:17 +00:00
QCOMPARE(menuBar->x(), 0.0);
Teach ApplicationWindow about safe area margins If the window has non-safe areas, as reflected by the window's safe area margins, ApplicationWindow will now automatically pad the content item accordingly, ensuring that the content item is within the safe area of the window. To implement this we piggy-back on QQuickControl, letting the control manage the size and position of the content item. This allows us to use the built in padding of QQuickControl to inset the content. Internally the item hierarchy of ApplicationWindow no longer represents the header, footer, and menu bar as children of the ApplicationWindow's content item, but rather as sibling items in the QQuickWindow content item, similar to the window's background item. Doing this is a slight behavior change, but for something that should have been an implementation detail as far as users are concerned. The content control and header, footer and menu bar now all live within the same root QQuickWindow::contentItem, which is a focus scope on its own. End users can override the automatic padding that we do for the contentItem by setting any of the four new padding properties that we expose, mirroring the properties on QQuickControl. [ChangeLog][Important Behavior Changes] The contentItem of ApplicationWindow is now automatically padded to account for safe area margins. To override the automatic padding, set the padding explicitly, via e.g. `topPadding: 0`. Task-number: QTBUG-125373 Change-Id: I986e425a7f316db244c7fc86283b8b333978e3ad Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-11-17 14:35:26 +00:00
QCOMPARE(menuBar->y(), 0.0);
QCOMPARE(menuBar->width(), qreal(window->width()));
Add ApplicationWindow::menuBar A follow-up commit to 66faa149. Change-Id: I94c92752d54ae0ca4878da72915b3d83461a4124 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-08-30 09:28:17 +00:00
QVERIFY(menuBar->height() > 0);
AppWindow: take header & footer visibility into account in relayout() Task-number: QTBUG-55143 Change-Id: I2acf8ca720df33a0417d850b5b0410ec9166dc89 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-08-08 18:50:13 +00:00
QCOMPARE(header->x(), 0.0);
Teach ApplicationWindow about safe area margins If the window has non-safe areas, as reflected by the window's safe area margins, ApplicationWindow will now automatically pad the content item accordingly, ensuring that the content item is within the safe area of the window. To implement this we piggy-back on QQuickControl, letting the control manage the size and position of the content item. This allows us to use the built in padding of QQuickControl to inset the content. Internally the item hierarchy of ApplicationWindow no longer represents the header, footer, and menu bar as children of the ApplicationWindow's content item, but rather as sibling items in the QQuickWindow content item, similar to the window's background item. Doing this is a slight behavior change, but for something that should have been an implementation detail as far as users are concerned. The content control and header, footer and menu bar now all live within the same root QQuickWindow::contentItem, which is a focus scope on its own. End users can override the automatic padding that we do for the contentItem by setting any of the four new padding properties that we expose, mirroring the properties on QQuickControl. [ChangeLog][Important Behavior Changes] The contentItem of ApplicationWindow is now automatically padded to account for safe area margins. To override the automatic padding, set the padding explicitly, via e.g. `topPadding: 0`. Task-number: QTBUG-125373 Change-Id: I986e425a7f316db244c7fc86283b8b333978e3ad Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-11-17 14:35:26 +00:00
QCOMPARE(header->y(), menuBar->height());
AppWindow: take header & footer visibility into account in relayout() Task-number: QTBUG-55143 Change-Id: I2acf8ca720df33a0417d850b5b0410ec9166dc89 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-08-08 18:50:13 +00:00
QCOMPARE(header->width(), qreal(window->width()));
QVERIFY(header->height() > 0);
QCOMPARE(footer->x(), 0.0);
Teach ApplicationWindow about safe area margins If the window has non-safe areas, as reflected by the window's safe area margins, ApplicationWindow will now automatically pad the content item accordingly, ensuring that the content item is within the safe area of the window. To implement this we piggy-back on QQuickControl, letting the control manage the size and position of the content item. This allows us to use the built in padding of QQuickControl to inset the content. Internally the item hierarchy of ApplicationWindow no longer represents the header, footer, and menu bar as children of the ApplicationWindow's content item, but rather as sibling items in the QQuickWindow content item, similar to the window's background item. Doing this is a slight behavior change, but for something that should have been an implementation detail as far as users are concerned. The content control and header, footer and menu bar now all live within the same root QQuickWindow::contentItem, which is a focus scope on its own. End users can override the automatic padding that we do for the contentItem by setting any of the four new padding properties that we expose, mirroring the properties on QQuickControl. [ChangeLog][Important Behavior Changes] The contentItem of ApplicationWindow is now automatically padded to account for safe area margins. To override the automatic padding, set the padding explicitly, via e.g. `topPadding: 0`. Task-number: QTBUG-125373 Change-Id: I986e425a7f316db244c7fc86283b8b333978e3ad Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-11-17 14:35:26 +00:00
QCOMPARE(footer->y(), window->height() - footer->height());
AppWindow: take header & footer visibility into account in relayout() Task-number: QTBUG-55143 Change-Id: I2acf8ca720df33a0417d850b5b0410ec9166dc89 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-08-08 18:50:13 +00:00
QCOMPARE(footer->width(), qreal(window->width()));
QVERIFY(footer->height() > 0.0);
Add ApplicationWindow::menuBar A follow-up commit to 66faa149. Change-Id: I94c92752d54ae0ca4878da72915b3d83461a4124 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-08-30 09:28:17 +00:00
QCOMPARE(content->x(), 0.0);
QCOMPARE(content->y(), menuBar->height() + header->height());
QCOMPARE(content->width(), qreal(window->width()));
QCOMPARE(content->height(), window->height() - menuBar->height() - header->height() - footer->height());
menuBar->setVisible(false);
AppWindow: take header & footer visibility into account in relayout() Task-number: QTBUG-55143 Change-Id: I2acf8ca720df33a0417d850b5b0410ec9166dc89 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-08-08 18:50:13 +00:00
QCOMPARE(content->x(), 0.0);
QCOMPARE(content->y(), header->height());
QCOMPARE(content->width(), qreal(window->width()));
QCOMPARE(content->height(), window->height() - header->height() - footer->height());
header->setVisible(false);
QCOMPARE(content->x(), 0.0);
QCOMPARE(content->y(), 0.0);
QCOMPARE(content->width(), qreal(window->width()));
QCOMPARE(content->height(), window->height() - footer->height());
footer->setVisible(false);
QCOMPARE(content->x(), 0.0);
QCOMPARE(content->y(), 0.0);
QCOMPARE(content->width(), qreal(window->width()));
QCOMPARE(content->height(), qreal(window->height()));
}
Add recursion guard to QQuickApplicationWindowPrivate::relayout() relayout() might change the size of the header, footer or contentitem When one of those items changes, QQuickApplicationWindowPrivate will get notified by that through QQuickApplicationWindowPrivate::itemGeometryChanged(). itemGeometryChanged() will then call relayout()... (*recursed*). Pick-to: 5.15 6.2 Task-number: QTBUG-87708 Change-Id: I9403952e776afb2be37d009642c65b5520c79341 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2021-06-11 14:31:30 +00:00
void tst_QQuickApplicationWindow::layoutLayout()
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("layoutLayout.qml"));
QScopedPointer<QObject> object(component.create());
QVERIFY2(!object.isNull(), qPrintable(component.errorString()));
QQuickApplicationWindow* window = qobject_cast<QQuickApplicationWindow*>(object.data());
QVERIFY(window);
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickItem *content = window->contentItem();
QVERIFY(content);
QQuickItem *header = window->header();
QVERIFY(header);
QQuickItem *footer = window->footer();
QVERIFY(footer);
QQuickItem *headerChild = header->findChild<QQuickItem*>();
QVERIFY(headerChild);
QCOMPARE(header->x(), 0.0);
Teach ApplicationWindow about safe area margins If the window has non-safe areas, as reflected by the window's safe area margins, ApplicationWindow will now automatically pad the content item accordingly, ensuring that the content item is within the safe area of the window. To implement this we piggy-back on QQuickControl, letting the control manage the size and position of the content item. This allows us to use the built in padding of QQuickControl to inset the content. Internally the item hierarchy of ApplicationWindow no longer represents the header, footer, and menu bar as children of the ApplicationWindow's content item, but rather as sibling items in the QQuickWindow content item, similar to the window's background item. Doing this is a slight behavior change, but for something that should have been an implementation detail as far as users are concerned. The content control and header, footer and menu bar now all live within the same root QQuickWindow::contentItem, which is a focus scope on its own. End users can override the automatic padding that we do for the contentItem by setting any of the four new padding properties that we expose, mirroring the properties on QQuickControl. [ChangeLog][Important Behavior Changes] The contentItem of ApplicationWindow is now automatically padded to account for safe area margins. To override the automatic padding, set the padding explicitly, via e.g. `topPadding: 0`. Task-number: QTBUG-125373 Change-Id: I986e425a7f316db244c7fc86283b8b333978e3ad Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-11-17 14:35:26 +00:00
QCOMPARE(header->y(), 0.0);
Add recursion guard to QQuickApplicationWindowPrivate::relayout() relayout() might change the size of the header, footer or contentitem When one of those items changes, QQuickApplicationWindowPrivate will get notified by that through QQuickApplicationWindowPrivate::itemGeometryChanged(). itemGeometryChanged() will then call relayout()... (*recursed*). Pick-to: 5.15 6.2 Task-number: QTBUG-87708 Change-Id: I9403952e776afb2be37d009642c65b5520c79341 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2021-06-11 14:31:30 +00:00
QCOMPARE(header->width(), qreal(window->width()));
QCOMPARE(headerChild->width(), qreal(window->width()));
QVERIFY(header->height() > 0);
tst_QQuickApplicationWindow::layoutLayout(): Check correct child element Pick-to: 6.9 6.8 6.5 Task-number: QTBUG-87708 Change-Id: I2ec6fd196b160e6e99b7601ba730348dc7958664 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2025-05-26 06:27:22 +00:00
QQuickItem *footerChild = footer->findChild<QQuickItem*>();
Add recursion guard to QQuickApplicationWindowPrivate::relayout() relayout() might change the size of the header, footer or contentitem When one of those items changes, QQuickApplicationWindowPrivate will get notified by that through QQuickApplicationWindowPrivate::itemGeometryChanged(). itemGeometryChanged() will then call relayout()... (*recursed*). Pick-to: 5.15 6.2 Task-number: QTBUG-87708 Change-Id: I9403952e776afb2be37d009642c65b5520c79341 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2021-06-11 14:31:30 +00:00
QVERIFY(footerChild);
QCOMPARE(footer->x(), 0.0);
Teach ApplicationWindow about safe area margins If the window has non-safe areas, as reflected by the window's safe area margins, ApplicationWindow will now automatically pad the content item accordingly, ensuring that the content item is within the safe area of the window. To implement this we piggy-back on QQuickControl, letting the control manage the size and position of the content item. This allows us to use the built in padding of QQuickControl to inset the content. Internally the item hierarchy of ApplicationWindow no longer represents the header, footer, and menu bar as children of the ApplicationWindow's content item, but rather as sibling items in the QQuickWindow content item, similar to the window's background item. Doing this is a slight behavior change, but for something that should have been an implementation detail as far as users are concerned. The content control and header, footer and menu bar now all live within the same root QQuickWindow::contentItem, which is a focus scope on its own. End users can override the automatic padding that we do for the contentItem by setting any of the four new padding properties that we expose, mirroring the properties on QQuickControl. [ChangeLog][Important Behavior Changes] The contentItem of ApplicationWindow is now automatically padded to account for safe area margins. To override the automatic padding, set the padding explicitly, via e.g. `topPadding: 0`. Task-number: QTBUG-125373 Change-Id: I986e425a7f316db244c7fc86283b8b333978e3ad Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-11-17 14:35:26 +00:00
QCOMPARE(footer->y(), window->height() - footer->height());
Add recursion guard to QQuickApplicationWindowPrivate::relayout() relayout() might change the size of the header, footer or contentitem When one of those items changes, QQuickApplicationWindowPrivate will get notified by that through QQuickApplicationWindowPrivate::itemGeometryChanged(). itemGeometryChanged() will then call relayout()... (*recursed*). Pick-to: 5.15 6.2 Task-number: QTBUG-87708 Change-Id: I9403952e776afb2be37d009642c65b5520c79341 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2021-06-11 14:31:30 +00:00
QCOMPARE(footer->width(), qreal(window->width()));
QCOMPARE(footerChild->width(), qreal(window->width()));
QVERIFY(footer->height() > 0.0);
}
Fix QQuickApplicationWindow::isComponentComplete() It has to default to true to ensure that a QQuickApplicationWindow instantiated in C++ is not stuck to false forever. When instantiated by the QML engine, it is set to false during the QML component initialization phase from classBegin() to componentComple(). Change-Id: Ieba2bbfb8fc0296b8cb28df91b12bcc55dd31bf4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-04-21 05:45:13 +00:00
class FriendlyApplicationWindow : public QQuickApplicationWindow
{
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
friend class tst_QQuickApplicationWindow;
Fix QQuickApplicationWindow::isComponentComplete() It has to default to true to ensure that a QQuickApplicationWindow instantiated in C++ is not stuck to false forever. When instantiated by the QML engine, it is set to false during the QML component initialization phase from classBegin() to componentComple(). Change-Id: Ieba2bbfb8fc0296b8cb28df91b12bcc55dd31bf4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-04-21 05:45:13 +00:00
};
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
void tst_QQuickApplicationWindow::componentComplete()
Fix QQuickApplicationWindow::isComponentComplete() It has to default to true to ensure that a QQuickApplicationWindow instantiated in C++ is not stuck to false forever. When instantiated by the QML engine, it is set to false during the QML component initialization phase from classBegin() to componentComple(). Change-Id: Ieba2bbfb8fc0296b8cb28df91b12bcc55dd31bf4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-04-21 05:45:13 +00:00
{
FriendlyApplicationWindow cppWindow;
QVERIFY(cppWindow.isComponentComplete());
QQmlEngine engine;
QQmlComponent component(&engine);
auto tests: remove all versioning from the test data The problem is that QtQuick.Controls.macos is only available with revision 6.0. And when importing e.g QtQuick.Controls 2.15, we try to load a style with the same revision. But it simply doesn't exist. So remove all versioning from the tests to also support testing newer styles. Change-Id: I666a93ab03ec4c5dcf2055a363547f8cdac8d25e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-09-04 08:38:35 +00:00
component.setData("import QtQuick.Controls; ApplicationWindow { }", QUrl());
Fix QQuickApplicationWindow::isComponentComplete() It has to default to true to ensure that a QQuickApplicationWindow instantiated in C++ is not stuck to false forever. When instantiated by the QML engine, it is set to false during the QML component initialization phase from classBegin() to componentComple(). Change-Id: Ieba2bbfb8fc0296b8cb28df91b12bcc55dd31bf4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-04-21 05:45:13 +00:00
FriendlyApplicationWindow *qmlWindow = static_cast<FriendlyApplicationWindow *>(component.beginCreate(engine.rootContext()));
QVERIFY(qmlWindow);
QVERIFY(!qmlWindow->isComponentComplete());
component.completeCreate();
QVERIFY(qmlWindow->isComponentComplete());
}
Register C++ types declaratively Adapt to the new way of registering C++ types. The types need to be seen at compile time so that code can be generated that invokes them. This patch: - Adds QML_* macros where applicable. - Adapts the build system files to the new way of registering modules. - Splits up the QtQuick.Controls[.*].impl files into their own plugins, as we can only register one QML module per .pro file. - Removes C++ type registration calls in every plugin. - Moves private types from src/quickcontrols2/quickcontrols2.pro to src/quickcontrols2/impl/quickcontrols2-impl.pro. Some of these types need to be exposed to QML, but quickcontrols2.pro is already in use to declare the QtQuick.Controls import (and also provides the public C++ QQuickStyle API), and the new QML_IMPORT_NAME/VERSION syntax only allows one module per project. As some of the types that need to be exposed to QML are also referenced by some C++ code (e.g. tests, etc.), we just move all of the private types to the new library. Follow-up patches will register the QML types declaratively. Task-number: QTBUG-82922 Change-Id: Iaf9ee106237d61701d57a8896f3822304c8151a6 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2020-03-27 10:17:35 +00:00
void tst_QQuickApplicationWindow::opacity()
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("opacity.qml"));
QScopedPointer<QObject> object(component.create());
QVERIFY2(!object.isNull(), qPrintable(component.errorString()));
QQuickApplicationWindow *window = qobject_cast<QQuickApplicationWindow *>(object.data());
QVERIFY(window);
}
ApplicationWindow: explicitly set background size if not explicitly set 41eb033fa2585b3644a545b75a414d4d3efa8b2c addressed QTBUG-118779 by documenting that certain items like Image would need to have their size explicitly set to the size of the window. This isn't in line with the background-resizing behavior of Control, which explicitly sets the size of the background if it hasn't been set (see 7e3c882d9a5cd6a25f547091a4ece786f516f2a4). This patch partially reverts 41eb033fa2585b3644a545b75a414d4d3efa8b2c by removing the change to the documentation. The relevant code in the wearable example has since been changed, so there's nothing to revert there. [ChangeLog][Controls][Important Behavior Changes] ApplicationWindow now explicitly sets the width and height of its background if no size was explicitly set by the user. This matches the behavior of Control, and ensures that if e.g. an Image is used as a window's background, any changes in its implicit size (e.g. after a source change) won't affect its actual size. Fixes: QTBUG-121466 Pick-to: 6.5 6.6 6.7 Change-Id: I0fbe029626d736b4b96acce1a2ca450660a47271 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-11 05:03:30 +00:00
void tst_QQuickApplicationWindow::backgroundSize()
{
QQuickControlsApplicationHelper helper(this, QLatin1String("backgroundSize.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
QCOMPARE(window->width(), 600);
QCOMPARE(window->height(), 400);
auto *background = window->background();
QCOMPARE(background->implicitWidth(), 123);
QCOMPARE(background->implicitHeight(), 456);
QCOMPARE(background->width(), window->width());
QCOMPARE(background->height(), window->height());
// Changing the implicit size of the background shouldn't have any effect
// on its size if it was never explicitly set.
background->setImplicitWidth(234);
QCOMPARE(background->implicitWidth(), 234);
QCOMPARE(window->width(), 600);
QCOMPARE(background->width(), window->width());
background->setImplicitHeight(567);
QCOMPARE(background->implicitHeight(), 567);
QCOMPARE(window->height(), 400);
QCOMPARE(background->height(), window->height());
// Explicitly setting the size of the background should ensure
// that it's respected from that point onwards.
background->setWidth(345);
QCOMPARE(background->implicitWidth(), 234);
QCOMPARE(window->width(), 600);
QCOMPARE(background->width(), 345);
window->setWidth(610);
QCOMPARE(background->width(), 345);
background->setHeight(678);
QCOMPARE(background->implicitHeight(), 567);
QCOMPARE(window->height(), 400);
QCOMPARE(background->height(), 678);
window->setHeight(410);
QCOMPARE(background->height(), 678);
}
ApplicationWindow: respect explicitly set background size 4a2466ea075676e8953ac7e9729492a0ace02c32 made ApplicationWindow explicitly set the background's width and height if they hadn't already been explicitly set. However, in certain cases widthValid() and heightValid() were checked before background's deferred execution had completed. This meant that the user's width and height bindings hadn't been evaluated yet, and hence widthValid and heightValid were false. Fix this by waiting until execution has finished before checking. Fixes: QTBUG-124744 Pick-to: 6.5 6.6 6.7 Change-Id: I1007f638a60c1ae4e0b07dbf91d5583bbfdcf8fb Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2024-04-26 02:41:38 +00:00
void tst_QQuickApplicationWindow::explicitBackgroundSizeBinding()
{
QQuickControlsApplicationHelper helper(this, QLatin1String("explicitBackgroundSizeBinding.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
Request window activate after show in tst_qquickapplicationwindow The qquickapplicationwindow tests are failing when run locally because the window is not activated after it is shown. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I6c429016a0271b03581d3077f052ad46afbe5b09 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-08-20 10:59:35 +00:00
window->requestActivate();
ApplicationWindow: respect explicitly set background size 4a2466ea075676e8953ac7e9729492a0ace02c32 made ApplicationWindow explicitly set the background's width and height if they hadn't already been explicitly set. However, in certain cases widthValid() and heightValid() were checked before background's deferred execution had completed. This meant that the user's width and height bindings hadn't been evaluated yet, and hence widthValid and heightValid were false. Fix this by waiting until execution has finished before checking. Fixes: QTBUG-124744 Pick-to: 6.5 6.6 6.7 Change-Id: I1007f638a60c1ae4e0b07dbf91d5583bbfdcf8fb Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2024-04-26 02:41:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
auto *background = window->background();
QCOMPARE(background->width(), window->width());
QCOMPARE(background->height(), window->height());
window->setProperty("scaleFactor", 0.5);
QCOMPARE(background->width(), window->width() / 2);
QCOMPARE(background->height(), window->height() / 2);
}
Teach ApplicationWindow about safe area margins If the window has non-safe areas, as reflected by the window's safe area margins, ApplicationWindow will now automatically pad the content item accordingly, ensuring that the content item is within the safe area of the window. To implement this we piggy-back on QQuickControl, letting the control manage the size and position of the content item. This allows us to use the built in padding of QQuickControl to inset the content. Internally the item hierarchy of ApplicationWindow no longer represents the header, footer, and menu bar as children of the ApplicationWindow's content item, but rather as sibling items in the QQuickWindow content item, similar to the window's background item. Doing this is a slight behavior change, but for something that should have been an implementation detail as far as users are concerned. The content control and header, footer and menu bar now all live within the same root QQuickWindow::contentItem, which is a focus scope on its own. End users can override the automatic padding that we do for the contentItem by setting any of the four new padding properties that we expose, mirroring the properties on QQuickControl. [ChangeLog][Important Behavior Changes] The contentItem of ApplicationWindow is now automatically padded to account for safe area margins. To override the automatic padding, set the padding explicitly, via e.g. `topPadding: 0`. Task-number: QTBUG-125373 Change-Id: I986e425a7f316db244c7fc86283b8b333978e3ad Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-11-17 14:35:26 +00:00
void tst_QQuickApplicationWindow::safeArea()
{
QQuickControlsApplicationHelper helper(this, QLatin1String("safeArea.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowExposed(window));
auto menuBarRect = window->menuBar()->mapRectToScene(window->menuBar()->boundingRect());
auto headerRect = window->header()->mapRectToScene(window->header()->boundingRect());
auto contentRect = window->contentItem()->mapRectToScene(window->contentItem()->boundingRect());
auto footerRect = window->footer()->mapRectToScene(window->footer()->boundingRect());
// No item should overlap by default when there are no margins
QCOMPARE(menuBarRect.intersected(headerRect), QRectF());
QCOMPARE(menuBarRect.intersected(contentRect), QRectF());
QCOMPARE(menuBarRect.intersected(footerRect), QRectF());
QCOMPARE(headerRect.intersected(contentRect), QRectF());
QCOMPARE(headerRect.intersected(footerRect), QRectF());
QCOMPARE(footerRect.intersected(contentRect), QRectF());
// And content item should not report any safe area margins
auto *contentSafeArea = qobject_cast<QQuickSafeArea*>(
qmlAttachedPropertiesObject<QQuickSafeArea>(window->contentItem()));
QCOMPARE(contentSafeArea->margins(), QMarginsF());
auto *windowSafeArea = qobject_cast<QQuickSafeArea*>(
qmlAttachedPropertiesObject<QQuickSafeArea>(window));
windowSafeArea->setAdditionalMargins(QMarginsF(100, 100, 100, 100));
QTRY_COMPARE(window->property("margins").value<QMarginsF>(),
windowSafeArea->additionalMargins());
menuBarRect = window->menuBar()->mapRectToScene(window->menuBar()->boundingRect());
headerRect = window->header()->mapRectToScene(window->header()->boundingRect());
contentRect = window->contentItem()->mapRectToScene(window->contentItem()->boundingRect());
footerRect = window->footer()->mapRectToScene(window->footer()->boundingRect());
// No item should overlap by default when there are margins
QCOMPARE(menuBarRect.intersected(headerRect), QRectF());
QCOMPARE(menuBarRect.intersected(contentRect), QRectF());
QCOMPARE(menuBarRect.intersected(footerRect), QRectF());
QCOMPARE(headerRect.intersected(contentRect), QRectF());
QCOMPARE(headerRect.intersected(footerRect), QRectF());
QCOMPARE(footerRect.intersected(contentRect), QRectF());
// And content item should not report any safe area margins
QCOMPARE(contentSafeArea->margins(), QMarginsF());
QQmlProperty::write(window, "leftPadding", 0);
QQmlProperty::write(window, "topPadding", 0);
QQmlProperty::write(window, "rightPadding", 0);
QQmlProperty::write(window, "bottomPadding", 0);
// Removing the automatic padding should reflect the window's safe area margins
QCOMPARE(contentSafeArea->margins(), windowSafeArea->additionalMargins());
// And the content item should fill the entire window
QCOMPARE(window->contentItem()->position(), QPoint());
QCOMPARE(window->contentItem()->size(), window->size());
// Having no window safe area marings should still reflect the
// menuBar, header, and footer as safe areas
windowSafeArea->setAdditionalMargins(QMarginsF());
QTRY_COMPARE(window->property("margins").value<QMarginsF>(),
windowSafeArea->additionalMargins());
QCOMPARE(contentSafeArea->margins(),
QMarginsF(0, window->menuBar()->height() + window->header()->height(),
0, window->footer()->height()));
// And the content item still should fill the entire window
QCOMPARE(window->contentItem()->position(), QPoint());
QCOMPARE(window->contentItem()->size(), window->size());
}
Extend autotest of QML ApplicationWindow To test (show) the current tab order behavior, the ApplicationWindow of the autotest is extended by setting the menuBar, header, and footer properties. Consequently, the autotest will now test the tab order by traversing all the ApplicationWindow's content. Additionally the test now ensures correct z-stacking of the contents. Cleanup QKeyEvent creation lines by removing redundant parameters and use consistent assignment syntax. Fixes: QTBUG-137823 Pick-to: 6.8 6.9 6.10 Change-Id: I156397c00c308e2abd5e1f0acefd4889330f7619 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-06-26 09:26:43 +00:00
void tst_QQuickApplicationWindow::paintOrderChildItems()
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.loadUrl(testFileUrl("activefocusontab.qml"));
QObject *created = component.create();
QScopedPointer<QObject> cleanup(created);
QVERIFY(created);
QQuickWindow *window = qobject_cast<QQuickWindow *>(created);
QVERIFY(window);
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
const auto &paintOrder = QQuickItemPrivate::get(window->contentItem())->paintOrderChildItems();
for (const auto &child : paintOrder) {
if (child == window->contentItem())
QVERIFY(child->z() == 0);
else if (child == qobject_cast<QQuickApplicationWindow *>(window)->menuBar())
QVERIFY(child->z() == 2);
else if (child == qobject_cast<QQuickApplicationWindow *>(window)->header())
QVERIFY(child->z() == 1);
else if (child == qobject_cast<QQuickApplicationWindow *>(window)->footer())
QVERIFY(child->z() == 1);
else if (child == qobject_cast<QQuickApplicationWindow *>(window)->background())
QVERIFY(child->z() == -1);
}
}
Fix tst_qquickapplicationwindow compilation when hover is disabled Task-number: QTBUG-136101 Pick-to: 6.9 6.8 Change-Id: I38ffaa60219cb4432ca7444d8b560a9daa22c935 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2025-04-25 07:25:25 +00:00
#if QT_CONFIG(quicktemplates2_hover)
Fix broken hover in ApplicationWindow's background 8fb643f6d63813a5a8df5e829e4ddeb357e0348d fixed ComboBox not being hoverable by setting QQuickApplicationWindowPrivate::control's hoverEnabled property to true. By doing so, it ensured that only that control and its parent chain could get hover events, breaking hover for e.g. background. The correct fix is to adapt QQuickControlPrivate::calcHoverEnabled to skip the property("hoverEnabled") == true check for QQuickApplicationWindowPrivate::control, resulting in it falling back to the global checks. - Remove code added in 8fb643f6d63813a5a8df5e829e4ddeb357e0348d. - Move QQuickApplicationWindowPrivate declaration into its own header so that code outside the .cpp file (qquickcontrol.cpp, in this case) can use it. - Document behavior of hover flags in void QQuickItem::setAcceptHoverEvents. - Move the check done in tst_QQuickControl::hoverEnabledDefault() into the new tst_QQuickApplicationWindow::hoverInBackground() since they're closely related. - Add initial starting position argument to PointLerper's constructor since it wasn't previously possible to set it. - Remove unused headers in qquickapplicationwindow.cpp. Fixes: QTBUG-133886 Fixes: QTBUG-136031 Pick-to: 6.9 Change-Id: Ic32f902be6433c1c9dc9f4610c5715ce1537e605 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2025-04-17 02:34:11 +00:00
void tst_QQuickApplicationWindow::hoverInBackground()
{
QQuickControlsApplicationHelper helper(this, QLatin1String("hoverInBackground.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
auto *mouseArea = window->findChild<QQuickMouseArea *>();
QVERIFY(mouseArea);
const QPoint windowCenter = mapCenterToWindow(window->contentItem());
PointLerper pointLerper(window, windowCenter - QPoint(100, 100));
pointLerper.move(windowCenter, 2);
QVERIFY(mouseArea->hovered());
auto *button = window->findChild<QQuickAbstractButton *>();
QVERIFY(button);
pointLerper.move(mapCenterToWindow(button), 2);
QCOMPARE(button->isHovered(), QQuickControlPrivate::calcHoverEnabled(window->contentItem()));
}
Fix tst_qquickapplicationwindow compilation when hover is disabled Task-number: QTBUG-136101 Pick-to: 6.9 6.8 Change-Id: I38ffaa60219cb4432ca7444d8b560a9daa22c935 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2025-04-25 07:25:25 +00:00
#endif // QT_CONFIG(quicktemplates2_hover)
Fix broken hover in ApplicationWindow's background 8fb643f6d63813a5a8df5e829e4ddeb357e0348d fixed ComboBox not being hoverable by setting QQuickApplicationWindowPrivate::control's hoverEnabled property to true. By doing so, it ensured that only that control and its parent chain could get hover events, breaking hover for e.g. background. The correct fix is to adapt QQuickControlPrivate::calcHoverEnabled to skip the property("hoverEnabled") == true check for QQuickApplicationWindowPrivate::control, resulting in it falling back to the global checks. - Remove code added in 8fb643f6d63813a5a8df5e829e4ddeb357e0348d. - Move QQuickApplicationWindowPrivate declaration into its own header so that code outside the .cpp file (qquickcontrol.cpp, in this case) can use it. - Document behavior of hover flags in void QQuickItem::setAcceptHoverEvents. - Move the check done in tst_QQuickControl::hoverEnabledDefault() into the new tst_QQuickApplicationWindow::hoverInBackground() since they're closely related. - Add initial starting position argument to PointLerper's constructor since it wasn't previously possible to set it. - Remove unused headers in qquickapplicationwindow.cpp. Fixes: QTBUG-133886 Fixes: QTBUG-136031 Pick-to: 6.9 Change-Id: Ic32f902be6433c1c9dc9f4610c5715ce1537e605 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2025-04-17 02:34:11 +00:00
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
QTEST_MAIN(tst_QQuickApplicationWindow)
Add ApplicationWindow auto tests. These were copied from Qt Quick Controls. There are some issues with regards to QQuickThemeData, so some are commented out for now (see tests for details). I also added a test for QTBUG-47318. Change-Id: Iaee0f4531b8d7bc9b4984146aaf00b76afa77793 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
2015-07-20 15:27:05 +00:00
Rename tst_applicationwindow to tst_QQuickApplicationWindow Change-Id: If9fc2bb41cf251af71479b25656240e0d3c238d8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 12:48:17 +00:00
#include "tst_qquickapplicationwindow.moc"