qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp

3506 lines
142 KiB
C++
Raw Normal View History

Use SPDX license identifiers Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2022-05-13 13:12:05 +00:00
// Copyright (C) 2017 The Qt Company Ltd.
Correct license for test files According to QUIP-18 [1], all test files should be LicenseRef-Qt-Commercial OR GPL-3.0-only [1]: https://contribute.qt-project.org/quips/18 Pick-to: 6.7 Task-number: QTBUG-121787 Change-Id: I26d72e8de04d4c7c57b3b7838af5d033265de5ba Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Kai Köhne <kai.koehne@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2024-02-22 14:51:16 +00:00
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
#include <QtTest/qtest.h>
#include <QtTest/qsignalspy.h>
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
#include <QtGui/qcursor.h>
Fix sub-menu shortcuts not being triggered When QQuickShortcutContext::matcher is checking who should get a shortcut, it starts with the object that registered the shortcut and climbs up its parent hierarchy until it finds a window. Sub-menus, unlike top-level menus, will not have an associated window until their parent menu is opened. So, check if the popup is a sub-menu so that actions within it can grab shortcuts. Change-Id: I07172b1038af1e9fffd9983f7bf0a155b11bb1c3 Fixes: QTBUG-101034 Pick-to: 6.2 6.3 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-03-10 08:47:34 +00:00
#if QT_CONFIG(shortcut)
#include <QtGui/qkeysequence.h>
#endif
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
#include <QtGui/qstylehints.h>
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
#include <QtGui/qpa/qplatformintegration.h>
tst_qquickmenu: move native menu support check to runtime It's clear that the build time check doesn't work, and since we can't easily check which platform plugin we're using (and maintaining such a check could be fragile), just check if we can create a platform menu. Task-number: QTBUG-69558 Change-Id: I2d8057f4012a4762d9d323ddc7127824811229a6 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 12:52:20 +00:00
#include <QtGui/qpa/qplatformtheme.h>
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
#include <QtGui/private/qguiapplication_p.h>
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
#include <QtQml/qqmlengine.h>
#include <QtQml/qqmlcomponent.h>
#include <QtQml/qqmlcontext.h>
#include <QtQuick/qquickview.h>
#include <QtQuick/private/qquickitem_p.h>
Menu: force contentItem ListView layout before starting enter transition Enter transitions may want to animate the Menu's height based on its implicitHeight. The Menu's implicitHeight is typically based on the ListView's contentHeight, among other things. The docs for ListView's forceLayout function say: "Responding to changes in the model is usually batched to happen only once per frame." As e.g. NumberAnimation's from and to values are set before any polishes happen, any re-evaluation of their bindings happen too late, and the starting height can be out-dated when menu items are added after component completion (QQuickItemView::componentComplete does a layout, so items declared as children aren't affected by this). To account for this, this patch forces a layout before the transition starts, if necessary. Fixes: QTBUG-136256 Pick-to: 6.5 6.8 6.9 Change-Id: I1cc912347b774369b3542f0d32c654ae5615b97a Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2025-05-06 06:00:50 +00:00
#include <QtQuick/private/qquicklistview_p.h>
Don't propagate mouse event for menu configured inside popup The patch e4a159632ec39542ec23567963191162f9dcdfef fixes propagating mouse events by not allowing it to the underlying items beneath the overlay. It still can cause an issue when the menu is nested within the popup. This is because the menu doesn't block the input, which allows the overlay to pass on the events to the next child item. This patch enables the menu to consume the mouse press event (as similar to the drawer), further causing overlay not to pass on the events to the other child items. Fixes: QTBUG-130536 Pick-to: 6.8 6.5 Change-Id: I1014c692a4a5aed22e096a79c06e27cb26fea70d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-10-30 09:14:14 +00:00
#include <QtQuick/private/qquickmousearea_p.h>
Menu: fix mixing non-Menu-related items in with native menus Create QQuickNativeMenuItems even for items that we don't recognize so that our indices match up with contentModel's. Task-number: QTBUG-69558 Change-Id: I7515dbefe4adb075bbda92adde5a9327033154c1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-12 06:35:17 +00:00
#include <QtQuick/private/qquickrectangle_p.h>
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
#include <QtQuickTest/quicktest.h>
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
#include <QtQuickTestUtils/private/qmlutils_p.h>
#include <QtQuickTestUtils/private/visualtestutils_p.h>
#include <QtQuickControlsTestUtils/private/controlstestutils_p.h>
#include <QtQuickControlsTestUtils/private/qtest_quickcontrols_p.h>
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
Add QQuickMenu::add/insert/remove/takeAction() [ChangeLog][Controls][Menu] Added addAction(), insertAction(), removeAction(), and takeAction() methods for adding and removing actions programmatically. Change-Id: I7d494ef1edc1cf384314fa90d97cfd2290d2e8a3 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-09 08:09:28 +00:00
#include <QtQuickTemplates2/private/qquickaction_p.h>
Templates: rename the C++ module to qtquicktemplates2 Change-Id: I146da903b46f5c2caf865e37291c25376b49021a Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-13 13:59:53 +00:00
#include <QtQuickTemplates2/private/qquickapplicationwindow_p.h>
#include <QtQuickTemplates2/private/qquickoverlay_p.h>
#include <QtQuickTemplates2/private/qquickbutton_p.h>
QuickControls2: implement icons for submenus Previously in Qt 5 there was an option to define iconSource property in Controls 1 Menu. But it's missed in Controls 2, so it's not possible to use icon for submenu item in Qt 6. This patch introduces icon group property for the Menu so that it behaves and displayed the same as for regular menu items. [ChangeLog][QtQuick][Controls] Now it's possible to set icon for Menu. This is useful for submenus, so icon will be displayed as for regular menu items. Fixes: QTBUG-79972 Change-Id: I4610d4b6d40c51b774b035e238e5e1ceea53a8a3 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-09-14 11:09:49 +00:00
#include <QtQuickTemplates2/private/qquickicon_p.h>
Templates: rename the C++ module to qtquicktemplates2 Change-Id: I146da903b46f5c2caf865e37291c25376b49021a Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-13 13:59:53 +00:00
#include <QtQuickTemplates2/private/qquickmenu_p.h>
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
#include <QtQuickTemplates2/private/qquickmenu_p_p.h>
Templates: rename the C++ module to qtquicktemplates2 Change-Id: I146da903b46f5c2caf865e37291c25376b49021a Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-13 13:59:53 +00:00
#include <QtQuickTemplates2/private/qquickmenuitem_p.h>
Add MenuSeparator [ChangeLog][Controls] Added MenuSeparator to visually distinguish between groups of items in a menu. Change-Id: I7a52910b19633ed1188c90ca56c92346a28d4d5c Task-number: QTBUG-54862 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-07-21 14:04:18 +00:00
#include <QtQuickTemplates2/private/qquickmenuseparator_p.h>
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
#include <QtQuickTemplates2/private/qquicknativemenuitem_p.h>
Use leftPadding of parent menus when flipping submenus QQuickMenuPositioner positions child menus to the right of the menu item that opened it. In additon, the overlap and rightPadding properties are used to offset the x position, which styles can use to fine tune how exactly submenus should be positioned relative to the parent menu item. The parent menu's padding is used, because the submenu's position is initially set to be relative to the menu item that opened it. When the position is offset by the padding, it will position itself to the parent menu, and not just the parent menu item. 7add1868c0956bca769a33d2974b211c6e533567 introduced the flipping behavior for menus that have their popupType set to Popup.Window. Causing menus that don't have enough space to open to the right side, to instead open on the left side. The aformentioned patch used the overlap, but forgot to also add the leftPadding, when flipping submenus. Also fix the test tst_QQuickMenu::subMenuFlipsPositionWhenOutOfBounds, which was previously broken on all styles that modified the rightPadding property of Menu. 6e327f28c7cd05d90881998696da45615 introduced a temporary fix, in order to unblock CI, and this patch should fix it properly. Pick-to: 6.9 6.8 Change-Id: I62c58617dbcf27c097009859213cb78eb59a8008 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2025-02-11 17:53:43 +00:00
#include <QtQuickTemplates2/private/qquickpopupitem_p_p.h>
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
#include <QtQuickTemplates2/private/qquickpopupwindow_p_p.h>
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
using namespace QQuickVisualTestUtils;
using namespace QQuickControlsTestUtils;
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
Add beginnings of native Menu backend This patch gets the basic functionality and initial API in place so that work on MenuBar can begin. Task-number: QTBUG-69558 Change-Id: I94df848f771d38cd1cabb964b695d383f66240f2 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2023-11-21 03:12:31 +00:00
// Native menu tests are in "nativemenus".
Rename tst_menu to tst_QQuickMenu Change-Id: I1c7e1a2b337e9d16bc6c9b098db08f29f1b9d1e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 13:14:32 +00:00
class tst_QQuickMenu : public QQmlDataTest
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
{
Q_OBJECT
public:
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
tst_QQuickMenu();
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
private slots:
Tests: Avoid some warnings Change-Id: I463e41352467dab7998b79843547a4a05046520c Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io>
2024-06-06 12:35:25 +00:00
void init() final;
tst_qquickmenu: Close all popups in cleanup() This ensures that no popups are active at the start of a test function. Useful in case a test forgets to close the popup manually. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I6c1169ccf3b0f95d92b751ddd5561633e65d02bf Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-09-02 23:43:15 +00:00
void cleanup();
Menu, MenuBar: remove requestNative and rely solely on app attributes It was decided that we'll have two attributes: - AA_DontUseNativeMenuBar - AA_DontUseNativeMenuWindows Setting AA_DontUseNativeMenuWindows only affects windows we create (context menus, combobox menus, menus of non-native menu bars). So, setting AA_DontUseNativeMenuWindows restores Qt to today's behavior. But we can't control the windows of native menu bars, so if you don't want those to be native, you have to set AA_DontUseNativeMenuBar just like today. By removing requestNative, we also effectively default to native menus and menu bars, as the attributes are not set by default. [ChangeLog][Controls][Important Behavior Changes] Menu and MenuBar now use native menus by default on platforms where they're supported. Task-number: QTBUG-69558 Change-Id: Ia917c2f820634def0cf815aa8ca8895ca79db75d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-14 03:36:06 +00:00
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
void defaults();
Add QQuickMenu::count [ChangeLog][Controls][Menu] Added "count" property. Change-Id: I42971a6bf8fd74b9f2d3df52f191b66cd7022b81 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-12 13:58:02 +00:00
void count();
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
void mouse_data();
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
void mouse();
QQuickMenu: fix press-and-hold support Remove the OnReleaseOutside close policy, just use the defaults from QQuickPopup. This way menus won't get immediately closed on release, when opened from an onPressAndHold signal handler. Task-number: QTBUG-61608 Change-Id: Ifedd596aa0e71ac5f4211fa42e2ae499918df1b2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 11:15:24 +00:00
void pressAndHold();
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
void contextMenuKeyboard_data();
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
void contextMenuKeyboard();
QQuickMenu: don't give focus to disabled menu items Change-Id: I7eb394ca3991eae585fbbd8e665c46b11ef64a07 Fixes: QTBUG-70181 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2019-02-01 12:53:06 +00:00
void disabledMenuItemKeyNavigation();
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
void mnemonics();
Menu: Activate Menu Item When Mnemonic Key is Pressed, Same as Widgets When a menu is opened, its menu items aren't triggered by pressing their mnemonic key using the Alt key. Also, aren't triggered even when their mnemonic key is pressed without the Alt key. This behavior is different from the widgets menu behavior. When the widgets menu is opened its actions can be activated by pressing their mnemonic key without holding the Alt key. When a key is pressed on QQuickMenu and no modifier is held, it loops over its items to find the item whose mnemonic key matches the key. If the item is found, the click() method will be called. The test case opens the menu and sends the press and release events with the mnemonic key of each menu item, and checks that they are triggered. When the item is checkable, the test verifies that the checkedChanged() signal is also emitted. Task-number: QTBUG-96630 Pick-to: 6.8 6.7 6.5 Change-Id: I99f27c6306e14375b45d0630e4f9047e33fa64fb Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2024-08-15 10:49:34 +00:00
#if QT_CONFIG(shortcut)
void checkableMnemonics_data();
void checkableMnemonics();
#endif
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
void menuButton();
Menu: support dynamically added items in the same way as static ones Task-number: QTBUG-53274 Change-Id: I172e431cd456b91dee569b510288d0eccbdb4cef Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 11:58:05 +00:00
void addItem();
Add MenuSeparator [ChangeLog][Controls] Added MenuSeparator to visually distinguish between groups of items in a menu. Change-Id: I7a52910b19633ed1188c90ca56c92346a28d4d5c Task-number: QTBUG-54862 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-07-21 14:04:18 +00:00
void menuSeparator();
QQuickMenu: fix Repeater support QQuickMenu had itemChildAdded() copied from QQuickContainer, but it did not actually install an item change listener on the content item so itemChildAdded() got never called. Change-Id: Idfe558c7055b9a3df124b1f009941c423ecef4bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-12-28 19:24:18 +00:00
void repeater();
void order();
tst_QQuickMenu: skip entire popup() test where necessary If the cursor configure feature is not enabled, don't build the code. If the platform is Android or Wayland, skip the test. Pick-to: 6.2 6.3 6.4 Change-Id: Ic60771decf7f2e0bd7db77c112925147015af5a6 Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
2022-06-28 08:05:18 +00:00
#if QT_CONFIG(cursor)
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
void popup();
tst_QQuickMenu: skip entire popup() test where necessary If the cursor configure feature is not enabled, don't build the code. If the platform is Android or Wayland, skip the test. Pick-to: 6.2 6.3 6.4 Change-Id: Ic60771decf7f2e0bd7db77c112925147015af5a6 Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
2022-06-28 08:05:18 +00:00
#endif
QQuickMenu: guard agains crashing, if the visual parent is set to null The application can do silly things as setting a menus visual parent to null before showing it. This will currently cause a crash. And doing so will also make the menu not showing when using non-native menus, since the menu will not be a part of the scene. This patch will there check if a menus visual parent is set before trying to show it. Change-Id: I6094b3ddee88189db59a82c6791fe90456c8da92 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-03-14 10:07:30 +00:00
void openParentlessMenu();
QQuickMenu: add support for declaring Actions [ChangeLog][Controls][Menu] Added support for declaring Actions. The new "delegate" property is used to define a Component that is used to create menu items that present the actions. Change-Id: If26f38f6910aa5592879703429a2b418193d5710 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 18:09:44 +00:00
void actions();
Fix sub-menu shortcuts not being triggered When QQuickShortcutContext::matcher is checking who should get a shortcut, it starts with the object that registered the shortcut and climbs up its parent hierarchy until it finds a window. Sub-menus, unlike top-level menus, will not have an associated window until their parent menu is opened. So, check if the popup is a sub-menu so that actions within it can grab shortcuts. Change-Id: I07172b1038af1e9fffd9983f7bf0a155b11bb1c3 Fixes: QTBUG-101034 Pick-to: 6.2 6.3 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-03-10 08:47:34 +00:00
#if QT_CONFIG(shortcut)
void actionShortcuts();
#endif
QQuickMenu: removeItem(Item) and takeItem(int) Deprecate removeItem(int) in favor of removeItem(Item) and takeItem(int) with clearer semantics. If one already has access to an item, one can pass it to removeItem() to get rid of it for good, instead of having to call destroy() by hand. If one knows the index instead, we provide a way to take the respective item out of the menu, and let the user decide what to do with it. This way we provide convenient ways to remove & destroy items in one go, and to take items out without destroying them. This nice pattern was once upon time planned for the QQC1 containers such as SplitView, and should have been used for the QQC2 containers, but was simply forgotten during the development... [ChangeLog][Controls][Menu] Deprecated removeItem(int) in favor of removeItem(Item) and takeItem(int) with clearer semantics. The former destroys the item, whereas the latter transfers ownership to the caller. Change-Id: Id2a07fb65019b2904a013c8bcc3154089d36a0ea Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-02 14:18:56 +00:00
void removeTakeItem();
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
void subMenuMouse_data();
void subMenuMouse();
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
void subMenuDisabledMouse_data();
void subMenuDisabledMouse();
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
void subMenuKeyboard_data();
void subMenuKeyboard();
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
void subMenuDisabledKeyboard_data();
void subMenuDisabledKeyboard();
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
void subMenuPosition_data();
void subMenuPosition();
PopupPositioner: ensure popup windows are placed inside a screen When `popupType: Popup.Item`, the popup positioner will attempt to flip, move and resize the popup item, in order to make it fit inside its window. We want something similar for when `popupType: Popup.Window`, except that the bounds in this case, ends up being the geometry of the screen that contains the popup window, instead of the nearest parent item's window. The omission of any resizing to the popup window, is done on purpose. Since the popup positioner's current role, is to only affect the popup window position. This might change in the future, in case we decide to refactor some of the logic around popup window resizing. Pick-to: 6.9 6.8 Change-Id: Iee0f1c7363624b73d0b64f0b6c47765abdb365e2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-26 14:25:42 +00:00
void subMenuFlipsPositionWhenOutOfBounds_data();
void subMenuFlipsPositionWhenOutOfBounds();
QuickControls2: implement icons for submenus Previously in Qt 5 there was an option to define iconSource property in Controls 1 Menu. But it's missed in Controls 2, so it's not possible to use icon for submenu item in Qt 6. This patch introduces icon group property for the Menu so that it behaves and displayed the same as for regular menu items. [ChangeLog][QtQuick][Controls] Now it's possible to set icon for Menu. This is useful for submenus, so icon will be displayed as for regular menu items. Fixes: QTBUG-79972 Change-Id: I4610d4b6d40c51b774b035e238e5e1ceea53a8a3 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-09-14 11:09:49 +00:00
void subMenuWithIcon();
Add QQuickMenu::add/insert/remove/takeMenu() [ChangeLog][Controls][Menu] Added addMenu(), insertMenu(), removeMenu(), and takeMenu() methods for adding and removing sub-menus programmatically. Change-Id: Ibf39448cdf528f64695b1ee5f0781384b754ba22 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-07 17:43:58 +00:00
void addRemoveSubMenus();
QQuickMenu: let a child menu use the same popup type as the parent We currently allow a child menu to have a popupType different from the parent menu. This will not work in practice, since all menus in the same hierarchy have to have the same type. Rather than placing the burden on the application developer to set the same popup type on all (sub)menus, we let QQuickMenu do this automatically based on the what the root menu ends up using. This is also the documented behavior. In order to implement this change, add a virtual QQuickPopup::resolvedPopupType(). The other sub-classes of QQuickPopup can then override this function and resolve the actual popup type at run-time. This also allows us to remove using Qt::Widget as a popupWindowType(), since e.g a Drawer will never resolve the popup type to be QQuickPopup::Window anyway. Pick-to: 6.8 Change-Id: I9cf95bb02fb0a912497c77d2df25a9cb76c153cd Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-12 11:50:31 +00:00
void subMenuPopupType();
Menu: fix items not being scrollable when using Window Use Window.window instead of ApplicationWindow.window, as the former will always result in a window regardless of which type of window is in use. Task-number: QTBUG-68858 Change-Id: I3bdb60350d92b13621b0f4db9085bf067b6ff6e2 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-06-18 09:38:40 +00:00
void scrollable_data();
void scrollable();
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
void disableWhenTriggered_data();
void disableWhenTriggered();
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
void menuItemWidth_data();
void menuItemWidth();
void menuItemWidthAfterMenuWidthChanged_data();
void menuItemWidthAfterMenuWidthChanged();
void menuItemWidthAfterImplicitWidthChanged_data();
void menuItemWidthAfterImplicitWidthChanged();
void menuItemWidthAfterRetranslate();
QQuickAbstractButton: don't accept key release if we're not pressed A control should have been pressed if it's going to accept a release. This prevents an issue where a menu opened by pressing enter (handled via attached Keys property) would instantly trigger the first menu item. Pick-to: 5.15 5.12 Fixes: QTBUG-83698 Change-Id: I6b1afbb76f37623012472b2b1148b4862c159239 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-10-20 08:34:53 +00:00
void giveMenuItemFocusOnButtonPress();
Menu: cull non-visible items when `contentItem` inherits Item For a custom menu control, when the contentItem does not inherit from ItemView, the text overlaps. A related bug is QTBUG-53262, but this problem is only fixed for the ItemView control. Since the contentItem control can accept the Item control, I think the repair only for ItemView has limitations. Therefore, this submission cancels the restriction on the type of contentitem. Pick-to: 6.3 6.4 Fixes: QTBUG-104470 Change-Id: I7e697e3cb993475d157a92f37d9512e4a9872387 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-21 03:10:00 +00:00
void customMenuCullItems();
Repeater: uncull items that come from ObjectModel After 6173fc0e4be93604286b9a424f1aa3ff5896082a, Menu will unconditionally cull items as they are inserted. This behavior relies on the fact that ListView will uncull the items as necessary. However, when implementing Menu with a Repeater as the contentItem (which is unusual but not unreasonable), the items will never be unculled and hence will be invisible. We can't fix this in Menu by checking its contentItem, because when items are inserted, their parent item is the root contentItem, not the Repeater, and there's no nice, efficient way to check if the item belongs to a Repeater. This patch fixes the issue in Repeater by unculling the item if it came from an ObjectModel. Done-with: Mitch Curtis <mitch.curtis@qt.io> Pick-to: 6.3 6.4 Fixes: QTBUG-104544 Change-Id: Ib37d2d49d3608156a3f1e3652b63ccdd5dfd0f41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 02:38:51 +00:00
void customMenuUseRepeaterAsTheContentItem();
Fix crash issue when invalid img tag used in text The img tag should contain valid base url. If not, it shall be considered as invalid and style text ignore those tags. Fixes: QTBUG-116672 Pick-to: 6.6 6.5 Change-Id: Iccf74f895a9f6b7fb83e458fe27f2aada86094e3 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-09-05 20:14:30 +00:00
void invalidUrlInImgTag();
Menu: support adding MenuItem to native menu Originally the plan was to revert to a non-native menu when MenuItem was used, but now that we always create the non-native items regardless, we shouldn't need to do that. Checkable MenuItems do not currently work. This will be implemented in a follow-up commit. Task-number: QTBUG-69558 Change-Id: I7238dad89e478f7cc664738fb6036787e0193dab Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 07:10:33 +00:00
void nativeStatic();
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
void nativeDynamicActions();
void nativeDynamicSubmenus();
void nativeMenuSeparator();
QQuickMenu: respect Qt::AA_DontUseNativeMenuWindows Now that we enable native menus by default for the macOS style, we also need to make sure that we actually respect the Qt::AA_DontUseNativeMenuWindows. Pick-to: 6.8 Change-Id: I2a02b5528110a4e0514fb53c0673653f0086dfe8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-27 10:18:09 +00:00
void AA_DontUseNativeMenuWindows();
Menu, MenuBar: remove requestNative and rely solely on app attributes It was decided that we'll have two attributes: - AA_DontUseNativeMenuBar - AA_DontUseNativeMenuWindows Setting AA_DontUseNativeMenuWindows only affects windows we create (context menus, combobox menus, menus of non-native menu bars). So, setting AA_DontUseNativeMenuWindows restores Qt to today's behavior. But we can't control the windows of native menu bars, so if you don't want those to be native, you have to set AA_DontUseNativeMenuBar just like today. By removing requestNative, we also effectively default to native menus and menu bars, as the attributes are not set by default. [ChangeLog][Controls][Important Behavior Changes] Menu and MenuBar now use native menus by default on platforms where they're supported. Task-number: QTBUG-69558 Change-Id: Ia917c2f820634def0cf815aa8ca8895ca79db75d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-14 03:36:06 +00:00
void dontUseNativeMenuWindowsChanges();
Menu: fix mixing non-Menu-related items in with native menus Create QQuickNativeMenuItems even for items that we don't recognize so that our indices match up with contentModel's. Task-number: QTBUG-69558 Change-Id: I7515dbefe4adb075bbda92adde5a9327033154c1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-12 06:35:17 +00:00
void nativeMixedItems();
QQuickPopupPositioner: implement setEffectivePosFromWindowPos() Factor out setting the effective position to a separate function, and call it from all places where we change it. This ensures that we always emit the xChanged/yChanged signals, and that we always include any drop-shadow offset in the calculation. Also change the effectPos variable to be a QPointF. Pick-to: 6.8 Change-Id: I00ad7e25397887719811738343448f177261cc54 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-03 14:03:48 +00:00
void effectivePosition_data();
void effectivePosition();
QQuickMenuItem: add implicitTextPadding and textPadding Add the properties "implicitTextPadding" and "textPadding" to MenuItem. They can be used by the style to ensure that all MenuItems inside the same Menu end up left-aligned WRT text. Each MenuItem should set implicitTextPadding to be the needed space from the left edge of the contentItem to the text label. QQuickMenu will then iterate over all the MenuItems inside the same Menu, and set textPadding to be the maximum implicitTextPadding found. All MenuItems should then use textPadding (which will end up the same for all MenuItems) to position the text. This API is meant to solve the problem that MenuItems inside a single Menu can have different contents. Some can be checkable, some can have an icon, some are just plain text. And for several of our styles (e.g macOS and Windows), we want the text to be left-aligned regardless of that. Without this API, The checkmark inside a checkable MenuItem would be left-aligned with the text inside a plain MenuItem etc. [ChangeLog][Controls][MenuItem] A MenuItem now has two new properties (implicitTextPadding and textPadding) that can be used for aligning the text across all MenuItems inside a Menu. Change-Id: I1f2248b31c63d6b9780d8fc77229a8b902362f70 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-05-22 20:15:53 +00:00
void textPadding();
QQuickMenu: clear currentIndex upon a call to popup() If you popup() a Menu a second time, without providing a MenuItem as argument, the previously activated MenuItem will still be current, and rendered as highlighted. This is not the expected behavior for Context Menus or MenuBar menus. This patch will therefore make sure that we reset currentIndex when popping up a Menu. It's still possible to open() it instead, if currentIndex should be kept. Pick-to: 6.8 Change-Id: I09fdc2e5429ba107b236d0c761ca8d1de654710e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-03 09:58:44 +00:00
void resetCurrentIndexUponPopup_data();
void resetCurrentIndexUponPopup();
Don't propagate mouse event for menu configured inside popup The patch e4a159632ec39542ec23567963191162f9dcdfef fixes propagating mouse events by not allowing it to the underlying items beneath the overlay. It still can cause an issue when the menu is nested within the popup. This is because the menu doesn't block the input, which allows the overlay to pass on the events to the next child item. This patch enables the menu to consume the mouse press event (as similar to the drawer), further causing overlay not to pass on the events to the other child items. Fixes: QTBUG-130536 Pick-to: 6.8 6.5 Change-Id: I1014c692a4a5aed22e096a79c06e27cb26fea70d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-10-30 09:14:14 +00:00
void mousePropagationWithinPopup();
QQuickMenu: fix infinite loop with Action shortcut in nested sub-menus 51ad5091929c7f2c4bab94fab9fa1c20996a6efa forgot to set parentMenu in the loop. Fixes: QTBUG-135965 Pick-to: 6.5 6.8 6.9 Change-Id: I56ad611a6dd6e9f978ce3da5cc28e02d8f2b1a1a Reviewed-by: Santhosh Kumar <santhosh.kumar.selvaraj@qt.io>
2025-04-15 06:07:45 +00:00
void shortcutInNestedSubMenuAction();
Menu: force contentItem ListView layout before starting enter transition Enter transitions may want to animate the Menu's height based on its implicitHeight. The Menu's implicitHeight is typically based on the ListView's contentHeight, among other things. The docs for ListView's forceLayout function say: "Responding to changes in the model is usually batched to happen only once per frame." As e.g. NumberAnimation's from and to values are set before any polishes happen, any re-evaluation of their bindings happen too late, and the starting height can be out-dated when menu items are added after component completion (QQuickItemView::componentComplete does a layout, so items declared as children aren't affected by this). To account for this, this patch forces a layout before the transition starts, if necessary. Fixes: QTBUG-136256 Pick-to: 6.5 6.8 6.9 Change-Id: I1cc912347b774369b3542f0d32c654ae5615b97a Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2025-05-06 06:00:50 +00:00
void animationOnHeight();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
private:
tst_qquickmenu: move native menu support check to runtime It's clear that the build time check doesn't work, and since we can't easily check which platform plugin we're using (and maintaining such a check could be fragile), just check if we can create a platform menu. Task-number: QTBUG-69558 Change-Id: I2d8057f4012a4762d9d323ddc7127824811229a6 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 12:52:20 +00:00
bool nativeMenuSupported = false;
};
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
// This allows us to use QQuickMenuItem's more descriptive operator<< output
// for the QCOMPARE failure message. It doesn't seem possible to use toString
// overloads or template specialization when types declared in QML are involved,
// as is the case for the MenuItems created from Menu's delegate.
#define COMPARE_MENUITEMS(actualMenuItem, expectedMenuItem) \
QVERIFY2(actualMenuItem == expectedMenuItem, \
qPrintable(QString::fromLatin1("\n Actual: %1\n Expected: %2") \
.arg(QDebug::toString(actualMenuItem), QDebug::toString(expectedMenuItem))));
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
tst_QQuickMenu::tst_QQuickMenu()
: QQmlDataTest(QT_QMLTEST_DATADIR)
{
tst_qquickmenu: move native menu support check to runtime It's clear that the build time check doesn't work, and since we can't easily check which platform plugin we're using (and maintaining such a check could be fragile), just check if we can create a platform menu. Task-number: QTBUG-69558 Change-Id: I2d8057f4012a4762d9d323ddc7127824811229a6 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 12:52:20 +00:00
std::unique_ptr<QPlatformMenu> platformMenu(QGuiApplicationPrivate::platformTheme()->createPlatformMenu());
nativeMenuSupported = platformMenu != nullptr;
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
}
Menu, MenuBar: remove requestNative and rely solely on app attributes It was decided that we'll have two attributes: - AA_DontUseNativeMenuBar - AA_DontUseNativeMenuWindows Setting AA_DontUseNativeMenuWindows only affects windows we create (context menus, combobox menus, menus of non-native menu bars). So, setting AA_DontUseNativeMenuWindows restores Qt to today's behavior. But we can't control the windows of native menu bars, so if you don't want those to be native, you have to set AA_DontUseNativeMenuBar just like today. By removing requestNative, we also effectively default to native menus and menu bars, as the attributes are not set by default. [ChangeLog][Controls][Important Behavior Changes] Menu and MenuBar now use native menus by default on platforms where they're supported. Task-number: QTBUG-69558 Change-Id: Ia917c2f820634def0cf815aa8ca8895ca79db75d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-14 03:36:06 +00:00
void tst_QQuickMenu::init()
{
QQmlDataTest::init();
// By default we don't want to use native menus, as the majority of the tests
// were written before they were a thing. We instead explicitly set it where necessary.
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuWindows);
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuBar);
}
tst_qquickmenu: Close all popups in cleanup() This ensures that no popups are active at the start of a test function. Useful in case a test forgets to close the popup manually. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I6c1169ccf3b0f95d92b751ddd5561633e65d02bf Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-09-02 23:43:15 +00:00
void tst_QQuickMenu::cleanup()
{
// In case a test forgets to close all popup windows
if (QGuiApplicationPrivate::popupCount() > 0)
QGuiApplicationPrivate::closeAllPopups();
QTRY_COMPARE(QGuiApplicationPrivate::popupCount(), 0);
}
Rename tst_menu to tst_QQuickMenu Change-Id: I1c7e1a2b337e9d16bc6c9b098db08f29f1b9d1e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 13:14:32 +00:00
void tst_QQuickMenu::defaults()
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
{
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("applicationwindow.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
auto tests: allow using QQuickWindow with QQuickApplicationHelper This allows us to run the relevant popup tests for both QQuickWindow and QQuickApplicationWindow. Change-Id: I14b6435afeeb8a6cf640d8c52ad1d9e1fae070b0 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-09-03 13:15:53 +00:00
QQuickMenu *emptyMenu = helper.appWindow->property("emptyMenu").value<QQuickMenu*>();
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QCOMPARE(emptyMenu->isVisible(), false);
Give Dialogs and Menus focus by default Dialogs and Menus should always have focus when they're opened, especially now that the cancel key handling in QQuickPopup/QQuickPopupItem is done via regular key events and not shortcuts, as popups will now require focus in order to be cancelled via keyboard. [ChangeLog][Controls][Important Behavior Changes] Dialogs and Menus now have their focus property set to true by default. Popups are unchanged, meaning that popups that should be interacted with via keyboard (including cancelling) should have focus set to true or forceActiveFocus() called on them after opening. Task-number: QTBUG-79280 Change-Id: Idd070f2b1e8180a34a0dadb6e11dc56e531df211 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-02-25 08:43:45 +00:00
QVERIFY(emptyMenu->hasFocus());
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(emptyMenu->currentIndex(), -1);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QCOMPARE(emptyMenu->contentItem()->property("currentIndex"), QVariant(-1));
Add QQuickMenu::count [ChangeLog][Controls][Menu] Added "count" property. Change-Id: I42971a6bf8fd74b9f2d3df52f191b66cd7022b81 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-12 13:58:02 +00:00
QCOMPARE(emptyMenu->count(), 0);
}
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::count()
Add QQuickMenu::count [ChangeLog][Controls][Menu] Added "count" property. Change-Id: I42971a6bf8fd74b9f2d3df52f191b66cd7022b81 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-12 13:58:02 +00:00
{
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("applicationwindow.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Add QQuickMenu::count [ChangeLog][Controls][Menu] Added "count" property. Change-Id: I42971a6bf8fd74b9f2d3df52f191b66cd7022b81 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-12 13:58:02 +00:00
QQuickMenu *menu = helper.window->property("emptyMenu").value<QQuickMenu*>();
QVERIFY(menu);
QSignalSpy countSpy(menu, &QQuickMenu::countChanged);
QVERIFY(countSpy.isValid());
menu->addItem(new QQuickItem);
QCOMPARE(menu->count(), 1);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(countSpy.size(), 1);
Add QQuickMenu::count [ChangeLog][Controls][Menu] Added "count" property. Change-Id: I42971a6bf8fd74b9f2d3df52f191b66cd7022b81 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-12 13:58:02 +00:00
menu->insertItem(0, new QQuickItem);
QCOMPARE(menu->count(), 2);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(countSpy.size(), 2);
Add QQuickMenu::count [ChangeLog][Controls][Menu] Added "count" property. Change-Id: I42971a6bf8fd74b9f2d3df52f191b66cd7022b81 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-12 13:58:02 +00:00
menu->removeItem(menu->itemAt(1));
QCOMPARE(menu->count(), 1);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(countSpy.size(), 3);
Add QQuickMenu::count [ChangeLog][Controls][Menu] Added "count" property. Change-Id: I42971a6bf8fd74b9f2d3df52f191b66cd7022b81 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-12 13:58:02 +00:00
tst_qquickmenu: fix memory leak takeItem() unparents the item, so we need to make sure it gets deleted. The leak was caught by valgrind: ==10039== 832 (32 direct, 800 indirect) bytes in 1 blocks are definitely lost in loss record 6,465 of 6,706 ==10039== at 0x4C3017F: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==10039== by 0x112C1E: tst_QQuickMenu::count() (tst_qquickmenu.cpp:121) ==10039== by 0x12F313: tst_QQuickMenu::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (tst_qquickmenu.moc:156) ==10039== by 0x612B6B2: QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const (qmetaobject.cpp:2305) ==10039== by 0x41B07CD: invoke (qmetaobject.h:123) ==10039== by 0x41B07CD: QTest::TestMethods::invokeTestOnData(int) const (qtestcase.cpp:915) ==10039== by 0x41B15BF: QTest::TestMethods::invokeTest(int, char const*, QTest::WatchDog*) const (qtestcase.cpp:1114) ==10039== by 0x41B1D07: QTest::TestMethods::invokeTests(QObject*) const (qtestcase.cpp:1456) ==10039== by 0x41B2381: QTest::qRun() (qtestcase.cpp:1896) ==10039== by 0x41B24E1: QTest::qExec(QObject*, int, char**) (qtestcase.cpp:1783) ==10039== by 0x12F468: main (tst_qquickmenu.cpp:1505) Change-Id: I459c7897c1088c8b58152d2e0b5ceb8f3684e589 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-10-12 13:17:41 +00:00
QScopedPointer<QQuickItem> item(menu->takeItem(0));
Add QQuickMenu::count [ChangeLog][Controls][Menu] Added "count" property. Change-Id: I42971a6bf8fd74b9f2d3df52f191b66cd7022b81 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-12 13:58:02 +00:00
QVERIFY(item);
QCOMPARE(menu->count(), 0);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(countSpy.size(), 4);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
}
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
void tst_QQuickMenu::mouse_data()
{
QTest::addColumn<QQuickPopup::PopupType>("popupType");
QTest::newRow("Popup.Item") << QQuickPopup::Item;
Add arePopupWindowsSupported function to QQuickControlsTestUtils And reduce a few duplicate checks throughout our tests. Pick-to: 6.8 6.9 Change-Id: I31610f07eb548282ade5573af56ffef18d33cd66 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2025-03-25 05:26:26 +00:00
if (arePopupWindowsSupported())
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
QTest::newRow("Popup.Window") << QQuickPopup::Window;
}
Rename tst_menu to tst_QQuickMenu Change-Id: I1c7e1a2b337e9d16bc6c9b098db08f29f1b9d1e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 13:14:32 +00:00
void tst_QQuickMenu::mouse()
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
{
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
Move duplicate mouse hover checks into a skip macro Similar to 8d454b26263e5333d8475bbab91d7b3d1d5e04d8 and f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Pick-to: 6.5 6.8 Change-Id: Iaf9a4edc8a3c37f232ad3b66923864f4baa02d4d Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2024-11-21 06:54:21 +00:00
SKIP_IF_NO_MOUSE_HOVER;
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
QFETCH(QQuickPopup::PopupType, popupType);
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("applicationwindow.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
auto tests: allow using QQuickWindow with QQuickApplicationHelper This allows us to run the relevant popup tests for both QQuickWindow and QQuickApplicationWindow. Change-Id: I14b6435afeeb8a6cf640d8c52ad1d9e1fae070b0 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-09-03 13:15:53 +00:00
QQuickApplicationWindow *window = helper.appWindow;
Fix failing tests in tst_menu and tst_qquickmenubar As mentioned in the bug report for the failing tst_qquickmenubar test, the window is sometimes opened at the bottom right corner of the screen on the Ubuntu CI machines. However, even after centering the window on the screen, the old setPos() call still caused the tests to fail. So, we position the cursor past a different corner of the window, which works.. though I don't know why. Task-number: QTBUG-62363 Task-number: QTBUG-62383 Change-Id: I3649230002eaac5a6391daff24427e6f9f58cfa5 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2017-08-09 10:51:40 +00:00
centerOnScreen(window);
Stabilize tst_menu Add QQuickVisualTestUtil::moveMouseAway() (adapted from qtdeclarative) to help with testing menus that are now highlighting items on hover. It is important to move the mouse cursor away outside the window in such tests where hover highlight might conflict with the test. Change-Id: If3d642dd4f3ba2936a0d22c078d8fb0125d16c6c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-10 08:18:21 +00:00
moveMouseAway(window);
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
window->show();
tst_qquickmenu: call requestActivate before QTest::qWaitForWindowActive On a Ubuntu 22.04.4 VM, every test after the first one that didn't call requestActivate before QTest::qWaitForWindowActive would fail: qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in "" ********* Start testing of tst_QQuickMenu ********* Config: Using QtTest library 6.8.0, Qt 6.8.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 11.4.0), ubuntu 22.04 PASS : tst_QQuickMenu::Basic::initTestCase() PASS : tst_QQuickMenu::Basic::defaults() PASS : tst_QQuickMenu::Basic::count() PASS : tst_QQuickMenu::Basic::mouse() PASS : tst_QQuickMenu::Basic::pressAndHold() PASS : tst_QQuickMenu::Basic::contextMenuKeyboard() PASS : tst_QQuickMenu::Basic::disabledMenuItemKeyNavigation() PASS : tst_QQuickMenu::Basic::mnemonics() PASS : tst_QQuickMenu::Basic::menuButton() PASS : tst_QQuickMenu::Basic::addItem() FAIL! : tst_QQuickMenu::Basic::menuSeparator() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(697)] PASS : tst_QQuickMenu::Basic::repeater() PASS : tst_QQuickMenu::Basic::order() PASS : tst_QQuickMenu::Basic::popup() PASS : tst_QQuickMenu::Basic::actions() FAIL! : tst_QQuickMenu::Basic::actionShortcuts() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1084)] PASS : tst_QQuickMenu::Basic::removeTakeItem() PASS : tst_QQuickMenu::Basic::subMenuMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuMouse(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(non-cascading) FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuWithIcon() PASS : tst_QQuickMenu::Basic::addRemoveSubMenus() PASS : tst_QQuickMenu::Basic::scrollable(Window) PASS : tst_QQuickMenu::Basic::scrollable(ApplicationWindow) PASS : tst_QQuickMenu::Basic::scrollable(WithPadding) PASS : tst_QQuickMenu::Basic::scrollable(FixedHeight) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with no Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared inside) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with no Action) PASS : tst_QQuickMenu::Basic::menuItemWidth(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidth(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterRetranslate() FAIL! : tst_QQuickMenu::Basic::giveMenuItemFocusOnButtonPress() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(2097)] PASS : tst_QQuickMenu::Basic::customMenuCullItems() PASS : tst_QQuickMenu::Basic::customMenuUseRepeaterAsTheContentItem() PASS : tst_QQuickMenu::Basic::invalidUrlInImgTag() PASS : tst_QQuickMenu::Basic::nativeStatic() PASS : tst_QQuickMenu::Basic::nativeDynamicActions() PASS : tst_QQuickMenu::Basic::nativeDynamicSubmenus() PASS : tst_QQuickMenu::Basic::nativeMenuSeparator() PASS : tst_QQuickMenu::Basic::dontUseNativeMenuWindowsChanges() PASS : tst_QQuickMenu::Basic::nativeMixedItems() PASS : tst_QQuickMenu::Basic::cleanupTestCase() Totals: 59 passed, 11 failed, 0 skipped, 0 blacklisted, 74936ms ********* Finished testing of tst_QQuickMenu ********* Change-Id: I5ef76d2648fc7c8732aafab3a9a0a02844075c3e Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-20 07:33:47 +00:00
window->requestActivate();
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
QVERIFY(QTest::qWaitForWindowActive(window));
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
ApplicationWindow: remove deprecated overlay API [ChangeLog][Controls][ApplicationWindow] The deprecated overlay properties and attached API were removed. Use the Overlay attached type instead. Task-number: QTBUG-84715 Change-Id: I0781ea55ea502ffe5277385e82492291724d2090 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 11:31:53 +00:00
QVERIFY(menu);
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
QQuickMenuPrivate *menuPrivate = QQuickMenuPrivate::get(menu);
QVERIFY(menuPrivate);
menu->setPopupType(popupType);
Popup: rename show()/hide() to open()/close() QML popups have traditionally used more explicit open() and close(). Renaming them to show() and hide() at this stage doesn't seem to have any real advantages. Change-Id: I1e7c8c4817c67e62cef965525e00f5bf125a7d76 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-12-11 14:34:55 +00:00
menu->open();
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(menu->isOpened());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
QQuickItem *parentItem = nullptr;
if (!menuPrivate->usePopupWindow()) {
parentItem = window->property("overlay").value<QQuickOverlay*>();
} else {
QTRY_VERIFY(menuPrivate->popupWindow);
parentItem = menuPrivate->popupWindow->contentItem();
QVERIFY(QTest::qWaitForWindowExposed(menuPrivate->popupWindow));
QQuickTest::qWaitForPolish(menuPrivate->popupWindow);
}
QVERIFY(parentItem);
QVERIFY(parentItem->childItems().contains(menu->contentItem()->parentItem()));
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QQuickItem *firstItem = menu->itemAt(0);
AbstractButton: remove the mouse params from signals If we ever want to expose these, the name would be something else than "mouse"... :) Change-Id: Ie9dad16e84708059fd0b43d4764925db7b014d64 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2016-01-25 14:14:27 +00:00
QSignalSpy clickedSpy(firstItem, SIGNAL(clicked()));
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QSignalSpy triggeredSpy(firstItem, SIGNAL(triggered()));
QSignalSpy visibleSpy(menu, SIGNAL(visibleChanged()));
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
QCOMPARE(menu->currentIndex(), -1);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
// Ensure that presses cause the current index to change,
// so that the highlight acts as a way of illustrating press state.
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
QTest::mousePress(window, Qt::LeftButton, Qt::NoModifier, window->mapFromGlobal(firstItem->mapToGlobal(firstItem->boundingRect().center()).toPoint()));
QTRY_COMPARE(menu->currentIndex(), 0);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QTRY_VERIFY_ACTIVE_FOCUS(firstItem);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(0));
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
QTest::mouseRelease(window, Qt::LeftButton, Qt::NoModifier, window->mapFromGlobal(firstItem->mapToGlobal(firstItem->boundingRect().center()).toPoint()));
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(clickedSpy.size(), 1);
QCOMPARE(triggeredSpy.size(), 1);
QTRY_COMPARE(visibleSpy.size(), 1);
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(!menu->isVisible());
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
QVERIFY(!parentItem->childItems().contains(menu->contentItem()));
QTRY_COMPARE(menu->currentIndex(), -1);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(-1));
Popup: rename show()/hide() to open()/close() QML popups have traditionally used more explicit open() and close(). Renaming them to show() and hide() at this stage doesn't seem to have any real advantages. Change-Id: I1e7c8c4817c67e62cef965525e00f5bf125a7d76 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-12-11 14:34:55 +00:00
menu->open();
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
if (auto *popupWindow = menuPrivate->popupWindow)
QVERIFY(QTest::qWaitForWindowExposed(popupWindow));
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(visibleSpy.size(), 2);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(menu->isVisible());
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
QVERIFY(parentItem->childItems().contains(menu->contentItem()->parentItem()));
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(menu->isOpened());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
// Ensure that we have enough space to click outside of the menu.
tst_QQuickMenu::mouse: ensure we click outside of the menu For some reason the test used the contentItem's boundaries, but the size of the menu (including the background) can be bigger than that. Fixes: QTBUG-133380 Pick-to: 6.5 6.8 6.9 Change-Id: I6adc0cf103322040795b566915db6b0bd423f57c Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-03 04:48:40 +00:00
QVERIFY(window->width() > menu->width());
QVERIFY(window->height() > menu->height());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier,
tst_QQuickMenu::mouse: ensure we click outside of the menu For some reason the test used the contentItem's boundaries, but the size of the menu (including the background) can be bigger than that. Fixes: QTBUG-133380 Pick-to: 6.5 6.8 6.9 Change-Id: I6adc0cf103322040795b566915db6b0bd423f57c Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-03 04:48:40 +00:00
QPoint(menu->x() + menu->width() + 1, menu->y() + menu->height() + 1));
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(visibleSpy.size(), 3);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(!menu->isVisible());
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
if (menuPrivate->usePopupWindow())
QVERIFY(!menuPrivate->popupWindow->isVisible());
else
QVERIFY(!parentItem->childItems().contains(menu->contentItem()->parentItem()));
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
Popup: rename show()/hide() to open()/close() QML popups have traditionally used more explicit open() and close(). Renaming them to show() and hide() at this stage doesn't seem to have any real advantages. Change-Id: I1e7c8c4817c67e62cef965525e00f5bf125a7d76 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-12-11 14:34:55 +00:00
menu->open();
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
if (auto *popupWindow = menuPrivate->popupWindow)
QVERIFY(QTest::qWaitForWindowExposed(popupWindow));
QTRY_COMPARE(visibleSpy.size(), 4);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(menu->isVisible());
Make tst_QQuickMenu::mouse work with PopupType Item and Window The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-20 13:50:06 +00:00
QVERIFY(parentItem->childItems().contains(menu->contentItem()->parentItem()));
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(menu->isOpened());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
// Hover-highlighting does not work on Android
#ifndef Q_OS_ANDROID
QQuickMenu: update the highlighted item on mouse hover This is the expected behavior on desktop. NOTE: It must be possible to mix mouse hover highlighting, and keyboard navigation in the way that keyboard navigation must seamlessly continue from the item that was previously mouse highlighted. Furthermore, there should be only one item highlighted at a time. In order to be able to respect keyboard navigation while another item is hovered and vice versa, the visual highlight should be bound to MenuItem::highlighted instead of Control::activeFocus or Control::hovered. [ChangeLog][Controls][MenuItem] Menu has been fixed to highlight its items while key navigating and mouse hovering to ensure seamless item highlight between mouse hover and key navigation. In order to provide appropriate highlighting that works for key navigation and mouse hover, styles should bind their visual highlight to MenuItem::highlighted instead of Control::activeFocus or Control::hovered. Change-Id: I70cad5a5b441f2616d1ce2166e97974dc1ae063f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-06 13:58:36 +00:00
// Hover-highlight through the menu items one by one
QQuickItem *prevHoverItem = nullptr;
QQuickItem *listView = menu->contentItem();
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
for (int y = menu->topPadding(); y < listView->height(); ++y) {
QQuickMenu: update the highlighted item on mouse hover This is the expected behavior on desktop. NOTE: It must be possible to mix mouse hover highlighting, and keyboard navigation in the way that keyboard navigation must seamlessly continue from the item that was previously mouse highlighted. Furthermore, there should be only one item highlighted at a time. In order to be able to respect keyboard navigation while another item is hovered and vice versa, the visual highlight should be bound to MenuItem::highlighted instead of Control::activeFocus or Control::hovered. [ChangeLog][Controls][MenuItem] Menu has been fixed to highlight its items while key navigating and mouse hovering to ensure seamless item highlight between mouse hover and key navigation. In order to provide appropriate highlighting that works for key navigation and mouse hover, styles should bind their visual highlight to MenuItem::highlighted instead of Control::activeFocus or Control::hovered. Change-Id: I70cad5a5b441f2616d1ce2166e97974dc1ae063f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-06 13:58:36 +00:00
QQuickItem *hoverItem = nullptr;
QVERIFY(QMetaObject::invokeMethod(listView, "itemAt", Q_RETURN_ARG(QQuickItem *, hoverItem), Q_ARG(qreal, 0), Q_ARG(qreal, listView->property("contentY").toReal() + y)));
if (!hoverItem || !hoverItem->isVisible() || hoverItem == prevHoverItem)
continue;
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTest::mouseMove(window, QPoint(
tst_qquickmenu: Fix click position and wait for menu opened() signal - When clicking on the menu, take into account the menu's coordinates as this may not always be (0,0) depending on the style-specific margins. - Wait for the menu enter transitions to finish before trying to interact with it, otherwise it leads to flakiness. - Explicitly set the overlap property to 0 when testing the submenus as the test relies on the menuItem to be clickable and not hidden by an overlapping subMenu item. Pick-to: 6.2 6.3 6.4 Change-Id: I561f47e69b2c9ee12c46f6accacd06e22b448df5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-07-20 15:55:21 +00:00
menu->x() + menu->leftPadding() + hoverItem->x() + hoverItem->width() / 2,
menu->y() + menu->topPadding() + hoverItem->y() + hoverItem->height() / 2));
QQuickMenu: update the highlighted item on mouse hover This is the expected behavior on desktop. NOTE: It must be possible to mix mouse hover highlighting, and keyboard navigation in the way that keyboard navigation must seamlessly continue from the item that was previously mouse highlighted. Furthermore, there should be only one item highlighted at a time. In order to be able to respect keyboard navigation while another item is hovered and vice versa, the visual highlight should be bound to MenuItem::highlighted instead of Control::activeFocus or Control::hovered. [ChangeLog][Controls][MenuItem] Menu has been fixed to highlight its items while key navigating and mouse hovering to ensure seamless item highlight between mouse hover and key navigation. In order to provide appropriate highlighting that works for key navigation and mouse hover, styles should bind their visual highlight to MenuItem::highlighted instead of Control::activeFocus or Control::hovered. Change-Id: I70cad5a5b441f2616d1ce2166e97974dc1ae063f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-06 13:58:36 +00:00
QTRY_VERIFY(hoverItem->property("highlighted").toBool());
if (prevHoverItem)
QVERIFY(!prevHoverItem->property("highlighted").toBool());
prevHoverItem = hoverItem;
}
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
#endif
QQuickMenu: update the highlighted item on mouse hover This is the expected behavior on desktop. NOTE: It must be possible to mix mouse hover highlighting, and keyboard navigation in the way that keyboard navigation must seamlessly continue from the item that was previously mouse highlighted. Furthermore, there should be only one item highlighted at a time. In order to be able to respect keyboard navigation while another item is hovered and vice versa, the visual highlight should be bound to MenuItem::highlighted instead of Control::activeFocus or Control::hovered. [ChangeLog][Controls][MenuItem] Menu has been fixed to highlight its items while key navigating and mouse hovering to ensure seamless item highlight between mouse hover and key navigation. In order to provide appropriate highlighting that works for key navigation and mouse hover, styles should bind their visual highlight to MenuItem::highlighted instead of Control::activeFocus or Control::hovered. Change-Id: I70cad5a5b441f2616d1ce2166e97974dc1ae063f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-06 13:58:36 +00:00
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
// Try pressing within the menu and releasing outside of it; it should close.
Rename Panel to Popup Popup is a more descriptive name. Furthermore, this name change opens the door for another type called Pane. It gives the appropriate background color for the current style & theme. Change-Id: Idb91d37e807f62e870b50f0b656e84ee2d43a9fb Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-12-08 13:26:51 +00:00
// TODO: won't work until QQuickPopup::releasedOutside() actually gets emitted
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
// QTest::mousePress(window, Qt::LeftButton, Qt::NoModifier, QPoint(firstItem->width() / 2, firstItem->height() / 2));
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
// QVERIFY_ACTIVE_FOCUS(firstItem);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
// QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(0));
// QVERIFY(menu->isVisible());
// QCOMPARE(triggeredSpy.count(), 1);
// QTest::mouseRelease(window, Qt::LeftButton, Qt::NoModifier, QPoint(menu->contentItem()->width() + 1, firstItem->height() / 2));
// QCOMPARE(clickedSpy.count(), 1);
// QCOMPARE(triggeredSpy.count(), 1);
// QCOMPARE(visibleSpy.count(), 5);
// QVERIFY(!menu->isVisible());
ApplicationWindow: remove deprecated overlay API [ChangeLog][Controls][ApplicationWindow] The deprecated overlay properties and attached API were removed. Use the Overlay attached type instead. Task-number: QTBUG-84715 Change-Id: I0781ea55ea502ffe5277385e82492291724d2090 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 11:31:53 +00:00
// QVERIFY(!overlay->childItems().contains(menu->contentItem()));
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
// QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(-1));
}
Rename tst_menu to tst_QQuickMenu Change-Id: I1c7e1a2b337e9d16bc6c9b098db08f29f1b9d1e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 13:14:32 +00:00
void tst_QQuickMenu::pressAndHold()
QQuickMenu: fix press-and-hold support Remove the OnReleaseOutside close policy, just use the defaults from QQuickPopup. This way menus won't get immediately closed on release, when opened from an onPressAndHold signal handler. Task-number: QTBUG-61608 Change-Id: Ifedd596aa0e71ac5f4211fa42e2ae499918df1b2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 11:15:24 +00:00
{
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("pressAndHold.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
QQuickMenu: fix press-and-hold support Remove the OnReleaseOutside close policy, just use the defaults from QQuickPopup. This way menus won't get immediately closed on release, when opened from an onPressAndHold signal handler. Task-number: QTBUG-61608 Change-Id: Ifedd596aa0e71ac5f4211fa42e2ae499918df1b2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 11:15:24 +00:00
QQuickWindow *window = helper.window;
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu: fix press-and-hold support Remove the OnReleaseOutside close policy, just use the defaults from QQuickPopup. This way menus won't get immediately closed on release, when opened from an onPressAndHold signal handler. Task-number: QTBUG-61608 Change-Id: Ifedd596aa0e71ac5f4211fa42e2ae499918df1b2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 11:15:24 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QVERIFY(menu);
QTest::mousePress(window, Qt::LeftButton, Qt::NoModifier, QPoint(1, 1));
QTRY_VERIFY(menu->isVisible());
QTest::mouseRelease(window, Qt::LeftButton, Qt::NoModifier, QPoint(1, 1));
QVERIFY(menu->isVisible());
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier, QPoint(1, 1));
QTRY_VERIFY(!menu->isVisible());
}
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
void tst_QQuickMenu::contextMenuKeyboard_data()
{
QTest::addColumn<QQuickPopup::PopupType>("popupType");
QTest::newRow("Popup.Item") << QQuickPopup::Item;
QTest::newRow("Popup.Window") << QQuickPopup::Window;
}
Rename tst_menu to tst_QQuickMenu Change-Id: I1c7e1a2b337e9d16bc6c9b098db08f29f1b9d1e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 13:14:32 +00:00
void tst_QQuickMenu::contextMenuKeyboard()
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
{
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
QFETCH(QQuickPopup::PopupType, popupType);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
if (QGuiApplication::styleHints()->tabFocusBehavior() != Qt::TabFocusAllControls)
QSKIP("This platform only allows tab focus for text controls");
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("applicationwindow.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
auto tests: allow using QQuickWindow with QQuickApplicationHelper This allows us to run the relevant popup tests for both QQuickWindow and QQuickApplicationWindow. Change-Id: I14b6435afeeb8a6cf640d8c52ad1d9e1fae070b0 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-09-03 13:15:53 +00:00
QQuickApplicationWindow *window = helper.appWindow;
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
centerOnScreen(window);
moveMouseAway(window);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
QVERIFY(QGuiApplication::focusWindow() == window);
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
QVERIFY(menu);
QQuickMenuPrivate *menuPrivate = QQuickMenuPrivate::get(menu);
QVERIFY(menuPrivate);
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), -1);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(-1));
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
menu->setPopupType(popupType);
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QQuickMenuItem *firstItem = qobject_cast<QQuickMenuItem *>(menu->itemAt(0));
QVERIFY(firstItem);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QSignalSpy visibleSpy(menu, SIGNAL(visibleChanged()));
Give Dialogs and Menus focus by default Dialogs and Menus should always have focus when they're opened, especially now that the cancel key handling in QQuickPopup/QQuickPopupItem is done via regular key events and not shortcuts, as popups will now require focus in order to be cancelled via keyboard. [ChangeLog][Controls][Important Behavior Changes] Dialogs and Menus now have their focus property set to true by default. Popups are unchanged, meaning that popups that should be interacted with via keyboard (including cancelling) should have focus set to true or forceActiveFocus() called on them after opening. Task-number: QTBUG-79280 Change-Id: Idd070f2b1e8180a34a0dadb6e11dc56e531df211 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-02-25 08:43:45 +00:00
QVERIFY(menu->hasFocus());
Popup: rename show()/hide() to open()/close() QML popups have traditionally used more explicit open() and close(). Renaming them to show() and hide() at this stage doesn't seem to have any real advantages. Change-Id: I1e7c8c4817c67e62cef965525e00f5bf125a7d76 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-12-11 14:34:55 +00:00
menu->open();
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
QQuickItem *parentItem = nullptr;
if (!menuPrivate->usePopupWindow()) {
parentItem = window->property("overlay").value<QQuickOverlay*>();
} else {
QTRY_VERIFY(menuPrivate->popupWindow);
parentItem = menuPrivate->popupWindow->contentItem();
QVERIFY(QTest::qWaitForWindowExposed(menuPrivate->popupWindow));
QQuickTest::qWaitForPolish(menuPrivate->popupWindow);
}
QTRY_VERIFY(menu->isOpened());
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(visibleSpy.size(), 1);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(menu);
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
QVERIFY(parentItem);
QVERIFY(parentItem->childItems().contains(menu->contentItem()->parentItem()));
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(!firstItem->hasActiveFocus());
QQuickMenu: update the highlighted item on mouse hover This is the expected behavior on desktop. NOTE: It must be possible to mix mouse hover highlighting, and keyboard navigation in the way that keyboard navigation must seamlessly continue from the item that was previously mouse highlighted. Furthermore, there should be only one item highlighted at a time. In order to be able to respect keyboard navigation while another item is hovered and vice versa, the visual highlight should be bound to MenuItem::highlighted instead of Control::activeFocus or Control::hovered. [ChangeLog][Controls][MenuItem] Menu has been fixed to highlight its items while key navigating and mouse hovering to ensure seamless item highlight between mouse hover and key navigation. In order to provide appropriate highlighting that works for key navigation and mouse hover, styles should bind their visual highlight to MenuItem::highlighted instead of Control::activeFocus or Control::hovered. Change-Id: I70cad5a5b441f2616d1ce2166e97974dc1ae063f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-06 13:58:36 +00:00
QVERIFY(!firstItem->property("highlighted").toBool());
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), -1);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(-1));
QTest::keyClick(window, Qt::Key_Tab);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(firstItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(firstItem);
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(firstItem->isHighlighted());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(firstItem->focusReason(), Qt::TabFocusReason);
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), 0);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(0));
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QQuickMenuItem *secondItem = qobject_cast<QQuickMenuItem *>(menu->itemAt(1));
QVERIFY(secondItem);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QTest::keyClick(window, Qt::Key_Tab);
QVERIFY(!firstItem->hasActiveFocus());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QVERIFY(!firstItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!firstItem->isHighlighted());
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(secondItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(secondItem);
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(secondItem->isHighlighted());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(secondItem->focusReason(), Qt::TabFocusReason);
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), 1);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(1));
QSignalSpy secondTriggeredSpy(secondItem, SIGNAL(triggered()));
QTest::keyClick(window, Qt::Key_Space);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(secondTriggeredSpy.size(), 1);
QTRY_COMPARE(visibleSpy.size(), 2);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(!menu->isVisible());
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
QVERIFY(!parentItem->childItems().contains(menu->contentItem()));
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(!firstItem->hasActiveFocus());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QVERIFY(!firstItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!firstItem->isHighlighted());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(!secondItem->hasActiveFocus());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QVERIFY(!secondItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!secondItem->isHighlighted());
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), -1);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(-1));
QQuickMenu: allow enter/return to be used to activate items Before this patch, only space was allowed. Windows 10 and macOS 10.14.2 both allow using enter to activate menu items. Change-Id: I64476347669ff73f233efd129563a18ba51618a5 Fixes: QTBUG-73354 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-02-01 15:03:56 +00:00
// Enter/return should also work.
// Open the menu.
Popup: rename show()/hide() to open()/close() QML popups have traditionally used more explicit open() and close(). Renaming them to show() and hide() at this stage doesn't seem to have any real advantages. Change-Id: I1e7c8c4817c67e62cef965525e00f5bf125a7d76 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-12-11 14:34:55 +00:00
menu->open();
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(menu->isOpened());
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
QCOMPARE(visibleSpy.size(), 3);
if (auto *popupWindow = menuPrivate->popupWindow) {
QVERIFY(QTest::qWaitForWindowExposed(popupWindow));
QVERIFY(QQuickTest::qWaitForPolish(popupWindow));
}
QQuickMenu: allow enter/return to be used to activate items Before this patch, only space was allowed. Windows 10 and macOS 10.14.2 both allow using enter to activate menu items. Change-Id: I64476347669ff73f233efd129563a18ba51618a5 Fixes: QTBUG-73354 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-02-01 15:03:56 +00:00
// Give the first item focus.
QTest::keyClick(window, Qt::Key_Tab);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(firstItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(firstItem);
QQuickMenu: allow enter/return to be used to activate items Before this patch, only space was allowed. Windows 10 and macOS 10.14.2 both allow using enter to activate menu items. Change-Id: I64476347669ff73f233efd129563a18ba51618a5 Fixes: QTBUG-73354 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-02-01 15:03:56 +00:00
QVERIFY(firstItem->isHighlighted());
QCOMPARE(firstItem->focusReason(), Qt::TabFocusReason);
QCOMPARE(menu->currentIndex(), 0);
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(0));
// Press enter.
QSignalSpy firstTriggeredSpy(firstItem, SIGNAL(triggered()));
QTest::keyClick(window, Qt::Key_Return);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(firstTriggeredSpy.size(), 1);
QTRY_COMPARE(visibleSpy.size(), 4);
QQuickMenu: allow enter/return to be used to activate items Before this patch, only space was allowed. Windows 10 and macOS 10.14.2 both allow using enter to activate menu items. Change-Id: I64476347669ff73f233efd129563a18ba51618a5 Fixes: QTBUG-73354 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-02-01 15:03:56 +00:00
QVERIFY(!menu->isVisible());
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
QVERIFY(!parentItem->childItems().contains(menu->contentItem()));
QQuickMenu: allow enter/return to be used to activate items Before this patch, only space was allowed. Windows 10 and macOS 10.14.2 both allow using enter to activate menu items. Change-Id: I64476347669ff73f233efd129563a18ba51618a5 Fixes: QTBUG-73354 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-02-01 15:03:56 +00:00
QVERIFY(!firstItem->hasActiveFocus());
QVERIFY(!firstItem->hasVisualFocus());
QVERIFY(!firstItem->isHighlighted());
QVERIFY(!secondItem->hasActiveFocus());
QVERIFY(!secondItem->hasVisualFocus());
QVERIFY(!secondItem->isHighlighted());
QCOMPARE(menu->currentIndex(), -1);
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(-1));
menu->open();
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
if (auto *popupWindow = menuPrivate->popupWindow) {
QVERIFY(QTest::qWaitForWindowExposed(popupWindow));
QVERIFY(QQuickTest::qWaitForPolish(popupWindow));
}
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(menu->isOpened());
Make tst_QQuickMenu::contextMenuKeyboard work with popup windows The test would fail if popup windows were enabled. By making the test data driven, and fixing it so that it works with and without popup windows enabled, we'll ensure that regressions are detected, regardless of popupType. It's also needed if we decide to change the default behavior in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ia3da9c810a313c2b5e847f70d70ac36ec74d672d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 14:08:13 +00:00
QCOMPARE(visibleSpy.size(), 5);
QVERIFY(parentItem->childItems().contains(menu->contentItem()->parentItem()));
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(!firstItem->hasActiveFocus());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QVERIFY(!firstItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!firstItem->isHighlighted());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(!secondItem->hasActiveFocus());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QVERIFY(!secondItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!secondItem->isHighlighted());
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), -1);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(-1));
QTest::keyClick(window, Qt::Key_Down);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(firstItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(firstItem);
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(firstItem->isHighlighted());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(firstItem->focusReason(), Qt::TabFocusReason);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QTest::keyClick(window, Qt::Key_Down);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(secondItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(secondItem);
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(secondItem->isHighlighted());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(secondItem->focusReason(), Qt::TabFocusReason);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QTest::keyClick(window, Qt::Key_Down);
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QQuickMenuItem *thirdItem = qobject_cast<QQuickMenuItem *>(menu->itemAt(2));
QVERIFY(thirdItem);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(!firstItem->hasActiveFocus());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QVERIFY(!firstItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!firstItem->isHighlighted());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(!secondItem->hasActiveFocus());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QVERIFY(!secondItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!secondItem->isHighlighted());
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(thirdItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(thirdItem);
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(thirdItem->isHighlighted());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(thirdItem->focusReason(), Qt::TabFocusReason);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
// Key navigation shouldn't wrap by default.
QTest::keyClick(window, Qt::Key_Down);
QVERIFY(!firstItem->hasActiveFocus());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QVERIFY(!firstItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!firstItem->isHighlighted());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(!secondItem->hasActiveFocus());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QVERIFY(!secondItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!secondItem->isHighlighted());
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(thirdItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(thirdItem);
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(thirdItem->isHighlighted());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(thirdItem->focusReason(), Qt::TabFocusReason);
QTest::keyClick(window, Qt::Key_Up);
QVERIFY(!firstItem->hasActiveFocus());
QVERIFY(!firstItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!firstItem->isHighlighted());
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(secondItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(secondItem);
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(secondItem->isHighlighted());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(secondItem->focusReason(), Qt::BacktabFocusReason);
QVERIFY(!thirdItem->hasActiveFocus());
QVERIFY(!thirdItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!thirdItem->isHighlighted());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QTest::keyClick(window, Qt::Key_Backtab);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(firstItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(firstItem);
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(firstItem->isHighlighted());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(firstItem->focusReason(), Qt::BacktabFocusReason);
QVERIFY(!secondItem->hasActiveFocus());
QVERIFY(!secondItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!secondItem->isHighlighted());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QVERIFY(!thirdItem->hasActiveFocus());
QVERIFY(!thirdItem->hasVisualFocus());
Merge remote-tracking branch 'origin/5.9' into dev Conflicts: src/imports/controls/ButtonGroup.qml tests/auto/controls/data/tst_container.qml tests/auto/menu/tst_menu.cpp Change-Id: Ie8ee7e4f83f3fda6a09507b060576ebda929a7cd
2017-06-15 09:41:19 +00:00
QVERIFY(!thirdItem->isHighlighted());
Make Qt::Key_Escape close Menu Change-Id: Ib7d74b556378f7ec5ac3156c92a02d6834bff82e Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-03 09:29:00 +00:00
QTest::keyClick(window, Qt::Key_Escape);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(visibleSpy.size(), 6);
Make Qt::Key_Escape close Menu Change-Id: Ib7d74b556378f7ec5ac3156c92a02d6834bff82e Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-12-03 09:29:00 +00:00
QVERIFY(!menu->isVisible());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
}
QQuickMenu: don't give focus to disabled menu items Change-Id: I7eb394ca3991eae585fbbd8e665c46b11ef64a07 Fixes: QTBUG-70181 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2019-02-01 12:53:06 +00:00
// QTBUG-70181
void tst_QQuickMenu::disabledMenuItemKeyNavigation()
{
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QQuickMenu: don't give focus to disabled menu items Change-Id: I7eb394ca3991eae585fbbd8e665c46b11ef64a07 Fixes: QTBUG-70181 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2019-02-01 12:53:06 +00:00
if (QGuiApplication::styleHints()->tabFocusBehavior() != Qt::TabFocusAllControls)
QSKIP("This platform only allows tab focus for text controls");
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("disabledMenuItemKeyNavigation.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
QQuickMenu: don't give focus to disabled menu items Change-Id: I7eb394ca3991eae585fbbd8e665c46b11ef64a07 Fixes: QTBUG-70181 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2019-02-01 12:53:06 +00:00
QQuickApplicationWindow *window = helper.appWindow;
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
centerOnScreen(window);
moveMouseAway(window);
QQuickMenu: don't give focus to disabled menu items Change-Id: I7eb394ca3991eae585fbbd8e665c46b11ef64a07 Fixes: QTBUG-70181 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2019-02-01 12:53:06 +00:00
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
QVERIFY(QGuiApplication::focusWindow() == window);
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QCOMPARE(menu->currentIndex(), -1);
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(-1));
QQuickMenuItem *firstItem = qobject_cast<QQuickMenuItem *>(menu->itemAt(0));
QVERIFY(firstItem);
QQuickMenuItem *secondItem = qobject_cast<QQuickMenuItem *>(menu->itemAt(1));
QVERIFY(secondItem);
QQuickMenuItem *thirdItem = qobject_cast<QQuickMenuItem *>(menu->itemAt(2));
QVERIFY(thirdItem);
menu->setFocus(true);
menu->open();
QVERIFY(menu->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(menu->isOpened());
QQuickMenu: don't give focus to disabled menu items Change-Id: I7eb394ca3991eae585fbbd8e665c46b11ef64a07 Fixes: QTBUG-70181 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2019-02-01 12:53:06 +00:00
QVERIFY(!firstItem->hasActiveFocus());
QVERIFY(!firstItem->property("highlighted").toBool());
QCOMPARE(menu->currentIndex(), -1);
QTest::keyClick(window, Qt::Key_Tab);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(firstItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(firstItem);
QQuickMenu: don't give focus to disabled menu items Change-Id: I7eb394ca3991eae585fbbd8e665c46b11ef64a07 Fixes: QTBUG-70181 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2019-02-01 12:53:06 +00:00
QVERIFY(firstItem->isHighlighted());
QCOMPARE(firstItem->focusReason(), Qt::TabFocusReason);
QCOMPARE(menu->currentIndex(), 0);
// Shouldn't be possible to give focus to a disabled menu item.
QTest::keyClick(window, Qt::Key_Down);
QVERIFY(!secondItem->hasActiveFocus());
QVERIFY(!secondItem->hasVisualFocus());
QVERIFY(!secondItem->isHighlighted());
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(thirdItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(thirdItem);
QQuickMenu: don't give focus to disabled menu items Change-Id: I7eb394ca3991eae585fbbd8e665c46b11ef64a07 Fixes: QTBUG-70181 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2019-02-01 12:53:06 +00:00
QVERIFY(thirdItem->isHighlighted());
QCOMPARE(thirdItem->focusReason(), Qt::TabFocusReason);
QTest::keyClick(window, Qt::Key_Up);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(firstItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(firstItem);
QQuickMenu: don't give focus to disabled menu items Change-Id: I7eb394ca3991eae585fbbd8e665c46b11ef64a07 Fixes: QTBUG-70181 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2019-02-01 12:53:06 +00:00
QVERIFY(firstItem->isHighlighted());
QCOMPARE(firstItem->focusReason(), Qt::BacktabFocusReason);
QTest::keyClick(window, Qt::Key_Escape);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(!menu->isVisible());
QQuickMenu: don't give focus to disabled menu items Change-Id: I7eb394ca3991eae585fbbd8e665c46b11ef64a07 Fixes: QTBUG-70181 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2019-02-01 12:53:06 +00:00
}
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::mnemonics()
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
{
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
#ifdef Q_OS_MACOS
QSKIP("Mnemonics are not used on macOS");
#endif
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("mnemonics.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
QQuickWindow *window = helper.window;
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
Menu: Close menu by Alt key on platforms supporting mnemonic shortcuts This is close to what the widget QMenu (and Windows native menu) do. Before, the active menu was left open and Alt+<key> shortcut would be delivered to one of the matching items, which might be an item shadowed by the active menu popup. With this patch, the active menu is closed on Alt key pressed so the subsequent shortcut event will (likely) be delivered to the matching MenuBar item. Since I'm going to fix the issue of &mnemonic key conflict resolution, I need to first change the way of delivering a shortcut event to the parent MenuBar. The test cases use the undocumented function to simulate low-level behavior of Alt itself and Alt+<key> events. Apparently, there's no public QTest function to send multiple key events without releasing Alt modifier. Task-number: QTBUG-86276 Pick-to: 5.15 Change-Id: I0ed6ea94f0fee7983a5cb6352d388036d3a1f8df Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-08-28 09:32:20 +00:00
MnemonicKeySimulator keySim(window);
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QQuickAction *action = window->property("action").value<QQuickAction *>();
QQuickMenuItem *menuItem = window->property("menuItem").value<QQuickMenuItem *>();
QQuickMenu *subMenu = window->property("subMenu").value<QQuickMenu *>();
QQuickMenuItem *subMenuItem = window->property("subMenuItem").value<QQuickMenuItem *>();
QVERIFY(menu && action && menuItem && subMenu && subMenuItem);
tst_qquickmenu: force some tests to use popupType: Popup.Item These tests pass with `popupType: Popup.Window` on some systems, but not on Windows. For now, we`ll just force them to use the popupType that we know works. Further investigation is needed to figure out how to make them work on Windows, and other platforms. Task-number: QTBUG-128474 Pick-to: 6.8 Change-Id: If018c9b964dcf77ec2cbf6a1ee64f2d834a47e3e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-29 12:57:04 +00:00
// TODO: QTBUG-128474
menu->setPopupType(QQuickPopup::Item);
Menu: Close menu by Alt key on platforms supporting mnemonic shortcuts This is close to what the widget QMenu (and Windows native menu) do. Before, the active menu was left open and Alt+<key> shortcut would be delivered to one of the matching items, which might be an item shadowed by the active menu popup. With this patch, the active menu is closed on Alt key pressed so the subsequent shortcut event will (likely) be delivered to the matching MenuBar item. Since I'm going to fix the issue of &mnemonic key conflict resolution, I need to first change the way of delivering a shortcut event to the parent MenuBar. The test cases use the undocumented function to simulate low-level behavior of Alt itself and Alt+<key> events. Apparently, there's no public QTest function to send multiple key events without releasing Alt modifier. Task-number: QTBUG-86276 Pick-to: 5.15 Change-Id: I0ed6ea94f0fee7983a5cb6352d388036d3a1f8df Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-08-28 09:32:20 +00:00
keySim.press(Qt::Key_Alt);
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
menu->open();
QTRY_VERIFY(menu->isOpened());
tst_qquickmenu::mnemonics: make test friendly for transitions The Material style uses enter and exit transitions, which causes the menu to not popup instantly. The test didn't take this into consideration, since it was designed with only the Basic style in mind. It should now pass with the Material style. Pick-to: 6.9 6.8 Change-Id: I1a55564438ef4d65d597123d12de1e838e55b3b5 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2025-02-07 12:00:12 +00:00
QVERIFY(QQuickTest::qWaitForPolish(window));
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
QSignalSpy actionSpy(action, &QQuickAction::triggered);
QVERIFY(actionSpy.isValid());
Menu: Close menu by Alt key on platforms supporting mnemonic shortcuts This is close to what the widget QMenu (and Windows native menu) do. Before, the active menu was left open and Alt+<key> shortcut would be delivered to one of the matching items, which might be an item shadowed by the active menu popup. With this patch, the active menu is closed on Alt key pressed so the subsequent shortcut event will (likely) be delivered to the matching MenuBar item. Since I'm going to fix the issue of &mnemonic key conflict resolution, I need to first change the way of delivering a shortcut event to the parent MenuBar. The test cases use the undocumented function to simulate low-level behavior of Alt itself and Alt+<key> events. Apparently, there's no public QTest function to send multiple key events without releasing Alt modifier. Task-number: QTBUG-86276 Pick-to: 5.15 Change-Id: I0ed6ea94f0fee7983a5cb6352d388036d3a1f8df Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-08-28 09:32:20 +00:00
keySim.click(Qt::Key_A); // "&Action"
tst_qquickmenu::mnemonics: make test friendly for transitions The Material style uses enter and exit transitions, which causes the menu to not popup instantly. The test didn't take this into consideration, since it was designed with only the Basic style in mind. It should now pass with the Material style. Pick-to: 6.9 6.8 Change-Id: I1a55564438ef4d65d597123d12de1e838e55b3b5 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2025-02-07 12:00:12 +00:00
QTRY_COMPARE(actionSpy.size(), 1);
QTRY_COMPARE(QQuickMenuPrivate::get(menu)->transitionState, QQuickPopupPrivate::NoTransition);
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
menu->open();
tst_qquickmenu::mnemonics: make test friendly for transitions The Material style uses enter and exit transitions, which causes the menu to not popup instantly. The test didn't take this into consideration, since it was designed with only the Basic style in mind. It should now pass with the Material style. Pick-to: 6.9 6.8 Change-Id: I1a55564438ef4d65d597123d12de1e838e55b3b5 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2025-02-07 12:00:12 +00:00
QTRY_VERIFY(!QQuickMenuPrivate::get(menu)->transitionManager.isRunning());
QVERIFY(menu->isOpened());
QVERIFY(QQuickTest::qWaitForPolish(window));
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
QSignalSpy menuItemSpy(menuItem, &QQuickMenuItem::triggered);
QVERIFY(menuItemSpy.isValid());
Menu: Close menu by Alt key on platforms supporting mnemonic shortcuts This is close to what the widget QMenu (and Windows native menu) do. Before, the active menu was left open and Alt+<key> shortcut would be delivered to one of the matching items, which might be an item shadowed by the active menu popup. With this patch, the active menu is closed on Alt key pressed so the subsequent shortcut event will (likely) be delivered to the matching MenuBar item. Since I'm going to fix the issue of &mnemonic key conflict resolution, I need to first change the way of delivering a shortcut event to the parent MenuBar. The test cases use the undocumented function to simulate low-level behavior of Alt itself and Alt+<key> events. Apparently, there's no public QTest function to send multiple key events without releasing Alt modifier. Task-number: QTBUG-86276 Pick-to: 5.15 Change-Id: I0ed6ea94f0fee7983a5cb6352d388036d3a1f8df Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-08-28 09:32:20 +00:00
keySim.click(Qt::Key_I); // "Menu &Item"
keySim.release(Qt::Key_Alt);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(menuItemSpy.size(), 1);
tst_qquickmenu::mnemonics: make test friendly for transitions The Material style uses enter and exit transitions, which causes the menu to not popup instantly. The test didn't take this into consideration, since it was designed with only the Basic style in mind. It should now pass with the Material style. Pick-to: 6.9 6.8 Change-Id: I1a55564438ef4d65d597123d12de1e838e55b3b5 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2025-02-07 12:00:12 +00:00
QTRY_COMPARE(QQuickMenuPrivate::get(menu)->transitionState, QQuickPopupPrivate::NoTransition);
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
Menu: Close menu by Alt key on platforms supporting mnemonic shortcuts This is close to what the widget QMenu (and Windows native menu) do. Before, the active menu was left open and Alt+<key> shortcut would be delivered to one of the matching items, which might be an item shadowed by the active menu popup. With this patch, the active menu is closed on Alt key pressed so the subsequent shortcut event will (likely) be delivered to the matching MenuBar item. Since I'm going to fix the issue of &mnemonic key conflict resolution, I need to first change the way of delivering a shortcut event to the parent MenuBar. The test cases use the undocumented function to simulate low-level behavior of Alt itself and Alt+<key> events. Apparently, there's no public QTest function to send multiple key events without releasing Alt modifier. Task-number: QTBUG-86276 Pick-to: 5.15 Change-Id: I0ed6ea94f0fee7983a5cb6352d388036d3a1f8df Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-08-28 09:32:20 +00:00
keySim.press(Qt::Key_Alt);
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
menu->open();
tst_qquickmenu::mnemonics: make test friendly for transitions The Material style uses enter and exit transitions, which causes the menu to not popup instantly. The test didn't take this into consideration, since it was designed with only the Basic style in mind. It should now pass with the Material style. Pick-to: 6.9 6.8 Change-Id: I1a55564438ef4d65d597123d12de1e838e55b3b5 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2025-02-07 12:00:12 +00:00
QTRY_VERIFY(!QQuickMenuPrivate::get(menu)->transitionManager.isRunning());
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
QTRY_VERIFY(menu->isOpened());
tst_qquickmenu::mnemonics: make test friendly for transitions The Material style uses enter and exit transitions, which causes the menu to not popup instantly. The test didn't take this into consideration, since it was designed with only the Basic style in mind. It should now pass with the Material style. Pick-to: 6.9 6.8 Change-Id: I1a55564438ef4d65d597123d12de1e838e55b3b5 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2025-02-07 12:00:12 +00:00
QVERIFY(QQuickTest::qWaitForPolish(window));
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
Menu: Close menu by Alt key on platforms supporting mnemonic shortcuts This is close to what the widget QMenu (and Windows native menu) do. Before, the active menu was left open and Alt+<key> shortcut would be delivered to one of the matching items, which might be an item shadowed by the active menu popup. With this patch, the active menu is closed on Alt key pressed so the subsequent shortcut event will (likely) be delivered to the matching MenuBar item. Since I'm going to fix the issue of &mnemonic key conflict resolution, I need to first change the way of delivering a shortcut event to the parent MenuBar. The test cases use the undocumented function to simulate low-level behavior of Alt itself and Alt+<key> events. Apparently, there's no public QTest function to send multiple key events without releasing Alt modifier. Task-number: QTBUG-86276 Pick-to: 5.15 Change-Id: I0ed6ea94f0fee7983a5cb6352d388036d3a1f8df Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-08-28 09:32:20 +00:00
keySim.click(Qt::Key_M); // "Sub &Menu"
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
QTRY_VERIFY(subMenu->isOpened());
tst_qquickmenu::mnemonics: make test friendly for transitions The Material style uses enter and exit transitions, which causes the menu to not popup instantly. The test didn't take this into consideration, since it was designed with only the Basic style in mind. It should now pass with the Material style. Pick-to: 6.9 6.8 Change-Id: I1a55564438ef4d65d597123d12de1e838e55b3b5 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2025-02-07 12:00:12 +00:00
QVERIFY(QQuickTest::qWaitForPolish(window));
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
QSignalSpy subMenuItemSpy(subMenuItem, &QQuickMenuItem::triggered);
QVERIFY(subMenuItemSpy.isValid());
Menu: Close menu by Alt key on platforms supporting mnemonic shortcuts This is close to what the widget QMenu (and Windows native menu) do. Before, the active menu was left open and Alt+<key> shortcut would be delivered to one of the matching items, which might be an item shadowed by the active menu popup. With this patch, the active menu is closed on Alt key pressed so the subsequent shortcut event will (likely) be delivered to the matching MenuBar item. Since I'm going to fix the issue of &mnemonic key conflict resolution, I need to first change the way of delivering a shortcut event to the parent MenuBar. The test cases use the undocumented function to simulate low-level behavior of Alt itself and Alt+<key> events. Apparently, there's no public QTest function to send multiple key events without releasing Alt modifier. Task-number: QTBUG-86276 Pick-to: 5.15 Change-Id: I0ed6ea94f0fee7983a5cb6352d388036d3a1f8df Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-08-28 09:32:20 +00:00
keySim.click(Qt::Key_S); // "&Sub Menu Item"
keySim.release(Qt::Key_Alt);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(subMenuItemSpy.size(), 1);
QQuickMenu: fix mnemonics for dynamic action/submenu items Previously mnemonics worked only for "normal" menu items, but not for dynamically created menu items that present actions and sub-menus. This patch fixes the issue by specifying the menu as a QObject-parent for such dynamically created items, because QQuickShortcutContext is based on QObject-hierarchy. Change-Id: I3637ef06e9cb2a27673e4618c253279a0123b7c8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 12:23:13 +00:00
}
Menu: Activate Menu Item When Mnemonic Key is Pressed, Same as Widgets When a menu is opened, its menu items aren't triggered by pressing their mnemonic key using the Alt key. Also, aren't triggered even when their mnemonic key is pressed without the Alt key. This behavior is different from the widgets menu behavior. When the widgets menu is opened its actions can be activated by pressing their mnemonic key without holding the Alt key. When a key is pressed on QQuickMenu and no modifier is held, it loops over its items to find the item whose mnemonic key matches the key. If the item is found, the click() method will be called. The test case opens the menu and sends the press and release events with the mnemonic key of each menu item, and checks that they are triggered. When the item is checkable, the test verifies that the checkedChanged() signal is also emitted. Task-number: QTBUG-96630 Pick-to: 6.8 6.7 6.5 Change-Id: I99f27c6306e14375b45d0630e4f9047e33fa64fb Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2024-08-15 10:49:34 +00:00
#if QT_CONFIG(shortcut)
namespace CheckableMnemonics {
using MnemonicKey = std::pair<Qt::Key, QString>;
enum class MenuItemType {
Action,
MenuItem
};
enum class SignalName {
CheckedChanged = 0x01,
Triggered = 0x02,
};
Q_DECLARE_FLAGS(SignalNames, SignalName);
class ItemSignalSpy
{
public:
ItemSignalSpy(MenuItemType type, QObject *item) : item(item)
{
switch (type) {
case MenuItemType::Action:
initSignals<QQuickAction>(qobject_cast<QQuickAction *>(item));
break;
case MenuItemType::MenuItem:
initSignals<QQuickMenuItem>(qobject_cast<QQuickMenuItem *>(item));
break;
}
}
[[nodiscard]] bool isValid() const
{
return ((checkedChangedSpy && checkedChangedSpy->isValid()) &&
(triggeredSpy && triggeredSpy->isValid()));
}
[[nodiscard]] int signalSize(SignalName signal) const
{
constexpr int INVALID_SIZE = -1; // makes the test fail even when the signal is not expected
switch (signal) {
case SignalName::CheckedChanged:
return checkedChangedSpy ? checkedChangedSpy->size() : INVALID_SIZE;
case SignalName::Triggered:
return triggeredSpy ? triggeredSpy->size() : INVALID_SIZE;
}
Q_UNREACHABLE_RETURN(INVALID_SIZE);
}
private:
template<typename Item>
void initSignals(Item *item)
{
checkedChangedSpy = std::make_unique<QSignalSpy>(item, &Item::checkedChanged);
triggeredSpy = std::make_unique<QSignalSpy>(item, &Item::triggered);
}
private:
QPointer<QObject> item;
std::unique_ptr<QSignalSpy> checkedChangedSpy = nullptr;
std::unique_ptr<QSignalSpy> triggeredSpy = nullptr;
};
}
void tst_QQuickMenu::checkableMnemonics_data()
{
if (QKeySequence::mnemonic("&A").isEmpty())
QSKIP("Mnemonics are not enabled");
using namespace CheckableMnemonics;
QTest::addColumn<bool>("checkable");
QTest::addColumn<bool>("enabled");
QTest::addColumn<bool>("isSubMenu");
QTest::addColumn<MenuItemType>("itemType");
QTest::addColumn<MnemonicKey>("mnemonicKey");
QTest::addColumn<SignalNames>("expectedSignals");
QTest::addRow("checkable_enabled_action")
<< true << true << false << MenuItemType::Action << MnemonicKey{Qt::Key_A, "A"}
<< SignalNames{SignalName::Triggered, SignalName::CheckedChanged};
QTest::addRow("checkable_disabled_action")
<< true << false << false << MenuItemType::Action << MnemonicKey{Qt::Key_A, "A"}
<< SignalNames{};
QTest::addRow("uncheckable_enabled_action")
<< false << true << false << MenuItemType::Action << MnemonicKey{Qt::Key_A, "A"}
<< SignalNames{SignalName::Triggered};
QTest::addRow("uncheckable_disabled_action")
<< false << false << false << MenuItemType::Action << MnemonicKey{Qt::Key_A, "A"}
<< SignalNames{};
QTest::addRow("checkable_enabled_menuItem")
<< true << true << false << MenuItemType::MenuItem << MnemonicKey{Qt::Key_I, "I"}
<< SignalNames{SignalName::Triggered, SignalName::CheckedChanged};
QTest::addRow("checkable_disabled_menuItem")
<< true << false << false << MenuItemType::MenuItem << MnemonicKey{Qt::Key_I, "I"}
<< SignalNames{};
QTest::addRow("uncheckable_enabled_menuItem")
<< false << true << false << MenuItemType::MenuItem << MnemonicKey{Qt::Key_I, "I"}
<< SignalNames{SignalName::Triggered};
QTest::addRow("uncheckable_disabled_menuItem")
<< false << false << false << MenuItemType::MenuItem << MnemonicKey{Qt::Key_I, "I"}
<< SignalNames{};
QTest::addRow("checkable_enabled_subMenuItem")
<< true << true << true << MenuItemType::MenuItem << MnemonicKey{Qt::Key_S, "S"}
<< SignalNames{SignalName::Triggered, SignalName::CheckedChanged};
QTest::addRow("checkable_disabled_subMenuItem")
<< true << false << true << MenuItemType::MenuItem << MnemonicKey{Qt::Key_S, "S"}
<< SignalNames{};
QTest::addRow("uncheckable_enabled_subMenuItem")
<< false << true << true << MenuItemType::MenuItem << MnemonicKey{Qt::Key_S, "S"}
<< SignalNames{SignalName::Triggered};
QTest::addRow("uncheckable_disabled_subMenuItem")
<< false << false << true << MenuItemType::MenuItem << MnemonicKey{Qt::Key_S, "S"}
<< SignalNames{};
QTest::addRow("checkable_enabled_subMenuAction")
<< true << true << true << MenuItemType::Action << MnemonicKey{Qt::Key_U, "U"}
<< SignalNames{SignalName::Triggered, SignalName::CheckedChanged};
QTest::addRow("checkable_disabled_subMenuAction")
<< true << false << true << MenuItemType::Action << MnemonicKey{Qt::Key_U, "U"}
<< SignalNames{};
QTest::addRow("uncheckable_enabled_subMenuAction")
<< false << true << true << MenuItemType::Action << MnemonicKey{Qt::Key_U, "U"}
<< SignalNames{SignalName::Triggered};
QTest::addRow("uncheckable_disabled_subMenuAction")
<< false << false << true << MenuItemType::Action << MnemonicKey{Qt::Key_U, "U"}
<< SignalNames{};
}
// QTBUG-96630
void tst_QQuickMenu::checkableMnemonics()
{
using namespace CheckableMnemonics;
QFETCH(bool, checkable);
QFETCH(bool, enabled);
QFETCH(bool, isSubMenu);
QFETCH(MenuItemType, itemType);
QFETCH(MnemonicKey, mnemonicKey);
QFETCH(SignalNames, expectedSignals);
QQuickControlsApplicationHelper helper(this, QLatin1String("mnemonics.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickWindow *window = helper.window;
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
window->setProperty("checkable", checkable);
window->setProperty("enabled", enabled);
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QVERIFY(menu);
auto clickKey = [window](const MnemonicKey &mnemonic) mutable {
QTest::simulateEvent(window, true, mnemonic.first, Qt::NoModifier, mnemonic.second, false);
QTest::simulateEvent(window, false, mnemonic.first, Qt::NoModifier, mnemonic.second, false);
};
constexpr auto EMPTY_ITEM_NAME = "";
const char *itemName = EMPTY_ITEM_NAME;
switch (itemType) {
case MenuItemType::Action:
itemName = isSubMenu ? "subMenuAction" : "action";
break;
case MenuItemType::MenuItem:
itemName = isSubMenu ? "subMenuItem" : "menuItem";
break;
}
QCOMPARE_NE(itemName, EMPTY_ITEM_NAME);
QObject *menuItem = window->property(itemName).value<QObject*>();
QVERIFY(menuItem);
menu->open();
QTRY_VERIFY(menu->isOpened());
if (isSubMenu) {
QQuickMenu *subMenu = window->property("subMenu").value<QQuickMenu *>();
QVERIFY(subMenu);
clickKey(MnemonicKey{Qt::Key_M, "M"}); // "Sub &Menu"
QTRY_VERIFY(subMenu->isOpened());
}
const ItemSignalSpy itemSignalSpy(itemType, menuItem);
QVERIFY(itemSignalSpy.isValid());
clickKey(mnemonicKey);
QCOMPARE(itemSignalSpy.signalSize(SignalName::CheckedChanged),
expectedSignals & SignalName::CheckedChanged ? 1 : 0);
QCOMPARE(itemSignalSpy.signalSize(SignalName::Triggered),
expectedSignals & SignalName::Triggered ? 1 : 0);
}
#endif
Rename tst_menu to tst_QQuickMenu Change-Id: I1c7e1a2b337e9d16bc6c9b098db08f29f1b9d1e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 13:14:32 +00:00
void tst_QQuickMenu::menuButton()
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
{
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
if (QGuiApplication::styleHints()->tabFocusBehavior() != Qt::TabFocusAllControls)
QSKIP("This platform only allows tab focus for text controls");
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("applicationwindow.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
auto tests: allow using QQuickWindow with QQuickApplicationHelper This allows us to run the relevant popup tests for both QQuickWindow and QQuickApplicationWindow. Change-Id: I14b6435afeeb8a6cf640d8c52ad1d9e1fae070b0 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-09-03 13:15:53 +00:00
QQuickApplicationWindow *window = helper.appWindow;
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
QVERIFY(QGuiApplication::focusWindow() == window);
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QQuickButton *menuButton = window->property("menuButton").value<QQuickButton*>();
QSignalSpy visibleSpy(menu, SIGNAL(visibleChanged()));
menuButton->setVisible(true);
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier,
menuButton->mapToScene(QPointF(menuButton->width() / 2, menuButton->height() / 2)).toPoint());
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(visibleSpy.size(), 1);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QVERIFY(menu->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(menu->isOpened());
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
QTest::keyClick(window, Qt::Key_Tab);
QQuickItem *firstItem = menu->itemAt(0);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(firstItem);
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
}
Rename tst_menu to tst_QQuickMenu Change-Id: I1c7e1a2b337e9d16bc6c9b098db08f29f1b9d1e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 13:14:32 +00:00
void tst_QQuickMenu::addItem()
Menu: support dynamically added items in the same way as static ones Task-number: QTBUG-53274 Change-Id: I172e431cd456b91dee569b510288d0eccbdb4cef Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 11:58:05 +00:00
{
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("addItem.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
auto tests: allow using QQuickWindow with QQuickApplicationHelper This allows us to run the relevant popup tests for both QQuickWindow and QQuickApplicationWindow. Change-Id: I14b6435afeeb8a6cf640d8c52ad1d9e1fae070b0 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-09-03 13:15:53 +00:00
QQuickApplicationWindow *window = helper.appWindow;
Menu: support dynamically added items in the same way as static ones Task-number: QTBUG-53274 Change-Id: I172e431cd456b91dee569b510288d0eccbdb4cef Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 11:58:05 +00:00
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Menu: support dynamically added items in the same way as static ones Task-number: QTBUG-53274 Change-Id: I172e431cd456b91dee569b510288d0eccbdb4cef Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 11:58:05 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QVERIFY(menu);
menu->open();
QQuickMenu: cull items outside the popup Same as a055629 for QQuickSwipeView. This hides them until they become visible in the popup. Hiding them explicitly is not an option, because then they will never show up. This technique is used in QQuickItemView::initItem() and FxViewItem::setVisible(). Change-Id: I848652fd98f47b87a85f742205d1db729ad9de8d Task-number: QTBUG-53262 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-05-11 13:15:17 +00:00
QVERIFY(menu->isVisible());
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
Menu: support dynamically added items in the same way as static ones Task-number: QTBUG-53274 Change-Id: I172e431cd456b91dee569b510288d0eccbdb4cef Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 11:58:05 +00:00
QQuickItem *menuItem = menu->itemAt(0);
QQuickMenu: cull items outside the popup Same as a055629 for QQuickSwipeView. This hides them until they become visible in the popup. Hiding them explicitly is not an option, because then they will never show up. This technique is used in QQuickItemView::initItem() and FxViewItem::setVisible(). Change-Id: I848652fd98f47b87a85f742205d1db729ad9de8d Task-number: QTBUG-53262 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-05-11 13:15:17 +00:00
QVERIFY(menuItem);
QTRY_VERIFY(!QQuickItemPrivate::get(menuItem)->culled); // QTBUG-53262
Menu: support dynamically added items in the same way as static ones Task-number: QTBUG-53274 Change-Id: I172e431cd456b91dee569b510288d0eccbdb4cef Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 11:58:05 +00:00
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier,
menuItem->mapToScene(QPointF(menuItem->width() / 2, menuItem->height() / 2)).toPoint());
QQuickMenu: cull items outside the popup Same as a055629 for QQuickSwipeView. This hides them until they become visible in the popup. Hiding them explicitly is not an option, because then they will never show up. This technique is used in QQuickItemView::initItem() and FxViewItem::setVisible(). Change-Id: I848652fd98f47b87a85f742205d1db729ad9de8d Task-number: QTBUG-53262 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-05-11 13:15:17 +00:00
QTRY_VERIFY(!menu->isVisible());
Menu: support dynamically added items in the same way as static ones Task-number: QTBUG-53274 Change-Id: I172e431cd456b91dee569b510288d0eccbdb4cef Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-05-10 11:58:05 +00:00
}
Rename tst_menu to tst_QQuickMenu Change-Id: I1c7e1a2b337e9d16bc6c9b098db08f29f1b9d1e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 13:14:32 +00:00
void tst_QQuickMenu::menuSeparator()
Add MenuSeparator [ChangeLog][Controls] Added MenuSeparator to visually distinguish between groups of items in a menu. Change-Id: I7a52910b19633ed1188c90ca56c92346a28d4d5c Task-number: QTBUG-54862 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-07-21 14:04:18 +00:00
{
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("menuSeparator.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Merge remote-tracking branch 'origin/5.7' into 5.8 Change-Id: Ief98cd56abd13cfa4e30578e150207462a8243b8
2016-09-06 16:52:28 +00:00
QQuickWindow *window = helper.window;
Fix failing tests in tst_menu and tst_qquickmenubar As mentioned in the bug report for the failing tst_qquickmenubar test, the window is sometimes opened at the bottom right corner of the screen on the Ubuntu CI machines. However, even after centering the window on the screen, the old setPos() call still caused the tests to fail. So, we position the cursor past a different corner of the window, which works.. though I don't know why. Task-number: QTBUG-62363 Task-number: QTBUG-62383 Change-Id: I3649230002eaac5a6391daff24427e6f9f58cfa5 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2017-08-09 10:51:40 +00:00
centerOnScreen(window);
Yet another attempt to stabilize tst_menu We've seen a few tst_menu failures in the CI: FAIL! : tst_menu::menuSeparator() 'newMenuItem->hasActiveFocus()' returned FALSE. () Loc: [tst_menu.cpp(428)] Add moveMouseAway() calls (e81332e) to all remaining tests that test the current item or index, which can be affected by unexpected mouse hover events. Change-Id: I23b1743fcdcea5a4064fba2748426fd25274481e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 13:15:31 +00:00
moveMouseAway(window);
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
window->show();
tst_qquickmenu: call requestActivate before QTest::qWaitForWindowActive On a Ubuntu 22.04.4 VM, every test after the first one that didn't call requestActivate before QTest::qWaitForWindowActive would fail: qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in "" ********* Start testing of tst_QQuickMenu ********* Config: Using QtTest library 6.8.0, Qt 6.8.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 11.4.0), ubuntu 22.04 PASS : tst_QQuickMenu::Basic::initTestCase() PASS : tst_QQuickMenu::Basic::defaults() PASS : tst_QQuickMenu::Basic::count() PASS : tst_QQuickMenu::Basic::mouse() PASS : tst_QQuickMenu::Basic::pressAndHold() PASS : tst_QQuickMenu::Basic::contextMenuKeyboard() PASS : tst_QQuickMenu::Basic::disabledMenuItemKeyNavigation() PASS : tst_QQuickMenu::Basic::mnemonics() PASS : tst_QQuickMenu::Basic::menuButton() PASS : tst_QQuickMenu::Basic::addItem() FAIL! : tst_QQuickMenu::Basic::menuSeparator() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(697)] PASS : tst_QQuickMenu::Basic::repeater() PASS : tst_QQuickMenu::Basic::order() PASS : tst_QQuickMenu::Basic::popup() PASS : tst_QQuickMenu::Basic::actions() FAIL! : tst_QQuickMenu::Basic::actionShortcuts() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1084)] PASS : tst_QQuickMenu::Basic::removeTakeItem() PASS : tst_QQuickMenu::Basic::subMenuMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuMouse(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(non-cascading) FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuWithIcon() PASS : tst_QQuickMenu::Basic::addRemoveSubMenus() PASS : tst_QQuickMenu::Basic::scrollable(Window) PASS : tst_QQuickMenu::Basic::scrollable(ApplicationWindow) PASS : tst_QQuickMenu::Basic::scrollable(WithPadding) PASS : tst_QQuickMenu::Basic::scrollable(FixedHeight) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with no Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared inside) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with no Action) PASS : tst_QQuickMenu::Basic::menuItemWidth(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidth(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterRetranslate() FAIL! : tst_QQuickMenu::Basic::giveMenuItemFocusOnButtonPress() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(2097)] PASS : tst_QQuickMenu::Basic::customMenuCullItems() PASS : tst_QQuickMenu::Basic::customMenuUseRepeaterAsTheContentItem() PASS : tst_QQuickMenu::Basic::invalidUrlInImgTag() PASS : tst_QQuickMenu::Basic::nativeStatic() PASS : tst_QQuickMenu::Basic::nativeDynamicActions() PASS : tst_QQuickMenu::Basic::nativeDynamicSubmenus() PASS : tst_QQuickMenu::Basic::nativeMenuSeparator() PASS : tst_QQuickMenu::Basic::dontUseNativeMenuWindowsChanges() PASS : tst_QQuickMenu::Basic::nativeMixedItems() PASS : tst_QQuickMenu::Basic::cleanupTestCase() Totals: 59 passed, 11 failed, 0 skipped, 0 blacklisted, 74936ms ********* Finished testing of tst_QQuickMenu ********* Change-Id: I5ef76d2648fc7c8732aafab3a9a0a02844075c3e Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-20 07:33:47 +00:00
window->requestActivate();
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
QVERIFY(QTest::qWaitForWindowActive(window));
Add MenuSeparator [ChangeLog][Controls] Added MenuSeparator to visually distinguish between groups of items in a menu. Change-Id: I7a52910b19633ed1188c90ca56c92346a28d4d5c Task-number: QTBUG-54862 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-07-21 14:04:18 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QVERIFY(menu);
menu->open();
QVERIFY(menu->isVisible());
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
Add MenuSeparator [ChangeLog][Controls] Added MenuSeparator to visually distinguish between groups of items in a menu. Change-Id: I7a52910b19633ed1188c90ca56c92346a28d4d5c Task-number: QTBUG-54862 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-07-21 14:04:18 +00:00
QQuickMenuItem *newMenuItem = qobject_cast<QQuickMenuItem*>(menu->itemAt(0));
QVERIFY(newMenuItem);
QCOMPARE(newMenuItem->text(), QStringLiteral("New"));
QQuickMenuSeparator *menuSeparator = qobject_cast<QQuickMenuSeparator*>(menu->itemAt(1));
QVERIFY(menuSeparator);
QQuickMenuItem *saveMenuItem = qobject_cast<QQuickMenuItem*>(menu->itemAt(2));
QVERIFY(saveMenuItem);
QCOMPARE(saveMenuItem->text(), QStringLiteral("Save"));
QTRY_VERIFY(!QQuickItemPrivate::get(saveMenuItem)->culled); // QTBUG-53262
// Clicking on items should still close the menu.
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier,
newMenuItem->mapToScene(QPointF(newMenuItem->width() / 2, newMenuItem->height() / 2)).toPoint());
QTRY_VERIFY(!menu->isVisible());
menu->open();
tst_qquickmenu: Fix click position and wait for menu opened() signal - When clicking on the menu, take into account the menu's coordinates as this may not always be (0,0) depending on the style-specific margins. - Wait for the menu enter transitions to finish before trying to interact with it, otherwise it leads to flakiness. - Explicitly set the overlap property to 0 when testing the submenus as the test relies on the menuItem to be clickable and not hidden by an overlapping subMenu item. Pick-to: 6.2 6.3 6.4 Change-Id: I561f47e69b2c9ee12c46f6accacd06e22b448df5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-07-20 15:55:21 +00:00
QTRY_VERIFY(menu->isOpened());
Add MenuSeparator [ChangeLog][Controls] Added MenuSeparator to visually distinguish between groups of items in a menu. Change-Id: I7a52910b19633ed1188c90ca56c92346a28d4d5c Task-number: QTBUG-54862 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-07-21 14:04:18 +00:00
// Clicking on a separator shouldn't close the menu.
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier,
menuSeparator->mapToScene(QPointF(menuSeparator->width() / 2, menuSeparator->height() / 2)).toPoint());
QVERIFY(menu->isVisible());
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
Add MenuSeparator [ChangeLog][Controls] Added MenuSeparator to visually distinguish between groups of items in a menu. Change-Id: I7a52910b19633ed1188c90ca56c92346a28d4d5c Task-number: QTBUG-54862 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-07-21 14:04:18 +00:00
// Clicking on items should still close the menu.
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier,
saveMenuItem->mapToScene(QPointF(saveMenuItem->width() / 2, saveMenuItem->height() / 2)).toPoint());
QTRY_VERIFY(!menu->isVisible());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
Auto tests: incorporate the QEvent::Leave trick to moveMouseAway() 6f1eba89 used QEvent::Leave to make QQuickWindow clear its last known mouse position, which ensures that QQuickWindow won't send unexpected hover events from flushFrameSynchronousEvents(). The same hover events are causing trouble in tst_qquickmenubar too, so incorporate the leave event trick to moveMouseAway() to benefit from it in other tests too. Change-Id: I25a285d008d1cb639c7be09d714e482d472b4e50 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-06 12:51:52 +00:00
moveMouseAway(window);
Stabilize tst_menu::menuSeparator() The same old story... QQuickWindowPrivate::flushFrameSynchronousEvents() keeps sending spurious hover events during auto tests. Send a manual leave event to the window to clear QQuickWindowPrivate::lastMousePosition so it won't send those hover events. Change-Id: I4d5548b2a5beff1a82f273f7e1e290e1cb88aadf Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-03 08:32:29 +00:00
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
menu->open();
QVERIFY(menu->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(menu->isOpened());
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
// Key navigation skips separators
QTest::keyClick(window, Qt::Key_Down);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(newMenuItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(newMenuItem);
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(newMenuItem->focusReason(), Qt::TabFocusReason);
QTest::keyClick(window, Qt::Key_Down);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(saveMenuItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(saveMenuItem);
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(saveMenuItem->focusReason(), Qt::TabFocusReason);
QTest::keyClick(window, Qt::Key_Down);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(saveMenuItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(saveMenuItem);
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(saveMenuItem->focusReason(), Qt::TabFocusReason);
QTest::keyClick(window, Qt::Key_Up);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(newMenuItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(newMenuItem);
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(newMenuItem->focusReason(), Qt::BacktabFocusReason);
QTest::keyClick(window, Qt::Key_Up);
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(newMenuItem);
QQuickControlsTestUtils: add VERIFY_VISUAL_FOCUS and use it Adds useful information to diagnose the cause of active focus failures. The failure message will now look like this: FAIL! : tst_QQuickMenu::FluentWinUI3::contextMenuKeyboard(Popup.Window) 'firstItem->hasVisualFocus()' returned FALSE. (control: MenuItem_QMLTYPE_1545(0x5db854767310, name="firstMenuItem", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1) activeFocus: true focusReason: Qt::OtherFocusReason activeFocusItem: "MenuItem_QMLTYPE_1545(0x5db854767310, name=\"firstMenuItem\", parent=0x5db8549a28d0, geometry=0,0 190x30, z=1)") We add both a function and a macro, as this allows the helper to be stepped into while debugging. Task-number: QTBUG-133858 Pick-to: 6.8 6.9 Change-Id: I26014ee93f5f053df1ac19ac6e673876abce1258 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-19 07:09:10 +00:00
VERIFY_VISUAL_FOCUS(newMenuItem);
QQuickMenu: fix key navigation Skip non-focusable separators, and use a key focus reason (Qt::TabFocusReason & Qt::BacktabFocusReason) to give the items visual focus. [ChangeLog][Controls][Menu] Fixed key navigation to skip separators. Change-Id: I99affabc50703c7363ab8146e5ced9b45111de00 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 18:19:50 +00:00
QCOMPARE(newMenuItem->focusReason(), Qt::BacktabFocusReason);
Add MenuSeparator [ChangeLog][Controls] Added MenuSeparator to visually distinguish between groups of items in a menu. Change-Id: I7a52910b19633ed1188c90ca56c92346a28d4d5c Task-number: QTBUG-54862 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-07-21 14:04:18 +00:00
}
Rename tst_menu to tst_QQuickMenu Change-Id: I1c7e1a2b337e9d16bc6c9b098db08f29f1b9d1e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 13:14:32 +00:00
void tst_QQuickMenu::repeater()
QQuickMenu: fix Repeater support QQuickMenu had itemChildAdded() copied from QQuickContainer, but it did not actually install an item change listener on the content item so itemChildAdded() got never called. Change-Id: Idfe558c7055b9a3df124b1f009941c423ecef4bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-12-28 19:24:18 +00:00
{
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("repeater.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
QQuickMenu: fix Repeater support QQuickMenu had itemChildAdded() copied from QQuickContainer, but it did not actually install an item change listener on the content item so itemChildAdded() got never called. Change-Id: Idfe558c7055b9a3df124b1f009941c423ecef4bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-12-28 19:24:18 +00:00
QQuickWindow *window = helper.window;
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu: fix Repeater support QQuickMenu had itemChildAdded() copied from QQuickContainer, but it did not actually install an item change listener on the content item so itemChildAdded() got never called. Change-Id: Idfe558c7055b9a3df124b1f009941c423ecef4bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-12-28 19:24:18 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QVERIFY(menu);
menu->open();
QVERIFY(menu->isVisible());
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
QQuickMenu: fix Repeater support QQuickMenu had itemChildAdded() copied from QQuickContainer, but it did not actually install an item change listener on the content item so itemChildAdded() got never called. Change-Id: Idfe558c7055b9a3df124b1f009941c423ecef4bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-12-28 19:24:18 +00:00
QObject *repeater = window->property("repeater").value<QObject*>();
QVERIFY(repeater);
int count = repeater->property("count").toInt();
QCOMPARE(count, 5);
for (int i = 0; i < count; ++i) {
QQuickItem *item = menu->itemAt(i);
Revert all Menu delegate patches This reverts the following commits: d5cb26bc56a3b6f6e99c88654d4f7a65f43551ac - Menu: ensure the correct delegates are used when created via Component d923dd467c1aeb3e195a09949b04862084002f88 - MenuBar: ensure the correct delegates are used when created via Component d56c193eb4ceb640611d66f22e1f26aae91cd7d1 - QQuickPopupPositioner: avoid adding duplicate item change listeners 567a2de8cd493aabe0055d6dbc367b39447e70dd - Stabilize tst_qquickmenubar 953fbac6131823e4fce0eb4707a854469c4c04ff - Fix Instantiator-created MenuItems disappearing 936d31179d44220571ded15840bedeccb581c83b - tst_qquickmenu: add a test for MenuItems before and after a Repeater fc1832810f6c09505d9413685ed0b2d6295bea4a - QQuickMenuBar: fix menu not opening The fix for QTBUG-67559 has caused lots of issues, with the latest being a crash right before the 5.12 release. The bug that they fix is a P2, so it's not worth the hassle. The patches might be able to be resubmitted to dev after the crash is fixed. Change-Id: Ic192c7a302176bcdb2503b636b3462b10898a2ba Fixes: QTBUG-71770 Reviewed-by: J-P Nurmi <jpnurmi@gmail.com> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-11-14 10:13:15 +00:00
QVERIFY(item);
QQuickMenu: fix Repeater support QQuickMenu had itemChildAdded() copied from QQuickContainer, but it did not actually install an item change listener on the content item so itemChildAdded() got never called. Change-Id: Idfe558c7055b9a3df124b1f009941c423ecef4bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-12-28 19:24:18 +00:00
QCOMPARE(item->property("idx").toInt(), i);
QQuickItem *repeaterItem = nullptr;
QVERIFY(QMetaObject::invokeMethod(repeater, "itemAt", Q_RETURN_ARG(QQuickItem*, repeaterItem), Q_ARG(int, i)));
QCOMPARE(item, repeaterItem);
}
repeater->setProperty("model", 3);
count = repeater->property("count").toInt();
QCOMPARE(count, 3);
for (int i = 0; i < count; ++i) {
QQuickItem *item = menu->itemAt(i);
QVERIFY(item);
QCOMPARE(item->property("idx").toInt(), i);
QQuickItem *repeaterItem = nullptr;
QVERIFY(QMetaObject::invokeMethod(repeater, "itemAt", Q_RETURN_ARG(QQuickItem*, repeaterItem), Q_ARG(int, i)));
QCOMPARE(item, repeaterItem);
}
}
Rename tst_menu to tst_QQuickMenu Change-Id: I1c7e1a2b337e9d16bc6c9b098db08f29f1b9d1e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 13:14:32 +00:00
void tst_QQuickMenu::order()
QQuickMenu: fix Repeater support QQuickMenu had itemChildAdded() copied from QQuickContainer, but it did not actually install an item change listener on the content item so itemChildAdded() got never called. Change-Id: Idfe558c7055b9a3df124b1f009941c423ecef4bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-12-28 19:24:18 +00:00
{
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("order.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
QQuickMenu: fix Repeater support QQuickMenu had itemChildAdded() copied from QQuickContainer, but it did not actually install an item change listener on the content item so itemChildAdded() got never called. Change-Id: Idfe558c7055b9a3df124b1f009941c423ecef4bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-12-28 19:24:18 +00:00
QQuickWindow *window = helper.window;
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu: fix Repeater support QQuickMenu had itemChildAdded() copied from QQuickContainer, but it did not actually install an item change listener on the content item so itemChildAdded() got never called. Change-Id: Idfe558c7055b9a3df124b1f009941c423ecef4bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-12-28 19:24:18 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QVERIFY(menu);
menu->open();
QVERIFY(menu->isVisible());
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
QQuickMenu: fix Repeater support QQuickMenu had itemChildAdded() copied from QQuickContainer, but it did not actually install an item change listener on the content item so itemChildAdded() got never called. Change-Id: Idfe558c7055b9a3df124b1f009941c423ecef4bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-12-28 19:24:18 +00:00
const QStringList texts = {"dynamic_0", "static_1", "repeated_2", "repeated_3", "static_4", "dynamic_5", "dynamic_6"};
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
for (int i = 0; i < texts.size(); ++i) {
QQuickMenu: fix Repeater support QQuickMenu had itemChildAdded() copied from QQuickContainer, but it did not actually install an item change listener on the content item so itemChildAdded() got never called. Change-Id: Idfe558c7055b9a3df124b1f009941c423ecef4bb Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-12-28 19:24:18 +00:00
QQuickItem *item = menu->itemAt(i);
QVERIFY(item);
QCOMPARE(item->property("text").toString(), texts.at(i));
}
}
tst_QQuickMenu: skip entire popup() test where necessary If the cursor configure feature is not enabled, don't build the code. If the platform is Android or Wayland, skip the test. Pick-to: 6.2 6.3 6.4 Change-Id: Ic60771decf7f2e0bd7db77c112925147015af5a6 Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
2022-06-28 08:05:18 +00:00
#if QT_CONFIG(cursor)
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::popup()
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
{
tst_QQuickMenu: skip entire popup() test where necessary If the cursor configure feature is not enabled, don't build the code. If the platform is Android or Wayland, skip the test. Pick-to: 6.2 6.3 6.4 Change-Id: Ic60771decf7f2e0bd7db77c112925147015af5a6 Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
2022-06-28 08:05:18 +00:00
#if defined(Q_OS_ANDROID)
QSKIP("Setting cursor position is not supported on Android");
#endif
if (QGuiApplication::platformName().startsWith(QLatin1String("wayland")))
QSKIP("Setting cursor position is not supported on Wayland");
tst_qquickmenu: Unblacklist some test cases on macOS - SKIP instead of blacklist the popup test on macOS as the cursor position can't be controlled on this platform. - Use the TRY variant with isOpened() instead of isVisible() in order to make sure that all enter/exit transitions are finished before interacting with the menu. Otherwise, the test can be flaky. - The subMenuDisabledMouse test expects currentIndex to be set on mainMenu when the click happens. As we set the currentIndex on a hover or keyboard navigation event, explicitly generate a hover event with mouseMove before clicking. Pick-to: 6.2 6.3 6.4 Change-Id: I7eba20a6b25f2e48a66145774539523def7142e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-07-21 15:44:03 +00:00
// Try moving the cursor from the current position
// Skip if it fails since the test relies on moving the cursor
const QPoint point = QCursor::pos() + QPoint(1, 1);
QCursor::setPos(point);
if (!QTest::qWaitFor([point]{ return QCursor::pos() == point; }))
QSKIP("Setting cursor position is not supported on this platform");
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("popup.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
QQuickApplicationWindow *window = helper.appWindow;
Fix failing tests in tst_menu and tst_qquickmenubar As mentioned in the bug report for the failing tst_qquickmenubar test, the window is sometimes opened at the bottom right corner of the screen on the Ubuntu CI machines. However, even after centering the window on the screen, the old setPos() call still caused the tests to fail. So, we position the cursor past a different corner of the window, which works.. though I don't know why. Task-number: QTBUG-62363 Task-number: QTBUG-62383 Change-Id: I3649230002eaac5a6391daff24427e6f9f58cfa5 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2017-08-09 10:51:40 +00:00
centerOnScreen(window);
Yet another attempt to stabilize tst_menu We've seen a few tst_menu failures in the CI: FAIL! : tst_menu::menuSeparator() 'newMenuItem->hasActiveFocus()' returned FALSE. () Loc: [tst_menu.cpp(428)] Add moveMouseAway() calls (e81332e) to all remaining tests that test the current item or index, which can be affected by unexpected mouse hover events. Change-Id: I23b1743fcdcea5a4064fba2748426fd25274481e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-29 13:15:31 +00:00
moveMouseAway(window);
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QVERIFY(menu);
QQuickMenuItem *menuItem1 = window->property("menuItem1").value<QQuickMenuItem *>();
QVERIFY(menuItem1);
QQuickMenuItem *menuItem2 = window->property("menuItem2").value<QQuickMenuItem *>();
QVERIFY(menuItem2);
QQuickMenuItem *menuItem3 = window->property("menuItem3").value<QQuickMenuItem *>();
QVERIFY(menuItem3);
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
QQuickItem *button = window->property("button").value<QQuickItem *>();
QVERIFY(button);
Stabilize tst_menu Add QQuickVisualTestUtil::moveMouseAway() (adapted from qtdeclarative) to help with testing menus that are now highlighting items on hover. It is important to move the mouse cursor away outside the window in such tests where hover highlight might conflict with the test. Change-Id: If3d642dd4f3ba2936a0d22c078d8fb0125d16c6c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-10 08:18:21 +00:00
QPoint oldCursorPos = QCursor::pos();
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
QPoint cursorPos = window->mapToGlobal(QPoint(11, 22));
QCursor::setPos(cursorPos);
QTRY_COMPARE(QCursor::pos(), cursorPos);
QVERIFY(QMetaObject::invokeMethod(window, "popupAtCursor"));
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
QCOMPARE(menu->parentItem(), window->contentItem());
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), -1);
QQuickMenu::popup(): set the current index If a specific menu item is passed to popup(), set the current index appropriately to highlight the item. Change-Id: Id7b687d1248127fe0c2cdb88d3ebd5689763fe24 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-06 18:56:54 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), -1);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
const qreal elevenOrLeftMargin = qMax(qreal(11), menu->leftMargin());
const qreal twentyTwoOrTopMargin = qMax(qreal(22), menu->topMargin());
// If the Menu has large margins, it may be moved to stay within them.
tst_qquickmenu::popup: Make test less flaky This test is very flaky when running it locally with the Material style. Part of this has to do with the popup's x position sometimes being half a pixel away from the intended location. Fix this by tolerating this 0.5 pixel difference. The reason behind this difference is currently unknown. Another issue is that we don't wait for the menu to close before attempting to open it again. Pick-to: 6.9 6.8 Fixes: QTBUG-133566 Change-Id: I08e68a87d477e6b3a9ea0b5b3350e5c8dc57919b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-07 13:04:36 +00:00
static QString errorStringXPos("The menu's x position was %1 and differed too much from %2");
static QString errorStringYPos("The menu's y position was %1 and differed too much from %2");
QTRY_VERIFY2(qAbs(menu->x() - elevenOrLeftMargin) <= 0.5, qPrintable(errorStringXPos.arg(menu->x()).arg(elevenOrLeftMargin)));
QTRY_VERIFY2(qAbs(menu->y() - twentyTwoOrTopMargin) <= 0.5, qPrintable(errorStringYPos.arg(menu->y()).arg(twentyTwoOrTopMargin)));
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
menu->close();
QVERIFY(QMetaObject::invokeMethod(window, "popupAtPos", Q_ARG(QVariant, QPointF(33, 44))));
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
QCOMPARE(menu->parentItem(), window->contentItem());
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), -1);
QQuickMenu::popup(): set the current index If a specific menu item is passed to popup(), set the current index appropriately to highlight the item. Change-Id: Id7b687d1248127fe0c2cdb88d3ebd5689763fe24 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-06 18:56:54 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), -1);
tst_qquickmenu: Take into account menu margins when checking coordinates Pick-to: 6.2 6.3 6.4 Change-Id: I416de281882a2ad94d03567d12dbb1491ffa801c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-08-01 16:26:48 +00:00
QTRY_VERIFY(qFuzzyCompare(menu->x(), qMax(qreal(33), menu->leftMargin())));
QTRY_VERIFY(qFuzzyCompare(menu->y(), qMax(qreal(44), menu->topMargin())));
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
menu->close();
QVERIFY(QMetaObject::invokeMethod(window, "popupAtCoord", Q_ARG(QVariant, 55), Q_ARG(QVariant, 66)));
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
QCOMPARE(menu->parentItem(), window->contentItem());
QCOMPARE(menu->currentIndex(), -1);
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), -1);
tst_qquickmenu: Take into account menu margins when checking coordinates Pick-to: 6.2 6.3 6.4 Change-Id: I416de281882a2ad94d03567d12dbb1491ffa801c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-08-01 16:26:48 +00:00
QTRY_VERIFY(qFuzzyCompare(menu->x(), qMax(qreal(55), menu->leftMargin())));
QTRY_VERIFY(qFuzzyCompare(menu->y(), qMax(qreal(66), menu->topMargin())));
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
menu->close();
menu->setParentItem(nullptr);
QVERIFY(QMetaObject::invokeMethod(window, "popupAtParentCursor", Q_ARG(QVariant, QVariant::fromValue(button))));
QCOMPARE(menu->parentItem(), button);
QCOMPARE(menu->currentIndex(), -1);
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), -1);
tst_qquickmenu::popup: Make test less flaky This test is very flaky when running it locally with the Material style. Part of this has to do with the popup's x position sometimes being half a pixel away from the intended location. Fix this by tolerating this 0.5 pixel difference. The reason behind this difference is currently unknown. Another issue is that we don't wait for the menu to close before attempting to open it again. Pick-to: 6.9 6.8 Fixes: QTBUG-133566 Change-Id: I08e68a87d477e6b3a9ea0b5b3350e5c8dc57919b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-07 13:04:36 +00:00
QTRY_VERIFY2(qAbs(menu->x() - button->mapFromScene(QPointF(elevenOrLeftMargin, twentyTwoOrTopMargin)).x()) <= 0.5,
qPrintable(errorStringXPos.arg(menu->x()).arg(button->mapFromScene(QPointF(elevenOrLeftMargin, twentyTwoOrTopMargin)).x())));
QTRY_VERIFY2(qAbs(menu->y() - button->mapFromScene(QPointF(elevenOrLeftMargin, twentyTwoOrTopMargin)).y()) <= 0.5,
qPrintable(errorStringYPos.arg(menu->y()).arg(button->mapFromScene(QPointF(elevenOrLeftMargin, twentyTwoOrTopMargin)).y())));
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
menu->close();
menu->setParentItem(nullptr);
QVERIFY(QMetaObject::invokeMethod(window, "popupAtParentPos", Q_ARG(QVariant, QVariant::fromValue(button)), Q_ARG(QVariant, QPointF(-11, -22))));
QCOMPARE(menu->parentItem(), button);
QCOMPARE(menu->currentIndex(), -1);
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), -1);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
// Don't need to worry about margins here because we're opening close
// to the center of the window.
QTRY_VERIFY(qFuzzyCompare(menu->x(), -11));
QTRY_VERIFY(qFuzzyCompare(menu->y(), -22));
tst_qquickmenu::popup: EXPECT_FAIL for iOS style Pick-to: 6.8 6.9 Task-number: QTBUG-133530 Change-Id: Ib913d973ee41b2a6db9946fdc6af4d5b7ba661a3 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-16 15:26:09 +00:00
if ((QQuickStyle::name() == QLatin1String("iOS")))
QEXPECT_FAIL("", "This fails with the iOS style: QTBUG-133530", Abort);
Fix tst_qquickmenu::popup() on Windows The test compares QPointF values rather than QPoint values. The windows windowing system allows for sub-pixel positioning of window coordinates, apparently. The QCOMPARE statements are not lenient enough, and can fail with tiny fractional differences. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I5114aa7e92de643e8062bca639983b76b099b2dc Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-29 12:28:52 +00:00
QCOMPARE(menu->popupItem()->mapToGlobal({0,0}).toPoint(), button->mapToGlobal({-11, -22}).toPoint());
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
menu->close();
menu->setParentItem(nullptr);
QVERIFY(QMetaObject::invokeMethod(window, "popupAtParentCoord", Q_ARG(QVariant, QVariant::fromValue(button)), Q_ARG(QVariant, -33), Q_ARG(QVariant, -44)));
QCOMPARE(menu->parentItem(), button);
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), -1);
QQuickMenu::popup(): set the current index If a specific menu item is passed to popup(), set the current index appropriately to highlight the item. Change-Id: Id7b687d1248127fe0c2cdb88d3ebd5689763fe24 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-06 18:56:54 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), -1);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(qFuzzyCompare(menu->x(), -33));
QTRY_VERIFY(qFuzzyCompare(menu->y(), -44));
Fix tst_qquickmenu::popup() on Windows The test compares QPointF values rather than QPoint values. The windows windowing system allows for sub-pixel positioning of window coordinates, apparently. The QCOMPARE statements are not lenient enough, and can fail with tiny fractional differences. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I5114aa7e92de643e8062bca639983b76b099b2dc Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-29 12:28:52 +00:00
QCOMPARE(menu->popupItem()->mapToGlobal({0,0}).toPoint(), button->mapToGlobal({-33, -44}).toPoint());
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
menu->close();
tst_qquickmenu::popup: Make test less flaky This test is very flaky when running it locally with the Material style. Part of this has to do with the popup's x position sometimes being half a pixel away from the intended location. Fix this by tolerating this 0.5 pixel difference. The reason behind this difference is currently unknown. Another issue is that we don't wait for the menu to close before attempting to open it again. Pick-to: 6.9 6.8 Fixes: QTBUG-133566 Change-Id: I08e68a87d477e6b3a9ea0b5b3350e5c8dc57919b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-07 13:04:36 +00:00
QTRY_VERIFY(!menu->isVisible());
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
const qreal twelveOrLeftMargin = qMax(qreal(12), menu->leftMargin());
cursorPos = window->mapToGlobal(QPoint(twelveOrLeftMargin, window->height() / 2));
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
QCursor::setPos(cursorPos);
QTRY_COMPARE(QCursor::pos(), cursorPos);
const QList<QQuickMenuItem *> menuItems = QList<QQuickMenuItem *>() << menuItem1 << menuItem2 << menuItem3;
for (QQuickMenuItem *menuItem : menuItems) {
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
menu->resetParentItem();
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
QVERIFY(QMetaObject::invokeMethod(window, "popupItemAtCursor", Q_ARG(QVariant, QVariant::fromValue(menuItem))));
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), menuItems.indexOf(menuItem));
QQuickMenu::popup(): set the current index If a specific menu item is passed to popup(), set the current index appropriately to highlight the item. Change-Id: Id7b687d1248127fe0c2cdb88d3ebd5689763fe24 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-06 18:56:54 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), menuItems.indexOf(menuItem));
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
tst_qquickmenu::popup: Make test less flaky This test is very flaky when running it locally with the Material style. Part of this has to do with the popup's x position sometimes being half a pixel away from the intended location. Fix this by tolerating this 0.5 pixel difference. The reason behind this difference is currently unknown. Another issue is that we don't wait for the menu to close before attempting to open it again. Pick-to: 6.9 6.8 Fixes: QTBUG-133566 Change-Id: I08e68a87d477e6b3a9ea0b5b3350e5c8dc57919b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-07 13:04:36 +00:00
QTRY_VERIFY2(qAbs(menu->x() - twelveOrLeftMargin) <= 0.5, qPrintable(errorStringXPos.arg(menu->x()).arg(twelveOrLeftMargin)));
QTRY_VERIFY(qFuzzyCompare(menu->y(), window->height() / 2 - menu->topPadding() - menuItem->y()));
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
menu->close();
tst_qquickmenu::popup: Make test less flaky This test is very flaky when running it locally with the Material style. Part of this has to do with the popup's x position sometimes being half a pixel away from the intended location. Fix this by tolerating this 0.5 pixel difference. The reason behind this difference is currently unknown. Another issue is that we don't wait for the menu to close before attempting to open it again. Pick-to: 6.9 6.8 Fixes: QTBUG-133566 Change-Id: I08e68a87d477e6b3a9ea0b5b3350e5c8dc57919b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-07 13:04:36 +00:00
QTRY_VERIFY(!menu->isVisible());
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
QVERIFY(QMetaObject::invokeMethod(window, "popupItemAtPos", Q_ARG(QVariant, QPointF(33, window->height() / 3)), Q_ARG(QVariant, QVariant::fromValue(menuItem))));
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), menuItems.indexOf(menuItem));
QQuickMenu::popup(): set the current index If a specific menu item is passed to popup(), set the current index appropriately to highlight the item. Change-Id: Id7b687d1248127fe0c2cdb88d3ebd5689763fe24 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-06 18:56:54 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), menuItems.indexOf(menuItem));
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
QVERIFY(qFuzzyCompare(menu->x(), 33));
QVERIFY(qFuzzyCompare(menu->y(), window->height() / 3 - menu->topPadding() - menuItem->y()));
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
menu->close();
tst_qquickmenu::popup: Make test less flaky This test is very flaky when running it locally with the Material style. Part of this has to do with the popup's x position sometimes being half a pixel away from the intended location. Fix this by tolerating this 0.5 pixel difference. The reason behind this difference is currently unknown. Another issue is that we don't wait for the menu to close before attempting to open it again. Pick-to: 6.9 6.8 Fixes: QTBUG-133566 Change-Id: I08e68a87d477e6b3a9ea0b5b3350e5c8dc57919b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-07 13:04:36 +00:00
QTRY_VERIFY(!menu->isVisible());
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
QVERIFY(QMetaObject::invokeMethod(window, "popupItemAtCoord", Q_ARG(QVariant, 55), Q_ARG(QVariant, window->height() / 3 * 2), Q_ARG(QVariant, QVariant::fromValue(menuItem))));
Add Menu::currentIndex De-couple current index management from the content item. Instead of manipulating the content item's current index directly from C++, offer a currentIndex property that can be visualized by the style, also when not using a ListView. This is essentially the same technique ComboBox uses to control the highlighted index in the popup ListView. [ChangeLog][Controls][Menu] Added currentIndex property for styling purposes. Change-Id: Idf7746d9c08fc9ca9a0dfd15225ebae5a29243c9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-14 22:16:57 +00:00
QCOMPARE(menu->currentIndex(), menuItems.indexOf(menuItem));
QQuickMenu::popup(): set the current index If a specific menu item is passed to popup(), set the current index appropriately to highlight the item. Change-Id: Id7b687d1248127fe0c2cdb88d3ebd5689763fe24 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-06 18:56:54 +00:00
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), menuItems.indexOf(menuItem));
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
QVERIFY(qFuzzyCompare(menu->x(), 55));
QVERIFY(qFuzzyCompare(menu->y(), window->height() / 3 * 2 - menu->topPadding() - menuItem->y()));
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
menu->close();
tst_qquickmenu::popup: Make test less flaky This test is very flaky when running it locally with the Material style. Part of this has to do with the popup's x position sometimes being half a pixel away from the intended location. Fix this by tolerating this 0.5 pixel difference. The reason behind this difference is currently unknown. Another issue is that we don't wait for the menu to close before attempting to open it again. Pick-to: 6.9 6.8 Fixes: QTBUG-133566 Change-Id: I08e68a87d477e6b3a9ea0b5b3350e5c8dc57919b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-07 13:04:36 +00:00
QTRY_VERIFY(!menu->isVisible());
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
menu->setParentItem(nullptr);
QVERIFY(QMetaObject::invokeMethod(window, "popupItemAtParentCursor", Q_ARG(QVariant, QVariant::fromValue(button)), Q_ARG(QVariant, QVariant::fromValue(menuItem))));
QCOMPARE(menu->parentItem(), button);
QCOMPARE(menu->currentIndex(), menuItems.indexOf(menuItem));
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), menuItems.indexOf(menuItem));
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
tst_qquickmenu::popup: Make test less flaky This test is very flaky when running it locally with the Material style. Part of this has to do with the popup's x position sometimes being half a pixel away from the intended location. Fix this by tolerating this 0.5 pixel difference. The reason behind this difference is currently unknown. Another issue is that we don't wait for the menu to close before attempting to open it again. Pick-to: 6.9 6.8 Fixes: QTBUG-133566 Change-Id: I08e68a87d477e6b3a9ea0b5b3350e5c8dc57919b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-07 13:04:36 +00:00
QTRY_VERIFY2(qAbs(menu->x() - button->mapFromScene(QPoint(twelveOrLeftMargin, window->height() / 2)).x()) <= 0.5,
qPrintable(errorStringXPos.arg(menu->x()).arg(button->mapFromScene(QPoint(twelveOrLeftMargin, window->height() / 2)).x())));
QTRY_VERIFY(qFuzzyCompare(menu->y(), button->mapFromScene(QPoint(twelveOrLeftMargin, window->height() / 2)).y() - menu->topPadding() - menuItem->y()));
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
menu->close();
tst_qquickmenu::popup: Make test less flaky This test is very flaky when running it locally with the Material style. Part of this has to do with the popup's x position sometimes being half a pixel away from the intended location. Fix this by tolerating this 0.5 pixel difference. The reason behind this difference is currently unknown. Another issue is that we don't wait for the menu to close before attempting to open it again. Pick-to: 6.9 6.8 Fixes: QTBUG-133566 Change-Id: I08e68a87d477e6b3a9ea0b5b3350e5c8dc57919b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-07 13:04:36 +00:00
QTRY_VERIFY(!menu->isVisible());
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
menu->setParentItem(nullptr);
QVERIFY(QMetaObject::invokeMethod(window, "popupItemAtParentPos", Q_ARG(QVariant, QVariant::fromValue(button)), Q_ARG(QVariant, QPointF(-11, -22)), Q_ARG(QVariant, QVariant::fromValue(menuItem))));
QCOMPARE(menu->parentItem(), button);
QCOMPARE(menu->currentIndex(), menuItems.indexOf(menuItem));
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), menuItems.indexOf(menuItem));
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
QVERIFY(qFuzzyCompare(menu->x(), -11));
QVERIFY(qFuzzyCompare(menu->y(), -22 - menu->topPadding() - menuItem->y()));
Fix tst_qquickmenu::popup() on Windows The test compares QPointF values rather than QPoint values. The windows windowing system allows for sub-pixel positioning of window coordinates, apparently. The QCOMPARE statements are not lenient enough, and can fail with tiny fractional differences. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I5114aa7e92de643e8062bca639983b76b099b2dc Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-29 12:28:52 +00:00
QCOMPARE(menu->popupItem()->mapToGlobal({0,0}).toPoint(), button->mapToGlobal({-11, -22 - menu->topPadding() - menuItem->y()}).toPoint());
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
menu->close();
tst_qquickmenu::popup: Make test less flaky This test is very flaky when running it locally with the Material style. Part of this has to do with the popup's x position sometimes being half a pixel away from the intended location. Fix this by tolerating this 0.5 pixel difference. The reason behind this difference is currently unknown. Another issue is that we don't wait for the menu to close before attempting to open it again. Pick-to: 6.9 6.8 Fixes: QTBUG-133566 Change-Id: I08e68a87d477e6b3a9ea0b5b3350e5c8dc57919b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-07 13:04:36 +00:00
QTRY_VERIFY(!menu->isVisible());
QQuickMenu::popup(): allow a parent argument The parent argument is handy for sharing a single context menu instance for multiple listview items: ListView { delegate: ItemDelegate { onPressAndHold: contextMenu.popup(this) } Menu { id: contextMenu } } Change-Id: I77ff87ee03d2d1b53485863ab9c99f3226496dfc Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-11 12:20:37 +00:00
menu->setParentItem(nullptr);
QVERIFY(QMetaObject::invokeMethod(window, "popupItemAtParentCoord", Q_ARG(QVariant, QVariant::fromValue(button)), Q_ARG(QVariant, -33), Q_ARG(QVariant, -44), Q_ARG(QVariant, QVariant::fromValue(menuItem))));
QCOMPARE(menu->parentItem(), button);
QCOMPARE(menu->currentIndex(), menuItems.indexOf(menuItem));
QCOMPARE(menu->contentItem()->property("currentIndex").toInt(), menuItems.indexOf(menuItem));
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
QVERIFY(qFuzzyCompare(menu->x(), -33));
QVERIFY(qFuzzyCompare(menu->y(), -44 - menu->topPadding() - menuItem->y()));
Fix tst_qquickmenu::popup() on Windows The test compares QPointF values rather than QPoint values. The windows windowing system allows for sub-pixel positioning of window coordinates, apparently. The QCOMPARE statements are not lenient enough, and can fail with tiny fractional differences. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I5114aa7e92de643e8062bca639983b76b099b2dc Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-29 12:28:52 +00:00
QCOMPARE(menu->popupItem()->mapToGlobal({0,0}).toPoint(), button->mapToGlobal({-33, -44 - menu->topPadding() - menuItem->y()}).toPoint());
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
menu->close();
tst_qquickmenu::popup: Make test less flaky This test is very flaky when running it locally with the Material style. Part of this has to do with the popup's x position sometimes being half a pixel away from the intended location. Fix this by tolerating this 0.5 pixel difference. The reason behind this difference is currently unknown. Another issue is that we don't wait for the menu to close before attempting to open it again. Pick-to: 6.9 6.8 Fixes: QTBUG-133566 Change-Id: I08e68a87d477e6b3a9ea0b5b3350e5c8dc57919b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-07 13:04:36 +00:00
QTRY_VERIFY(!menu->isVisible());
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
}
Stabilize tst_menu Add QQuickVisualTestUtil::moveMouseAway() (adapted from qtdeclarative) to help with testing menus that are now highlighting items on hover. It is important to move the mouse cursor away outside the window in such tests where hover highlight might conflict with the test. Change-Id: If3d642dd4f3ba2936a0d22c078d8fb0125d16c6c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-10 08:18:21 +00:00
QCursor::setPos(oldCursorPos);
QTRY_COMPARE(QCursor::pos(), oldCursorPos);
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
}
tst_QQuickMenu: skip entire popup() test where necessary If the cursor configure feature is not enabled, don't build the code. If the platform is Android or Wayland, skip the test. Pick-to: 6.2 6.3 6.4 Change-Id: Ic60771decf7f2e0bd7db77c112925147015af5a6 Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
2022-06-28 08:05:18 +00:00
#endif // QT_CONFIG(cursor)
Add QQuickMenu::popup() [ChangeLog][Controls][Menu] Added a popup() method that opens a menu at the mouse cursor on desktop platforms that have a mouse cursor available, and otherwise centers the menu over its parent item. Task-number: QTBUG-50471 Change-Id: I9456a48e71fde91f73cdb268fcdd69a8511a41a4 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-05-17 15:35:00 +00:00
QQuickMenu: guard agains crashing, if the visual parent is set to null The application can do silly things as setting a menus visual parent to null before showing it. This will currently cause a crash. And doing so will also make the menu not showing when using non-native menus, since the menu will not be a part of the scene. This patch will there check if a menus visual parent is set before trying to show it. Change-Id: I6094b3ddee88189db59a82c6791fe90456c8da92 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-03-14 10:07:30 +00:00
void tst_QQuickMenu::openParentlessMenu()
{
// Check that we don't get a crash if the application sets a menu's parentItem
// to null. This will also result in the menu not showing at all, since it's
// no longer a part of the scene. Even if this limitiation is technically only
// relevant for non-native menus, we enforce it also for native menus to ensure
// that an application works the same on all platforms.
QQuickControlsApplicationHelper helper(this, QLatin1String("popup.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
centerOnScreen(window);
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
QTest::ignoreMessage(QtWarningMsg, QRegularExpression("cannot show menu: parent is null"));
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QVERIFY(menu);
menu->setParentItem(nullptr);
menu->popup();
QVERIFY(!menu->isVisible());
}
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::actions()
QQuickMenu: add support for declaring Actions [ChangeLog][Controls][Menu] Added support for declaring Actions. The new "delegate" property is used to define a Component that is used to create menu items that present the actions. Change-Id: If26f38f6910aa5592879703429a2b418193d5710 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 18:09:44 +00:00
{
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("actions.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
QQuickMenu: add support for declaring Actions [ChangeLog][Controls][Menu] Added support for declaring Actions. The new "delegate" property is used to define a Component that is used to create menu items that present the actions. Change-Id: If26f38f6910aa5592879703429a2b418193d5710 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 18:09:44 +00:00
QQuickWindow *window = helper.window;
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu: add support for declaring Actions [ChangeLog][Controls][Menu] Added support for declaring Actions. The new "delegate" property is used to define a Component that is used to create menu items that present the actions. Change-Id: If26f38f6910aa5592879703429a2b418193d5710 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 18:09:44 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QVERIFY(menu);
QQuickMenu: add actionAt() and menuAt() accessors This complements the add/insert/remove/take API that was added for actions and menus. Unlike for menu items, there was no convenient way to access a specific action or menu directly without accessing the respective item first. [ChangeLog][Controls][Menu] Added actionAt() and menuAt() accessors. Change-Id: I5515441626b3a04b05265d5b42afdaea8e256709 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 09:59:47 +00:00
QPointer<QQuickAction> action1 = menu->actionAt(0);
QVERIFY(!action1.isNull());
QPointer<QQuickAction> action3 = menu->actionAt(2);
QVERIFY(!action3.isNull());
QVERIFY(!menu->actionAt(1));
QVERIFY(!menu->actionAt(3));
Add QQuickMenu::add/insert/remove/takeAction() [ChangeLog][Controls][Menu] Added addAction(), insertAction(), removeAction(), and takeAction() methods for adding and removing actions programmatically. Change-Id: I7d494ef1edc1cf384314fa90d97cfd2290d2e8a3 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-09 08:09:28 +00:00
QPointer<QQuickMenuItem> menuItem1 = qobject_cast<QQuickMenuItem *>(menu->itemAt(0));
QVERIFY(!menuItem1.isNull());
QQuickMenu: add actionAt() and menuAt() accessors This complements the add/insert/remove/take API that was added for actions and menus. Unlike for menu items, there was no convenient way to access a specific action or menu directly without accessing the respective item first. [ChangeLog][Controls][Menu] Added actionAt() and menuAt() accessors. Change-Id: I5515441626b3a04b05265d5b42afdaea8e256709 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 09:59:47 +00:00
QCOMPARE(menuItem1->action(), action1.data());
QQuickMenu: add support for declaring Actions [ChangeLog][Controls][Menu] Added support for declaring Actions. The new "delegate" property is used to define a Component that is used to create menu items that present the actions. Change-Id: If26f38f6910aa5592879703429a2b418193d5710 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 18:09:44 +00:00
QCOMPARE(menuItem1->text(), "action1");
Add QQuickMenu::add/insert/remove/takeAction() [ChangeLog][Controls][Menu] Added addAction(), insertAction(), removeAction(), and takeAction() methods for adding and removing actions programmatically. Change-Id: I7d494ef1edc1cf384314fa90d97cfd2290d2e8a3 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-09 08:09:28 +00:00
QPointer<QQuickMenuItem> menuItem2 = qobject_cast<QQuickMenuItem *>(menu->itemAt(1));
QVERIFY(!menuItem2.isNull());
QQuickMenu: add support for declaring Actions [ChangeLog][Controls][Menu] Added support for declaring Actions. The new "delegate" property is used to define a Component that is used to create menu items that present the actions. Change-Id: If26f38f6910aa5592879703429a2b418193d5710 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 18:09:44 +00:00
QVERIFY(!menuItem2->action());
QCOMPARE(menuItem2->text(), "menuitem2");
Add QQuickMenu::add/insert/remove/takeAction() [ChangeLog][Controls][Menu] Added addAction(), insertAction(), removeAction(), and takeAction() methods for adding and removing actions programmatically. Change-Id: I7d494ef1edc1cf384314fa90d97cfd2290d2e8a3 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-09 08:09:28 +00:00
QPointer<QQuickMenuItem> menuItem3 = qobject_cast<QQuickMenuItem *>(menu->itemAt(2));
QVERIFY(!menuItem3.isNull());
QQuickMenu: add actionAt() and menuAt() accessors This complements the add/insert/remove/take API that was added for actions and menus. Unlike for menu items, there was no convenient way to access a specific action or menu directly without accessing the respective item first. [ChangeLog][Controls][Menu] Added actionAt() and menuAt() accessors. Change-Id: I5515441626b3a04b05265d5b42afdaea8e256709 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 09:59:47 +00:00
QCOMPARE(menuItem3->action(), action3.data());
QQuickMenu: add support for declaring Actions [ChangeLog][Controls][Menu] Added support for declaring Actions. The new "delegate" property is used to define a Component that is used to create menu items that present the actions. Change-Id: If26f38f6910aa5592879703429a2b418193d5710 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 18:09:44 +00:00
QCOMPARE(menuItem3->text(), "action3");
Add QQuickMenu::add/insert/remove/takeAction() [ChangeLog][Controls][Menu] Added addAction(), insertAction(), removeAction(), and takeAction() methods for adding and removing actions programmatically. Change-Id: I7d494ef1edc1cf384314fa90d97cfd2290d2e8a3 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-09 08:09:28 +00:00
QPointer<QQuickMenuItem> menuItem4 = qobject_cast<QQuickMenuItem *>(menu->itemAt(3));
QVERIFY(!menuItem4.isNull());
QQuickMenu: add support for declaring Actions [ChangeLog][Controls][Menu] Added support for declaring Actions. The new "delegate" property is used to define a Component that is used to create menu items that present the actions. Change-Id: If26f38f6910aa5592879703429a2b418193d5710 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 18:09:44 +00:00
QVERIFY(!menuItem4->action());
QCOMPARE(menuItem4->text(), "menuitem4");
Add QQuickMenu::add/insert/remove/takeAction() [ChangeLog][Controls][Menu] Added addAction(), insertAction(), removeAction(), and takeAction() methods for adding and removing actions programmatically. Change-Id: I7d494ef1edc1cf384314fa90d97cfd2290d2e8a3 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-09 08:09:28 +00:00
// takeAction(int) does not destroy the action, but does destroy the respective item
QCOMPARE(menu->takeAction(0), action1.data());
QVERIFY(!menu->itemAt(3));
QCoreApplication::sendPostedEvents(action1, QEvent::DeferredDelete);
QVERIFY(!action1.isNull());
QCoreApplication::sendPostedEvents(menuItem1, QEvent::DeferredDelete);
QVERIFY(menuItem1.isNull());
// takeAction(int) does not destroy an item that doesn't have an action
QVERIFY(!menuItem2->subMenu());
QVERIFY(!menu->takeAction(0));
QCoreApplication::sendPostedEvents(menuItem2, QEvent::DeferredDelete);
QVERIFY(!menuItem2.isNull());
// addAction(Action) re-creates the respective item in the menu
menu->addAction(action1);
menuItem1 = qobject_cast<QQuickMenuItem *>(menu->itemAt(3));
QVERIFY(!menuItem1.isNull());
QCOMPARE(menuItem1->action(), action1.data());
// removeAction(Action) destroys both the action and the respective item
menu->removeAction(action1);
QVERIFY(!menu->itemAt(3));
QCoreApplication::sendPostedEvents(action1, QEvent::DeferredDelete);
QVERIFY(action1.isNull());
QCoreApplication::sendPostedEvents(menuItem1, QEvent::DeferredDelete);
QVERIFY(menuItem1.isNull());
QQuickMenu: add support for declaring Actions [ChangeLog][Controls][Menu] Added support for declaring Actions. The new "delegate" property is used to define a Component that is used to create menu items that present the actions. Change-Id: If26f38f6910aa5592879703429a2b418193d5710 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 18:09:44 +00:00
}
Fix sub-menu shortcuts not being triggered When QQuickShortcutContext::matcher is checking who should get a shortcut, it starts with the object that registered the shortcut and climbs up its parent hierarchy until it finds a window. Sub-menus, unlike top-level menus, will not have an associated window until their parent menu is opened. So, check if the popup is a sub-menu so that actions within it can grab shortcuts. Change-Id: I07172b1038af1e9fffd9983f7bf0a155b11bb1c3 Fixes: QTBUG-101034 Pick-to: 6.2 6.3 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-03-10 08:47:34 +00:00
#if QT_CONFIG(shortcut)
void tst_QQuickMenu::actionShortcuts()
{
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
Fix sub-menu shortcuts not being triggered When QQuickShortcutContext::matcher is checking who should get a shortcut, it starts with the object that registered the shortcut and climbs up its parent hierarchy until it finds a window. Sub-menus, unlike top-level menus, will not have an associated window until their parent menu is opened. So, check if the popup is a sub-menu so that actions within it can grab shortcuts. Change-Id: I07172b1038af1e9fffd9983f7bf0a155b11bb1c3 Fixes: QTBUG-101034 Pick-to: 6.2 6.3 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-03-10 08:47:34 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("actionShortcuts.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickWindow *window = helper.window;
window->show();
tst_qquickmenu: call requestActivate before QTest::qWaitForWindowActive On a Ubuntu 22.04.4 VM, every test after the first one that didn't call requestActivate before QTest::qWaitForWindowActive would fail: qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in "" ********* Start testing of tst_QQuickMenu ********* Config: Using QtTest library 6.8.0, Qt 6.8.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 11.4.0), ubuntu 22.04 PASS : tst_QQuickMenu::Basic::initTestCase() PASS : tst_QQuickMenu::Basic::defaults() PASS : tst_QQuickMenu::Basic::count() PASS : tst_QQuickMenu::Basic::mouse() PASS : tst_QQuickMenu::Basic::pressAndHold() PASS : tst_QQuickMenu::Basic::contextMenuKeyboard() PASS : tst_QQuickMenu::Basic::disabledMenuItemKeyNavigation() PASS : tst_QQuickMenu::Basic::mnemonics() PASS : tst_QQuickMenu::Basic::menuButton() PASS : tst_QQuickMenu::Basic::addItem() FAIL! : tst_QQuickMenu::Basic::menuSeparator() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(697)] PASS : tst_QQuickMenu::Basic::repeater() PASS : tst_QQuickMenu::Basic::order() PASS : tst_QQuickMenu::Basic::popup() PASS : tst_QQuickMenu::Basic::actions() FAIL! : tst_QQuickMenu::Basic::actionShortcuts() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1084)] PASS : tst_QQuickMenu::Basic::removeTakeItem() PASS : tst_QQuickMenu::Basic::subMenuMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuMouse(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(non-cascading) FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuWithIcon() PASS : tst_QQuickMenu::Basic::addRemoveSubMenus() PASS : tst_QQuickMenu::Basic::scrollable(Window) PASS : tst_QQuickMenu::Basic::scrollable(ApplicationWindow) PASS : tst_QQuickMenu::Basic::scrollable(WithPadding) PASS : tst_QQuickMenu::Basic::scrollable(FixedHeight) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with no Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared inside) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with no Action) PASS : tst_QQuickMenu::Basic::menuItemWidth(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidth(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterRetranslate() FAIL! : tst_QQuickMenu::Basic::giveMenuItemFocusOnButtonPress() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(2097)] PASS : tst_QQuickMenu::Basic::customMenuCullItems() PASS : tst_QQuickMenu::Basic::customMenuUseRepeaterAsTheContentItem() PASS : tst_QQuickMenu::Basic::invalidUrlInImgTag() PASS : tst_QQuickMenu::Basic::nativeStatic() PASS : tst_QQuickMenu::Basic::nativeDynamicActions() PASS : tst_QQuickMenu::Basic::nativeDynamicSubmenus() PASS : tst_QQuickMenu::Basic::nativeMenuSeparator() PASS : tst_QQuickMenu::Basic::dontUseNativeMenuWindowsChanges() PASS : tst_QQuickMenu::Basic::nativeMixedItems() PASS : tst_QQuickMenu::Basic::cleanupTestCase() Totals: 59 passed, 11 failed, 0 skipped, 0 blacklisted, 74936ms ********* Finished testing of tst_QQuickMenu ********* Change-Id: I5ef76d2648fc7c8732aafab3a9a0a02844075c3e Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-20 07:33:47 +00:00
window->requestActivate();
Fix sub-menu shortcuts not being triggered When QQuickShortcutContext::matcher is checking who should get a shortcut, it starts with the object that registered the shortcut and climbs up its parent hierarchy until it finds a window. Sub-menus, unlike top-level menus, will not have an associated window until their parent menu is opened. So, check if the popup is a sub-menu so that actions within it can grab shortcuts. Change-Id: I07172b1038af1e9fffd9983f7bf0a155b11bb1c3 Fixes: QTBUG-101034 Pick-to: 6.2 6.3 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-03-10 08:47:34 +00:00
QVERIFY(QTest::qWaitForWindowActive(window));
// Try the menu's shortcut.
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QVERIFY(menu);
QPointer<QQuickAction> action1 = menu->actionAt(0);
QVERIFY(action1);
QCOMPARE(action1->shortcut(), QKeySequence(Qt::Key_A));
QSignalSpy action1TriggeredSpy(action1, SIGNAL(triggered()));
QVERIFY(action1TriggeredSpy.isValid());
QTest::keyClick(window, Qt::Key_A);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(action1TriggeredSpy.size(), 1);
Fix sub-menu shortcuts not being triggered When QQuickShortcutContext::matcher is checking who should get a shortcut, it starts with the object that registered the shortcut and climbs up its parent hierarchy until it finds a window. Sub-menus, unlike top-level menus, will not have an associated window until their parent menu is opened. So, check if the popup is a sub-menu so that actions within it can grab shortcuts. Change-Id: I07172b1038af1e9fffd9983f7bf0a155b11bb1c3 Fixes: QTBUG-101034 Pick-to: 6.2 6.3 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-03-10 08:47:34 +00:00
// Try the sub-menu.
QQuickMenu *subMenu = window->property("subMenu").value<QQuickMenu *>();
QVERIFY(subMenu);
QPointer<QQuickAction> subMenuAction1 = subMenu->actionAt(0);
QVERIFY(subMenuAction1);
QCOMPARE(subMenuAction1->shortcut(), QKeySequence(Qt::Key_B));
QSignalSpy subMenuAction1TriggeredSpy(subMenuAction1, SIGNAL(triggered()));
QVERIFY(subMenuAction1TriggeredSpy.isValid());
QTest::keyClick(window, Qt::Key_B);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(subMenuAction1TriggeredSpy.size(), 1);
Fix sub-menu shortcuts not being triggered When QQuickShortcutContext::matcher is checking who should get a shortcut, it starts with the object that registered the shortcut and climbs up its parent hierarchy until it finds a window. Sub-menus, unlike top-level menus, will not have an associated window until their parent menu is opened. So, check if the popup is a sub-menu so that actions within it can grab shortcuts. Change-Id: I07172b1038af1e9fffd9983f7bf0a155b11bb1c3 Fixes: QTBUG-101034 Pick-to: 6.2 6.3 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-03-10 08:47:34 +00:00
// Try the button menu.
QQuickMenu *buttonMenu = window->property("buttonMenu").value<QQuickMenu *>();
QVERIFY(buttonMenu);
QPointer<QQuickAction> buttonMenuAction1 = buttonMenu->actionAt(0);
QVERIFY(buttonMenuAction1);
QCOMPARE(buttonMenuAction1->shortcut(), QKeySequence(Qt::Key_C));
QSignalSpy buttonMenuAction1TriggeredSpy(buttonMenuAction1, SIGNAL(triggered()));
QVERIFY(buttonMenuAction1TriggeredSpy.isValid());
QTest::keyClick(window, Qt::Key_C);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(buttonMenuAction1TriggeredSpy.size(), 1);
Fix sub-menu shortcuts not being triggered When QQuickShortcutContext::matcher is checking who should get a shortcut, it starts with the object that registered the shortcut and climbs up its parent hierarchy until it finds a window. Sub-menus, unlike top-level menus, will not have an associated window until their parent menu is opened. So, check if the popup is a sub-menu so that actions within it can grab shortcuts. Change-Id: I07172b1038af1e9fffd9983f7bf0a155b11bb1c3 Fixes: QTBUG-101034 Pick-to: 6.2 6.3 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-03-10 08:47:34 +00:00
}
#endif
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::removeTakeItem()
QQuickMenu: removeItem(Item) and takeItem(int) Deprecate removeItem(int) in favor of removeItem(Item) and takeItem(int) with clearer semantics. If one already has access to an item, one can pass it to removeItem() to get rid of it for good, instead of having to call destroy() by hand. If one knows the index instead, we provide a way to take the respective item out of the menu, and let the user decide what to do with it. This way we provide convenient ways to remove & destroy items in one go, and to take items out without destroying them. This nice pattern was once upon time planned for the QQC1 containers such as SplitView, and should have been used for the QQC2 containers, but was simply forgotten during the development... [ChangeLog][Controls][Menu] Deprecated removeItem(int) in favor of removeItem(Item) and takeItem(int) with clearer semantics. The former destroys the item, whereas the latter transfers ownership to the caller. Change-Id: Id2a07fb65019b2904a013c8bcc3154089d36a0ea Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-02 14:18:56 +00:00
{
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("removeTakeItem.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
QQuickMenu: removeItem(Item) and takeItem(int) Deprecate removeItem(int) in favor of removeItem(Item) and takeItem(int) with clearer semantics. If one already has access to an item, one can pass it to removeItem() to get rid of it for good, instead of having to call destroy() by hand. If one knows the index instead, we provide a way to take the respective item out of the menu, and let the user decide what to do with it. This way we provide convenient ways to remove & destroy items in one go, and to take items out without destroying them. This nice pattern was once upon time planned for the QQC1 containers such as SplitView, and should have been used for the QQC2 containers, but was simply forgotten during the development... [ChangeLog][Controls][Menu] Deprecated removeItem(int) in favor of removeItem(Item) and takeItem(int) with clearer semantics. The former destroys the item, whereas the latter transfers ownership to the caller. Change-Id: Id2a07fb65019b2904a013c8bcc3154089d36a0ea Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-02 14:18:56 +00:00
QQuickWindow *window = helper.window;
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu: removeItem(Item) and takeItem(int) Deprecate removeItem(int) in favor of removeItem(Item) and takeItem(int) with clearer semantics. If one already has access to an item, one can pass it to removeItem() to get rid of it for good, instead of having to call destroy() by hand. If one knows the index instead, we provide a way to take the respective item out of the menu, and let the user decide what to do with it. This way we provide convenient ways to remove & destroy items in one go, and to take items out without destroying them. This nice pattern was once upon time planned for the QQC1 containers such as SplitView, and should have been used for the QQC2 containers, but was simply forgotten during the development... [ChangeLog][Controls][Menu] Deprecated removeItem(int) in favor of removeItem(Item) and takeItem(int) with clearer semantics. The former destroys the item, whereas the latter transfers ownership to the caller. Change-Id: Id2a07fb65019b2904a013c8bcc3154089d36a0ea Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-02 14:18:56 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QVERIFY(menu);
QPointer<QQuickMenuItem> menuItem1 = window->property("menuItem1").value<QQuickMenuItem *>();
QVERIFY(!menuItem1.isNull());
QCOMPARE(menuItem1->menu(), menu);
QPointer<QQuickMenuItem> menuItem2 = window->property("menuItem2").value<QQuickMenuItem *>();
QVERIFY(!menuItem2.isNull());
QCOMPARE(menuItem2->menu(), menu);
QPointer<QQuickMenuItem> menuItem3 = window->property("menuItem3").value<QQuickMenuItem *>();
QVERIFY(!menuItem3.isNull());
QCOMPARE(menuItem3->menu(), menu);
// takeItem(int) does not destroy
QVariant ret;
QVERIFY(QMetaObject::invokeMethod(window, "takeSecondItem", Q_RETURN_ARG(QVariant, ret)));
QCOMPARE(ret.value<QQuickMenuItem *>(), menuItem2);
QVERIFY(!menuItem2->menu());
QCoreApplication::sendPostedEvents(menuItem2, QEvent::DeferredDelete);
QVERIFY(!menuItem2.isNull());
// removeItem(Item) destroys
QVERIFY(QMetaObject::invokeMethod(window, "removeFirstItem"));
QVERIFY(!menuItem1->menu());
QCoreApplication::sendPostedEvents(menuItem1, QEvent::DeferredDelete);
QVERIFY(menuItem1.isNull());
// removeItem(null) must not call removeItem(0)
QVERIFY(QMetaObject::invokeMethod(window, "removeNullItem"));
QCOMPARE(menuItem3->menu(), menu);
QCoreApplication::sendPostedEvents(menuItem3, QEvent::DeferredDelete);
QVERIFY(!menuItem3.isNull());
}
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::subMenuMouse_data()
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
{
QTest::addColumn<bool>("cascade");
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
QTest::addColumn<QQuickPopup::PopupType>("popupType");
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
QTest::newRow("cascading, in-scene") << true << QQuickPopup::Item;
QTest::newRow("non-cascading, in-scene") << false << QQuickPopup::Item;
Add arePopupWindowsSupported function to QQuickControlsTestUtils And reduce a few duplicate checks throughout our tests. Pick-to: 6.8 6.9 Change-Id: I31610f07eb548282ade5573af56ffef18d33cd66 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2025-03-25 05:26:26 +00:00
if (arePopupWindowsSupported()) {
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
QTest::newRow("cascading, popup windows") << true << QQuickPopup::Window;
QTest::newRow("non-cascading, popup windows") << false << QQuickPopup::Window;
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
}
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::subMenuMouse()
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
{
Move duplicate mouse hover checks into a skip macro Similar to 8d454b26263e5333d8475bbab91d7b3d1d5e04d8 and f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Pick-to: 6.5 6.8 Change-Id: Iaf9a4edc8a3c37f232ad3b66923864f4baa02d4d Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2024-11-21 06:54:21 +00:00
SKIP_IF_NO_MOUSE_HOVER;
Fix tests for boot2qt The tests for boot2qt were disabled with commit 28063805bf22b77a93f22a4289ca8afa9f1cb201. The tests can be enabled since qtdeclarative now fallbacks to software renderer if OpenGL is not supported. Some tests involving mouse behavior and window grabbing need to be skipped on minimal/offscreen platforms. Task-number: QTBUG-60268 Change-Id: Ib468638df8d5001bf127dd17aee7dcfe38b11780 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2017-06-05 09:48:40 +00:00
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QFETCH(bool, cascade);
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
QFETCH(QQuickPopup::PopupType, popupType);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("subMenus.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickApplicationWindow *window = helper.appWindow;
Fix failing tests in tst_menu and tst_qquickmenubar As mentioned in the bug report for the failing tst_qquickmenubar test, the window is sometimes opened at the bottom right corner of the screen on the Ubuntu CI machines. However, even after centering the window on the screen, the old setPos() call still caused the tests to fail. So, we position the cursor past a different corner of the window, which works.. though I don't know why. Task-number: QTBUG-62363 Task-number: QTBUG-62383 Change-Id: I3649230002eaac5a6391daff24427e6f9f58cfa5 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2017-08-09 10:51:40 +00:00
centerOnScreen(window);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
moveMouseAway(window);
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
Stabilize tst_QQuickMenu::subMenuMouse() on macOS If the platform can't do QCursor::setPos() we still want Qt to think the mouse is outside the window, so that it clears any hover state of the menu. Pick-to: 6.8 Change-Id: I64a1f143dab4a719ce74788a6fac1843ee0c8afe Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2024-09-26 12:10:51 +00:00
// Ensure Qt's view of where the mouse is is outside of the
// window, even if moveMouseAway() could not use QCursor::setPos()
// to do that.
QTest::mouseMove(window, QPoint(-1, -1));
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickMenu *mainMenu = window->property("mainMenu").value<QQuickMenu *>();
QVERIFY(mainMenu);
mainMenu->setCascade(cascade);
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
mainMenu->setPopupType(popupType);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QCOMPARE(mainMenu->cascade(), cascade);
QQuickMenu *subMenu1 = window->property("subMenu1").value<QQuickMenu *>();
QVERIFY(subMenu1);
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
subMenu1->setCascade(cascade);
QCOMPARE(subMenu1->cascade(), cascade);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickMenu *subMenu2 = window->property("subMenu2").value<QQuickMenu *>();
QVERIFY(subMenu2);
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
subMenu2->setCascade(cascade);
QCOMPARE(subMenu2->cascade(), cascade);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickMenu *subSubMenu1 = window->property("subSubMenu1").value<QQuickMenu *>();
QVERIFY(subSubMenu1);
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
subSubMenu1->setCascade(cascade);
QCOMPARE(subSubMenu1->cascade(), cascade);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
mainMenu->open();
QVERIFY(mainMenu->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(mainMenu->isOpened());
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
auto *mainMenuPrivate = QQuickMenuPrivate::get(mainMenu);
QCOMPARE(mainMenuPrivate->resolvedPopupType(), popupType);
if (mainMenuPrivate->usePopupWindow()) {
QTRY_VERIFY(mainMenuPrivate->popupWindow);
QVERIFY(QTest::qWaitForWindowExposed(mainMenuPrivate->popupWindow));
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu1->isVisible());
QVERIFY(!subMenu2->isVisible());
QVERIFY(!subSubMenu1->isVisible());
// open the sub-menu with mouse click
QQuickMenuItem *subMenu1Item = qobject_cast<QQuickMenuItem *>(mainMenu->itemAt(1));
QVERIFY(subMenu1Item);
QCOMPARE(subMenu1Item->subMenu(), subMenu1);
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
const QPoint subMenu1ItemPos = subMenu1Item->mapToGlobal(QPoint(1, 1)).toPoint();
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier, window->mapFromGlobal(subMenu1ItemPos));
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_COMPARE(mainMenu->isVisible(), cascade);
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
auto *subMenu1Private = QQuickMenuPrivate::get(subMenu1);
QCOMPARE(subMenu1Private->resolvedPopupType(), popupType);
if (mainMenuPrivate->usePopupWindow()) {
QTRY_VERIFY(subMenu1Private->popupWindow);
QVERIFY(QTest::qWaitForWindowExposed(subMenu1Private->popupWindow));
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(subMenu1->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(subMenu1->isOpened());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu2->isVisible());
QVERIFY(!subSubMenu1->isVisible());
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
// on Android mouse hover will not open and close sub-menus
#ifndef Q_OS_ANDROID
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
// open the cascading sub-sub-menu with mouse hover
QQuickMenuItem *subSubMenu1Item = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(2));
QVERIFY(subSubMenu1Item);
QCOMPARE(subSubMenu1Item->subMenu(), subSubMenu1);
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
const QPoint subSubMenu1ItemPos = subSubMenu1Item->mapToGlobal(QPoint(1, 1)).toPoint();
QTest::mouseMove(window, window->mapFromGlobal(subSubMenu1ItemPos));
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QCOMPARE(mainMenu->isVisible(), cascade);
QVERIFY(subMenu1->isVisible());
QVERIFY(!subMenu2->isVisible());
QQuickMenu: add a little delay for opening sub-menus on hover This improves the usability on desktop. When a menu has multiple sub- menu items, they don't all trigger a sub-menu (and close immediately) while moving mouse over the items. Change-Id: Ie4c9e409da8d6877e35506bffb94ed57f5985dcd Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 05:12:53 +00:00
QVERIFY(!subSubMenu1->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
if (cascade) {
QQuickMenu: add a little delay for opening sub-menus on hover This improves the usability on desktop. When a menu has multiple sub- menu items, they don't all trigger a sub-menu (and close immediately) while moving mouse over the items. Change-Id: Ie4c9e409da8d6877e35506bffb94ed57f5985dcd Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 05:12:53 +00:00
QTRY_VERIFY(subSubMenu1->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(subSubMenu1->isOpened());
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
// close the sub-sub-menu with mouse hover over another parent menu item
QQuickMenuItem *subMenuItem1 = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(0));
QVERIFY(subMenuItem1);
QVERIFY(!subMenuItem1->subMenu());
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
const QPoint subMenuItem1Pos = subMenuItem1->mapToGlobal(QPoint(1, 1)).toPoint();
QTest::mouseMove(window, window->mapFromGlobal(subMenuItem1Pos));
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QCOMPARE(mainMenu->isVisible(), cascade);
QVERIFY(subMenu1->isVisible());
QVERIFY(!subMenu2->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(!subSubMenu1->isVisible());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
// re-open the sub-sub-menu with mouse hover
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
QTest::mouseMove(window, window->mapFromGlobal(subSubMenu1ItemPos));
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QCOMPARE(mainMenu->isVisible(), cascade);
QVERIFY(subMenu1->isVisible());
QVERIFY(!subMenu2->isVisible());
Fix flaky tst_qquickmenu test The important part of the "cascading" test is checking that the sub-sub menu eventually opens, so move the !visible check to the non-cascading branch of the if statement. Change-Id: I5a09bf0b5d45832f7b75c3e8c397fdb9e6fcc011 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
2019-05-06 15:04:27 +00:00
if (!cascade) {
QVERIFY(!subSubMenu1->isVisible());
} else {
QQuickMenu: add a little delay for opening sub-menus on hover This improves the usability on desktop. When a menu has multiple sub- menu items, they don't all trigger a sub-menu (and close immediately) while moving mouse over the items. Change-Id: Ie4c9e409da8d6877e35506bffb94ed57f5985dcd Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-08 05:12:53 +00:00
QTRY_VERIFY(subSubMenu1->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(subSubMenu1->isOpened());
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
// close sub-menu and sub-sub-menu with mouse hover in the main menu
QQuickMenuItem *mainMenuItem1 = qobject_cast<QQuickMenuItem *>(mainMenu->itemAt(0));
QVERIFY(mainMenuItem1);
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
const QPoint mainMenuItem1Pos = mainMenuItem1->mapToGlobal(QPoint(1, 1)).toPoint();
QTest::mouseMove(window, window->mapFromGlobal(mainMenuItem1Pos));
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QCOMPARE(mainMenu->isVisible(), cascade);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_COMPARE(subMenu1->isVisible(), !cascade);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu2->isVisible());
QVERIFY(!subSubMenu1->isVisible());
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
// close all menus by click triggering an item
QQuickAbstractButton *itemToClick = cascade ? mainMenuItem1 : subMenuItem1;
QVERIFY(itemToClick->isVisible());
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier, window->mapFromGlobal(itemToClick->mapToGlobal({1,1}).toPoint()));
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
#else
QQuickMenuItem *mainMenuItem1 = qobject_cast<QQuickMenuItem *>(mainMenu->itemAt(0));
QVERIFY(mainMenuItem1);
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier, mainMenuItem1->mapToScene({1,1}).toPoint());
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
#endif // !Q_OS_ANDROID
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(!subMenu1->isVisible());
Make tst_QQuickMenu::subMenuMouse pass, regardless of popupType If we ever decide to change the default value of QQuickPopup::popupType, we'll need to make changes like this one, in order for tests to wait long enough for popup windows to be exposed, and make scene-independent positional calculations. Task-number: QTBUG-126553 Pick-to: 6.8 6.8.0 Change-Id: I811db75496af439a06db9711fd8756b75438568e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-20 17:29:02 +00:00
QTRY_VERIFY(!mainMenu->isVisible());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu2->isVisible());
QVERIFY(!subSubMenu1->isVisible());
}
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
void tst_QQuickMenu::subMenuDisabledMouse_data()
{
subMenuMouse_data();
}
// QTBUG-69540
void tst_QQuickMenu::subMenuDisabledMouse()
{
Move duplicate mouse hover checks into a skip macro Similar to 8d454b26263e5333d8475bbab91d7b3d1d5e04d8 and f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Pick-to: 6.5 6.8 Change-Id: Iaf9a4edc8a3c37f232ad3b66923864f4baa02d4d Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2024-11-21 06:54:21 +00:00
SKIP_IF_NO_MOUSE_HOVER;
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QFETCH(bool, cascade);
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("subMenuDisabled.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QQuickApplicationWindow *window = helper.appWindow;
centerOnScreen(window);
moveMouseAway(window);
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QQuickMenu *mainMenu = window->property("mainMenu").value<QQuickMenu *>();
QVERIFY(mainMenu);
mainMenu->setCascade(cascade);
QCOMPARE(mainMenu->cascade(), cascade);
tst_qquickmenu: force some tests to use popupType: Popup.Item These tests pass with `popupType: Popup.Window` on some systems, but not on Windows. For now, we`ll just force them to use the popupType that we know works. Further investigation is needed to figure out how to make them work on Windows, and other platforms. Task-number: QTBUG-128474 Pick-to: 6.8 Change-Id: If018c9b964dcf77ec2cbf6a1ee64f2d834a47e3e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-29 12:57:04 +00:00
// TODO: QTBUG-128474
mainMenu->setPopupType(QQuickPopup::Item);
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QQuickMenuItem *menuItem1 = qobject_cast<QQuickMenuItem *>(mainMenu->itemAt(0));
QVERIFY(menuItem1);
QQuickMenu *subMenu = window->property("subMenu").value<QQuickMenu *>();
QVERIFY(subMenu);
mainMenu->open();
tst_qquickmenu: Unblacklist some test cases on macOS - SKIP instead of blacklist the popup test on macOS as the cursor position can't be controlled on this platform. - Use the TRY variant with isOpened() instead of isVisible() in order to make sure that all enter/exit transitions are finished before interacting with the menu. Otherwise, the test can be flaky. - The subMenuDisabledMouse test expects currentIndex to be set on mainMenu when the click happens. As we set the currentIndex on a hover or keyboard navigation event, explicitly generate a hover event with mouseMove before clicking. Pick-to: 6.2 6.3 6.4 Change-Id: I7eba20a6b25f2e48a66145774539523def7142e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-07-21 15:44:03 +00:00
QTRY_VERIFY(mainMenu->isOpened());
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QVERIFY(!menuItem1->isHighlighted());
QVERIFY(!subMenu->isVisible());
tst_qquickmenu: Unblacklist some test cases on macOS - SKIP instead of blacklist the popup test on macOS as the cursor position can't be controlled on this platform. - Use the TRY variant with isOpened() instead of isVisible() in order to make sure that all enter/exit transitions are finished before interacting with the menu. Otherwise, the test can be flaky. - The subMenuDisabledMouse test expects currentIndex to be set on mainMenu when the click happens. As we set the currentIndex on a hover or keyboard navigation event, explicitly generate a hover event with mouseMove before clicking. Pick-to: 6.2 6.3 6.4 Change-Id: I7eba20a6b25f2e48a66145774539523def7142e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-07-21 15:44:03 +00:00
// Hover-highlighting does not work on Android
#ifndef Q_OS_ANDROID
// Generate a hover event to set the current index
QTest::mouseMove(window, menuItem1->mapToScene(QPoint(2, 2)).toPoint());
QTRY_VERIFY(menuItem1->isHighlighted());
#endif
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
// Open the sub-menu with a mouse click.
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier, menuItem1->mapToScene(QPoint(1, 1)).toPoint());
tst_qquickmenu: Unblacklist some test cases on macOS - SKIP instead of blacklist the popup test on macOS as the cursor position can't be controlled on this platform. - Use the TRY variant with isOpened() instead of isVisible() in order to make sure that all enter/exit transitions are finished before interacting with the menu. Otherwise, the test can be flaky. - The subMenuDisabledMouse test expects currentIndex to be set on mainMenu when the click happens. As we set the currentIndex on a hover or keyboard navigation event, explicitly generate a hover event with mouseMove before clicking. Pick-to: 6.2 6.3 6.4 Change-Id: I7eba20a6b25f2e48a66145774539523def7142e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-07-21 15:44:03 +00:00
// Need to use the TRY variant here,
// as e.g. Material, iOS style menus have transitions and don't open/close immediately.
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_COMPARE(mainMenu->isVisible(), cascade);
tst_qquickmenu: Unblacklist some test cases on macOS - SKIP instead of blacklist the popup test on macOS as the cursor position can't be controlled on this platform. - Use the TRY variant with isOpened() instead of isVisible() in order to make sure that all enter/exit transitions are finished before interacting with the menu. Otherwise, the test can be flaky. - The subMenuDisabledMouse test expects currentIndex to be set on mainMenu when the click happens. As we set the currentIndex on a hover or keyboard navigation event, explicitly generate a hover event with mouseMove before clicking. Pick-to: 6.2 6.3 6.4 Change-Id: I7eba20a6b25f2e48a66145774539523def7142e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-07-21 15:44:03 +00:00
QTRY_VERIFY(subMenu->isOpened());
tst_qquickmenu: fix flaky test The included test fails every now and then for Imagine, Fusion and Mac style. By using QTRY_VERIFY to wait a bit before we check if the menu is highlighted, it seems to pass each time. Change-Id: Ib8b207e1b5f81b3086595bb8ad7dc6881272def1 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-09-03 20:54:36 +00:00
QTRY_VERIFY(menuItem1->isHighlighted());
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
// Now the sub-menu is open. The current behavior is that the first menu item
// in the new menu is highlighted; make sure that we choose the next item if
// the first is disabled.
QQuickMenuItem *subMenuItem1 = qobject_cast<QQuickMenuItem *>(subMenu->itemAt(0));
QVERIFY(subMenuItem1);
QQuickMenuItem *subMenuItem2 = qobject_cast<QQuickMenuItem *>(subMenu->itemAt(1));
QVERIFY(subMenuItem2);
QVERIFY(!subMenuItem1->isHighlighted());
QVERIFY(subMenuItem2->isHighlighted());
// Close all menus by clicking on the item that isn't disabled.
Fix tst_QQuickMenu::subMenuDisabledMouse to work with popup windows Making our test work, independently of the popupType, will allow us to potentially change the default value in the future. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I33d9b342d6d3d58a037cd79e3bd824741a6009b7 Reviewed-by: Ed Cooke <ed.cooke@qt.io> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-08-22 12:34:53 +00:00
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier, window->mapFromGlobal(subMenuItem2->mapToGlobal(QPoint(1, 1)).toPoint()));
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(!mainMenu->isVisible());
QTRY_VERIFY(!subMenu->isVisible());
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
}
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::subMenuKeyboard_data()
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
{
QTest::addColumn<bool>("cascade");
QTest::addColumn<bool>("mirrored");
QTest::newRow("cascading") << true << false;
QTest::newRow("cascading,mirrored") << true << true;
QTest::newRow("non-cascading") << false << false;
QTest::newRow("non-cascading,mirrored") << false << true;
}
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::subMenuKeyboard()
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
{
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QFETCH(bool, cascade);
QFETCH(bool, mirrored);
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("subMenus.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickApplicationWindow *window = helper.appWindow;
Fix failing tests in tst_menu and tst_qquickmenubar As mentioned in the bug report for the failing tst_qquickmenubar test, the window is sometimes opened at the bottom right corner of the screen on the Ubuntu CI machines. However, even after centering the window on the screen, the old setPos() call still caused the tests to fail. So, we position the cursor past a different corner of the window, which works.. though I don't know why. Task-number: QTBUG-62363 Task-number: QTBUG-62383 Change-Id: I3649230002eaac5a6391daff24427e6f9f58cfa5 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2017-08-09 10:51:40 +00:00
centerOnScreen(window);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
moveMouseAway(window);
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
window->show();
tst_qquickmenu: call requestActivate before QTest::qWaitForWindowActive On a Ubuntu 22.04.4 VM, every test after the first one that didn't call requestActivate before QTest::qWaitForWindowActive would fail: qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in "" ********* Start testing of tst_QQuickMenu ********* Config: Using QtTest library 6.8.0, Qt 6.8.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 11.4.0), ubuntu 22.04 PASS : tst_QQuickMenu::Basic::initTestCase() PASS : tst_QQuickMenu::Basic::defaults() PASS : tst_QQuickMenu::Basic::count() PASS : tst_QQuickMenu::Basic::mouse() PASS : tst_QQuickMenu::Basic::pressAndHold() PASS : tst_QQuickMenu::Basic::contextMenuKeyboard() PASS : tst_QQuickMenu::Basic::disabledMenuItemKeyNavigation() PASS : tst_QQuickMenu::Basic::mnemonics() PASS : tst_QQuickMenu::Basic::menuButton() PASS : tst_QQuickMenu::Basic::addItem() FAIL! : tst_QQuickMenu::Basic::menuSeparator() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(697)] PASS : tst_QQuickMenu::Basic::repeater() PASS : tst_QQuickMenu::Basic::order() PASS : tst_QQuickMenu::Basic::popup() PASS : tst_QQuickMenu::Basic::actions() FAIL! : tst_QQuickMenu::Basic::actionShortcuts() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1084)] PASS : tst_QQuickMenu::Basic::removeTakeItem() PASS : tst_QQuickMenu::Basic::subMenuMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuMouse(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(non-cascading) FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuWithIcon() PASS : tst_QQuickMenu::Basic::addRemoveSubMenus() PASS : tst_QQuickMenu::Basic::scrollable(Window) PASS : tst_QQuickMenu::Basic::scrollable(ApplicationWindow) PASS : tst_QQuickMenu::Basic::scrollable(WithPadding) PASS : tst_QQuickMenu::Basic::scrollable(FixedHeight) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with no Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared inside) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with no Action) PASS : tst_QQuickMenu::Basic::menuItemWidth(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidth(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterRetranslate() FAIL! : tst_QQuickMenu::Basic::giveMenuItemFocusOnButtonPress() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(2097)] PASS : tst_QQuickMenu::Basic::customMenuCullItems() PASS : tst_QQuickMenu::Basic::customMenuUseRepeaterAsTheContentItem() PASS : tst_QQuickMenu::Basic::invalidUrlInImgTag() PASS : tst_QQuickMenu::Basic::nativeStatic() PASS : tst_QQuickMenu::Basic::nativeDynamicActions() PASS : tst_QQuickMenu::Basic::nativeDynamicSubmenus() PASS : tst_QQuickMenu::Basic::nativeMenuSeparator() PASS : tst_QQuickMenu::Basic::dontUseNativeMenuWindowsChanges() PASS : tst_QQuickMenu::Basic::nativeMixedItems() PASS : tst_QQuickMenu::Basic::cleanupTestCase() Totals: 59 passed, 11 failed, 0 skipped, 0 blacklisted, 74936ms ********* Finished testing of tst_QQuickMenu ********* Change-Id: I5ef76d2648fc7c8732aafab3a9a0a02844075c3e Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-20 07:33:47 +00:00
window->requestActivate();
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
QVERIFY(QTest::qWaitForWindowActive(window));
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
Fix layout is always RTL when locale is RTL isMirrored() will always return true when locale is RTL, so that we cannot change the layout. To fix this, remove out the relation between LayoutMirroring.enabled and locale's text direction. [ChangeLog][Controls][Important Behavior Changes] Control's locale property no longer affects layout direction. Use LayoutMirroring instead. Fixes: QTBUG-91227 Change-Id: Ibedd3f09828f81f1889077892452a27c90e21533 Reviewed-by: Hyunkook Khang <hyunkook.khang@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2021-02-23 01:51:31 +00:00
if (mirrored) {
QQmlExpression mirroringExpression(qmlContext(window), window,
"LayoutMirroring.childrenInherit = true; LayoutMirroring.enabled = true");
QVERIFY2(mirroringExpression.evaluate().isValid(), qPrintable(mirroringExpression.error().toString()));
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickMenu *mainMenu = window->property("mainMenu").value<QQuickMenu *>();
QVERIFY(mainMenu);
mainMenu->setCascade(cascade);
QCOMPARE(mainMenu->cascade(), cascade);
tst_qquickmenu: force some tests to use popupType: Popup.Item These tests pass with `popupType: Popup.Window` on some systems, but not on Windows. For now, we`ll just force them to use the popupType that we know works. Further investigation is needed to figure out how to make them work on Windows, and other platforms. Task-number: QTBUG-128474 Pick-to: 6.8 Change-Id: If018c9b964dcf77ec2cbf6a1ee64f2d834a47e3e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-29 12:57:04 +00:00
// TODO: QTBUG-128474
mainMenu->setPopupType(QQuickPopup::Item);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickMenu *subMenu1 = window->property("subMenu1").value<QQuickMenu *>();
QVERIFY(subMenu1);
QQuickMenu *subMenu2 = window->property("subMenu2").value<QQuickMenu *>();
QVERIFY(subMenu2);
QQuickMenu *subSubMenu1 = window->property("subSubMenu1").value<QQuickMenu *>();
QVERIFY(subSubMenu1);
mainMenu->open();
QVERIFY(mainMenu->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(mainMenu->isOpened());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu1->isVisible());
QVERIFY(!subMenu2->isVisible());
QVERIFY(!subSubMenu1->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
// navigate to the sub-menu item and trigger it to open the sub-menu
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickMenuItem *subMenu1Item = qobject_cast<QQuickMenuItem *>(mainMenu->itemAt(1));
QVERIFY(subMenu1Item);
QVERIFY(!subMenu1Item->isHighlighted());
QCOMPARE(subMenu1Item->subMenu(), subMenu1);
QTest::keyClick(window, Qt::Key_Down);
QTest::keyClick(window, Qt::Key_Down);
QVERIFY(subMenu1Item->isHighlighted());
QTest::keyClick(window, Qt::Key_Space);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_COMPARE(mainMenu->isVisible(), cascade);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(subMenu1->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(subMenu1->isOpened());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu2->isVisible());
QVERIFY(!subSubMenu1->isVisible());
// navigate to the sub-sub-menu item and open it with the arrow key
QQuickMenuItem *subSubMenu1Item = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(2));
QVERIFY(subSubMenu1Item);
QVERIFY(!subSubMenu1Item->isHighlighted());
QCOMPARE(subSubMenu1Item->subMenu(), subSubMenu1);
QTest::keyClick(window, Qt::Key_Down);
QTest::keyClick(window, Qt::Key_Down);
QTest::keyClick(window, Qt::Key_Down);
QVERIFY(subSubMenu1Item->isHighlighted());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_COMPARE(mainMenu->isVisible(), cascade);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(subMenu1->isVisible());
QVERIFY(!subMenu2->isVisible());
QVERIFY(!subSubMenu1->isVisible());
QTest::keyClick(window, mirrored ? Qt::Key_Left : Qt::Key_Right);
QCOMPARE(mainMenu->isVisible(), cascade);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_COMPARE(subMenu1->isVisible(), cascade);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu2->isVisible());
QVERIFY(subSubMenu1->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(subSubMenu1->isOpened());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
// navigate within the sub-sub-menu
QQuickMenuItem *subSubMenuItem1 = qobject_cast<QQuickMenuItem *>(subSubMenu1->itemAt(0));
QVERIFY(subSubMenuItem1);
QQuickMenuItem *subSubMenuItem2 = qobject_cast<QQuickMenuItem *>(subSubMenu1->itemAt(1));
QVERIFY(subSubMenuItem2);
QVERIFY(subSubMenuItem1->isHighlighted());
QVERIFY(!subSubMenuItem2->isHighlighted());
QTest::keyClick(window, Qt::Key_Down);
QVERIFY(!subSubMenuItem1->isHighlighted());
QVERIFY(subSubMenuItem2->isHighlighted());
// navigate to the parent menu with the arrow key
QTest::keyClick(window, mirrored ? Qt::Key_Right : Qt::Key_Left);
QVERIFY(subSubMenu1Item->isHighlighted());
QCOMPARE(mainMenu->isVisible(), cascade);
QVERIFY(subMenu1->isVisible());
QVERIFY(!subMenu2->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(!subSubMenu1->isVisible());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
// navigate within the sub-menu
QQuickMenuItem *subMenuItem1 = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(0));
QVERIFY(subMenuItem1);
QQuickMenuItem *subMenuItem2 = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(1));
QVERIFY(subMenuItem2);
QVERIFY(!subMenuItem1->isHighlighted());
QVERIFY(!subMenuItem2->isHighlighted());
QVERIFY(subSubMenu1Item->isHighlighted());
QTest::keyClick(window, Qt::Key_Up);
QVERIFY(!subMenuItem1->isHighlighted());
QVERIFY(subMenuItem2->isHighlighted());
QVERIFY(!subSubMenu1Item->isHighlighted());
// close the menus with esc
QTest::keyClick(window, Qt::Key_Escape);
QCOMPARE(mainMenu->isVisible(), cascade);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(!subMenu1->isVisible());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu2->isVisible());
QVERIFY(!subSubMenu1->isVisible());
QTest::keyClick(window, Qt::Key_Escape);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(!mainMenu->isVisible());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu1->isVisible());
QVERIFY(!subMenu2->isVisible());
QVERIFY(!subSubMenu1->isVisible());
}
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
void tst_QQuickMenu::subMenuDisabledKeyboard_data()
{
subMenuKeyboard_data();
}
// QTBUG-69540
void tst_QQuickMenu::subMenuDisabledKeyboard()
{
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QFETCH(bool, cascade);
QFETCH(bool, mirrored);
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("subMenuDisabled.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QQuickApplicationWindow *window = helper.appWindow;
centerOnScreen(window);
moveMouseAway(window);
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
window->show();
tst_qquickmenu: call requestActivate before QTest::qWaitForWindowActive On a Ubuntu 22.04.4 VM, every test after the first one that didn't call requestActivate before QTest::qWaitForWindowActive would fail: qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in "" ********* Start testing of tst_QQuickMenu ********* Config: Using QtTest library 6.8.0, Qt 6.8.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 11.4.0), ubuntu 22.04 PASS : tst_QQuickMenu::Basic::initTestCase() PASS : tst_QQuickMenu::Basic::defaults() PASS : tst_QQuickMenu::Basic::count() PASS : tst_QQuickMenu::Basic::mouse() PASS : tst_QQuickMenu::Basic::pressAndHold() PASS : tst_QQuickMenu::Basic::contextMenuKeyboard() PASS : tst_QQuickMenu::Basic::disabledMenuItemKeyNavigation() PASS : tst_QQuickMenu::Basic::mnemonics() PASS : tst_QQuickMenu::Basic::menuButton() PASS : tst_QQuickMenu::Basic::addItem() FAIL! : tst_QQuickMenu::Basic::menuSeparator() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(697)] PASS : tst_QQuickMenu::Basic::repeater() PASS : tst_QQuickMenu::Basic::order() PASS : tst_QQuickMenu::Basic::popup() PASS : tst_QQuickMenu::Basic::actions() FAIL! : tst_QQuickMenu::Basic::actionShortcuts() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1084)] PASS : tst_QQuickMenu::Basic::removeTakeItem() PASS : tst_QQuickMenu::Basic::subMenuMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuMouse(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(non-cascading) FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuWithIcon() PASS : tst_QQuickMenu::Basic::addRemoveSubMenus() PASS : tst_QQuickMenu::Basic::scrollable(Window) PASS : tst_QQuickMenu::Basic::scrollable(ApplicationWindow) PASS : tst_QQuickMenu::Basic::scrollable(WithPadding) PASS : tst_QQuickMenu::Basic::scrollable(FixedHeight) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with no Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared inside) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with no Action) PASS : tst_QQuickMenu::Basic::menuItemWidth(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidth(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterRetranslate() FAIL! : tst_QQuickMenu::Basic::giveMenuItemFocusOnButtonPress() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(2097)] PASS : tst_QQuickMenu::Basic::customMenuCullItems() PASS : tst_QQuickMenu::Basic::customMenuUseRepeaterAsTheContentItem() PASS : tst_QQuickMenu::Basic::invalidUrlInImgTag() PASS : tst_QQuickMenu::Basic::nativeStatic() PASS : tst_QQuickMenu::Basic::nativeDynamicActions() PASS : tst_QQuickMenu::Basic::nativeDynamicSubmenus() PASS : tst_QQuickMenu::Basic::nativeMenuSeparator() PASS : tst_QQuickMenu::Basic::dontUseNativeMenuWindowsChanges() PASS : tst_QQuickMenu::Basic::nativeMixedItems() PASS : tst_QQuickMenu::Basic::cleanupTestCase() Totals: 59 passed, 11 failed, 0 skipped, 0 blacklisted, 74936ms ********* Finished testing of tst_QQuickMenu ********* Change-Id: I5ef76d2648fc7c8732aafab3a9a0a02844075c3e Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-20 07:33:47 +00:00
window->requestActivate();
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
QVERIFY(QTest::qWaitForWindowActive(window));
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
Fix layout is always RTL when locale is RTL isMirrored() will always return true when locale is RTL, so that we cannot change the layout. To fix this, remove out the relation between LayoutMirroring.enabled and locale's text direction. [ChangeLog][Controls][Important Behavior Changes] Control's locale property no longer affects layout direction. Use LayoutMirroring instead. Fixes: QTBUG-91227 Change-Id: Ibedd3f09828f81f1889077892452a27c90e21533 Reviewed-by: Hyunkook Khang <hyunkook.khang@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2021-02-23 01:51:31 +00:00
if (mirrored) {
QQmlExpression mirroringExpression(qmlContext(window), window,
"LayoutMirroring.childrenInherit = true; LayoutMirroring.enabled = true");
QVERIFY2(mirroringExpression.evaluate().isValid(), qPrintable(mirroringExpression.error().toString()));
}
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QQuickMenu *mainMenu = window->property("mainMenu").value<QQuickMenu *>();
QVERIFY(mainMenu);
mainMenu->setCascade(cascade);
QCOMPARE(mainMenu->cascade(), cascade);
tst_qquickmenu: force some tests to use popupType: Popup.Item These tests pass with `popupType: Popup.Window` on some systems, but not on Windows. For now, we`ll just force them to use the popupType that we know works. Further investigation is needed to figure out how to make them work on Windows, and other platforms. Task-number: QTBUG-128474 Pick-to: 6.8 Change-Id: If018c9b964dcf77ec2cbf6a1ee64f2d834a47e3e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-29 12:57:04 +00:00
// TODO: QTBUG-128474
mainMenu->setPopupType(QQuickPopup::Item);
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QQuickMenuItem *menuItem1 = qobject_cast<QQuickMenuItem *>(mainMenu->itemAt(0));
QVERIFY(menuItem1);
QQuickMenu *subMenu = window->property("subMenu").value<QQuickMenu *>();
QVERIFY(subMenu);
mainMenu->open();
QVERIFY(mainMenu->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(mainMenu->isOpened());
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QVERIFY(!menuItem1->isHighlighted());
QVERIFY(!subMenu->isVisible());
// Highlight the top-level menu item.
QTest::keyClick(window, Qt::Key_Down);
QVERIFY(menuItem1->isHighlighted());
QQuickMenuItem *subMenuItem1 = qobject_cast<QQuickMenuItem *>(subMenu->itemAt(0));
QVERIFY(subMenuItem1);
QQuickMenuItem *subMenuItem2 = qobject_cast<QQuickMenuItem *>(subMenu->itemAt(1));
QVERIFY(subMenuItem2);
// Open the sub-menu.
QTest::keyClick(window, mirrored ? Qt::Key_Left : Qt::Key_Right);
// The first sub-menu item is disabled, so it should highlight the second one.
QVERIFY(!subMenuItem1->isHighlighted());
QVERIFY(subMenuItem2->isHighlighted());
// Close the menus with escape.
QTest::keyClick(window, Qt::Key_Escape);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_COMPARE(mainMenu->isVisible(), cascade);
QTRY_VERIFY(!subMenu->isVisible());
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QTest::keyClick(window, Qt::Key_Escape);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(!mainMenu->isVisible());
Menu: fix disabled sub-menu items being highlighted When a menu item with a sub-menu was triggered by key or mouse, it would open the sub-menu with the first menu item highlighted. This doesn't make sense for disabled menu items, so this patch makes it find the first enabled item. Change-Id: I9df1c750749e5a77b027b6f476b8ae1f5ea035bd Fixes: QTBUG-69540 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-01-28 12:14:30 +00:00
QVERIFY(!subMenu->isVisible());
}
Fix tst_QQuickMenu::subMenuPosition() We're still getting failures after QCOMPARE was fixed (in c78a960198d59fb9a9ddd83ad7098b1db396edfd): FAIL! : tst_QQuickMenu::Material::subMenuPosition(cascading,flip) Compared doubles are not the same (fuzzy compare) Actual (subSubMenu1->popupItem()->x()) : 3.88240550819e-11 Expected (subMenu1->popupItem()->x() - subSubMenu1->width() + overlap): 0 tst_qquickmenu.cpp(1532) : failure location Quoting Eddy: "[...] the threshold for double equality is one part in 1e12; the threshold for fuzzy-is-zero is likewise 1e-12; so 3e-11 is non-zero. One work-around, of course, would be to cast float(each operand) so as to get float's wider tolerance (one part in 100,000, null if less than 1e-5)." So that's what we do in this patch. Change-Id: Iecf1b6f4b2cf2c81eb652bb0f565ac682b024dae Pick-to: 5.15 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-07-14 12:18:29 +00:00
/*
QCOMPARE() compares doubles with 1-in-1e12 precision, which is too fine for these tests.
Casting to floats, compared with 1-in-1e5 precision, gives more robust results.
*/
#define FLOAT_EQ(u, v) QCOMPARE(float(u), float(v))
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::subMenuPosition_data()
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
{
QTest::addColumn<bool>("cascade");
Menu: allow horizontal flip for cascading sub-menus Allow sub-menus to open on the left side if there's more space than on the right side. This is the expected behavior on desktop. Change-Id: I915cb93e98a42bf50758d9e98fd98632e55c2cfa Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-16 03:28:59 +00:00
QTest::addColumn<bool>("flip");
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QTest::addColumn<bool>("mirrored");
QTest::addColumn<qreal>("overlap");
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
QTest::addColumn<QQuickPopup::PopupType>("popupType");
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
QTest::newRow("cascading") << true << false << false << 0.0 << QQuickPopup::Item;
QTest::newRow("cascading,flip") << true << true << false << 0.0 << QQuickPopup::Item;
QTest::newRow("cascading,overlap") << true << false << false << 10.0 << QQuickPopup::Item;
QTest::newRow("cascading,flip,overlap") << true << true << false << 10.0 << QQuickPopup::Item;
QTest::newRow("cascading,mirrored") << true << false << true << 0.0 << QQuickPopup::Item;
QTest::newRow("cascading,mirrored,flip") << true << true << true << 0.0 << QQuickPopup::Item;
QTest::newRow("cascading,mirrored,overlap") << true << false << true << 10.0 << QQuickPopup::Item;
QTest::newRow("cascading,mirrored,flip,overlap") << true << true << true << 10.0 << QQuickPopup::Item;
QTest::newRow("non-cascading") << false << false << false << 0.0 << QQuickPopup::Item;
// Flipping is tested in subMenuFlipsPositionWhenOutOfBounds(), and mirroring doesn't currently work when using popup windows.
// TODO: enable the test rows below, once they're fixed to not be flaky. QTBUG-128471
//QTest::newRow("cascading,window") << true << false << false << 0.0 << QQuickPopup::Window;
//QTest::newRow("non-cascading,window") << false << false << false << 0.0 << QQuickPopup::Window;
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
}
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::subMenuPosition()
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
{
QFETCH(bool, cascade);
Menu: allow horizontal flip for cascading sub-menus Allow sub-menus to open on the left side if there's more space than on the right side. This is the expected behavior on desktop. Change-Id: I915cb93e98a42bf50758d9e98fd98632e55c2cfa Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-16 03:28:59 +00:00
QFETCH(bool, flip);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QFETCH(bool, mirrored);
QFETCH(qreal, overlap);
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
QFETCH(QQuickPopup::PopupType, popupType);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("subMenus.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickApplicationWindow *window = helper.appWindow;
Menu: allow horizontal flip for cascading sub-menus Allow sub-menus to open on the left side if there's more space than on the right side. This is the expected behavior on desktop. Change-Id: I915cb93e98a42bf50758d9e98fd98632e55c2cfa Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-16 03:28:59 +00:00
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
// Ensure that the default size of the window fits three menus side by side.
QQuickMenu *mainMenu = window->property("mainMenu").value<QQuickMenu *>();
QVERIFY(mainMenu);
window->setWidth(mainMenu->width() * 3 + mainMenu->leftMargin() + mainMenu->rightMargin());
Menu: allow horizontal flip for cascading sub-menus Allow sub-menus to open on the left side if there's more space than on the right side. This is the expected behavior on desktop. Change-Id: I915cb93e98a42bf50758d9e98fd98632e55c2cfa Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-16 03:28:59 +00:00
// the default size of the window fits three menus side by side.
// when testing flipping, we resize the window so that the first
// sub-menu fits, but the second doesn't
if (flip)
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
window->setWidth(window->width() - mainMenu->width());
Menu: allow horizontal flip for cascading sub-menus Allow sub-menus to open on the left side if there's more space than on the right side. This is the expected behavior on desktop. Change-Id: I915cb93e98a42bf50758d9e98fd98632e55c2cfa Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-16 03:28:59 +00:00
Fix failing tests in tst_menu and tst_qquickmenubar As mentioned in the bug report for the failing tst_qquickmenubar test, the window is sometimes opened at the bottom right corner of the screen on the Ubuntu CI machines. However, even after centering the window on the screen, the old setPos() call still caused the tests to fail. So, we position the cursor past a different corner of the window, which works.. though I don't know why. Task-number: QTBUG-62363 Task-number: QTBUG-62383 Change-Id: I3649230002eaac5a6391daff24427e6f9f58cfa5 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2017-08-09 10:51:40 +00:00
centerOnScreen(window);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
moveMouseAway(window);
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
#ifndef Q_OS_ANDROID
Fix Flaky tests These tests where failing sometimes in our CI, because centerOnScreen() was invoked which asks the window manager to move the window, but does not wait for the event's completion. The solution is to do all that *before* the initial qWaitForWindowActive(). Fixes: QTBUG-73128 Change-Id: I06c1f85d5ff9657dccab50f29084f7624cd7e194 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-07-18 17:02:40 +00:00
window->show();
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
#else
// On Android the desired size does not fit into the screen, so we just
// call showNormal. This will make the window larger than the screen, but
// all the geometry calculations will be correct. Otherwise we'll get
// unpredictable results
window->showNormal();
#endif
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
Fix layout is always RTL when locale is RTL isMirrored() will always return true when locale is RTL, so that we cannot change the layout. To fix this, remove out the relation between LayoutMirroring.enabled and locale's text direction. [ChangeLog][Controls][Important Behavior Changes] Control's locale property no longer affects layout direction. Use LayoutMirroring instead. Fixes: QTBUG-91227 Change-Id: Ibedd3f09828f81f1889077892452a27c90e21533 Reviewed-by: Hyunkook Khang <hyunkook.khang@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2021-02-23 01:51:31 +00:00
if (mirrored) {
QQmlExpression mirroringExpression(qmlContext(window), window,
"LayoutMirroring.childrenInherit = true; LayoutMirroring.enabled = true");
QVERIFY2(mirroringExpression.evaluate().isValid(), qPrintable(mirroringExpression.error().toString()));
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
mainMenu->setCascade(cascade);
QCOMPARE(mainMenu->cascade(), cascade);
mainMenu->setOverlap(overlap);
QCOMPARE(mainMenu->overlap(), overlap);
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
mainMenu->setPopupType(popupType);
QCOMPARE(mainMenu->popupType(), popupType);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickMenu *subMenu1 = window->property("subMenu1").value<QQuickMenu *>();
QVERIFY(subMenu1);
subMenu1->setCascade(cascade);
QCOMPARE(subMenu1->cascade(), cascade);
subMenu1->setOverlap(overlap);
QCOMPARE(subMenu1->overlap(), overlap);
QQuickMenu *subMenu2 = window->property("subMenu2").value<QQuickMenu *>();
QVERIFY(subMenu2);
subMenu2->setCascade(cascade);
QCOMPARE(subMenu2->cascade(), cascade);
subMenu2->setOverlap(overlap);
QCOMPARE(subMenu2->overlap(), overlap);
QQuickMenu *subSubMenu1 = window->property("subSubMenu1").value<QQuickMenu *>();
QVERIFY(subSubMenu1);
subSubMenu1->setCascade(cascade);
QCOMPARE(subSubMenu1->cascade(), cascade);
subSubMenu1->setOverlap(overlap);
QCOMPARE(subSubMenu1->overlap(), overlap);
Menu: allow horizontal flip for cascading sub-menus Allow sub-menus to open on the left side if there's more space than on the right side. This is the expected behavior on desktop. Change-Id: I915cb93e98a42bf50758d9e98fd98632e55c2cfa Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-16 03:28:59 +00:00
// choose the main menu position so that there's room for the
// sub-menus to cascade to the left when mirrored
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
if (mirrored)
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
mainMenu->setX(window->width() - mainMenu->width());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
mainMenu->open();
QVERIFY(mainMenu->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(mainMenu->isOpened());
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
QQuickMenuPrivate *mainMenuPrivate = QQuickMenuPrivate::get(mainMenu);
QVERIFY(mainMenuPrivate);
if (mainMenuPrivate->usePopupWindow()) {
QTRY_VERIFY(mainMenuPrivate->popupWindow);
QVERIFY(QTest::qWaitForWindowExposed(mainMenuPrivate->popupWindow));
QVERIFY(QQuickTest::qWaitForPolish(mainMenuPrivate->popupWindow));
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu1->isVisible());
QVERIFY(!subMenu2->isVisible());
QVERIFY(!subSubMenu1->isVisible());
Menu: allow horizontal flip for cascading sub-menus Allow sub-menus to open on the left side if there's more space than on the right side. This is the expected behavior on desktop. Change-Id: I915cb93e98a42bf50758d9e98fd98632e55c2cfa Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-16 03:28:59 +00:00
// open the sub-menu (never flips)
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickMenuItem *subMenu1Item = qobject_cast<QQuickMenuItem *>(mainMenu->itemAt(1));
QVERIFY(subMenu1Item);
QCOMPARE(subMenu1Item->subMenu(), subMenu1);
emit subMenu1Item->triggered();
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_COMPARE(mainMenu->isVisible(), cascade);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(subMenu1->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(subMenu1->isOpened());
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
QQuickMenuPrivate *subMenu1Private = QQuickMenuPrivate::get(subMenu1);
QVERIFY(subMenu1Private);
if (subMenu1Private->usePopupWindow()) {
QTRY_VERIFY(subMenu1Private->popupWindow);
QVERIFY(QTest::qWaitForWindowExposed(subMenu1Private->popupWindow));
QVERIFY(QQuickTest::qWaitForPolish(subMenu1Private->popupWindow));
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu2->isVisible());
QVERIFY(!subSubMenu1->isVisible());
if (cascade) {
QCOMPARE(subMenu1->parentItem(), subMenu1Item);
// vertically aligned to the parent menu item
Fix tst_QQuickMenu::subMenuPosition() We're still getting failures after QCOMPARE was fixed (in c78a960198d59fb9a9ddd83ad7098b1db396edfd): FAIL! : tst_QQuickMenu::Material::subMenuPosition(cascading,flip) Compared doubles are not the same (fuzzy compare) Actual (subSubMenu1->popupItem()->x()) : 3.88240550819e-11 Expected (subMenu1->popupItem()->x() - subSubMenu1->width() + overlap): 0 tst_qquickmenu.cpp(1532) : failure location Quoting Eddy: "[...] the threshold for double equality is one part in 1e12; the threshold for fuzzy-is-zero is likewise 1e-12; so 3e-11 is non-zero. One work-around, of course, would be to cast float(each operand) so as to get float's wider tolerance (one part in 100,000, null if less than 1e-5)." So that's what we do in this patch. Change-Id: Iecf1b6f4b2cf2c81eb652bb0f565ac682b024dae Pick-to: 5.15 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-07-14 12:18:29 +00:00
// We cast to float here because we want to use its larger tolerance for equality (because it has less precision than double).
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
QCOMPARE(subMenu1->popupItem()->mapToGlobal({0, 0}).y(), mainMenu->popupItem()->mapToGlobal({0, subMenu1Item->y()}).y());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
if (mirrored) {
// on the left of the parent menu
Fix tst_QQuickMenu::subMenuPosition() We're still getting failures after QCOMPARE was fixed (in c78a960198d59fb9a9ddd83ad7098b1db396edfd): FAIL! : tst_QQuickMenu::Material::subMenuPosition(cascading,flip) Compared doubles are not the same (fuzzy compare) Actual (subSubMenu1->popupItem()->x()) : 3.88240550819e-11 Expected (subMenu1->popupItem()->x() - subSubMenu1->width() + overlap): 0 tst_qquickmenu.cpp(1532) : failure location Quoting Eddy: "[...] the threshold for double equality is one part in 1e12; the threshold for fuzzy-is-zero is likewise 1e-12; so 3e-11 is non-zero. One work-around, of course, would be to cast float(each operand) so as to get float's wider tolerance (one part in 100,000, null if less than 1e-5)." So that's what we do in this patch. Change-Id: Iecf1b6f4b2cf2c81eb652bb0f565ac682b024dae Pick-to: 5.15 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-07-14 12:18:29 +00:00
FLOAT_EQ(subMenu1->popupItem()->x(), mainMenu->popupItem()->x() - subMenu1->width() + overlap);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
} else {
// on the right of the parent menu
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
if (!mainMenuPrivate->usePopupWindow())
FLOAT_EQ(subMenu1->popupItem()->x(), mainMenu->popupItem()->x() + mainMenu->width() - overlap);
else
QCOMPARE(subMenu1->popupItem()->mapToGlobal({0, 0}).x(), mainMenu->popupItem()->mapToGlobal({subMenu1->width() - overlap,0}).x());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
} else {
QCOMPARE(subMenu1->parentItem(), mainMenu->parentItem());
// centered over the parent menu
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
if (!mainMenuPrivate->usePopupWindow()) {
FLOAT_EQ(subMenu1->popupItem()->x(), mainMenu->popupItem()->x() + (mainMenu->width() - subMenu1->width()) / 2);
FLOAT_EQ(subMenu1->popupItem()->y(), mainMenu->popupItem()->y() + (mainMenu->height() - subMenu1->height()) / 2);
} else {
QCOMPARE(subMenu1->popupItem()->mapToGlobal({0, 0}),
mainMenu->popupItem()->mapToGlobal({(mainMenu->width() - subMenu1->width()) / 2, (mainMenu->height() - subMenu1->height()) / 2}));
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
}
Menu: allow horizontal flip for cascading sub-menus Allow sub-menus to open on the left side if there's more space than on the right side. This is the expected behavior on desktop. Change-Id: I915cb93e98a42bf50758d9e98fd98632e55c2cfa Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-16 03:28:59 +00:00
// open the sub-sub-menu (can flip)
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QQuickMenuItem *subSubMenu1Item = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(2));
QVERIFY(subSubMenu1Item);
QCOMPARE(subSubMenu1Item->subMenu(), subSubMenu1);
emit subSubMenu1Item->triggered();
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_COMPARE(mainMenu->isVisible(), cascade);
QTRY_COMPARE(subMenu1->isVisible(), cascade);
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
QVERIFY(!subMenu2->isVisible());
QVERIFY(subSubMenu1->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(subSubMenu1->isOpened());
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
QQuickMenuPrivate *subSubMenu1Private = QQuickMenuPrivate::get(subSubMenu1);
if (subSubMenu1Private->usePopupWindow()) {
QTRY_VERIFY(subSubMenu1Private->popupWindow);
QVERIFY(QTest::qWaitForWindowExposed(subSubMenu1Private->popupWindow));
QVERIFY(QQuickTest::qWaitForPolish(subSubMenu1Private->popupWindow));
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
if (cascade) {
QCOMPARE(subSubMenu1->parentItem(), subSubMenu1Item);
// vertically aligned to the parent menu item
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
QCOMPARE(subSubMenu1->popupItem()->mapToGlobal({0, 0}).y(), subMenu1->popupItem()->mapToGlobal({0, subSubMenu1Item->y()}).y());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
if (mirrored != flip) {
// on the left of the parent menu
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
if (!mainMenuPrivate->usePopupWindow())
FLOAT_EQ(subSubMenu1->popupItem()->x(), subMenu1->popupItem()->x() - subSubMenu1->width() + overlap);
else
QCOMPARE(subSubMenu1->popupItem()->mapToGlobal({0, 0}).x(), subMenu1->popupItem()->mapToGlobal({overlap - subSubMenu1->width(),0}).x());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
} else {
// on the right of the parent menu
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
if (!mainMenuPrivate->usePopupWindow())
FLOAT_EQ(subSubMenu1->popupItem()->x(), subMenu1->popupItem()->x() + subMenu1->width() - overlap);
else
QCOMPARE(subSubMenu1->popupItem()->mapToGlobal({0, 0}).x(), subMenu1->popupItem()->mapToGlobal({subMenu1->width() - overlap,0}).x());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
} else {
QCOMPARE(subSubMenu1->parentItem(), subMenu1->parentItem());
// centered over the parent menu
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
if (!mainMenuPrivate->usePopupWindow()) {
FLOAT_EQ(subSubMenu1->popupItem()->x(), subMenu1->popupItem()->x() + (subMenu1->width() - subSubMenu1->width()) / 2);
FLOAT_EQ(subSubMenu1->popupItem()->y(), subMenu1->popupItem()->y() + (subMenu1->height() - subSubMenu1->height()) / 2);
} else {
const QWindow *subSubMenu1Window = subSubMenu1->popupItem()->window();
const QWindow *subMenu1Window = subMenu1->popupItem()->window();
const QPoint offset((subMenu1->width() - subSubMenu1->width()) / 2, (subMenu1->height() - subSubMenu1->height()) / 2);
QTRY_COMPARE(subSubMenu1Window->position(), subMenu1Window->position() + offset);
}
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
}
Make tst_QQuickMenu::subMenuPosition consider popupType Since we're debating whether or not to change the default popupType. We'll need to fix some tests that break when the popupType is Window. subMenuPosition is one of those tests that break. Fix the test so that it passes, regardless of the default popupType. Since it's data driven, we can run it both with and without popup windows. Since flipping is implemented in a different test, it doesn't quite make sense to test it in this function. Mirroring doesn't currently work when using popup windows. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: Ie07d0ab867a90724f10ef7e5acbee60e314c7f9f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 00:18:04 +00:00
subSubMenu1->close();
subMenu1->close();
mainMenu->close();
Add support for cascading sub-menus This commit adds initial support for cascading sub-menus by allowing one to nest declarative Menu declarations. A follow-up commit adds support for adding, inserting, and removing menus programmatically. [ChangeLog][Controls][Menu] Added support for cascading sub-menus. Task-number: QTBUG-60351 Change-Id: I0eee4f74d92a97c09333fcc4348b019782448535 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-01 21:36:57 +00:00
}
Fix tst_QQuickMenu::subMenuPosition() We're still getting failures after QCOMPARE was fixed (in c78a960198d59fb9a9ddd83ad7098b1db396edfd): FAIL! : tst_QQuickMenu::Material::subMenuPosition(cascading,flip) Compared doubles are not the same (fuzzy compare) Actual (subSubMenu1->popupItem()->x()) : 3.88240550819e-11 Expected (subMenu1->popupItem()->x() - subSubMenu1->width() + overlap): 0 tst_qquickmenu.cpp(1532) : failure location Quoting Eddy: "[...] the threshold for double equality is one part in 1e12; the threshold for fuzzy-is-zero is likewise 1e-12; so 3e-11 is non-zero. One work-around, of course, would be to cast float(each operand) so as to get float's wider tolerance (one part in 100,000, null if less than 1e-5)." So that's what we do in this patch. Change-Id: Iecf1b6f4b2cf2c81eb652bb0f565ac682b024dae Pick-to: 5.15 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-07-14 12:18:29 +00:00
#undef FLOAT_EQ
PopupPositioner: ensure popup windows are placed inside a screen When `popupType: Popup.Item`, the popup positioner will attempt to flip, move and resize the popup item, in order to make it fit inside its window. We want something similar for when `popupType: Popup.Window`, except that the bounds in this case, ends up being the geometry of the screen that contains the popup window, instead of the nearest parent item's window. The omission of any resizing to the popup window, is done on purpose. Since the popup positioner's current role, is to only affect the popup window position. This might change in the future, in case we decide to refactor some of the logic around popup window resizing. Pick-to: 6.9 6.8 Change-Id: Iee0f1c7363624b73d0b64f0b6c47765abdb365e2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-26 14:25:42 +00:00
void tst_QQuickMenu::subMenuFlipsPositionWhenOutOfBounds_data()
{
QTest::addColumn<QQuickPopup::PopupType>("popupType");
QTest::newRow("PopupType::Item") << QQuickPopup::Item;
Add arePopupWindowsSupported function to QQuickControlsTestUtils And reduce a few duplicate checks throughout our tests. Pick-to: 6.8 6.9 Change-Id: I31610f07eb548282ade5573af56ffef18d33cd66 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2025-03-25 05:26:26 +00:00
if (arePopupWindowsSupported())
PopupPositioner: ensure popup windows are placed inside a screen When `popupType: Popup.Item`, the popup positioner will attempt to flip, move and resize the popup item, in order to make it fit inside its window. We want something similar for when `popupType: Popup.Window`, except that the bounds in this case, ends up being the geometry of the screen that contains the popup window, instead of the nearest parent item's window. The omission of any resizing to the popup window, is done on purpose. Since the popup positioner's current role, is to only affect the popup window position. This might change in the future, in case we decide to refactor some of the logic around popup window resizing. Pick-to: 6.9 6.8 Change-Id: Iee0f1c7363624b73d0b64f0b6c47765abdb365e2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-26 14:25:42 +00:00
QTest::newRow("PopupType::Window") << QQuickPopup::Window;
}
void tst_QQuickMenu::subMenuFlipsPositionWhenOutOfBounds()
{
QFETCH(QQuickPopup::PopupType, popupType);
QQuickControlsApplicationHelper helper(this, QLatin1String("SubMenusNearScreenBound.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
QQuickMenu *mainMenu = window->property("mainMenu").value<QQuickMenu *>();
QVERIFY(mainMenu);
QQuickMenu *subMenu = window->property("subMenu").value<QQuickMenu *>();
QVERIFY(subMenu);
mainMenu->setPopupType(popupType);
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
mainMenu->open();
QTRY_VERIFY(mainMenu->isOpened());
Use leftPadding of parent menus when flipping submenus QQuickMenuPositioner positions child menus to the right of the menu item that opened it. In additon, the overlap and rightPadding properties are used to offset the x position, which styles can use to fine tune how exactly submenus should be positioned relative to the parent menu item. The parent menu's padding is used, because the submenu's position is initially set to be relative to the menu item that opened it. When the position is offset by the padding, it will position itself to the parent menu, and not just the parent menu item. 7add1868c0956bca769a33d2974b211c6e533567 introduced the flipping behavior for menus that have their popupType set to Popup.Window. Causing menus that don't have enough space to open to the right side, to instead open on the left side. The aformentioned patch used the overlap, but forgot to also add the leftPadding, when flipping submenus. Also fix the test tst_QQuickMenu::subMenuFlipsPositionWhenOutOfBounds, which was previously broken on all styles that modified the rightPadding property of Menu. 6e327f28c7cd05d90881998696da45615 introduced a temporary fix, in order to unblock CI, and this patch should fix it properly. Pick-to: 6.9 6.8 Change-Id: I62c58617dbcf27c097009859213cb78eb59a8008 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2025-02-11 17:53:43 +00:00
const QQuickPopupPrivate *mainMenu_d = QQuickPopupPrivate::get(mainMenu);
PopupPositioner: ensure popup windows are placed inside a screen When `popupType: Popup.Item`, the popup positioner will attempt to flip, move and resize the popup item, in order to make it fit inside its window. We want something similar for when `popupType: Popup.Window`, except that the bounds in this case, ends up being the geometry of the screen that contains the popup window, instead of the nearest parent item's window. The omission of any resizing to the popup window, is done on purpose. Since the popup positioner's current role, is to only affect the popup window position. This might change in the future, in case we decide to refactor some of the logic around popup window resizing. Pick-to: 6.9 6.8 Change-Id: Iee0f1c7363624b73d0b64f0b6c47765abdb365e2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-26 14:25:42 +00:00
QVERIFY(mainMenu_d);
if (mainMenu_d->usePopupWindow()) {
SKIP_IF_NO_WINDOW_ACTIVATION;
Use leftPadding of parent menus when flipping submenus QQuickMenuPositioner positions child menus to the right of the menu item that opened it. In additon, the overlap and rightPadding properties are used to offset the x position, which styles can use to fine tune how exactly submenus should be positioned relative to the parent menu item. The parent menu's padding is used, because the submenu's position is initially set to be relative to the menu item that opened it. When the position is offset by the padding, it will position itself to the parent menu, and not just the parent menu item. 7add1868c0956bca769a33d2974b211c6e533567 introduced the flipping behavior for menus that have their popupType set to Popup.Window. Causing menus that don't have enough space to open to the right side, to instead open on the left side. The aformentioned patch used the overlap, but forgot to also add the leftPadding, when flipping submenus. Also fix the test tst_QQuickMenu::subMenuFlipsPositionWhenOutOfBounds, which was previously broken on all styles that modified the rightPadding property of Menu. 6e327f28c7cd05d90881998696da45615 introduced a temporary fix, in order to unblock CI, and this patch should fix it properly. Pick-to: 6.9 6.8 Change-Id: I62c58617dbcf27c097009859213cb78eb59a8008 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2025-02-11 17:53:43 +00:00
QVERIFY(QTest::qWaitForWindowActive(mainMenu_d->popupItem->window()));
QCOMPARE(mainMenu_d->popupItem->window(), mainMenu_d->popupWindow);
PopupPositioner: ensure popup windows are placed inside a screen When `popupType: Popup.Item`, the popup positioner will attempt to flip, move and resize the popup item, in order to make it fit inside its window. We want something similar for when `popupType: Popup.Window`, except that the bounds in this case, ends up being the geometry of the screen that contains the popup window, instead of the nearest parent item's window. The omission of any resizing to the popup window, is done on purpose. Since the popup positioner's current role, is to only affect the popup window position. This might change in the future, in case we decide to refactor some of the logic around popup window resizing. Pick-to: 6.9 6.8 Change-Id: Iee0f1c7363624b73d0b64f0b6c47765abdb365e2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-26 14:25:42 +00:00
}
Use leftPadding of parent menus when flipping submenus QQuickMenuPositioner positions child menus to the right of the menu item that opened it. In additon, the overlap and rightPadding properties are used to offset the x position, which styles can use to fine tune how exactly submenus should be positioned relative to the parent menu item. The parent menu's padding is used, because the submenu's position is initially set to be relative to the menu item that opened it. When the position is offset by the padding, it will position itself to the parent menu, and not just the parent menu item. 7add1868c0956bca769a33d2974b211c6e533567 introduced the flipping behavior for menus that have their popupType set to Popup.Window. Causing menus that don't have enough space to open to the right side, to instead open on the left side. The aformentioned patch used the overlap, but forgot to also add the leftPadding, when flipping submenus. Also fix the test tst_QQuickMenu::subMenuFlipsPositionWhenOutOfBounds, which was previously broken on all styles that modified the rightPadding property of Menu. 6e327f28c7cd05d90881998696da45615 introduced a temporary fix, in order to unblock CI, and this patch should fix it properly. Pick-to: 6.9 6.8 Change-Id: I62c58617dbcf27c097009859213cb78eb59a8008 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2025-02-11 17:53:43 +00:00
QVERIFY(QQuickTest::qWaitForPolish(mainMenu_d->popupItem->window()));
PopupPositioner: ensure popup windows are placed inside a screen When `popupType: Popup.Item`, the popup positioner will attempt to flip, move and resize the popup item, in order to make it fit inside its window. We want something similar for when `popupType: Popup.Window`, except that the bounds in this case, ends up being the geometry of the screen that contains the popup window, instead of the nearest parent item's window. The omission of any resizing to the popup window, is done on purpose. Since the popup positioner's current role, is to only affect the popup window position. This might change in the future, in case we decide to refactor some of the logic around popup window resizing. Pick-to: 6.9 6.8 Change-Id: Iee0f1c7363624b73d0b64f0b6c47765abdb365e2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-26 14:25:42 +00:00
for (int i = 0; i < mainMenu->count(); ++i) {
QTest::keyClick(window, Qt::Key_Down);
QTRY_COMPARE(mainMenu->currentIndex(), i);
}
QTest::keyClick(window, Qt::Key_Right);
QTRY_VERIFY(subMenu->isOpened());
const auto *subMenu_d = QQuickPopupPrivate::get(subMenu);
QVERIFY(subMenu_d);
if (subMenu_d->usePopupWindow()) {
SKIP_IF_NO_WINDOW_ACTIVATION;
Use leftPadding of parent menus when flipping submenus QQuickMenuPositioner positions child menus to the right of the menu item that opened it. In additon, the overlap and rightPadding properties are used to offset the x position, which styles can use to fine tune how exactly submenus should be positioned relative to the parent menu item. The parent menu's padding is used, because the submenu's position is initially set to be relative to the menu item that opened it. When the position is offset by the padding, it will position itself to the parent menu, and not just the parent menu item. 7add1868c0956bca769a33d2974b211c6e533567 introduced the flipping behavior for menus that have their popupType set to Popup.Window. Causing menus that don't have enough space to open to the right side, to instead open on the left side. The aformentioned patch used the overlap, but forgot to also add the leftPadding, when flipping submenus. Also fix the test tst_QQuickMenu::subMenuFlipsPositionWhenOutOfBounds, which was previously broken on all styles that modified the rightPadding property of Menu. 6e327f28c7cd05d90881998696da45615 introduced a temporary fix, in order to unblock CI, and this patch should fix it properly. Pick-to: 6.9 6.8 Change-Id: I62c58617dbcf27c097009859213cb78eb59a8008 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2025-02-11 17:53:43 +00:00
QVERIFY(QTest::qWaitForWindowActive(subMenu_d->popupItem->window()));
QCOMPARE(subMenu_d->popupItem->window(), subMenu_d->popupWindow);
QVERIFY(QQuickTest::qWaitForPolish(subMenu_d->popupItem->window()));
PopupPositioner: ensure popup windows are placed inside a screen When `popupType: Popup.Item`, the popup positioner will attempt to flip, move and resize the popup item, in order to make it fit inside its window. We want something similar for when `popupType: Popup.Window`, except that the bounds in this case, ends up being the geometry of the screen that contains the popup window, instead of the nearest parent item's window. The omission of any resizing to the popup window, is done on purpose. Since the popup positioner's current role, is to only affect the popup window position. This might change in the future, in case we decide to refactor some of the logic around popup window resizing. Pick-to: 6.9 6.8 Change-Id: Iee0f1c7363624b73d0b64f0b6c47765abdb365e2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-26 14:25:42 +00:00
}
Use leftPadding of parent menus when flipping submenus QQuickMenuPositioner positions child menus to the right of the menu item that opened it. In additon, the overlap and rightPadding properties are used to offset the x position, which styles can use to fine tune how exactly submenus should be positioned relative to the parent menu item. The parent menu's padding is used, because the submenu's position is initially set to be relative to the menu item that opened it. When the position is offset by the padding, it will position itself to the parent menu, and not just the parent menu item. 7add1868c0956bca769a33d2974b211c6e533567 introduced the flipping behavior for menus that have their popupType set to Popup.Window. Causing menus that don't have enough space to open to the right side, to instead open on the left side. The aformentioned patch used the overlap, but forgot to also add the leftPadding, when flipping submenus. Also fix the test tst_QQuickMenu::subMenuFlipsPositionWhenOutOfBounds, which was previously broken on all styles that modified the rightPadding property of Menu. 6e327f28c7cd05d90881998696da45615 introduced a temporary fix, in order to unblock CI, and this patch should fix it properly. Pick-to: 6.9 6.8 Change-Id: I62c58617dbcf27c097009859213cb78eb59a8008 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2025-02-11 17:53:43 +00:00
const QPointF mainMenuGlobalPos = mainMenu_d->popupItem->mapToGlobal({mainMenu->leftMargin(), mainMenu->topMargin()});
const QPointF subMenuGlobalPos = subMenu_d->popupItem->mapToGlobal({subMenu->leftMargin(), subMenu->topMargin()});
const qreal expectedGlobalSubMenuPositionX = qFloor(mainMenuGlobalPos.x()) - subMenu->width() + mainMenu->overlap() * mainMenu->scale();
PopupPositioner: ensure popup windows are placed inside a screen When `popupType: Popup.Item`, the popup positioner will attempt to flip, move and resize the popup item, in order to make it fit inside its window. We want something similar for when `popupType: Popup.Window`, except that the bounds in this case, ends up being the geometry of the screen that contains the popup window, instead of the nearest parent item's window. The omission of any resizing to the popup window, is done on purpose. Since the popup positioner's current role, is to only affect the popup window position. This might change in the future, in case we decide to refactor some of the logic around popup window resizing. Pick-to: 6.9 6.8 Change-Id: Iee0f1c7363624b73d0b64f0b6c47765abdb365e2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-26 14:25:42 +00:00
Use leftPadding of parent menus when flipping submenus QQuickMenuPositioner positions child menus to the right of the menu item that opened it. In additon, the overlap and rightPadding properties are used to offset the x position, which styles can use to fine tune how exactly submenus should be positioned relative to the parent menu item. The parent menu's padding is used, because the submenu's position is initially set to be relative to the menu item that opened it. When the position is offset by the padding, it will position itself to the parent menu, and not just the parent menu item. 7add1868c0956bca769a33d2974b211c6e533567 introduced the flipping behavior for menus that have their popupType set to Popup.Window. Causing menus that don't have enough space to open to the right side, to instead open on the left side. The aformentioned patch used the overlap, but forgot to also add the leftPadding, when flipping submenus. Also fix the test tst_QQuickMenu::subMenuFlipsPositionWhenOutOfBounds, which was previously broken on all styles that modified the rightPadding property of Menu. 6e327f28c7cd05d90881998696da45615 introduced a temporary fix, in order to unblock CI, and this patch should fix it properly. Pick-to: 6.9 6.8 Change-Id: I62c58617dbcf27c097009859213cb78eb59a8008 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2025-02-11 17:53:43 +00:00
if (popupType == QQuickPopup::Item && !qFuzzyCompare(mainMenu->scale(), 1.0))
QEXPECT_FAIL(nullptr, "Item based menu flipping doesn't properly work when the parent menu's scale isn't 1.0", TestFailMode::Continue);
PopupPositioner: ensure popup windows are placed inside a screen When `popupType: Popup.Item`, the popup positioner will attempt to flip, move and resize the popup item, in order to make it fit inside its window. We want something similar for when `popupType: Popup.Window`, except that the bounds in this case, ends up being the geometry of the screen that contains the popup window, instead of the nearest parent item's window. The omission of any resizing to the popup window, is done on purpose. Since the popup positioner's current role, is to only affect the popup window position. This might change in the future, in case we decide to refactor some of the logic around popup window resizing. Pick-to: 6.9 6.8 Change-Id: Iee0f1c7363624b73d0b64f0b6c47765abdb365e2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-26 14:25:42 +00:00
QCOMPARE(subMenuGlobalPos.x(), mainMenu->cascade() ? expectedGlobalSubMenuPositionX : mainMenuGlobalPos.x());
}
QuickControls2: implement icons for submenus Previously in Qt 5 there was an option to define iconSource property in Controls 1 Menu. But it's missed in Controls 2, so it's not possible to use icon for submenu item in Qt 6. This patch introduces icon group property for the Menu so that it behaves and displayed the same as for regular menu items. [ChangeLog][QtQuick][Controls] Now it's possible to set icon for Menu. This is useful for submenus, so icon will be displayed as for regular menu items. Fixes: QTBUG-79972 Change-Id: I4610d4b6d40c51b774b035e238e5e1ceea53a8a3 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-09-14 11:09:49 +00:00
void tst_QQuickMenu::subMenuWithIcon()
{
QQuickControlsApplicationHelper helper(this, QLatin1String("subMenus.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
QQuickMenu *mainMenu = window->property("mainMenu").value<QQuickMenu *>();
QVERIFY(mainMenu);
QQuickMenu *subMenu = window->property("subMenu1").value<QQuickMenu *>();
QVERIFY(subMenu);
const int iconWidth = 14;
const int iconHeight = 20;
const QUrl iconSource("qrc:/qt-project.org/imports/QtQuick/Controls/Basic/images/check.png");
QQuickIcon icon;
icon.setSource(iconSource);
icon.setWidth(iconWidth);
icon.setHeight(iconHeight);
subMenu->setIcon(icon);
QCOMPARE(subMenu->icon().source(), iconSource);
QCOMPARE(subMenu->icon().width(), iconWidth);
QCOMPARE(subMenu->icon().height(), iconHeight);
QQuickMenuItem *subMenuItem = qobject_cast<QQuickMenuItem *>(mainMenu->itemAt(1));
QVERIFY(subMenuItem);
QCOMPARE(subMenuItem->icon().source(), iconSource);
QCOMPARE(subMenuItem->icon().width(), iconWidth);
QCOMPARE(subMenuItem->icon().height(), iconHeight);
}
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: .gitignore tests/auto/auto.pro tests/auto/qquickmenu/tst_qquickmenu.cpp tests/auto/qquickpopup/tst_qquickpopup.cpp Change-Id: I7e5a7b39d890796fd63a7b24ae19765ab41fecda
2017-09-27 18:07:23 +00:00
void tst_QQuickMenu::addRemoveSubMenus()
Add QQuickMenu::add/insert/remove/takeMenu() [ChangeLog][Controls][Menu] Added addMenu(), insertMenu(), removeMenu(), and takeMenu() methods for adding and removing sub-menus programmatically. Change-Id: Ibf39448cdf528f64695b1ee5f0781384b754ba22 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-07 17:43:58 +00:00
{
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("subMenus.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Add QQuickMenu::add/insert/remove/takeMenu() [ChangeLog][Controls][Menu] Added addMenu(), insertMenu(), removeMenu(), and takeMenu() methods for adding and removing sub-menus programmatically. Change-Id: Ibf39448cdf528f64695b1ee5f0781384b754ba22 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-07 17:43:58 +00:00
QQuickWindow *window = helper.window;
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Add QQuickMenu::add/insert/remove/takeMenu() [ChangeLog][Controls][Menu] Added addMenu(), insertMenu(), removeMenu(), and takeMenu() methods for adding and removing sub-menus programmatically. Change-Id: Ibf39448cdf528f64695b1ee5f0781384b754ba22 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-07 17:43:58 +00:00
QQuickMenu *mainMenu = window->property("mainMenu").value<QQuickMenu *>();
QVERIFY(mainMenu);
QQuickMenu: add actionAt() and menuAt() accessors This complements the add/insert/remove/take API that was added for actions and menus. Unlike for menu items, there was no convenient way to access a specific action or menu directly without accessing the respective item first. [ChangeLog][Controls][Menu] Added actionAt() and menuAt() accessors. Change-Id: I5515441626b3a04b05265d5b42afdaea8e256709 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 09:59:47 +00:00
QVERIFY(!mainMenu->menuAt(0));
Add QQuickMenu::add/insert/remove/takeMenu() [ChangeLog][Controls][Menu] Added addMenu(), insertMenu(), removeMenu(), and takeMenu() methods for adding and removing sub-menus programmatically. Change-Id: Ibf39448cdf528f64695b1ee5f0781384b754ba22 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-07 17:43:58 +00:00
QPointer<QQuickMenu> subMenu1 = window->property("subMenu1").value<QQuickMenu *>();
QVERIFY(!subMenu1.isNull());
QQuickMenu: add actionAt() and menuAt() accessors This complements the add/insert/remove/take API that was added for actions and menus. Unlike for menu items, there was no convenient way to access a specific action or menu directly without accessing the respective item first. [ChangeLog][Controls][Menu] Added actionAt() and menuAt() accessors. Change-Id: I5515441626b3a04b05265d5b42afdaea8e256709 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 09:59:47 +00:00
QCOMPARE(mainMenu->menuAt(1), subMenu1.data());
QVERIFY(!mainMenu->menuAt(2));
Add QQuickMenu::add/insert/remove/takeMenu() [ChangeLog][Controls][Menu] Added addMenu(), insertMenu(), removeMenu(), and takeMenu() methods for adding and removing sub-menus programmatically. Change-Id: Ibf39448cdf528f64695b1ee5f0781384b754ba22 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-07 17:43:58 +00:00
QPointer<QQuickMenu> subMenu2 = window->property("subMenu2").value<QQuickMenu *>();
QVERIFY(!subMenu2.isNull());
QQuickMenu: add actionAt() and menuAt() accessors This complements the add/insert/remove/take API that was added for actions and menus. Unlike for menu items, there was no convenient way to access a specific action or menu directly without accessing the respective item first. [ChangeLog][Controls][Menu] Added actionAt() and menuAt() accessors. Change-Id: I5515441626b3a04b05265d5b42afdaea8e256709 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-07-10 09:59:47 +00:00
QCOMPARE(mainMenu->menuAt(3), subMenu2.data());
QVERIFY(!mainMenu->menuAt(4));
Add QQuickMenu::add/insert/remove/takeMenu() [ChangeLog][Controls][Menu] Added addMenu(), insertMenu(), removeMenu(), and takeMenu() methods for adding and removing sub-menus programmatically. Change-Id: Ibf39448cdf528f64695b1ee5f0781384b754ba22 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-06-07 17:43:58 +00:00
QPointer<QQuickMenu> subSubMenu1 = window->property("subSubMenu1").value<QQuickMenu *>();
QVERIFY(!subSubMenu1.isNull());
// takeMenu(int) does not destroy the menu, but does destroy the respective item in the parent menu
QPointer<QQuickMenuItem> subSubMenu1Item = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(2));
QVERIFY(subSubMenu1Item);
QCOMPARE(subSubMenu1Item->subMenu(), subSubMenu1.data());
QCOMPARE(subMenu1->takeMenu(2), subSubMenu1.data());
QVERIFY(!subMenu1->itemAt(2));
QCoreApplication::sendPostedEvents(subSubMenu1, QEvent::DeferredDelete);
QVERIFY(!subSubMenu1.isNull());
QCoreApplication::sendPostedEvents(subSubMenu1Item, QEvent::DeferredDelete);
QVERIFY(subSubMenu1Item.isNull());
// takeMenu(int) does not destroy an item that doesn't present a menu
QPointer<QQuickMenuItem> subMenuItem1 = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(0));
QVERIFY(subMenuItem1);
QVERIFY(!subMenuItem1->subMenu());
QVERIFY(!subMenu1->takeMenu(0));
QCoreApplication::sendPostedEvents(subMenuItem1, QEvent::DeferredDelete);
QVERIFY(!subMenuItem1.isNull());
// addMenu(Menu) re-creates the respective item in the parent menu
subMenu1->addMenu(subSubMenu1);
subSubMenu1Item = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(2));
QVERIFY(!subSubMenu1Item.isNull());
// removeMenu(Menu) destroys both the menu and the respective item in the parent menu
subMenu1->removeMenu(subSubMenu1);
QVERIFY(!subMenu1->itemAt(2));
QCoreApplication::sendPostedEvents(subSubMenu1, QEvent::DeferredDelete);
QVERIFY(subSubMenu1.isNull());
QCoreApplication::sendPostedEvents(subSubMenu1Item, QEvent::DeferredDelete);
QVERIFY(subSubMenu1Item.isNull());
}
QQuickMenu: let a child menu use the same popup type as the parent We currently allow a child menu to have a popupType different from the parent menu. This will not work in practice, since all menus in the same hierarchy have to have the same type. Rather than placing the burden on the application developer to set the same popup type on all (sub)menus, we let QQuickMenu do this automatically based on the what the root menu ends up using. This is also the documented behavior. In order to implement this change, add a virtual QQuickPopup::resolvedPopupType(). The other sub-classes of QQuickPopup can then override this function and resolve the actual popup type at run-time. This also allows us to remove using Qt::Widget as a popupWindowType(), since e.g a Drawer will never resolve the popup type to be QQuickPopup::Window anyway. Pick-to: 6.8 Change-Id: I9cf95bb02fb0a912497c77d2df25a9cb76c153cd Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-12 11:50:31 +00:00
void tst_QQuickMenu::subMenuPopupType()
{
Add arePopupWindowsSupported function to QQuickControlsTestUtils And reduce a few duplicate checks throughout our tests. Pick-to: 6.8 6.9 Change-Id: I31610f07eb548282ade5573af56ffef18d33cd66 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2025-03-25 05:26:26 +00:00
if (!arePopupWindowsSupported())
Only test popup windows on Windows and macOS Testing popup windows is a lot more tedius than popup items, since we're at the mercy of the window manager to position the window, based on our requests. Android and QNX in particular has caused us much headache, since they're currently able to use popup windows, but they also behave very different from normal desktop systems. Since popup windows are intended to be used by desktop platforms, it doesn't make sense that QNX and Android show stop us from merging patches that improve the feature for the platforms they're intended for. By limiting testing to Windows and macOS, we can safely know that the feature works on these stable platforms, while also being able to get fixes through CI. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I6bb2a9308382bb3a17f6640ebcf4254e101f5f58 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-23 15:53:26 +00:00
QSKIP("The platform doesn't support popup windows. Skipping test.");
QQuickMenu: respect Qt::AA_DontUseNativeMenuWindows Now that we enable native menus by default for the macOS style, we also need to make sure that we actually respect the Qt::AA_DontUseNativeMenuWindows. Pick-to: 6.8 Change-Id: I2a02b5528110a4e0514fb53c0673653f0086dfe8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-27 10:18:09 +00:00
// Undo the setting of AA_DontUseNativeMenuWindows to true from init()
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuWindows, false);
QQuickMenu: let a child menu use the same popup type as the parent We currently allow a child menu to have a popupType different from the parent menu. This will not work in practice, since all menus in the same hierarchy have to have the same type. Rather than placing the burden on the application developer to set the same popup type on all (sub)menus, we let QQuickMenu do this automatically based on the what the root menu ends up using. This is also the documented behavior. In order to implement this change, add a virtual QQuickPopup::resolvedPopupType(). The other sub-classes of QQuickPopup can then override this function and resolve the actual popup type at run-time. This also allows us to remove using Qt::Widget as a popupWindowType(), since e.g a Drawer will never resolve the popup type to be QQuickPopup::Window anyway. Pick-to: 6.8 Change-Id: I9cf95bb02fb0a912497c77d2df25a9cb76c153cd Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-12 11:50:31 +00:00
// Check that all sub-menus will end up with an effective popup
// type equal to the root menu.
QQuickControlsApplicationHelper helper(this, QLatin1String("subMenus.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickWindow *window = helper.window;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
auto *mainMenu = window->property("mainMenu").value<QQuickMenu *>();
auto *subMenu1 = window->property("subMenu1").value<QQuickMenu *>();
auto *subSubMenu1 = window->property("subSubMenu1").value<QQuickMenu *>();
QVERIFY(mainMenu);
QVERIFY(subMenu1);
QVERIFY(subSubMenu1);
auto *mainMenu_d = QQuickMenuPrivate::get(mainMenu);
auto *subMenu1_d = QQuickMenuPrivate::get(subMenu1);
auto *subSubMenu1_d = QQuickMenuPrivate::get(subSubMenu1);
mainMenu->setPopupType(QQuickPopup::Item);
QCOMPARE(mainMenu->popupType(), QQuickPopup::Item);
mainMenu->open();
QTRY_VERIFY(mainMenu->isOpened());
QCOMPARE(mainMenu_d->resolvedPopupType(), QQuickPopup::Item);
QCOMPARE(subMenu1_d->resolvedPopupType(), QQuickPopup::Item);
QCOMPARE(subSubMenu1_d->resolvedPopupType(), QQuickPopup::Item);
mainMenu->close();
QTRY_VERIFY(!mainMenu->isVisible());
// Even if we set QQuickPopup::Window as preferred popup type for
// subMenu1, the the effective type will still be the same as the
// parent menu: QQuickPopup::Item
subMenu1->setPopupType(QQuickPopup::Window);
QCOMPARE(subMenu1->popupType(), QQuickPopup::Window);
QCOMPARE(mainMenu->popupType(), QQuickPopup::Item);
mainMenu->open();
QTRY_VERIFY(mainMenu->isOpened());
QCOMPARE(mainMenu_d->resolvedPopupType(), QQuickPopup::Item);
QCOMPARE(subMenu1_d->resolvedPopupType(), QQuickPopup::Item);
QCOMPARE(subSubMenu1_d->resolvedPopupType(), QQuickPopup::Item);
mainMenu->close();
QTRY_VERIFY(!mainMenu->isVisible());
// Setting QQuickPopup::Window on the root menu will force all sub-menus
// to use QQuickPopup::Window as well, if it's supported on the platform
// where the test runs. Otherwise it will fall back to QQuickPopup::Item.
mainMenu->setPopupType(QQuickPopup::Window);
QCOMPARE(mainMenu->popupType(), QQuickPopup::Window);
QCOMPARE(subMenu1->popupType(), QQuickPopup::Window);
mainMenu->open();
QTRY_VERIFY(mainMenu->isOpened());
Only test popup windows on Windows and macOS Testing popup windows is a lot more tedius than popup items, since we're at the mercy of the window manager to position the window, based on our requests. Android and QNX in particular has caused us much headache, since they're currently able to use popup windows, but they also behave very different from normal desktop systems. Since popup windows are intended to be used by desktop platforms, it doesn't make sense that QNX and Android show stop us from merging patches that improve the feature for the platforms they're intended for. By limiting testing to Windows and macOS, we can safely know that the feature works on these stable platforms, while also being able to get fixes through CI. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I6bb2a9308382bb3a17f6640ebcf4254e101f5f58 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-23 15:53:26 +00:00
QCOMPARE(mainMenu_d->resolvedPopupType(), QQuickPopup::Window);
QCOMPARE(subMenu1_d->resolvedPopupType(), QQuickPopup::Window);
QCOMPARE(subSubMenu1_d->resolvedPopupType(), QQuickPopup::Window);
QQuickMenu: let a child menu use the same popup type as the parent We currently allow a child menu to have a popupType different from the parent menu. This will not work in practice, since all menus in the same hierarchy have to have the same type. Rather than placing the burden on the application developer to set the same popup type on all (sub)menus, we let QQuickMenu do this automatically based on the what the root menu ends up using. This is also the documented behavior. In order to implement this change, add a virtual QQuickPopup::resolvedPopupType(). The other sub-classes of QQuickPopup can then override this function and resolve the actual popup type at run-time. This also allows us to remove using Qt::Widget as a popupWindowType(), since e.g a Drawer will never resolve the popup type to be QQuickPopup::Window anyway. Pick-to: 6.8 Change-Id: I9cf95bb02fb0a912497c77d2df25a9cb76c153cd Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-12 11:50:31 +00:00
mainMenu->close();
QTRY_VERIFY(!mainMenu->isVisible());
// Setting QQuickPopup::Native on the root menu will force all sub-menus
// to use QQuickPopup::Native as well, if it's supported on the platform
// where the test runs. Otherwise it will fall back to either
// QQuickPopup::Window or QQuickPopup::Item.
mainMenu->setPopupType(QQuickPopup::Native);
QCOMPARE(mainMenu->popupType(), QQuickPopup::Native);
QCOMPARE(subMenu1->popupType(), QQuickPopup::Window);
if (nativeMenuSupported) {
// Note that we cannot actually show a native popup while testing, since
// that will be a blocking call. Instead we just verify that we
// intend to use a native menu.
QVERIFY(mainMenu_d->useNativeMenu());
QVERIFY(subMenu1_d->useNativeMenu());
QVERIFY(subSubMenu1_d->useNativeMenu());
} else {
// When Native is not supported, we fall back to either Window or Item
mainMenu->open();
QTRY_VERIFY(mainMenu->isOpened());
Only test popup windows on Windows and macOS Testing popup windows is a lot more tedius than popup items, since we're at the mercy of the window manager to position the window, based on our requests. Android and QNX in particular has caused us much headache, since they're currently able to use popup windows, but they also behave very different from normal desktop systems. Since popup windows are intended to be used by desktop platforms, it doesn't make sense that QNX and Android show stop us from merging patches that improve the feature for the platforms they're intended for. By limiting testing to Windows and macOS, we can safely know that the feature works on these stable platforms, while also being able to get fixes through CI. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I6bb2a9308382bb3a17f6640ebcf4254e101f5f58 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2024-08-23 15:53:26 +00:00
QCOMPARE(mainMenu_d->resolvedPopupType(), QQuickPopup::Window);
QCOMPARE(subMenu1_d->resolvedPopupType(), QQuickPopup::Window);
QCOMPARE(subSubMenu1_d->resolvedPopupType(), QQuickPopup::Window);
QQuickMenu: let a child menu use the same popup type as the parent We currently allow a child menu to have a popupType different from the parent menu. This will not work in practice, since all menus in the same hierarchy have to have the same type. Rather than placing the burden on the application developer to set the same popup type on all (sub)menus, we let QQuickMenu do this automatically based on the what the root menu ends up using. This is also the documented behavior. In order to implement this change, add a virtual QQuickPopup::resolvedPopupType(). The other sub-classes of QQuickPopup can then override this function and resolve the actual popup type at run-time. This also allows us to remove using Qt::Widget as a popupWindowType(), since e.g a Drawer will never resolve the popup type to be QQuickPopup::Window anyway. Pick-to: 6.8 Change-Id: I9cf95bb02fb0a912497c77d2df25a9cb76c153cd Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-12 11:50:31 +00:00
mainMenu->close();
QTRY_VERIFY(!mainMenu->isVisible());
}
}
Menu: fix items not being scrollable when using Window Use Window.window instead of ApplicationWindow.window, as the former will always result in a window regardless of which type of window is in use. Task-number: QTBUG-68858 Change-Id: I3bdb60350d92b13621b0f4db9085bf067b6ff6e2 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-06-18 09:38:40 +00:00
void tst_QQuickMenu::scrollable_data()
{
QTest::addColumn<QString>("qmlFilePath");
QTest::addRow("Window") << QString::fromLatin1("windowScrollable.qml");
QTest::addRow("ApplicationWindow") << QString::fromLatin1("applicationWindowScrollable.qml");
Account for the padding around a menu when checking if it is interactive If there is padding around the menu then it will mean the available height is smaller than the containing item and as such should be interactive. Fixes: QTBUG-82473 Change-Id: Ie3e7568ab66aa3da93e5448c1a27c9bd2a5e486a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-03-17 19:19:41 +00:00
QTest::addRow("WithPadding") << QString::fromLatin1("scrollableWithPadding.qml");
Menu: fix contentItem's interactive The interactive property of the Menu's contentItem depends on its Menu (control) when Window.window is valid. In the case of a fixed-height menu, even if the contentItem's height is smaller than Window.window.height, the interactive property of the contentItem would be false if the menu's height is smaller than the window's height and also smaller than its contentItem's height. Fixes: QTBUG-93856 Pick-to: 6.6 6.5 6.2 Change-Id: If95080250c3953d4293a9e1dbcc6225d21ee034f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2023-11-13 12:44:22 +00:00
QTest::addRow("FixedHeight") << QString::fromLatin1("scrollableWithFixedHeight.qml");
Menu: fix items not being scrollable when using Window Use Window.window instead of ApplicationWindow.window, as the former will always result in a window regardless of which type of window is in use. Task-number: QTBUG-68858 Change-Id: I3bdb60350d92b13621b0f4db9085bf067b6ff6e2 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-06-18 09:38:40 +00:00
}
void tst_QQuickMenu::scrollable()
{
QFETCH(QString, qmlFilePath);
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, qmlFilePath);
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Menu: fix items not being scrollable when using Window Use Window.window instead of ApplicationWindow.window, as the former will always result in a window regardless of which type of window is in use. Task-number: QTBUG-68858 Change-Id: I3bdb60350d92b13621b0f4db9085bf067b6ff6e2 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-06-18 09:38:40 +00:00
QQuickWindow *window = helper.window;
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
#ifndef Q_OS_ANDROID
Menu: fix items not being scrollable when using Window Use Window.window instead of ApplicationWindow.window, as the former will always result in a window regardless of which type of window is in use. Task-number: QTBUG-68858 Change-Id: I3bdb60350d92b13621b0f4db9085bf067b6ff6e2 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-06-18 09:38:40 +00:00
window->show();
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
#else
window->showNormal();
#endif
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Menu: fix items not being scrollable when using Window Use Window.window instead of ApplicationWindow.window, as the former will always result in a window regardless of which type of window is in use. Task-number: QTBUG-68858 Change-Id: I3bdb60350d92b13621b0f4db9085bf067b6ff6e2 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-06-18 09:38:40 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
tst_qquickmenu: force some tests to use popupType: Popup.Item These tests pass with `popupType: Popup.Window` on some systems, but not on Windows. For now, we`ll just force them to use the popupType that we know works. Further investigation is needed to figure out how to make them work on Windows, and other platforms. Task-number: QTBUG-128474 Pick-to: 6.8 Change-Id: If018c9b964dcf77ec2cbf6a1ee64f2d834a47e3e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-29 12:57:04 +00:00
// TODO: QTBUG-128474
menu->setPopupType(QQuickPopup::Item);
Menu: fix items not being scrollable when using Window Use Window.window instead of ApplicationWindow.window, as the former will always result in a window regardless of which type of window is in use. Task-number: QTBUG-68858 Change-Id: I3bdb60350d92b13621b0f4db9085bf067b6ff6e2 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-06-18 09:38:40 +00:00
menu->open();
QVERIFY(menu->isVisible());
QQuickItem *contentItem = menu->contentItem();
QCOMPARE(contentItem->property("interactive").toBool(), true);
}
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
void tst_QQuickMenu::disableWhenTriggered_data()
{
QTest::addColumn<int>("menuItemIndex");
QTest::addColumn<int>("subMenuItemIndex");
QTest::addRow("Action") << 0 << -1;
QTest::addRow("MenuItem with Action") << 1 << -1;
QTest::addRow("MenuItem with Action declared outside menu") << 2 << -1;
QTest::addRow("MenuItem with no Action") << 3 << -1;
QTest::addRow("Sub-Action") << 4 << 0;
QTest::addRow("Sub-MenuItem with Action declared inside") << 4 << 1;
QTest::addRow("Sub-MenuItem with Action declared outside menu") << 4 << 2;
QTest::addRow("Sub-MenuItem with no Action") << 4 << 3;
}
// Tests that the menu is dismissed when a menu item sets "enabled = false" in onTriggered().
void tst_QQuickMenu::disableWhenTriggered()
{
Move duplicate mouse hover checks into a skip macro Similar to 8d454b26263e5333d8475bbab91d7b3d1d5e04d8 and f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Pick-to: 6.5 6.8 Change-Id: Iaf9a4edc8a3c37f232ad3b66923864f4baa02d4d Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2024-11-21 06:54:21 +00:00
SKIP_IF_NO_MOUSE_HOVER;
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
QFETCH(int, menuItemIndex);
QFETCH(int, subMenuItemIndex);
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("disableWhenTriggered.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
QQuickWindow *window = helper.window;
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
QQuickMenu *menu = window->findChild<QQuickMenu*>("Menu");
QVERIFY(menu);
tst_qquickmenu: force some tests to use popupType: Popup.Item These tests pass with `popupType: Popup.Window` on some systems, but not on Windows. For now, we`ll just force them to use the popupType that we know works. Further investigation is needed to figure out how to make them work on Windows, and other platforms. Task-number: QTBUG-128474 Pick-to: 6.8 Change-Id: If018c9b964dcf77ec2cbf6a1ee64f2d834a47e3e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-29 12:57:04 +00:00
// TODO: QTBUG-128474
menu->setPopupType(QQuickPopup::Item);
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
menu->open();
QVERIFY(menu->isVisible());
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(menu->isOpened());
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
Make tst_qquickmenu::disableWhenTriggered work with popup windows We're debating on whether or not we want to change the default popupType for popups and menus. This patch should make the remaining test work, by waiting for the popup window to appear, before sending input events. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: I27d48baef97a8b106cfdfede36652e5281b20862 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-08-27 06:32:07 +00:00
QQuickMenuPrivate *menuPrivate = QQuickMenuPrivate::get(menu);
if (menuPrivate->usePopupWindow()) {
QTRY_VERIFY(menuPrivate->popupWindow);
QVERIFY(QTest::qWaitForWindowExposed(menuPrivate->popupWindow));
}
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
QPointer<QQuickMenuItem> menuItem = qobject_cast<QQuickMenuItem*>(menu->itemAt(menuItemIndex));
QVERIFY(menuItem);
if (subMenuItemIndex == -1) {
// Click a top-level menu item.
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier,
menuItem->mapToScene(QPointF(menuItem->width() / 2, menuItem->height() / 2)).toPoint());
QCOMPARE(menuItem->isEnabled(), false);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(!menu->isVisible());
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
} else {
// Click a sub-menu item.
QPointer<QQuickMenu> subMenu = menuItem->subMenu();
QVERIFY(subMenu);
QPointer<QQuickMenuItem> subMenuItem = qobject_cast<QQuickMenuItem*>(subMenu->itemAt(subMenuItemIndex));
QVERIFY(subMenuItem);
// First, open the sub-menu.
tst_qquickmenu: click sub-menu to open it on webOS It appears that webOS behaves like Android platform and mouseHover does not open a sub-menu. The solution is the click the menu like we do on Android. Fixes: QTBUG-106491 Pick-to: 6.4 Change-Id: I51ee9b2c1aa161db85a7eec2c5f1822380895a8f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-09-12 12:41:40 +00:00
#if !defined(Q_OS_ANDROID) and !defined(Q_OS_WEBOS)
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
QTest::mouseMove(window, menuItem->mapToScene(QPoint(1, 1)).toPoint());
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
#else
tst_qquickmenu: click sub-menu to open it on webOS It appears that webOS behaves like Android platform and mouseHover does not open a sub-menu. The solution is the click the menu like we do on Android. Fixes: QTBUG-106491 Pick-to: 6.4 Change-Id: I51ee9b2c1aa161db85a7eec2c5f1822380895a8f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-09-12 12:41:40 +00:00
// On Android and webOS mouseHover does not open sub-menu, so just click on it
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier,
menuItem->mapToScene(QPointF(menuItem->width() / 2, menuItem->height() / 2)).toPoint());
#endif
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(subMenu->isOpened());
tst_qquickmenu: skip menuItem->isHovered() check on webOS Opening a sub-menu by mouse hover is not a supported feature on webOS, so that check caused a test failure. Fixes: QTBUG-106491 Pick-to: 6.5 6.4 Change-Id: Ib5fc2013498d189df05be9399b5861197c4ed662 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2023-01-05 12:48:20 +00:00
#if !defined(Q_OS_ANDROID) and !defined(Q_OS_WEBOS)
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
QVERIFY(menuItem->isHovered());
QTRY_VERIFY(subMenu->contentItem()->property("contentHeight").toReal() > 0.0);
Android: fix tst_QQuickMenu There were several reasons for the test failures: - Difference in default behavior on Android and Desktop systems. On Android the menus are not cascading by default, so some tests failed because they were expecting cascading menus. That is fixed by explicitly specifying cascade flag in QML files. - Mouse hovering does not open/close sub-menus on Android, because Android has no cursor support. So parts of the tests that rely on this behavior are simply skipped. Same for the parts of the tests that try to explicitly set cursor position. - Some of the tests expect certain window size. On Android calling QQuickWindow::show() shows the window fullscreen, which can be larger or smaller than an expected size. As a result the tests fail because various assumptions are broken. That is fixed by using showNormal(), which shows the window with the desired size. This makes little sense in real applications, because it can result in some information being "hidden" behind the screen border, but seems to be fine for tests. - The previously skipped tst_QQuickMenu::disableWhenTriggered() is now enabled, because it does not crash and needed just some minor adjustments. Fixes: QTBUG-100256 Pick-to: 6.3 6.2 Change-Id: I53832f52071d5c2495a97058a968775d3f89598e Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-04-22 15:01:14 +00:00
#endif
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
// Click the item.
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier,
subMenuItem->mapToScene(QPointF(subMenuItem->width() / 2, subMenuItem->height() / 2)).toPoint());
QCOMPARE(subMenuItem->isEnabled(), false);
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTRY_VERIFY(!menu->isVisible());
Fix Menu not being dismissed when the triggered item disables itself Problem Consider the following code: Menu { title: "Menu" Action { text: "Item" onTriggered: enabled = false } } A MenuItem (AbstractButton) is created for the Action, and when it is clicked, this function is called: void QQuickAbstractButtonPrivate::trigger() { Q_Q(QQuickAbstractButton); if (action && action->isEnabled()) QQuickActionPrivate::get(action)->trigger(q, false); else if (effectiveEnable) emit q->clicked(); } QQuickActionPrivate::get(action)->trigger(q, false) results in this function being called: void QQuickAbstractButtonPrivate::click() { Q_Q(QQuickAbstractButton); if (effectiveEnable) emit q->clicked(); } Since the action (and hence the menu item) was disabled in the signal handler, the effectiveEnable check fails and clicked() is not emitted. This causes the menu to not be dismissed. Solution Before calling QQuickActionPrivate::get(action)->trigger(), store the button's enabled state. If triggering the action causes the action to be disabled (due to the signal handler), we can then choose whether or not we emit QQuickAbstractButton::clicked(). Specifically, we emit clicked() if: - we were enabled before triggering the action, and - we have no associated action, or it's no longer enabled Task-number: QTBUG-69682 Change-Id: Ib4e3c313b776decc74089a6beffe415605c430be Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-07-30 12:28:44 +00:00
}
}
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
void tst_QQuickMenu::menuItemWidth_data()
{
QTest::addColumn<bool>("mirrored");
QTest::newRow("non-mirrored") << false;
QTest::newRow("mirrored") << true;
}
void tst_QQuickMenu::menuItemWidth()
{
QFETCH(bool, mirrored);
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("menuItemWidths.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
QQuickApplicationWindow *window = helper.appWindow;
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
Fix layout is always RTL when locale is RTL isMirrored() will always return true when locale is RTL, so that we cannot change the layout. To fix this, remove out the relation between LayoutMirroring.enabled and locale's text direction. [ChangeLog][Controls][Important Behavior Changes] Control's locale property no longer affects layout direction. Use LayoutMirroring instead. Fixes: QTBUG-91227 Change-Id: Ibedd3f09828f81f1889077892452a27c90e21533 Reviewed-by: Hyunkook Khang <hyunkook.khang@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2021-02-23 01:51:31 +00:00
if (mirrored) {
QQmlExpression mirroringExpression(qmlContext(window), window,
"LayoutMirroring.childrenInherit = true; LayoutMirroring.enabled = true");
QVERIFY2(mirroringExpression.evaluate().isValid(), qPrintable(mirroringExpression.error().toString()));
}
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QVERIFY(menu);
menu->open();
QTRY_VERIFY(menu->isOpened());
for (int i = 0; i < menu->count(); ++i)
QCOMPARE(menu->itemAt(i)->width(), menu->availableWidth());
}
void tst_QQuickMenu::menuItemWidthAfterMenuWidthChanged_data()
{
QTest::addColumn<bool>("mirrored");
QTest::newRow("non-mirrored") << false;
QTest::newRow("mirrored") << true;
}
void tst_QQuickMenu::menuItemWidthAfterMenuWidthChanged()
{
QFETCH(bool, mirrored);
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("menuItemWidths.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
QQuickApplicationWindow *window = helper.appWindow;
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
Fix layout is always RTL when locale is RTL isMirrored() will always return true when locale is RTL, so that we cannot change the layout. To fix this, remove out the relation between LayoutMirroring.enabled and locale's text direction. [ChangeLog][Controls][Important Behavior Changes] Control's locale property no longer affects layout direction. Use LayoutMirroring instead. Fixes: QTBUG-91227 Change-Id: Ibedd3f09828f81f1889077892452a27c90e21533 Reviewed-by: Hyunkook Khang <hyunkook.khang@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2021-02-23 01:51:31 +00:00
if (mirrored) {
QQmlExpression mirroringExpression(qmlContext(window), window,
"LayoutMirroring.childrenInherit = true; LayoutMirroring.enabled = true");
QVERIFY2(mirroringExpression.evaluate().isValid(), qPrintable(mirroringExpression.error().toString()));
}
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QVERIFY(menu);
menu->open();
QTRY_VERIFY(menu->isOpened());
for (int i = 0; i < menu->count(); ++i) {
// Check that the width of menu items is correct before we resize the menu.
const QQuickItem *item = menu->itemAt(i);
QVERIFY2(qFuzzyCompare(item->width(), menu->availableWidth()),
qPrintable(QString::fromLatin1("Expected width of %1 to be %2, but it's %3")
.arg(item->objectName()).arg(menu->availableWidth()).arg(item->width())));
}
menu->setWidth(menu->width() + 10);
// Check that the width of menu items is correct after we resize the menu.
for (int i = 0; i < menu->count(); ++i) {
// Check that the width of menu items is correct after we resize the menu.
const QQuickItem *item = menu->itemAt(i);
QVERIFY2(qFuzzyCompare(item->width(), menu->availableWidth()),
qPrintable(QString::fromLatin1("Expected width of %1 to be %2, but it's %3")
.arg(item->objectName()).arg(menu->availableWidth()).arg(item->width())));
}
}
void tst_QQuickMenu::menuItemWidthAfterImplicitWidthChanged_data()
{
QTest::addColumn<bool>("mirrored");
QTest::newRow("non-mirrored") << false;
QTest::newRow("mirrored") << true;
}
void tst_QQuickMenu::menuItemWidthAfterImplicitWidthChanged()
{
QFETCH(bool, mirrored);
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("menuItemWidths.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
QQuickApplicationWindow *window = helper.appWindow;
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
Fix layout is always RTL when locale is RTL isMirrored() will always return true when locale is RTL, so that we cannot change the layout. To fix this, remove out the relation between LayoutMirroring.enabled and locale's text direction. [ChangeLog][Controls][Important Behavior Changes] Control's locale property no longer affects layout direction. Use LayoutMirroring instead. Fixes: QTBUG-91227 Change-Id: Ibedd3f09828f81f1889077892452a27c90e21533 Reviewed-by: Hyunkook Khang <hyunkook.khang@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2021-02-23 01:51:31 +00:00
if (mirrored) {
QQmlExpression mirroringExpression(qmlContext(window), window,
"LayoutMirroring.childrenInherit = true; LayoutMirroring.enabled = true");
QVERIFY2(mirroringExpression.evaluate().isValid(), qPrintable(mirroringExpression.error().toString()));
}
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QVERIFY(menu);
menu->open();
QTRY_VERIFY(menu->isOpened());
// Check that the width of the menu item is correct before we change its font size.
QQuickMenuItem *menuItem = qobject_cast<QQuickMenuItem*>(menu->itemAt(0));
QCOMPARE(menuItem->width(), menu->availableWidth());
// Add some text to increase the implicitWidth of the MenuItem.
const qreal oldImplicitWidth = menuItem->implicitWidth();
for (int i = 0; menuItem->implicitWidth() <= oldImplicitWidth; ++i) {
menuItem->setText(menuItem->text() + QLatin1String("---"));
if (i == 100)
QFAIL("Shouldn't need 100 iterations to increase MenuItem's implicitWidth; something is wrong here");
}
// Check that the width of the menu item is correct after we change its font size.
QCOMPARE(menuItem->width(), menu->availableWidth());
}
void tst_QQuickMenu::menuItemWidthAfterRetranslate()
{
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("menuItemWidths.qml"));
QQuickApplicationHelper: don't use QTest macros outside test functions This has no effect. Task-number: QTBUG-66320 Pick-to: 5.15 5.12 Change-Id: Ie6efb26243178c4044ac0bc721c21ad89769c982 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-06-05 08:28:16 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
QQuickApplicationWindow *window = helper.appWindow;
window->show();
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
QVERIFY(QTest::qWaitForWindowExposed(window));
Fix MenuItem width not matching Menu's available width Short version: There are currently two problems with MenuItems: - Mirrored MenuItems don't fill the Menu's available width. - MenuItem does not fill the Menu's available width when changed after Component completion. This patch fixes both of them by listening to geometry changes in both the contentItem and individual menu items, and setting the explicit width of those menu items when either changes. Longer version: The first problem can be seen whenever the MenuItem's implicitWidth changes: - QQmlEngine::retranslate() is called, causing all bindings to be re-evaluated - The MenuItem's font size changes - The MenuItem's icon size changes - etc. We fix this by making Menu listen to the width of each of its MenuItems and call resizeItem() if it doesn't have an explicit width. The second problem can be seen when e.g. resizing a Menu to account for new items that are wider and hence require more space. This can be fixed by listening to width changes in Menu's contentItem, which was actually done in earlier versions but (probably accidentally) removed in 482ecb0f. I had tried to solve both issues by setting the explicit width of MenuItem to the width of its Menu, or undefined if it has none (which means it reverts to its implicit width). However, this does not account for e.g. MenuSeparator and custom items that can be added to Menu - they should also have their width fill the Menu automatically if they don't have an explicit width set. Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644 Fixes: QTBUG-75051 Fixes: QTBUG-75142 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-12 13:21:42 +00:00
QQuickMenu *menu = window->property("menu").value<QQuickMenu *>();
QVERIFY(menu);
menu->open();
QTRY_VERIFY(menu->isOpened());
for (int i = 0; i < menu->count(); ++i) {
// Check that the width of each menu item is correct before we retranslate.
const QQuickItem *item = menu->itemAt(i);
QVERIFY2(qFuzzyCompare(item->width(), menu->availableWidth()),
qPrintable(QString::fromLatin1("Expected width of %1 to be %2, but it's %3")
.arg(item->objectName()).arg(menu->availableWidth()).arg(item->width())));
}
// Call retranslate() and cause all bindings to be re-evaluated.
helper.engine.retranslate();
for (int i = 0; i < menu->count(); ++i) {
// Check that the width of each menu item is correct after we retranslate.
const QQuickItem *item = menu->itemAt(i);
QVERIFY2(qFuzzyCompare(item->width(), menu->availableWidth()),
qPrintable(QString::fromLatin1("Expected width of %1 to be %2, but it's %3")
.arg(item->objectName()).arg(menu->availableWidth()).arg(item->width())));
}
}
QQuickAbstractButton: don't accept key release if we're not pressed A control should have been pressed if it's going to accept a release. This prevents an issue where a menu opened by pressing enter (handled via attached Keys property) would instantly trigger the first menu item. Pick-to: 5.15 5.12 Fixes: QTBUG-83698 Change-Id: I6b1afbb76f37623012472b2b1148b4862c159239 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-10-20 08:34:53 +00:00
void tst_QQuickMenu::giveMenuItemFocusOnButtonPress()
{
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
Fix window activation usage in QQuickMenu(Bar) - Skip tests that depend on programmatic window activation on platforms where this is not supported, such as Wayland. - Change tests that don't rely on the window being activated to use qWaitForWindowExposed() instead. Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-104257 Change-Id: If99721a223b328869af86fddf6565002a19e987a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 10:39:41 +00:00
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("giveMenuItemFocusOnButtonPress.qml"));
QQuickAbstractButton: don't accept key release if we're not pressed A control should have been pressed if it's going to accept a release. This prevents an issue where a menu opened by pressing enter (handled via attached Keys property) would instantly trigger the first menu item. Pick-to: 5.15 5.12 Fixes: QTBUG-83698 Change-Id: I6b1afbb76f37623012472b2b1148b4862c159239 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-10-20 08:34:53 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
tst_qquickmenu: call requestActivate before QTest::qWaitForWindowActive On a Ubuntu 22.04.4 VM, every test after the first one that didn't call requestActivate before QTest::qWaitForWindowActive would fail: qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in "" ********* Start testing of tst_QQuickMenu ********* Config: Using QtTest library 6.8.0, Qt 6.8.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 11.4.0), ubuntu 22.04 PASS : tst_QQuickMenu::Basic::initTestCase() PASS : tst_QQuickMenu::Basic::defaults() PASS : tst_QQuickMenu::Basic::count() PASS : tst_QQuickMenu::Basic::mouse() PASS : tst_QQuickMenu::Basic::pressAndHold() PASS : tst_QQuickMenu::Basic::contextMenuKeyboard() PASS : tst_QQuickMenu::Basic::disabledMenuItemKeyNavigation() PASS : tst_QQuickMenu::Basic::mnemonics() PASS : tst_QQuickMenu::Basic::menuButton() PASS : tst_QQuickMenu::Basic::addItem() FAIL! : tst_QQuickMenu::Basic::menuSeparator() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(697)] PASS : tst_QQuickMenu::Basic::repeater() PASS : tst_QQuickMenu::Basic::order() PASS : tst_QQuickMenu::Basic::popup() PASS : tst_QQuickMenu::Basic::actions() FAIL! : tst_QQuickMenu::Basic::actionShortcuts() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1084)] PASS : tst_QQuickMenu::Basic::removeTakeItem() PASS : tst_QQuickMenu::Basic::subMenuMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuMouse(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(cascading) PASS : tst_QQuickMenu::Basic::subMenuDisabledMouse(non-cascading) FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1384)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] FAIL! : tst_QQuickMenu::Basic::subMenuDisabledKeyboard(non-cascading,mirrored) 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(1513)] PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(cascading,mirrored,flip,overlap) PASS : tst_QQuickMenu::Basic::subMenuPosition(non-cascading) PASS : tst_QQuickMenu::Basic::subMenuWithIcon() PASS : tst_QQuickMenu::Basic::addRemoveSubMenus() PASS : tst_QQuickMenu::Basic::scrollable(Window) PASS : tst_QQuickMenu::Basic::scrollable(ApplicationWindow) PASS : tst_QQuickMenu::Basic::scrollable(WithPadding) PASS : tst_QQuickMenu::Basic::scrollable(FixedHeight) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(MenuItem with no Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-Action) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared inside) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with Action declared outside menu) PASS : tst_QQuickMenu::Basic::disableWhenTriggered(Sub-MenuItem with no Action) PASS : tst_QQuickMenu::Basic::menuItemWidth(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidth(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterMenuWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(non-mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterImplicitWidthChanged(mirrored) PASS : tst_QQuickMenu::Basic::menuItemWidthAfterRetranslate() FAIL! : tst_QQuickMenu::Basic::giveMenuItemFocusOnButtonPress() 'QTest::qWaitForWindowActive(window)' returned FALSE. () Loc: [/home/mitch/dev/qt-dev/qtdeclarative/tests/auto/quickcontrols/qquickmenu/tst_qquickmenu.cpp(2097)] PASS : tst_QQuickMenu::Basic::customMenuCullItems() PASS : tst_QQuickMenu::Basic::customMenuUseRepeaterAsTheContentItem() PASS : tst_QQuickMenu::Basic::invalidUrlInImgTag() PASS : tst_QQuickMenu::Basic::nativeStatic() PASS : tst_QQuickMenu::Basic::nativeDynamicActions() PASS : tst_QQuickMenu::Basic::nativeDynamicSubmenus() PASS : tst_QQuickMenu::Basic::nativeMenuSeparator() PASS : tst_QQuickMenu::Basic::dontUseNativeMenuWindowsChanges() PASS : tst_QQuickMenu::Basic::nativeMixedItems() PASS : tst_QQuickMenu::Basic::cleanupTestCase() Totals: 59 passed, 11 failed, 0 skipped, 0 blacklisted, 74936ms ********* Finished testing of tst_QQuickMenu ********* Change-Id: I5ef76d2648fc7c8732aafab3a9a0a02844075c3e Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-20 07:33:47 +00:00
window->requestActivate();
QQuickAbstractButton: don't accept key release if we're not pressed A control should have been pressed if it's going to accept a release. This prevents an issue where a menu opened by pressing enter (handled via attached Keys property) would instantly trigger the first menu item. Pick-to: 5.15 5.12 Fixes: QTBUG-83698 Change-Id: I6b1afbb76f37623012472b2b1148b4862c159239 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-10-20 08:34:53 +00:00
QVERIFY(QTest::qWaitForWindowActive(window));
// Press enter on the button to open the menu.
QQuickButton *menuButton = window->property("menuButton").value<QQuickButton*>();
QVERIFY(menuButton);
menuButton->forceActiveFocus();
QQuickTest: add and use active focus macros Also add support for popups (when controlstestutils_p.h is included). [ChangeLog][Qt Quick Test] Added QVERIFY_ACTIVE_FOCUS and QTRY_VERIFY_ACTIVE_FOCUS macros that can be used to get detailed failure messages for when QQuickItem::hasActiveFocus should be true but isn't. Task-number: QTBUG-133858 Change-Id: I30c67a84ccc16e3969bac5661648d0062bc3d62c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2025-02-24 07:30:38 +00:00
QVERIFY_ACTIVE_FOCUS(menuButton);
QQuickAbstractButton: don't accept key release if we're not pressed A control should have been pressed if it's going to accept a release. This prevents an issue where a menu opened by pressing enter (handled via attached Keys property) would instantly trigger the first menu item. Pick-to: 5.15 5.12 Fixes: QTBUG-83698 Change-Id: I6b1afbb76f37623012472b2b1148b4862c159239 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-10-20 08:34:53 +00:00
QSignalSpy clickedSpy(window, SIGNAL(menuButtonClicked()));
QVERIFY(clickedSpy.isValid());
QTest::keyClick(window, Qt::Key_Return);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(clickedSpy.size(), 1);
QQuickAbstractButton: don't accept key release if we're not pressed A control should have been pressed if it's going to accept a release. This prevents an issue where a menu opened by pressing enter (handled via attached Keys property) would instantly trigger the first menu item. Pick-to: 5.15 5.12 Fixes: QTBUG-83698 Change-Id: I6b1afbb76f37623012472b2b1148b4862c159239 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-10-20 08:34:53 +00:00
// The menu should still be open.
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QVERIFY(menu);
QTRY_VERIFY(menu->isOpened());
}
Menu: cull non-visible items when `contentItem` inherits Item For a custom menu control, when the contentItem does not inherit from ItemView, the text overlaps. A related bug is QTBUG-53262, but this problem is only fixed for the ItemView control. Since the contentItem control can accept the Item control, I think the repair only for ItemView has limitations. Therefore, this submission cancels the restriction on the type of contentitem. Pick-to: 6.3 6.4 Fixes: QTBUG-104470 Change-Id: I7e697e3cb993475d157a92f37d9512e4a9872387 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-21 03:10:00 +00:00
void tst_QQuickMenu::customMenuCullItems()
{
QQuickControlsApplicationHelper helper(this, QLatin1String("customMenuCullItems.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QVERIFY(menu);
menu->open();
QTRY_VERIFY(menu->isOpened());
QQuickItem *menuItemFirst = menu->itemAt(0);
QQuickItem *menuItemLast = menu->itemAt(menu->count() - 1);
QVERIFY(menuItemFirst);
QVERIFY(menuItemLast);
QTRY_VERIFY(!QQuickItemPrivate::get(menuItemFirst)->culled);
QTRY_VERIFY(QQuickItemPrivate::get(menuItemLast)->culled);
}
Repeater: uncull items that come from ObjectModel After 6173fc0e4be93604286b9a424f1aa3ff5896082a, Menu will unconditionally cull items as they are inserted. This behavior relies on the fact that ListView will uncull the items as necessary. However, when implementing Menu with a Repeater as the contentItem (which is unusual but not unreasonable), the items will never be unculled and hence will be invisible. We can't fix this in Menu by checking its contentItem, because when items are inserted, their parent item is the root contentItem, not the Repeater, and there's no nice, efficient way to check if the item belongs to a Repeater. This patch fixes the issue in Repeater by unculling the item if it came from an ObjectModel. Done-with: Mitch Curtis <mitch.curtis@qt.io> Pick-to: 6.3 6.4 Fixes: QTBUG-104544 Change-Id: Ib37d2d49d3608156a3f1e3652b63ccdd5dfd0f41 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-06-24 02:38:51 +00:00
void tst_QQuickMenu::customMenuUseRepeaterAsTheContentItem()
{
QQuickControlsApplicationHelper helper(this, QLatin1String("customMenuUseRepeaterAsTheContentItem.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QVERIFY(menu);
menu->open();
QTRY_VERIFY(menu->isVisible());
QQuickItem *menuItemFirst = menu->itemAt(0);
QQuickItem *menuItemLast = menu->itemAt(menu->count() - 1);
QTRY_VERIFY(!QQuickItemPrivate::get(menuItemFirst)->culled);
QTRY_VERIFY(!QQuickItemPrivate::get(menuItemLast)->culled);
}
Fix crash issue when invalid img tag used in text The img tag should contain valid base url. If not, it shall be considered as invalid and style text ignore those tags. Fixes: QTBUG-116672 Pick-to: 6.6 6.5 Change-Id: Iccf74f895a9f6b7fb83e458fe27f2aada86094e3 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-09-05 20:14:30 +00:00
// QTBUG-116672 - Application loads menu containing invalid styled text
// (img tag) without crash
void tst_QQuickMenu::invalidUrlInImgTag()
{
QTest::ignoreMessage(QtWarningMsg, "StyledText - Invalid base url in img tag");
QQuickControlsApplicationHelper helper(this, QLatin1String("invalidUrlInImgTag.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QVERIFY(menu);
menu->open();
tst_qquickmenu: Take into account menu enter transitions Disable or wait for menu enter transitions when appropriate. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5b256cfc74852775b24cf26ef3432c1dec7ee703 Reviewed-by: Doris Verria <doris.verria@qt.io>
2025-02-05 10:23:19 +00:00
QTRY_VERIFY(menu->isOpened());
Fix crash issue when invalid img tag used in text The img tag should contain valid base url. If not, it shall be considered as invalid and style text ignore those tags. Fixes: QTBUG-116672 Pick-to: 6.6 6.5 Change-Id: Iccf74f895a9f6b7fb83e458fe27f2aada86094e3 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-09-05 20:14:30 +00:00
QQuickMenuItem *menuItemFirst = qobject_cast<QQuickMenuItem *>(menu->itemAt(0));
QVERIFY(menuItemFirst);
}
Menu: support adding MenuItem to native menu Originally the plan was to revert to a non-native menu when MenuItem was used, but now that we always create the non-native items regardless, we shouldn't need to do that. Checkable MenuItems do not currently work. This will be implemented in a follow-up commit. Task-number: QTBUG-69558 Change-Id: I7238dad89e478f7cc664738fb6036787e0193dab Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 07:10:33 +00:00
void tst_QQuickMenu::nativeStatic()
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
{
QQuickMenu: respect Qt::AA_DontUseNativeMenuWindows Now that we enable native menus by default for the macOS style, we also need to make sure that we actually respect the Qt::AA_DontUseNativeMenuWindows. Pick-to: 6.8 Change-Id: I2a02b5528110a4e0514fb53c0673653f0086dfe8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-27 10:18:09 +00:00
// Undo the setting of AA_DontUseNativeMenuWindows to true from init()
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuWindows, false);
Menu: support adding MenuItem to native menu Originally the plan was to revert to a non-native menu when MenuItem was used, but now that we always create the non-native items regardless, we shouldn't need to do that. Checkable MenuItems do not currently work. This will be implemented in a follow-up commit. Task-number: QTBUG-69558 Change-Id: I7238dad89e478f7cc664738fb6036787e0193dab Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 07:10:33 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("nativeStatic.qml"));
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu *contextMenu = window->property("contextMenu").value<QQuickMenu*>();
QVERIFY(contextMenu);
auto *contextMenuPrivate = QQuickMenuPrivate::get(contextMenu);
QQuickMenu: refactor all 'use native' logic into a single function As it stood, the logic that resolved if a menu can, and should be, native was duplicated into two functions; useNativeMenu() and resolvedPopupType(). And the two was somewhat inconsistent. This patch will therefore refactor all the logic into resolvedPopupType(), so that the popup type is resolved in a single place. Existing auto tests (such as tst_QQuickMenu::subMenuPopupType()) should verify that this refactoring is safe. Pick-to: 6.8 Change-Id: Ifc73d20c2d2e06646dc2849c8398660a35b17cb2 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-09-24 12:02:32 +00:00
QCOMPARE(contextMenuPrivate->useNativeMenu(), nativeMenuSupported);
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
// Check that the actions of the parent menu can be accessed
// and are in the appropriate places in contentModel and contentData.
auto *action1 = contextMenu->actionAt(0);
QVERIFY(action1);
auto *action1MenuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(0));
QVERIFY(action1MenuItem);
QCOMPARE(action1MenuItem->action(), action1);
COMPARE_MENUITEMS(qobject_cast<QQuickMenuItem *>(contextMenuPrivate->contentData.at(0)),
action1MenuItem);
Menu: support adding MenuItem to native menu Originally the plan was to revert to a non-native menu when MenuItem was used, but now that we always create the non-native items regardless, we shouldn't need to do that. Checkable MenuItems do not currently work. This will be implemented in a follow-up commit. Task-number: QTBUG-69558 Change-Id: I7238dad89e478f7cc664738fb6036787e0193dab Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 07:10:33 +00:00
auto *menuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(1));
QVERIFY(menuItem);
QVERIFY(menuItem->action());
QCOMPARE(menuItem->action()->text(), "menuItemAction");
COMPARE_MENUITEMS(qobject_cast<QQuickMenuItem *>(contextMenuPrivate->contentData.at(1)), menuItem);
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
// Check that the sub-menu can be accessed and is in the
// appropriate place in contentData.
auto *subMenu = contextMenu->menuAt(2);
QVERIFY(subMenu);
auto *subMenuPrivate = QQuickMenuPrivate::get(subMenu);
auto *subMenuAction1 = subMenu->actionAt(0);
QVERIFY(subMenuAction1);
auto *subMenuAction1MenuItem = qobject_cast<QQuickMenuItem *>(subMenu->itemAt(0));
QVERIFY(subMenuAction1MenuItem);
QCOMPARE(subMenuAction1MenuItem->action(), subMenuAction1);
COMPARE_MENUITEMS(qobject_cast<QQuickMenuItem *>(subMenuPrivate->contentData.at(0)),
subMenuAction1MenuItem);
}
void tst_QQuickMenu::nativeDynamicActions()
{
QQuickControlsApplicationHelper helper(this, QLatin1String("nativeEmptyMenu.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu *contextMenu = window->property("contextMenu").value<QQuickMenu*>();
QVERIFY(contextMenu);
auto *contextMenuPrivate = QQuickMenuPrivate::get(contextMenu);
// Check that items can be appended to an empty menu.
QCOMPARE(contextMenu->actionAt(0), nullptr);
QVERIFY(QMetaObject::invokeMethod(window, "addAction",
Q_ARG(QQuickMenu *, contextMenu), Q_ARG(QString, "action1")));
{
auto action1 = contextMenu->actionAt(0);
QVERIFY(action1);
QCOMPARE(action1->text(), "action1");
auto *action1MenuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(0));
QVERIFY(action1MenuItem);
QCOMPARE(action1MenuItem->action(), action1);
COMPARE_MENUITEMS(qobject_cast<QQuickMenuItem *>(contextMenuPrivate->contentData.at(0)),
action1MenuItem);
}
// Check that actions can be appended after existing items in the parent menu.
QCOMPARE(contextMenu->actionAt(1), nullptr);
QVERIFY(QMetaObject::invokeMethod(window, "addAction",
Q_ARG(QQuickMenu *, contextMenu), Q_ARG(QString, "action2")));
{
auto action2 = contextMenu->actionAt(1);
QVERIFY(action2);
QCOMPARE(action2->text(), "action2");
auto *action2MenuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(1));
QVERIFY(action2MenuItem);
QCOMPARE(action2MenuItem->action(), action2);
COMPARE_MENUITEMS(qobject_cast<QQuickMenuItem *>(contextMenuPrivate->contentData.at(1)),
action2MenuItem);
}
// Check that actions can be inserted before existing items in the parent menu.
QVERIFY(QMetaObject::invokeMethod(window, "insertAction",
Q_ARG(QQuickMenu *, contextMenu), Q_ARG(int, 0), Q_ARG(QString, "action0")));
{
auto action0 = contextMenu->actionAt(0);
QVERIFY(action0);
QCOMPARE(action0->text(), "action0");
auto *action0MenuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(0));
QVERIFY(action0MenuItem);
QCOMPARE(action0MenuItem->action(), action0);
// New items are always appended to contentData, regardless of the actual insertion index
// in contentModel.
COMPARE_MENUITEMS(qobject_cast<QQuickMenuItem *>(contextMenuPrivate->contentData.at(2)),
action0MenuItem);
}
}
void tst_QQuickMenu::nativeDynamicSubmenus()
{
QQuickMenu: respect Qt::AA_DontUseNativeMenuWindows Now that we enable native menus by default for the macOS style, we also need to make sure that we actually respect the Qt::AA_DontUseNativeMenuWindows. Pick-to: 6.8 Change-Id: I2a02b5528110a4e0514fb53c0673653f0086dfe8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-27 10:18:09 +00:00
// Undo the setting of AA_DontUseNativeMenuWindows to true from init()
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuWindows, false);
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("nativeDynamicSubmenus.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu *contextMenu = window->property("contextMenu").value<QQuickMenu*>();
QVERIFY(contextMenu);
auto *contextMenuPrivate = QQuickMenuPrivate::get(contextMenu);
// We construct the sub-menu first in QML. At least on Windows, menu items
// added to an empty sub-menu won't show up (tested with Widgets): QTBUG-120494.
// So, this adds an already-populated menu as a sub-menu.
QVERIFY(QMetaObject::invokeMethod(window, "addSubMenu", Q_ARG(QString, "subMenu1")));
auto subMenu1 = contextMenu->menuAt(0);
QVERIFY(subMenu1);
QCOMPARE(subMenu1->title(), "subMenu1");
auto *subMenu1Private = QQuickMenuPrivate::get(subMenu1);
tst_qquickmenu: move native menu support check to runtime It's clear that the build time check doesn't work, and since we can't easily check which platform plugin we're using (and maintaining such a check could be fragile), just check if we can create a platform menu. Task-number: QTBUG-69558 Change-Id: I2d8057f4012a4762d9d323ddc7127824811229a6 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 12:52:20 +00:00
if (nativeMenuSupported) {
QVERIFY(subMenu1Private->handle);
QCOMPARE(subMenu1Private->nativeItems.size(), 1);
}
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
auto *subMenu1MenuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(0));
QVERIFY(subMenu1MenuItem);
COMPARE_MENUITEMS(qobject_cast<QQuickMenuItem *>(contextMenuPrivate->contentData.at(0)),
subMenu1MenuItem);
QCOMPARE(contextMenuPrivate->contentData.size(), 1);
{
auto subMenuAction1 = subMenu1->actionAt(0);
QVERIFY(subMenuAction1);
QCOMPARE(subMenuAction1->text(), "subMenu1Action1");
auto *subMenuAction1MenuItem = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(0));
QVERIFY(subMenuAction1MenuItem);
QCOMPARE(subMenuAction1MenuItem->action(), subMenuAction1);
COMPARE_MENUITEMS(qobject_cast<QQuickMenuItem *>(subMenu1Private->contentData.at(0)),
subMenuAction1MenuItem);
tst_qquickmenu: move native menu support check to runtime It's clear that the build time check doesn't work, and since we can't easily check which platform plugin we're using (and maintaining such a check could be fragile), just check if we can create a platform menu. Task-number: QTBUG-69558 Change-Id: I2d8057f4012a4762d9d323ddc7127824811229a6 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 12:52:20 +00:00
if (nativeMenuSupported)
QCOMPARE(subMenu1Private->nativeItems.size(), 1);
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
}
// Check that actions can be appended after existing items in the sub-menu.
QCOMPARE(subMenu1->actionAt(1), nullptr);
QVERIFY(QMetaObject::invokeMethod(window, "addAction",
Q_ARG(QQuickMenu *, subMenu1), Q_ARG(QString, "subMenu1Action2")));
{
auto subMenu1Action2 = subMenu1->actionAt(1);
QVERIFY(subMenu1Action2);
QCOMPARE(subMenu1Action2->text(), "subMenu1Action2");
auto *subMenu1Action2MenuItem = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(1));
QVERIFY(subMenu1Action2MenuItem);
QCOMPARE(subMenu1Action2MenuItem->action(), subMenu1Action2);
COMPARE_MENUITEMS(qobject_cast<QQuickMenuItem *>(subMenu1Private->contentData.at(1)),
subMenu1Action2MenuItem);
QCOMPARE(subMenu1Private->contentData.size(), 2);
}
// Check that actions can be inserted before existing items in the sub-menu.
QVERIFY(QMetaObject::invokeMethod(window, "insertAction",
Q_ARG(QQuickMenu *, subMenu1), Q_ARG(int, 0), Q_ARG(QString, "subMenu1Action0")));
{
auto subMenu1Action0 = subMenu1->actionAt(0);
QVERIFY(subMenu1Action0);
QCOMPARE(subMenu1Action0->text(), "subMenu1Action0");
auto *subMenu1Action0MenuItem = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(0));
QVERIFY(subMenu1Action0MenuItem);
QCOMPARE(subMenu1Action0MenuItem->action(), subMenu1Action0);
// New items are always appended to contentData, regardless of the actual insertion index
// in contentModel.
COMPARE_MENUITEMS(qobject_cast<QQuickMenuItem *>(subMenu1Private->contentData.at(2)),
subMenu1Action0MenuItem);
QCOMPARE(subMenu1Private->contentData.size(), 3);
}
{
// Check that takeMenu works.
auto *takenSubMenu = contextMenu->takeMenu(0);
QCOMPARE(takenSubMenu, subMenu1);
QCOMPARE(contextMenuPrivate->contentData.size(), 0);
tst_qquickmenu: move native menu support check to runtime It's clear that the build time check doesn't work, and since we can't easily check which platform plugin we're using (and maintaining such a check could be fragile), just check if we can create a platform menu. Task-number: QTBUG-69558 Change-Id: I2d8057f4012a4762d9d323ddc7127824811229a6 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 12:52:20 +00:00
if (nativeMenuSupported) {
QVERIFY(!subMenu1Private->handle);
QCOMPARE(subMenu1Private->nativeItems.size(), 0);
}
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
// Check that the sub-menu can be added back in to the menu.
contextMenu->addMenu(takenSubMenu);
QCOMPARE(contextMenuPrivate->contentData.size(), 1);
auto *subMenu1MenuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(0));
QVERIFY(subMenu1MenuItem);
QCOMPARE(subMenu1MenuItem->text(), "subMenu1");
tst_qquickmenu: move native menu support check to runtime It's clear that the build time check doesn't work, and since we can't easily check which platform plugin we're using (and maintaining such a check could be fragile), just check if we can create a platform menu. Task-number: QTBUG-69558 Change-Id: I2d8057f4012a4762d9d323ddc7127824811229a6 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 12:52:20 +00:00
if (nativeMenuSupported) {
QVERIFY(subMenu1Private->handle);
QCOMPARE(subMenu1Private->nativeItems.size(), 3);
}
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
QCOMPARE(subMenu1Private->contentData.size(), 3);
auto *subMenu1Action0MenuItem = qobject_cast<QQuickMenuItem *>(subMenu1->itemAt(0));
QVERIFY(subMenu1Action0MenuItem);
}
// Check that removeMenu works.
QVERIFY(contextMenu->menuAt(0));
contextMenu->removeMenu(contextMenu->menuAt(0));
QCOMPARE(contextMenuPrivate->contentData.size(), 0);
}
void tst_QQuickMenu::nativeMenuSeparator()
{
QQuickMenu: respect Qt::AA_DontUseNativeMenuWindows Now that we enable native menus by default for the macOS style, we also need to make sure that we actually respect the Qt::AA_DontUseNativeMenuWindows. Pick-to: 6.8 Change-Id: I2a02b5528110a4e0514fb53c0673653f0086dfe8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-27 10:18:09 +00:00
// Undo the setting of AA_DontUseNativeMenuWindows to true from init()
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuWindows, false);
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("nativeMenuSeparator.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
// Check that separators in menus are where we expect them to be.
QQuickMenu *contextMenu = window->property("contextMenu").value<QQuickMenu*>();
QVERIFY(contextMenu);
auto *contextMenuSeparatorAsItem = contextMenu->itemAt(1);
QVERIFY(contextMenuSeparatorAsItem);
auto *contextMenuSeparator = qobject_cast<QQuickMenuSeparator *>(contextMenuSeparatorAsItem);
QVERIFY(contextMenuSeparator);
tst_qquickmenu: move native menu support check to runtime It's clear that the build time check doesn't work, and since we can't easily check which platform plugin we're using (and maintaining such a check could be fragile), just check if we can create a platform menu. Task-number: QTBUG-69558 Change-Id: I2d8057f4012a4762d9d323ddc7127824811229a6 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 12:52:20 +00:00
if (nativeMenuSupported) {
auto *contextMenuPrivate = QQuickMenuPrivate::get(contextMenu);
QCOMPARE(contextMenuPrivate->nativeItems.size(), 3);
auto *contextMenuSeparatorNativeItem = contextMenuPrivate->nativeItems.at(1);
QVERIFY(contextMenuSeparatorNativeItem);
QVERIFY(contextMenuSeparatorNativeItem->separator());
}
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
// Check that separators in sub-menus are where we expect them to be.
QQuickMenu *subMenu = window->property("contextMenu").value<QQuickMenu*>();
QVERIFY(subMenu);
auto *subMenuSeparatorAsItem = subMenu->itemAt(1);
QVERIFY(subMenuSeparatorAsItem);
auto *subMenuSeparator = qobject_cast<QQuickMenuSeparator *>(subMenuSeparatorAsItem);
QVERIFY(subMenuSeparator);
tst_qquickmenu: move native menu support check to runtime It's clear that the build time check doesn't work, and since we can't easily check which platform plugin we're using (and maintaining such a check could be fragile), just check if we can create a platform menu. Task-number: QTBUG-69558 Change-Id: I2d8057f4012a4762d9d323ddc7127824811229a6 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 12:52:20 +00:00
if (nativeMenuSupported) {
auto *subMenuPrivate = QQuickMenuPrivate::get(subMenu);
QCOMPARE(subMenuPrivate->nativeItems.size(), 3);
auto *subMenuSeparatorNativeItem = subMenuPrivate->nativeItems.at(1);
QVERIFY(subMenuSeparatorNativeItem);
QVERIFY(subMenuSeparatorNativeItem->separator());
}
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
}
QQuickMenu: respect Qt::AA_DontUseNativeMenuWindows Now that we enable native menus by default for the macOS style, we also need to make sure that we actually respect the Qt::AA_DontUseNativeMenuWindows. Pick-to: 6.8 Change-Id: I2a02b5528110a4e0514fb53c0673653f0086dfe8 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-27 10:18:09 +00:00
void tst_QQuickMenu::AA_DontUseNativeMenuWindows()
{
// Check that we end up with a non-native menu when AA_DontUseNativeMenuWindows
// is set, even if popupType is Native.
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuWindows);
QQuickControlsApplicationHelper helper(this, QLatin1String("applicationwindow.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QVERIFY(menu);
QQuickMenuPrivate *menu_d = QQuickMenuPrivate::get(menu);
menu->setPopupType(QQuickPopup::Native);
// Note: since a native menu is blocking, we cannot open it, in case
// the test fails and it actually opens. That would block the test as
// well. So we just check that useNativeMenu returns false for now.
QVERIFY(!menu_d->useNativeMenu());
QVERIFY(!menu_d->maybeNativeHandle());
}
Menu, MenuBar: remove requestNative and rely solely on app attributes It was decided that we'll have two attributes: - AA_DontUseNativeMenuBar - AA_DontUseNativeMenuWindows Setting AA_DontUseNativeMenuWindows only affects windows we create (context menus, combobox menus, menus of non-native menu bars). So, setting AA_DontUseNativeMenuWindows restores Qt to today's behavior. But we can't control the windows of native menu bars, so if you don't want those to be native, you have to set AA_DontUseNativeMenuBar just like today. By removing requestNative, we also effectively default to native menus and menu bars, as the attributes are not set by default. [ChangeLog][Controls][Important Behavior Changes] Menu and MenuBar now use native menus by default on platforms where they're supported. Task-number: QTBUG-69558 Change-Id: Ia917c2f820634def0cf815aa8ca8895ca79db75d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-14 03:36:06 +00:00
void tst_QQuickMenu::dontUseNativeMenuWindowsChanges()
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
{
Replace AA_DontUsePopupWindows with Popup::popupType The application attribute approach has some weaknesses which makes it less suitable, than simply having a property which can be set per instance of Popup. In addition, given just how many of our own tests that are failing, when changing the default behavior of popup, it`s a much safer approach to introduce this feature as an opt-in, in the beginning. We can instead potentially modify the behavior of PopupType::Default in the future, when we feel that it's less risky to do so. To give more context to why the AA approach is bad: - The AA is too grandiose of a solution, which adds an arbitrary limitation of not allowing mixing of in-scene popups and popup windows. This also affects 3rd party libraries. - It causes inconveniences when styling the various popup types. Dialog, for instance, has a title property, which should be shown in the window title, and not inside the popup window. - It also makes it less flexible for potential future changes. We've learned that this change is riskier, than initially expected, since the qobject and visual hierarchy of popup objects are different when using popup windows, and tests that simulate events, will need to send the events to a different window. The introduction of the PopupType::Default value, allows us to, for instance, add a property later in ApplicationWindow, or somewhere else, to change the behavior of PopupType::Default. Meaning that we can still add a more grandiose API, that affects the behavior of multiple popup instances, if we think it's too cumbersome for developers to add `popupType: Popup.Window` to all popup instances. Task-number: QTBUG-121363 Change-Id: I544da820261607621a9b9ad5c4c9679e676e44a0 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2024-05-27 22:01:20 +00:00
QSKIP("QTBUG-125967 This test will need to be fixed, by using popupType: Popup.Native instead of AA_DontUseNativeMenuWindows.");
Menu, MenuBar: remove requestNative and rely solely on app attributes It was decided that we'll have two attributes: - AA_DontUseNativeMenuBar - AA_DontUseNativeMenuWindows Setting AA_DontUseNativeMenuWindows only affects windows we create (context menus, combobox menus, menus of non-native menu bars). So, setting AA_DontUseNativeMenuWindows restores Qt to today's behavior. But we can't control the windows of native menu bars, so if you don't want those to be native, you have to set AA_DontUseNativeMenuBar just like today. By removing requestNative, we also effectively default to native menus and menu bars, as the attributes are not set by default. [ChangeLog][Controls][Important Behavior Changes] Menu and MenuBar now use native menus by default on platforms where they're supported. Task-number: QTBUG-69558 Change-Id: Ia917c2f820634def0cf815aa8ca8895ca79db75d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-14 03:36:06 +00:00
if (QSysInfo::productType() == QLatin1String("b2qt"))
QSKIP("b2qt doesn't support native menus");
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuWindows, false);
Menu: support adding MenuItem to native menu Originally the plan was to revert to a non-native menu when MenuItem was used, but now that we always create the non-native items regardless, we shouldn't need to do that. Checkable MenuItems do not currently work. This will be implemented in a follow-up commit. Task-number: QTBUG-69558 Change-Id: I7238dad89e478f7cc664738fb6036787e0193dab Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 07:10:33 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("nativeStatic.qml"));
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu *contextMenu = window->property("contextMenu").value<QQuickMenu*>();
QVERIFY(contextMenu);
QCOMPARE(contextMenu->count(), 3);
Menu, MenuBar: remove requestNative and rely solely on app attributes It was decided that we'll have two attributes: - AA_DontUseNativeMenuBar - AA_DontUseNativeMenuWindows Setting AA_DontUseNativeMenuWindows only affects windows we create (context menus, combobox menus, menus of non-native menu bars). So, setting AA_DontUseNativeMenuWindows restores Qt to today's behavior. But we can't control the windows of native menu bars, so if you don't want those to be native, you have to set AA_DontUseNativeMenuBar just like today. By removing requestNative, we also effectively default to native menus and menu bars, as the attributes are not set by default. [ChangeLog][Controls][Important Behavior Changes] Menu and MenuBar now use native menus by default on platforms where they're supported. Task-number: QTBUG-69558 Change-Id: Ia917c2f820634def0cf815aa8ca8895ca79db75d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-14 03:36:06 +00:00
// Sub-menus should respect the native-ness of their parents.
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
auto *subMenu = contextMenu->menuAt(2);
auto *subMenuPrivate = QQuickMenuPrivate::get(subMenu);
QVERIFY(subMenuPrivate->useNativeMenu());
tst_qquickmenu: move native menu support check to runtime It's clear that the build time check doesn't work, and since we can't easily check which platform plugin we're using (and maintaining such a check could be fragile), just check if we can create a platform menu. Task-number: QTBUG-69558 Change-Id: I2d8057f4012a4762d9d323ddc7127824811229a6 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 12:52:20 +00:00
if (nativeMenuSupported)
QVERIFY(subMenuPrivate->handle);
else
QVERIFY(!subMenuPrivate->handle);
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
// Ensure that the menu and its sub-menu have enough room to open.
if (window->width() / 2 <= contextMenu->width())
window->setWidth(contextMenu->width() * 2 + 1);
if (window->height() <= contextMenu->height())
window->setHeight(contextMenu->height() + 1);
QTRY_COMPARE(window->contentItem()->size(), window->size());
// We can't test that aboutToShow/aboutToHide is emitted for native menus
// because when they are shown, the event loop is blocked until they are closed.
// So we just check that a native menu is actually in use before going on to test
// non-native menus.
auto *contextMenuPrivate = QQuickMenuPrivate::get(contextMenu);
tst_qquickmenu: move native menu support check to runtime It's clear that the build time check doesn't work, and since we can't easily check which platform plugin we're using (and maintaining such a check could be fragile), just check if we can create a platform menu. Task-number: QTBUG-69558 Change-Id: I2d8057f4012a4762d9d323ddc7127824811229a6 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-07 12:52:20 +00:00
if (nativeMenuSupported)
QVERIFY(contextMenuPrivate->handle);
else
QVERIFY(!contextMenuPrivate->handle);
Menu, MenuBar: remove requestNative and rely solely on app attributes It was decided that we'll have two attributes: - AA_DontUseNativeMenuBar - AA_DontUseNativeMenuWindows Setting AA_DontUseNativeMenuWindows only affects windows we create (context menus, combobox menus, menus of non-native menu bars). So, setting AA_DontUseNativeMenuWindows restores Qt to today's behavior. But we can't control the windows of native menu bars, so if you don't want those to be native, you have to set AA_DontUseNativeMenuBar just like today. By removing requestNative, we also effectively default to native menus and menu bars, as the attributes are not set by default. [ChangeLog][Controls][Important Behavior Changes] Menu and MenuBar now use native menus by default on platforms where they're supported. Task-number: QTBUG-69558 Change-Id: Ia917c2f820634def0cf815aa8ca8895ca79db75d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-14 03:36:06 +00:00
// We need to wait until the menu is opened before it picks up the changes,
// which is why we don't check the native handle here yet.
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuWindows);
QQuickMenuBar: don't delete menus that might still be referenced from QML The current implementation documents that it "Removes and destroys the specified menu" from removeMenu(). This is not safe. Consider this code: Menu { id: menu } MenuBar { id: menuBar Component.onCompleted: addMenu(menu) } Text { text: menu.title } If the app after a while calls menuBar.removeMenu(menu), we would be deleting 'menu' from c++. This would cause it to be dangling, and perhaps cause a crash when the text binding is later reevaluated. The idea behind the MenuBar taking over memory management for the Menus and MenuBarItems, was probably to cater for the situation where you use the Component API to dynamically create menus that you feed to addMenu(). But even in that case the developer doesn't need to explicitly destroy anything; The gc will eventually come around and do the job. This patch will therefore change this, so that we never delete any menus using deleteLater, but leave it to the gc to find the right time. This is now also clarified in the docs. Change-Id: I654874f8b79fc90ccb818e688ed73183dace6c32 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-02 10:32:34 +00:00
QVERIFY(!contextMenuPrivate->useNativeMenu());
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
QVERIFY(!subMenuPrivate->useNativeMenu());
// Check that we can open the menu by right-clicking (or just open it manually
// if the platform doesn't support (moving) QCursor).
QSignalSpy aboutToShowSpy(contextMenu, &QQuickMenu::aboutToShow);
QVERIFY(aboutToShowSpy.isValid());
bool couldMoveCursorPos = false;
const QPoint cursorPos(1, 1);
#if QT_CONFIG(cursor)
// Try moving the cursor from the current position to test if the platform
// supports moving the cursor.
const QPoint point = QCursor::pos() + QPoint(1, 1);
QCursor::setPos(point);
if (QTest::qWaitFor([point]{ return QCursor::pos() == point; })) {
couldMoveCursorPos = true;
const QPoint globalCursorPos = window->mapToGlobal(cursorPos);
QCursor::setPos(globalCursorPos);
QTest::mouseClick(window, Qt::RightButton, Qt::NoModifier, cursorPos);
}
#endif
if (!couldMoveCursorPos) {
contextMenu->setX(cursorPos.x());
contextMenu->setY(cursorPos.y());
contextMenu->open();
}
QVERIFY(contextMenu->isVisible());
QTRY_VERIFY(contextMenu->isOpened());
QCOMPARE(aboutToShowSpy.size(), 1);
Menu, MenuBar: remove requestNative and rely solely on app attributes It was decided that we'll have two attributes: - AA_DontUseNativeMenuBar - AA_DontUseNativeMenuWindows Setting AA_DontUseNativeMenuWindows only affects windows we create (context menus, combobox menus, menus of non-native menu bars). So, setting AA_DontUseNativeMenuWindows restores Qt to today's behavior. But we can't control the windows of native menu bars, so if you don't want those to be native, you have to set AA_DontUseNativeMenuBar just like today. By removing requestNative, we also effectively default to native menus and menu bars, as the attributes are not set by default. [ChangeLog][Controls][Important Behavior Changes] Menu and MenuBar now use native menus by default on platforms where they're supported. Task-number: QTBUG-69558 Change-Id: Ia917c2f820634def0cf815aa8ca8895ca79db75d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-14 03:36:06 +00:00
// Now that it's open and has picked up the changes to Qt::AA_DontUseNativeMenuWindows, we can check it.
QVERIFY(!contextMenuPrivate->handle);
QVERIFY(!subMenuPrivate->handle);
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
// Check that it opened at the mouse cursor and actually has menu items.
QCOMPARE(contextMenu->x(), cursorPos.x());
QCOMPARE(contextMenu->y(), cursorPos.y());
auto *action1MenuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(0));
QVERIFY(action1MenuItem);
QCOMPARE(action1MenuItem->text(), "action1");
Menu, MenuBar: remove requestNative and rely solely on app attributes It was decided that we'll have two attributes: - AA_DontUseNativeMenuBar - AA_DontUseNativeMenuWindows Setting AA_DontUseNativeMenuWindows only affects windows we create (context menus, combobox menus, menus of non-native menu bars). So, setting AA_DontUseNativeMenuWindows restores Qt to today's behavior. But we can't control the windows of native menu bars, so if you don't want those to be native, you have to set AA_DontUseNativeMenuBar just like today. By removing requestNative, we also effectively default to native menus and menu bars, as the attributes are not set by default. [ChangeLog][Controls][Important Behavior Changes] Menu and MenuBar now use native menus by default on platforms where they're supported. Task-number: QTBUG-69558 Change-Id: Ia917c2f820634def0cf815aa8ca8895ca79db75d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-14 03:36:06 +00:00
// Test setting Qt::AA_DontUseNativeMenuWindows while visible has no effect
// (until it's re-opened, which we can't test because we can't test opening native menus).
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuWindows, false);
QVERIFY(contextMenuPrivate->useNativeMenu());
Menu: allow setting (but not always respecting) requestNative We can allow this to be set while the menu is a sub-menu and/or visible, and instead wait until it is re-opened to take the change into effect. Task-number: QTBUG-69558 Change-Id: Ie79819609950c2f6432e55c09d21dce7e8d9b220 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-06 06:20:10 +00:00
QVERIFY(!contextMenuPrivate->handle);
QVERIFY(!subMenuPrivate->handle);
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
// Also check the submenu.
auto *subAction1MenuItem = qobject_cast<QQuickMenuItem *>(subMenu->itemAt(0));
QVERIFY(subAction1MenuItem);
QCOMPARE(subAction1MenuItem->text(), "subAction1");
// Test closing the non-native menu by clicking on an item.
QSignalSpy aboutToHideSpy(contextMenu, &QQuickMenu::aboutToHide);
QVERIFY(aboutToHideSpy.isValid());
QVERIFY(clickButton(action1MenuItem));
QVERIFY(!contextMenu->isOpened());
QTRY_VERIFY(!contextMenu->isVisible());
QCOMPARE(aboutToShowSpy.size(), 1);
// Although we can't open the native menu, we can at least check that
Menu: allow setting (but not always respecting) requestNative We can allow this to be set while the menu is a sub-menu and/or visible, and instead wait until it is re-opened to take the change into effect. Task-number: QTBUG-69558 Change-Id: Ie79819609950c2f6432e55c09d21dce7e8d9b220 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-06 06:20:10 +00:00
// attempting (the changes won't come into effect until it's re-opened)
// to make the menu native again doesn't e.g. crash.
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
QVERIFY(contextMenuPrivate->useNativeMenu());
QVERIFY(subMenuPrivate->useNativeMenu());
Menu: allow setting (but not always respecting) requestNative We can allow this to be set while the menu is a sub-menu and/or visible, and instead wait until it is re-opened to take the change into effect. Task-number: QTBUG-69558 Change-Id: Ie79819609950c2f6432e55c09d21dce7e8d9b220 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-06 06:20:10 +00:00
QVERIFY(!contextMenuPrivate->handle);
QVERIFY(!subMenuPrivate->handle);
Merge tst_nativemenus into tst_qquickmenu Now that we also run the tests on platforms without native menu support. Doing so exposed an issue with requestNative and sub-menus, so this commit fixes that and, as a consequence, delays creation of native menus until component completion. Task-number: QTBUG-69558 Change-Id: I94e459708fa87783b0e79710f6c8ce2a03e0d789 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-02-05 08:51:46 +00:00
}
Menu: fix mixing non-Menu-related items in with native menus Create QQuickNativeMenuItems even for items that we don't recognize so that our indices match up with contentModel's. Task-number: QTBUG-69558 Change-Id: I7515dbefe4adb075bbda92adde5a9327033154c1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-12 06:35:17 +00:00
// Check that non-menu items (e.g. Rectangles) can be inserted between menu items without issues.
void tst_QQuickMenu::nativeMixedItems()
{
Menu, MenuBar: remove requestNative and rely solely on app attributes It was decided that we'll have two attributes: - AA_DontUseNativeMenuBar - AA_DontUseNativeMenuWindows Setting AA_DontUseNativeMenuWindows only affects windows we create (context menus, combobox menus, menus of non-native menu bars). So, setting AA_DontUseNativeMenuWindows restores Qt to today's behavior. But we can't control the windows of native menu bars, so if you don't want those to be native, you have to set AA_DontUseNativeMenuBar just like today. By removing requestNative, we also effectively default to native menus and menu bars, as the attributes are not set by default. [ChangeLog][Controls][Important Behavior Changes] Menu and MenuBar now use native menus by default on platforms where they're supported. Task-number: QTBUG-69558 Change-Id: Ia917c2f820634def0cf815aa8ca8895ca79db75d Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-03-14 03:36:06 +00:00
QCoreApplication::setAttribute(Qt::AA_DontUseNativeMenuWindows, false);
Menu: fix mixing non-Menu-related items in with native menus Create QQuickNativeMenuItems even for items that we don't recognize so that our indices match up with contentModel's. Task-number: QTBUG-69558 Change-Id: I7515dbefe4adb075bbda92adde5a9327033154c1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-12 06:35:17 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("nativeMixedItems.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu *contextMenu = window->property("contextMenu").value<QQuickMenu*>();
QVERIFY(contextMenu);
// Insert a Rectangle between the Action and MenuItem in the top-level menu.
QVERIFY(QMetaObject::invokeMethod(window, "insertRectangle",
Q_ARG(QQuickMenu *, contextMenu), Q_ARG(int, 1), Q_ARG(QColor, QColorConstants::Red)));
{
auto *action = contextMenu->actionAt(0);
QVERIFY(action);
QCOMPARE(action->text(), "action");
auto *rectangle = qobject_cast<QQuickRectangle *>(contextMenu->itemAt(1));
QVERIFY(rectangle);
QCOMPARE(rectangle->color(), QColorConstants::Red);
auto *menuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(2));
QVERIFY(menuItem);
QCOMPARE(menuItem->text(), "menuItem");
auto *subMenu = contextMenu->menuAt(3);
QVERIFY(subMenu);
QCOMPARE(subMenu->title(), "subMenu");
}
// Insert a Rectangle at the end of all of the items (which were: {Action, Rectangle, MenuItem, Menu}).
QVERIFY(QMetaObject::invokeMethod(window, "insertRectangle",
Q_ARG(QQuickMenu *, contextMenu), Q_ARG(int, 4), Q_ARG(QColor, QColorConstants::Blue)));
{
auto *action = contextMenu->actionAt(0);
QVERIFY(action);
QCOMPARE(action->text(), "action");
auto *rectangle1 = qobject_cast<QQuickRectangle *>(contextMenu->itemAt(1));
QVERIFY(rectangle1);
QCOMPARE(rectangle1->color(), QColorConstants::Red);
auto *menuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(2));
QVERIFY(menuItem);
QCOMPARE(menuItem->text(), "menuItem");
auto *subMenu = contextMenu->menuAt(3);
QVERIFY(subMenu);
QCOMPARE(subMenu->title(), "subMenu");
auto *rectangle2 = qobject_cast<QQuickRectangle *>(contextMenu->itemAt(4));
QVERIFY(rectangle2);
QCOMPARE(rectangle2->color(), QColorConstants::Blue);
}
// Check that the sub-menu can be accessed and is in the
// appropriate place in contentData.
auto *subMenu = contextMenu->menuAt(3);
QVERIFY(subMenu);
// Insert a Rectangle between the Action and MenuItem in the top-level menu.
QVERIFY(QMetaObject::invokeMethod(window, "insertRectangle",
Q_ARG(QQuickMenu *, subMenu), Q_ARG(int, 1), Q_ARG(QColor, QColorConstants::Green)));
{
auto *action1 = subMenu->actionAt(0);
QVERIFY(action1);
QCOMPARE(action1->text(), "subAction1");
auto *rectangle = qobject_cast<QQuickRectangle *>(subMenu->itemAt(1));
QVERIFY(rectangle);
QCOMPARE(rectangle->color(), QColorConstants::Green);
auto *action2 = subMenu->actionAt(2);
QVERIFY(action2);
QCOMPARE(action2->text(), "subAction2");
}
}
QQuickPopupPositioner: implement setEffectivePosFromWindowPos() Factor out setting the effective position to a separate function, and call it from all places where we change it. This ensures that we always emit the xChanged/yChanged signals, and that we always include any drop-shadow offset in the calculation. Also change the effectPos variable to be a QPointF. Pick-to: 6.8 Change-Id: I00ad7e25397887719811738343448f177261cc54 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-03 14:03:48 +00:00
void tst_QQuickMenu::effectivePosition_data()
{
QTest::addColumn<QQuickPopup::PopupType>("popupType");
QTest::newRow("Item") << QQuickPopup::Item;
Add arePopupWindowsSupported function to QQuickControlsTestUtils And reduce a few duplicate checks throughout our tests. Pick-to: 6.8 6.9 Change-Id: I31610f07eb548282ade5573af56ffef18d33cd66 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2025-03-25 05:26:26 +00:00
if (arePopupWindowsSupported())
Make tst_qquickmenu::effectivePosition work with popup windows The test were too strict, when comparing the background element, with the requested position. Causing it to be off by 1 pixel, on some systems. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: If7e87a018698bb89facd6dcb915c2a8bdf403c36 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-09-03 00:04:46 +00:00
QTest::newRow("Window") << QQuickPopup::Window;
QQuickPopupPositioner: implement setEffectivePosFromWindowPos() Factor out setting the effective position to a separate function, and call it from all places where we change it. This ensures that we always emit the xChanged/yChanged signals, and that we always include any drop-shadow offset in the calculation. Also change the effectPos variable to be a QPointF. Pick-to: 6.8 Change-Id: I00ad7e25397887719811738343448f177261cc54 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-03 14:03:48 +00:00
}
void tst_QQuickMenu::effectivePosition()
{
QQuickPopup: support popups with negative insets A Popup can have negative insets. This means that the the background will be drawn outside the bounds of the popup. This is fine when the popup is an item in the scene, since items are allowed to draw out-of-bounds. But when placing the popup inside a window, this is no longer true; Since the window will be resized to the same size as the popup, the background will be clipped. Since we plan to make popup windows the default in Qt 6.8, this clipping will quickly be seen as a regression. This issue can be seen if opening a context menu in the Imagine style, since the menus in that style use negative insets to draw a drop-shadow outside the popup. In order to make sure that we end up drawing the whole popup also when using popup windows, this patch will ensure that we resize the window to also include the (negative) insets. By positioning the popupItem inside the window according to the insets, and at the same time, move the window a bit back and up accordingly, the whole popupItem will be visible and end up at the requested position. With this change, the menus in the Imagine style will be drawn correctly. So update the macOS and Windows styles as well so that they all implement shadows the same way. This also allowes us to remove some early changes done to QQuickPopupItem, like overriding the contains() function. Pick-to: 6.8 Change-Id: I7a0b597bc768d3c485a125c644139dfc7eb0b8ab Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-17 08:52:38 +00:00
// Check that the top-left corner of the background delegate is placed
// at the requested menu position. If the popup have negative insets, it
// means that the background is drawn outside the bounds of the popup.
// To ensure that the whole background still ends up visible on screen, also
// when using QQuickPopup::Window, the window will be resized bigger to
// encompass both the background and the insets. The window will then be
// moved a bit left and up relative to the requested popup position, and the
// background the opposite way, to ensure that the top-left of the background
// ends up at the requested position.
QQuickPopupPositioner: implement setEffectivePosFromWindowPos() Factor out setting the effective position to a separate function, and call it from all places where we change it. This ensures that we always emit the xChanged/yChanged signals, and that we always include any drop-shadow offset in the calculation. Also change the effectPos variable to be a QPointF. Pick-to: 6.8 Change-Id: I00ad7e25397887719811738343448f177261cc54 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-03 14:03:48 +00:00
QFETCH(QQuickPopup::PopupType, popupType);
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
QQuickPopupPositioner: implement setEffectivePosFromWindowPos() Factor out setting the effective position to a separate function, and call it from all places where we change it. This ensures that we always emit the xChanged/yChanged signals, and that we always include any drop-shadow offset in the calculation. Also change the effectPos variable to be a QPointF. Pick-to: 6.8 Change-Id: I00ad7e25397887719811738343448f177261cc54 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-03 14:03:48 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("applicationwindow.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
centerOnScreen(window);
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QVERIFY(menu);
menu->setPopupType(popupType);
QQuickPopup: support popups with negative insets A Popup can have negative insets. This means that the the background will be drawn outside the bounds of the popup. This is fine when the popup is an item in the scene, since items are allowed to draw out-of-bounds. But when placing the popup inside a window, this is no longer true; Since the window will be resized to the same size as the popup, the background will be clipped. Since we plan to make popup windows the default in Qt 6.8, this clipping will quickly be seen as a regression. This issue can be seen if opening a context menu in the Imagine style, since the menus in that style use negative insets to draw a drop-shadow outside the popup. In order to make sure that we end up drawing the whole popup also when using popup windows, this patch will ensure that we resize the window to also include the (negative) insets. By positioning the popupItem inside the window according to the insets, and at the same time, move the window a bit back and up accordingly, the whole popupItem will be visible and end up at the requested position. With this change, the menus in the Imagine style will be drawn correctly. So update the macOS and Windows styles as well so that they all implement shadows the same way. This also allowes us to remove some early changes done to QQuickPopupItem, like overriding the contains() function. Pick-to: 6.8 Change-Id: I7a0b597bc768d3c485a125c644139dfc7eb0b8ab Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-17 08:52:38 +00:00
// Move the background delegate a bit out of the popup, to simulate using a drop-shadow.
const QPointF insets = QPointF{-20, -10};
QQuickPopupPositioner: implement setEffectivePosFromWindowPos() Factor out setting the effective position to a separate function, and call it from all places where we change it. This ensures that we always emit the xChanged/yChanged signals, and that we always include any drop-shadow offset in the calculation. Also change the effectPos variable to be a QPointF. Pick-to: 6.8 Change-Id: I00ad7e25397887719811738343448f177261cc54 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-03 14:03:48 +00:00
menu->setLeftInset(insets.x());
menu->setTopInset(insets.y());
const QPointF requestedPos{100, 100};
menu->popup(requestedPos);
QTRY_VERIFY(menu->isOpened());
QQuickPopup: support popups with negative insets A Popup can have negative insets. This means that the the background will be drawn outside the bounds of the popup. This is fine when the popup is an item in the scene, since items are allowed to draw out-of-bounds. But when placing the popup inside a window, this is no longer true; Since the window will be resized to the same size as the popup, the background will be clipped. Since we plan to make popup windows the default in Qt 6.8, this clipping will quickly be seen as a regression. This issue can be seen if opening a context menu in the Imagine style, since the menus in that style use negative insets to draw a drop-shadow outside the popup. In order to make sure that we end up drawing the whole popup also when using popup windows, this patch will ensure that we resize the window to also include the (negative) insets. By positioning the popupItem inside the window according to the insets, and at the same time, move the window a bit back and up accordingly, the whole popupItem will be visible and end up at the requested position. With this change, the menus in the Imagine style will be drawn correctly. So update the macOS and Windows styles as well so that they all implement shadows the same way. This also allowes us to remove some early changes done to QQuickPopupItem, like overriding the contains() function. Pick-to: 6.8 Change-Id: I7a0b597bc768d3c485a125c644139dfc7eb0b8ab Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-17 08:52:38 +00:00
// The logical position of the menu should still be the requested position
QQuickPopupPositioner: implement setEffectivePosFromWindowPos() Factor out setting the effective position to a separate function, and call it from all places where we change it. This ensures that we always emit the xChanged/yChanged signals, and that we always include any drop-shadow offset in the calculation. Also change the effectPos variable to be a QPointF. Pick-to: 6.8 Change-Id: I00ad7e25397887719811738343448f177261cc54 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-03 14:03:48 +00:00
QTRY_COMPARE(menu->position(), requestedPos);
QCOMPARE(menu->x(), requestedPos.x());
QCOMPARE(menu->y(), requestedPos.y());
QQuickPopup: support popups with negative insets A Popup can have negative insets. This means that the the background will be drawn outside the bounds of the popup. This is fine when the popup is an item in the scene, since items are allowed to draw out-of-bounds. But when placing the popup inside a window, this is no longer true; Since the window will be resized to the same size as the popup, the background will be clipped. Since we plan to make popup windows the default in Qt 6.8, this clipping will quickly be seen as a regression. This issue can be seen if opening a context menu in the Imagine style, since the menus in that style use negative insets to draw a drop-shadow outside the popup. In order to make sure that we end up drawing the whole popup also when using popup windows, this patch will ensure that we resize the window to also include the (negative) insets. By positioning the popupItem inside the window according to the insets, and at the same time, move the window a bit back and up accordingly, the whole popupItem will be visible and end up at the requested position. With this change, the menus in the Imagine style will be drawn correctly. So update the macOS and Windows styles as well so that they all implement shadows the same way. This also allowes us to remove some early changes done to QQuickPopupItem, like overriding the contains() function. Pick-to: 6.8 Change-Id: I7a0b597bc768d3c485a125c644139dfc7eb0b8ab Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-17 08:52:38 +00:00
// But in reality, the background delegate is placed at the
// requested position pluss the (negative) insets
QQuickPopupPositioner: implement setEffectivePosFromWindowPos() Factor out setting the effective position to a separate function, and call it from all places where we change it. This ensures that we always emit the xChanged/yChanged signals, and that we always include any drop-shadow offset in the calculation. Also change the effectPos variable to be a QPointF. Pick-to: 6.8 Change-Id: I00ad7e25397887719811738343448f177261cc54 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-03 14:03:48 +00:00
const auto background = menu->background();
QVERIFY(background);
Make tst_qquickmenu::effectivePosition work with popup windows The test were too strict, when comparing the background element, with the requested position. Causing it to be off by 1 pixel, on some systems. Task-number: QTBUG-126553 Pick-to: 6.8 Change-Id: If7e87a018698bb89facd6dcb915c2a8bdf403c36 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-09-03 00:04:46 +00:00
const QPoint actualBgPos = background->mapToItem(menu->parentItem(), {0, 0}).toPoint();
const QPoint requestedPlusInsets = (requestedPos + insets).toPoint();
QVERIFY2(qAbs(actualBgPos.x() - requestedPlusInsets.x()) < 2,
qPrintable(QStringLiteral("The background's requsted x value %1 didn't match the actual value of %2")
.arg(actualBgPos.x()).arg(requestedPlusInsets.x())));
QVERIFY2(qAbs(actualBgPos.y() - requestedPlusInsets.y()) < 2,
qPrintable(QStringLiteral("The background's requsted y value %1 didn't match the actual value of %2")
.arg(actualBgPos.y()).arg(requestedPlusInsets.y())));
QQuickPopupPositioner: implement setEffectivePosFromWindowPos() Factor out setting the effective position to a separate function, and call it from all places where we change it. This ensures that we always emit the xChanged/yChanged signals, and that we always include any drop-shadow offset in the calculation. Also change the effectPos variable to be a QPointF. Pick-to: 6.8 Change-Id: I00ad7e25397887719811738343448f177261cc54 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-06-03 14:03:48 +00:00
}
Menu: fix mixing non-Menu-related items in with native menus Create QQuickNativeMenuItems even for items that we don't recognize so that our indices match up with contentModel's. Task-number: QTBUG-69558 Change-Id: I7515dbefe4adb075bbda92adde5a9327033154c1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2024-02-12 06:35:17 +00:00
QQuickMenuItem: add implicitTextPadding and textPadding Add the properties "implicitTextPadding" and "textPadding" to MenuItem. They can be used by the style to ensure that all MenuItems inside the same Menu end up left-aligned WRT text. Each MenuItem should set implicitTextPadding to be the needed space from the left edge of the contentItem to the text label. QQuickMenu will then iterate over all the MenuItems inside the same Menu, and set textPadding to be the maximum implicitTextPadding found. All MenuItems should then use textPadding (which will end up the same for all MenuItems) to position the text. This API is meant to solve the problem that MenuItems inside a single Menu can have different contents. Some can be checkable, some can have an icon, some are just plain text. And for several of our styles (e.g macOS and Windows), we want the text to be left-aligned regardless of that. Without this API, The checkmark inside a checkable MenuItem would be left-aligned with the text inside a plain MenuItem etc. [ChangeLog][Controls][MenuItem] A MenuItem now has two new properties (implicitTextPadding and textPadding) that can be used for aligning the text across all MenuItems inside a Menu. Change-Id: I1f2248b31c63d6b9780d8fc77229a8b902362f70 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-05-22 20:15:53 +00:00
void tst_QQuickMenu::textPadding()
{
// Check that you can set implicitTextPadding on each MenuItem, and that
// textPadding will end up as the maximum implicitTextPadding among all the
// MenuItems in the same Menu.
QQuickControlsApplicationHelper helper(this, QLatin1String("nativeMixedItems.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
QQuickMenu *contextMenu = window->property("contextMenu").value<QQuickMenu*>();
QVERIFY(contextMenu);
Replace AA_DontUsePopupWindows with Popup::popupType The application attribute approach has some weaknesses which makes it less suitable, than simply having a property which can be set per instance of Popup. In addition, given just how many of our own tests that are failing, when changing the default behavior of popup, it`s a much safer approach to introduce this feature as an opt-in, in the beginning. We can instead potentially modify the behavior of PopupType::Default in the future, when we feel that it's less risky to do so. To give more context to why the AA approach is bad: - The AA is too grandiose of a solution, which adds an arbitrary limitation of not allowing mixing of in-scene popups and popup windows. This also affects 3rd party libraries. - It causes inconveniences when styling the various popup types. Dialog, for instance, has a title property, which should be shown in the window title, and not inside the popup window. - It also makes it less flexible for potential future changes. We've learned that this change is riskier, than initially expected, since the qobject and visual hierarchy of popup objects are different when using popup windows, and tests that simulate events, will need to send the events to a different window. The introduction of the PopupType::Default value, allows us to, for instance, add a property later in ApplicationWindow, or somewhere else, to change the behavior of PopupType::Default. Meaning that we can still add a more grandiose API, that affects the behavior of multiple popup instances, if we think it's too cumbersome for developers to add `popupType: Popup.Window` to all popup instances. Task-number: QTBUG-121363 Change-Id: I544da820261607621a9b9ad5c4c9679e676e44a0 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2024-05-27 22:01:20 +00:00
contextMenu->setPopupType(QQuickPopup::Item);
QQuickMenuItem: add implicitTextPadding and textPadding Add the properties "implicitTextPadding" and "textPadding" to MenuItem. They can be used by the style to ensure that all MenuItems inside the same Menu end up left-aligned WRT text. Each MenuItem should set implicitTextPadding to be the needed space from the left edge of the contentItem to the text label. QQuickMenu will then iterate over all the MenuItems inside the same Menu, and set textPadding to be the maximum implicitTextPadding found. All MenuItems should then use textPadding (which will end up the same for all MenuItems) to position the text. This API is meant to solve the problem that MenuItems inside a single Menu can have different contents. Some can be checkable, some can have an icon, some are just plain text. And for several of our styles (e.g macOS and Windows), we want the text to be left-aligned regardless of that. Without this API, The checkmark inside a checkable MenuItem would be left-aligned with the text inside a plain MenuItem etc. [ChangeLog][Controls][MenuItem] A MenuItem now has two new properties (implicitTextPadding and textPadding) that can be used for aligning the text across all MenuItems inside a Menu. Change-Id: I1f2248b31c63d6b9780d8fc77229a8b902362f70 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
2024-05-22 20:15:53 +00:00
contextMenu->setVisible(true);
// Go through all MenuItems, and give them an implicitTextPadding of 0
for (int i = 0; i < contextMenu->count(); ++i) {
auto menuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(i));
QVERIFY(menuItem);
menuItem->setImplicitTextPadding(0);
QCOMPARE(menuItem->implicitTextPadding(), 0);
}
// Check that all MenuItems now has a textPadding of 0
for (int i = 0; i < contextMenu->count(); ++i) {
auto menuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(i));
QCOMPARE(menuItem->textPadding(), 0);
}
// Let the first MenuItem get a implicitTextPadding of 100. This will
// make all MenuItems get a textPadding of 100.
auto firstItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(0));
firstItem->setImplicitTextPadding(100);
QCOMPARE(firstItem->implicitTextPadding(), 100);
QCOMPARE(firstItem->textPadding(), 100);
for (int i = 1; i < contextMenu->count(); ++i) {
auto menuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(i));
QCOMPARE(menuItem->implicitTextPadding(), 0);
QCOMPARE(menuItem->textPadding(), 100);
}
// Hide the MenuItem with implicitTextPadding set to 100. This
// should make all the MenuItems get a textPadding of 0 again.
firstItem->setVisible(false);
QCOMPARE(firstItem->implicitTextPadding(), 100);
for (int i = 0; i < contextMenu->count(); ++i) {
auto menuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(i));
QCOMPARE(menuItem->textPadding(), 0);
}
// Show it again
firstItem->setVisible(true);
for (int i = 0; i < contextMenu->count(); ++i) {
auto menuItem = qobject_cast<QQuickMenuItem *>(contextMenu->itemAt(i));
QCOMPARE(menuItem->textPadding(), 100);
}
}
QQuickMenu: clear currentIndex upon a call to popup() If you popup() a Menu a second time, without providing a MenuItem as argument, the previously activated MenuItem will still be current, and rendered as highlighted. This is not the expected behavior for Context Menus or MenuBar menus. This patch will therefore make sure that we reset currentIndex when popping up a Menu. It's still possible to open() it instead, if currentIndex should be kept. Pick-to: 6.8 Change-Id: I09fdc2e5429ba107b236d0c761ca8d1de654710e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-03 09:58:44 +00:00
void tst_QQuickMenu::resetCurrentIndexUponPopup_data()
{
QTest::addColumn<QQuickPopup::PopupType>("popupType");
QTest::newRow("Item") << QQuickPopup::Item;
QTest::newRow("Window") << QQuickPopup::Window;
// Note: a call to Menu.popup() will be a blocking call on many platforms
// when using native menus (e.g macOS and Windows). We can therefore not
// check a Menus internal state, nor make a MenuItem current, while it's visible.
// QTest::newRow("Native") << QQuickPopup::Native;
}
void tst_QQuickMenu::resetCurrentIndexUponPopup()
{
// Check that currentIndex is reset back to -1 when
// a menu is repopened using the popup() function without
// providing a MenuItem as argument.
QFETCH(QQuickPopup::PopupType, popupType);
Wrap SKIP_IF_NO_* macros in do while(false) loop This prevents errors in certain usages of the macros. https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Macros Amends f7dffe0ae8a97dd3d7bbcf753d122b2066639fc3. Change-Id: I0804d439f7019870f9750444316f3cc676e02405 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2024-09-05 07:02:00 +00:00
SKIP_IF_NO_WINDOW_ACTIVATION;
QQuickMenu: clear currentIndex upon a call to popup() If you popup() a Menu a second time, without providing a MenuItem as argument, the previously activated MenuItem will still be current, and rendered as highlighted. This is not the expected behavior for Context Menus or MenuBar menus. This patch will therefore make sure that we reset currentIndex when popping up a Menu. It's still possible to open() it instead, if currentIndex should be kept. Pick-to: 6.8 Change-Id: I09fdc2e5429ba107b236d0c761ca8d1de654710e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-03 09:58:44 +00:00
QQuickControlsApplicationHelper helper(this, QLatin1String("applicationwindow.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
centerOnScreen(window);
tst_qquickmenu: ensure that the menu doesn't open under the mouse The "resetCurrentIndexUponPopup" test checks that a menu item is not pre-selected when a menu opens a second time. But will only be the case if the menu doesn't open directly under the mouse, since otherwise the mouse will end up selecting the menu item underneath it. This patch will therefore make sure that we move the mouse away before the menu opens, and that we also tell the menu to open inside the bounds of the parent window rather than at the location of the mouse, since the latter turns out to be flaky. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5685e9223a6619cc179cc4e8b7e331b0ded11d20 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2025-02-17 12:47:37 +00:00
moveMouseAway(window);
QQuickMenu: clear currentIndex upon a call to popup() If you popup() a Menu a second time, without providing a MenuItem as argument, the previously activated MenuItem will still be current, and rendered as highlighted. This is not the expected behavior for Context Menus or MenuBar menus. This patch will therefore make sure that we reset currentIndex when popping up a Menu. It's still possible to open() it instead, if currentIndex should be kept. Pick-to: 6.8 Change-Id: I09fdc2e5429ba107b236d0c761ca8d1de654710e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-03 09:58:44 +00:00
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
QQuickMenu *menu = window->property("menu").value<QQuickMenu*>();
QVERIFY(menu);
menu->setPopupType(popupType);
QCOMPARE(menu->currentIndex(), -1);
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(-1));
tst_qquickmenu: ensure that the menu doesn't open under the mouse The "resetCurrentIndexUponPopup" test checks that a menu item is not pre-selected when a menu opens a second time. But will only be the case if the menu doesn't open directly under the mouse, since otherwise the mouse will end up selecting the menu item underneath it. This patch will therefore make sure that we move the mouse away before the menu opens, and that we also tell the menu to open inside the bounds of the parent window rather than at the location of the mouse, since the latter turns out to be flaky. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5685e9223a6619cc179cc4e8b7e331b0ded11d20 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2025-02-17 12:47:37 +00:00
menu->popup(0, 0, nullptr);
QQuickMenu: clear currentIndex upon a call to popup() If you popup() a Menu a second time, without providing a MenuItem as argument, the previously activated MenuItem will still be current, and rendered as highlighted. This is not the expected behavior for Context Menus or MenuBar menus. This patch will therefore make sure that we reset currentIndex when popping up a Menu. It's still possible to open() it instead, if currentIndex should be kept. Pick-to: 6.8 Change-Id: I09fdc2e5429ba107b236d0c761ca8d1de654710e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-03 09:58:44 +00:00
QTRY_VERIFY(menu->isOpened());
QCOMPARE(menu->currentIndex(), -1);
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(-1));
menu->setCurrentIndex(1);
QCOMPARE(menu->currentIndex(), 1);
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(1));
menu->close();
QTRY_VERIFY(!menu->isVisible());
tst_qquickmenu: ensure that the menu doesn't open under the mouse The "resetCurrentIndexUponPopup" test checks that a menu item is not pre-selected when a menu opens a second time. But will only be the case if the menu doesn't open directly under the mouse, since otherwise the mouse will end up selecting the menu item underneath it. This patch will therefore make sure that we move the mouse away before the menu opens, and that we also tell the menu to open inside the bounds of the parent window rather than at the location of the mouse, since the latter turns out to be flaky. Task-number: QTBUG-133530 Pick-to: 6.8 6.9 Change-Id: I5685e9223a6619cc179cc4e8b7e331b0ded11d20 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2025-02-17 12:47:37 +00:00
menu->popup(0, 0, nullptr);
QQuickMenu: clear currentIndex upon a call to popup() If you popup() a Menu a second time, without providing a MenuItem as argument, the previously activated MenuItem will still be current, and rendered as highlighted. This is not the expected behavior for Context Menus or MenuBar menus. This patch will therefore make sure that we reset currentIndex when popping up a Menu. It's still possible to open() it instead, if currentIndex should be kept. Pick-to: 6.8 Change-Id: I09fdc2e5429ba107b236d0c761ca8d1de654710e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-06-03 09:58:44 +00:00
QTRY_VERIFY(menu->isOpened());
QCOMPARE(menu->currentIndex(), -1);
QCOMPARE(menu->contentItem()->property("currentIndex"), QVariant(-1));
}
Don't propagate mouse event for menu configured inside popup The patch e4a159632ec39542ec23567963191162f9dcdfef fixes propagating mouse events by not allowing it to the underlying items beneath the overlay. It still can cause an issue when the menu is nested within the popup. This is because the menu doesn't block the input, which allows the overlay to pass on the events to the next child item. This patch enables the menu to consume the mouse press event (as similar to the drawer), further causing overlay not to pass on the events to the other child items. Fixes: QTBUG-130536 Pick-to: 6.8 6.5 Change-Id: I1014c692a4a5aed22e096a79c06e27cb26fea70d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-10-30 09:14:14 +00:00
void tst_QQuickMenu::mousePropagationWithinPopup()
{
QQuickControlsApplicationHelper helper(this, QLatin1String("mousePropagationWithinPopup.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
centerOnScreen(window);
window->show();
QVERIFY(QTest::qWaitForWindowActive(window));
QQuickPopup *popup = window->property("popup").value<QQuickPopup*>();
QVERIFY(popup);
popup->open();
QTRY_VERIFY(popup->isOpened());
QQuickMenu *nestedMenu = window->property("nestedMenu").value<QQuickMenu*>();
QVERIFY(nestedMenu);
nestedMenu->open();
QTRY_VERIFY(nestedMenu->isOpened());
QQuickMouseArea *mouseArea = window->property("mouseArea").value<QQuickMouseArea *>();
QVERIFY(mouseArea);
QSignalSpy clickedSpy(mouseArea, &QQuickMouseArea::clicked);
QQuickMenuItem *menuItem2 = qobject_cast<QQuickMenuItem *>(nestedMenu->itemAt(1));
QVERIFY(menuItem2);
QVERIFY(!menuItem2->isEnabled());
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier, mapCenterToWindow(menuItem2));
QCOMPARE(clickedSpy.size(), 0);
// Check on the gap area between menu and its item
Skip verifying mouse propagation in the menu gap area for some styles Amends patch 9fd43c27d19e675a0f5efdda4ea53fa97f61f852 The test case added to verify the mouse propagation in the gap area between the menu and its items doesn't work for styles (such as Universal) as there won't be any border. Make this case conditional, so the styles that don't support borders can skip it. Task-number: QTBUG-130536 Pick-to: 6.8 Change-Id: I0f9657be3965e02c49578006fbe14b6eb0a7dd1f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-11-05 14:01:54 +00:00
// Note: Skip verifying this case for the styles (such as Imagine) that doesn't have gap
// between menu and its item
const auto menuItem1 = qobject_cast<QQuickMenuItem *>(nestedMenu->itemAt(0));
Don't propagate mouse event for menu configured inside popup The patch e4a159632ec39542ec23567963191162f9dcdfef fixes propagating mouse events by not allowing it to the underlying items beneath the overlay. It still can cause an issue when the menu is nested within the popup. This is because the menu doesn't block the input, which allows the overlay to pass on the events to the next child item. This patch enables the menu to consume the mouse press event (as similar to the drawer), further causing overlay not to pass on the events to the other child items. Fixes: QTBUG-130536 Pick-to: 6.8 6.5 Change-Id: I1014c692a4a5aed22e096a79c06e27cb26fea70d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-10-30 09:14:14 +00:00
QVERIFY(menuItem1);
Skip verifying mouse propagation in the menu gap area for some styles Amends patch 9fd43c27d19e675a0f5efdda4ea53fa97f61f852 The test case added to verify the mouse propagation in the gap area between the menu and its items doesn't work for styles (such as Universal) as there won't be any border. Make this case conditional, so the styles that don't support borders can skip it. Task-number: QTBUG-130536 Pick-to: 6.8 Change-Id: I0f9657be3965e02c49578006fbe14b6eb0a7dd1f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-11-05 14:01:54 +00:00
const QPointF point = menuItem1->mapToItem(nestedMenu->background(), QPointF(0, 0));
const bool xAxis = (point.x() + nestedMenu->leftInset()) > 0;
const bool yAxis = (point.y() + nestedMenu->topInset()) > 0;
if (xAxis || yAxis) {
const auto menuItem1Pos = mapCenterToWindow(menuItem1);
QPoint gapPoint(xAxis ? menuItem1Pos.x() - menuItem1->width() / 2 - 1 : menuItem1Pos.x(),
yAxis ? menuItem1Pos.y() : menuItem1Pos.y() - menuItem1->height() / 2 - 1);
QTest::mouseClick(window, Qt::LeftButton, Qt::NoModifier, gapPoint);
QCOMPARE(clickedSpy.size(), 0);
}
Don't propagate mouse event for menu configured inside popup The patch e4a159632ec39542ec23567963191162f9dcdfef fixes propagating mouse events by not allowing it to the underlying items beneath the overlay. It still can cause an issue when the menu is nested within the popup. This is because the menu doesn't block the input, which allows the overlay to pass on the events to the next child item. This patch enables the menu to consume the mouse press event (as similar to the drawer), further causing overlay not to pass on the events to the other child items. Fixes: QTBUG-130536 Pick-to: 6.8 6.5 Change-Id: I1014c692a4a5aed22e096a79c06e27cb26fea70d Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2024-10-30 09:14:14 +00:00
}
QQuickMenu: fix infinite loop with Action shortcut in nested sub-menus 51ad5091929c7f2c4bab94fab9fa1c20996a6efa forgot to set parentMenu in the loop. Fixes: QTBUG-135965 Pick-to: 6.5 6.8 6.9 Change-Id: I56ad611a6dd6e9f978ce3da5cc28e02d8f2b1a1a Reviewed-by: Santhosh Kumar <santhosh.kumar.selvaraj@qt.io>
2025-04-15 06:07:45 +00:00
void tst_QQuickMenu::shortcutInNestedSubMenuAction()
{
QQuickControlsApplicationHelper helper(this, QLatin1String("shortcutInNestedSubMenuAction.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowActive(window));
// Shouldn't result in an infinite loop.
QTest::keyClick(window, Qt::Key_C, Qt::ControlModifier);
QCOMPARE(window->property("triggeredCount").value<int>(), 1);
}
Menu: force contentItem ListView layout before starting enter transition Enter transitions may want to animate the Menu's height based on its implicitHeight. The Menu's implicitHeight is typically based on the ListView's contentHeight, among other things. The docs for ListView's forceLayout function say: "Responding to changes in the model is usually batched to happen only once per frame." As e.g. NumberAnimation's from and to values are set before any polishes happen, any re-evaluation of their bindings happen too late, and the starting height can be out-dated when menu items are added after component completion (QQuickItemView::componentComplete does a layout, so items declared as children aren't affected by this). To account for this, this patch forces a layout before the transition starts, if necessary. Fixes: QTBUG-136256 Pick-to: 6.5 6.8 6.9 Change-Id: I1cc912347b774369b3542f0d32c654ae5615b97a Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2025-05-06 06:00:50 +00:00
void tst_QQuickMenu::animationOnHeight()
{
QQuickControlsApplicationHelper helper(this, QLatin1String("animationOnHeight.qml"));
QVERIFY2(helper.ready, helper.failureMessage());
QQuickApplicationWindow *window = helper.appWindow;
window->show();
QVERIFY(QTest::qWaitForWindowExposed(window));
auto *menu = window->findChild<QQuickMenu *>();
QVERIFY(menu);
menu->popup(100, 100);
QTRY_VERIFY(menu->isOpened());
// After adding the Action, the contentHeight of the Menu's ListView should
// be not be greater than its height; it shouldn't be possible to scroll.
auto *listView = qobject_cast<QQuickListView *>(menu->contentItem());
const qreal itemHeight = menu->itemAt(0)->height();
QCOMPARE(listView->contentHeight(), itemHeight * 2 + listView->spacing());
QCOMPARE_GE(listView->height(), listView->contentHeight());
}
Make tst_qquickmenu run with all styles This is a prerequisite for ensuring that an Imagine-style-specific fix works. Fixes: QTBUG-75141 Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2019-04-29 11:03:25 +00:00
QTEST_QUICKCONTROLS_MAIN(tst_QQuickMenu)
Add Menu An item-based menu derived from QQuickPanel. Eventually we'd like to make Panel itself a QQuickItem, as it makes both the implementation and the actual usage of Menu a lot easier. Change-Id: Ic1bf2a05ab98d9e17824c402ed8326ef65d26c69 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-16 15:06:07 +00:00
Rename tst_menu to tst_QQuickMenu Change-Id: I1c7e1a2b337e9d16bc6c9b098db08f29f1b9d1e6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-09-27 13:14:32 +00:00
#include "tst_qquickmenu.moc"