When using namespaced Qt, we need to prevent symbol clashes with symbols
of the same name.
* namespace some globally visible classes
* use hidden function as static lib initializer
Task-number: QTBUG-138543
Pick-to: 6.10
Change-Id: I096064e1c4d17c172659f802459f5c1f91fa7454
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
qmatrix4x4.h will lose its qquaternion.h include, so include
qquaternion.h explicitly in all files that mention 'QQuaternion',
unless, for a foo.cpp, the own foo.h has already included it.
Also add forward declarations where necessary.
No specific "Amends"; QQuaternion use was added "peu à peu" to the
module, but since the module hasn't materially changed since 6.5, this
patch will apply to all active branches.
Pick-to: 6.10 6.9 6.8 6.5
Change-Id: I2668164501b3ac5484546cf27c54b0d81c3ac8a6
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Kwanghyo Park <kwanghyo.park@qt.io>
The earliest we can move this is right after `BuildInternals`. This
allows us to add function calls before navigating the `find_package`
tree of the dependents.
Task-number: QTBUG-135233
Change-Id: I160079f5304a38061ac6f32d5e6a003edc176dbb
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Since 6.10, QDoc is capable of generating links to the declaration in
the source code for each documented C++ API entity in their `Detailed
description`.
Add the required configuration to enable this feature in Qt Data
Visualization.
Change-Id: I1ee8a9be3a1bcfa9be11a54f3ccacd64efd2dcc5
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
qcustom3dvolume.cpp has a function that takes in QList<uchar> and
uses the given data to create a volumetric texture without checking
the validity
Pick-to: 6.8 6.9 6.9.1
Fixes: QTBUG-135753
Change-Id: I0c439f59f4b40cb18a3fa44b2b06bd96223e4db5
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Niko Korkala <niko.korkala@qt.io>
Latest clang with -developer-build stops with
error: cast from 'NativeResourceForIntegrationFunction' (aka 'void *(*)()') to 'EnableTouch' (aka 'void *(*)(QWindow *, bool)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch
Adapt the fix already applied to e.g. qtgraphs (QTBUG-136654) here, too.
Pick-to: 6.9 6.9.1
Change-Id: I479cad4cdabfba67d83bdb6a48ebe89ec3fd5555
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
`git-review` is a command line tool for interacting with Gerrit.
Some IDEs offer support for this tool, either natively or through
plugins. The tool relies on a configuration file, .gitreview. Adding
this configuration file to our repositories simplifies initial setup
for contributors that use the tool directly or through their IDE of
choice.
The configuration file adds a remote called 'gerrit'. This is the
default for the tool, and also the name set for
codereview.qt-project.org by Qt's `init-repository` script. Thus,
the configuration should work seamlessly alongside other repository
helpers.
Task-number: QTBUG-132604
Pick-to: 6.9 6.8
Change-Id: I847be549490c9db4e18a22b3a30b0e92baf167c2
Reviewed-by: Samuel Gaist <samuel.gaist@idiap.ch>
A QUIP 18[1] update sets git files, REUSE.toml and licenseRule.json
as infrastructure type files. They are licensed with:
LicenseRef-Qt-Commercial OR BSD-3-Clause
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.9 6.8
Change-Id: I3dfcedd51bc765dc48de27cdaafb0c41e83a3510
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
This includes:
- turning VERIFY_SOURCE_SBOM ON
- adding rules to the licenseRule.json files
- correcting the licensing given via REUSE.toml files
A lot of files are skipped during the license test,
but all are present in the source SBOM.
This is why corrections are needed before turning the
source SBOM check on.
Task-number: QTBUG-131434
Pick-to: 6.9 6.8
Change-Id: I2f4caf0e11040274d443547856a2a31da0b120cc
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Datavis and Graphs have many duplicated files with same include guards.
Because QtGraphs has inherited many of its classes
from QtDataVisualization, the modules have many classes with the same
name. Therefore, mixing QtDataVisualization and QtGraphs headers in
the same TU violates ODR. This patch includes the check for that and
fails compilation with an error message.
Pick-to: 6.8 6.9
Change-Id: Ic21d18d976236c3104d32a0f7ff7dada1d721778
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
qdoc will soon warn about C++ types in QML property documentation.
This change fixes existing documentation to prevent warnings.
Pick-to: 6.8 6.9
Change-Id: I321023b8514909682c8a48dfce13f1c9c6d408b1
Reviewed-by: Paul Wicking <paul.wicking@qt.io>