Follow up on change in qtbase:577946c1f05aaaa2a3f9682001aeb4144386b26b.
Task-number: QTBUG-129575
Change-Id: I33b49a37276d18899c41d9261ae42ac74ad54df1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Pick-to: 6.7
Fixes: QTBUG-122209
Change-Id: I2492901edcf355772ee2524fcc3109a207105ab2
Reviewed-by: Chris René Lerner <chris.lerner@qt.io>
Reviewed-by: Kwanghyo Park <kwanghyo.park@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
The density of Q_FOREACH uses is high here, too high for this author,
unfamiliar with this module, to tackle in a short amount of time. But
they're concentrated in just a few TUs, so pick a different strategy:
Mark the whole module with QT_NO_FOREACH, to prevent new uses from
creeping in, and whitelist the affected TUs by #undef'ing
QT_NO_FOREACH locally, at the top of each file. For TUs that are part
of a larger executable, this requires these files to be compiled
separately, so add them to NO_PCH_SOURCES (which implies
NO_UNITY_BUILD_SOURCES, too). Created QTBUG-115807 to keep track of
this.
Ported one that was trivial and where whitelisting of the file with a
single Q_FOREACH would have been more work than directly fixing it.
Task-number: QTBUG-115807
Change-Id: I2fa6c740e35039baf34115af7d69d6c420e4de10
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
The qtgraphs and qtdatavis3d modules currently expose the same exact test
code.
When both are available, as it is by default, currently, when passing by
`init-repository`, they will define the same test targets, which will
prevent the correct setup of a superbuild at configuration time.
To avoid the name collision with qtgraphs, rename all test targets by
appending a "_datavis" suffix.
Change-Id: Ibe4a4393737efad3cbefe39305452ba5a70ad9de
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
This is a semantic patch using ClangTidyTransformator as in
qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8:
auto QtContainerClass = expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)
makeRule(cxxMemberCallExpr(on(QtContainerClass),
callee(cxxMethodDecl(hasAnyName({"count", "length"),
parameterCountIs(0))))),
changeTo(cat(access(o, cat("size"), "()"))),
cat("use 'size()' instead of 'count()/length()'"))
a.k.a qt-port-to-std-compatible-api with config Scope: 'Container',
with the extended set of container classes recognized.
Change-Id: Ibed02600e225ee63c06d61bcd6187518f650a0a0
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
CMakeLists.txt and .cmake files of significant size
(more than 2 lines according to our check in tst_license.pl)
now have the copyright and license header.
Existing copyright statements remain intact
Task-number: QTBUG-88621
Change-Id: I829aeda2bda017b7d5bf39795b79dbaee143cb60
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
Don't set CMAKE_AUTO* to ON, because in a top-level build AUTOMOC would
complain about a missing moc executable. Same for uic and rcc.
Change-Id: Iaa7c8013f11cebb3dc02f2de681c608ee5ba01e0
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
License files are organized under LICENSES directory.
Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I3b3112f5a36673b90fff0010f973d020886cf08d
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
Many of the manual tests were not compiling,
because many of the signals and slots had not
compatible signatures.
Pick-to: 6.4 6.3 6.2
Change-Id: Ibd881e5cca37ec666cb160c95b948e064ac09e5d
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
This will make sure the test data is packaged and available
on device at runtime.
Task-number: QTBUG-88846
Pick-to: 6.2 6.3
Change-Id: I9a62299243a784b5e3857ddd968a2abcdd3d6d54
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
This reverts commit 0b493d875d.
Reason for revert: Fixed in aec6b0075863bff181d1d3dfdf1399264de01f67
Task-number: QTBUG-101513
Change-Id: Ibf9e867bb787014d60dee1461b9c167bd158c360
Reviewed-by: Heikki Halmet <heikki.halmet@qt.io>
QNX QEMU does not have support for hw acceleration thus missing
createPlatformOpenGLContext, which is required for the QML applications
to work.
Pick-to: 6.2 6.3
Change-Id: Ic24f96e9cdc907ae16c1a50b0f0ddf75085d807e
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
- tst_customvolume::compile on qnx
- tst_touch::compile on qnx
- tst_themecolor::compile on qnx
- tst_colorgradient::compile on qnx
- tst_proxy::compile on qnx
- tst_heightproxy::compile on qnx
- tst_customitem::compile on qnx
- tst_scatterseries::compile on qnx
- tst_surfaceseries::compile on qnx
- tst_light::compile on qnx
- tst_surface::compile on qnx
- tst_value::compile on qnx
- tst_customlabel::compile on qnx
- tst_camera::compile on qnx
- tst_barseries::compile on qnx
- tst_category::compile on qnx
- tst_basic::compile on qnx
- tst_scene::compile on qnx
- tst_bars::compile on qnx
- tst_logvalue::compile on qnx
- tst_theme::compile on qnx
- tst_scatter::compile on qnx
- tst_input::compile on qnx
Pick-to: 6.2
Pick-to: 6.3
Task-number: QTBUG-101513
Change-Id: Ia08731ec898d02ad2196a3d21364850d9ac2dc49
Reviewed-by: CI Insignificant Platforms Monitor Bot <ci_insignificant_platforms_monitor_bot@qt.io>
Rename wireFrameColor to wireframeColor to be
consistent with other usage of wirfeframe in
QtDataVisualization.
Pick-to: 6.3
Change-Id: I1ae6cd7372e46efa2a5d83856126d45355fcff60
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Added rowColors property for Bar3DSeries.
The property can be used draw the individual
rows in the series in different colors.
Autotests and a manualtest for the property were
added also.
Fixes: QTBUG-96682
Change-Id: I5c4f778189d079206500a9289490792584eab2b9
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Added a hasSeries method to Abstract3Dgraph.
The method can be used to check whether a series
has already been added to the graph. In addition,
modified cpp and qml autotests to test
the added method.
Fixes: QTBUG-96683
Change-Id: I91f70ca15b6c5fbaa7691cd17bbfc2ef460c3d37
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Changed signals in declaratives to take their
arguments as const ref when suitable.
Pick-to: 6.1 6.2
Fixes: QTBUG-95941
Change-Id: I3d582422793ee2bfb4cb5251dcacd55d3d3acca9
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Added support for 16-bit heightmap in
QHeightmapSurfaceDataProxy. In addition, added a
manual test for testing the heightmap support.
Fixes: QTBUG-74814
Change-Id: Ief028a459600680593e8859c9e7b51fb2e43203c
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Added a new property to Bars3D. The property
controls the margin between the columns of
series. It can be used to show bars belonging
to same column, but different series
side by side. Also added autotest for qml and
cpp.
Fixes: QTBUG-69036
Change-Id: I3c353e9097a8be8cafc05f8f5120e4266baa4a5c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
If the first or last column or row of the data
given to surfacedataproxy contains NaN values,
the surfacedataproxy might fail to find the
limit values for the axis. Changed limitValues
function in surfacedataproxy so that if it
doesn't find min/max values from the first/last
column/row it continues from the next column/row.
Added a test to verify that the limit values are
found when first/last row contains NaN values.
Pick-to: 6.2
Change-Id: Ica3eebb1c6072656f59394814c3fa5e334f12c54
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Added color property for surfaceseries wireframe.
Modified surfaceseries cpptest and qmltest to
test the added property. In addition,
the documentation for the property was added.
Modified qmlsurface example to use the new
property.
Fixes: QTBUG-64748
Change-Id: I18f56258cdba2b3270dce7c8313cbf17e499ff39
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Rendering a graph directly to background didn't
work in Qt 6 since it uses RHI and there is
no way to not clear the color buffer
before rendering. The graph uses direct OpenGL
calls to render directly to background. Enabled
direct rendering to qml3doscilloscope example.
In addition, RenderDirectToBackground_NoClear got
deprecated.
When rendering directly to background,
using non-transparent qml item as a background
will hide the graph. This was already mentioned
in the documentation but not clearly enough.
Updated documentation for AbstractGraph3D.
Pick-to: 6.1
Fixes: QTBUG-90665
Change-Id: I53081bac382ab89573359886e4f5c4b41be8e86d
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Injection of parameters into signal handlers
is deprecated. So those signal handlers using
parameters needed to be changed to use formal
parameters instead. Uncommented the theme in
qmlperf manual test. Added missing space to
qmlgradient manual test.
Pick-to: 6.1
Fixes: QTBUG-92995
Change-Id: I5999df841c077be63a9f01d71188c07574b2669e
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Setting the QT_NO_INTERNAL_COMPATIBILITY_FUNCTIONS variable
in the project ensures we ported away from old API calls.
Task-number: QTBUG-86815
Change-Id: I657ce43f65def5a13ca14030215a8adc37690d20
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Added pointer to graph in Abstract3DController.
Controller can use that pointer to check whether
the graph is ready when receiving
a themetypeChanged signal. Added manual test
for gradients.
Pick-to: 6.1
Fixes: QTBUG-93506
Change-Id: I13df962b807feb615e3267f580ef57dd62a0b058
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
QVectorND and QQuarternion operates on floats, so pass in float literals
rather than doubles.
Pick-to: 6.1
Change-Id: I6ddb6a4f0caa6e8687e718e10957b6c939a091bd
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Adding one row causes an assert
ASSERT failure in QList::at: "index out of range", file include/QtCore/qlist.h, line 373
since there is no first row to check the column count against.
Check for empty as well.
Pick-to: 5.15 6.1
Task-number: PYSIDE-1438
Change-Id: I225b87b764545b7a430472dc5a4b2e476a26a7ff
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Volker Hilsheimer
Tomi Korpipaa
Sakaria Pouke
Marc Mutz
Luca Di Sera
Lucie Gérard
Ivan Solovev
Joerg Bornemann
Alexandru Croitor
Sami Varanka
Assam Boudjelthia
Pasi Petäjäjärvi
CI Insignificant Platforms Monitor Bot
Friedemann Kleint
Tuomo Pelkonen