qiurui
/
qtdatavis3d
mirror of https://github.com/qt/qtdatavis3d.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix: change signals to take values by const ref 

Changed signals in declaratives to take their
arguments as const ref when suitable.

Pick-to: 6.1 6.2
Fixes: QTBUG-95941
Change-Id: I3d582422793ee2bfb4cb5251dcacd55d3d3acca9
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
This commit is contained in:
Sami Varanka 2021-08-20 14:43:55 +03:00
parent 33e46e5572
commit 0cb6298a77
9 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/datavisualization/bars/graphmodifier.h
View File

@ -77,7 +77,7 @@ Q_SIGNALS:
void shadowQualityChanged(int quality);
void backgroundEnabledChanged(bool enabled);
void gridEnabledChanged(bool enabled);
void fontChanged(QFont font);
void fontChanged(const QFont &font);
void fontSizeChanged(int size);
private:

2
examples/datavisualization/scatter/scatterdatamodifier.h
View File

@ -63,7 +63,7 @@ Q_SIGNALS:
void backgroundEnabledChanged(bool enabled);
void gridEnabledChanged(bool enabled);
void shadowQualityChanged(int quality);
void fontChanged(QFont font);
void fontChanged(const QFont &font);
private:
QVector3D randVector();

2
src/datavisualization/engine/q3dcamera_p.h
View File

@ -89,7 +89,7 @@ Q_SIGNALS:
void minYRotationChanged(float rotation);
void maxXRotationChanged(float rotation);
void maxYRotationChanged(float rotation);
void viewMatrixChanged(QMatrix4x4 viewMatrix);
void viewMatrixChanged(const QMatrix4x4 &viewMatrix);
void viewMatrixAutoUpdateChanged(bool enabled);
public:

2
src/datavisualizationqml/colorgradient_p.h
View File

@ -67,7 +67,7 @@ public:
Q_SIGNALS:
void positionChanged(qreal position);
void colorChanged(QColor color);
void colorChanged(const QColor &color);
private:
void updateGradient();

6
src/datavisualizationqml/declarativebars_p.h
View File

@ -118,10 +118,10 @@ Q_SIGNALS:
void columnAxisChanged(QCategory3DAxis *axis);
void multiSeriesUniformChanged(bool uniform);
void barThicknessChanged(float thicknessRatio);
void barSpacingChanged(QSizeF spacing);
void barSpacingChanged(const QSizeF &spacing);
void barSpacingRelativeChanged(bool relative);
Q_REVISION(6, 3) void barSeriesMarginChanged(QSizeF margin);
void meshFileNameChanged(QString filename);
Q_REVISION(6, 3) void barSeriesMarginChanged(const QSizeF &margin);
void meshFileNameChanged(const QString &filename);
void primarySeriesChanged(QBar3DSeries *series);
void selectedSeriesChanged(QBar3DSeries *series);
Q_REVISION(1, 2) void floorLevelChanged(float level);

2
src/datavisualizationqml/declarativecolor_p.h
View File

@ -61,7 +61,7 @@ public:
QColor color() const;
Q_SIGNALS:
void colorChanged(QColor color);
void colorChanged(const QColor &color);
private:
QColor m_color;

2
src/datavisualizationqml/declarativescene_p.h
View File

@ -68,7 +68,7 @@ public:
QPoint invalidSelectionPoint() const;
Q_SIGNALS:
void selectionQueryPositionChanged(const QPointF position);
void selectionQueryPositionChanged(const QPointF &position);
};
QT_END_NAMESPACE

4
src/datavisualizationqml/declarativeseries_p.h
View File

@ -97,7 +97,7 @@ public Q_SLOTS:
void handleMultiHighlightGradientUpdate();
Q_SIGNALS:
void selectedBarChanged(QPointF position);
void selectedBarChanged(const QPointF &position);
void baseGradientChanged(ColorGradient *gradient);
void singleHighlightGradientChanged(ColorGradient *gradient);
void multiHighlightGradientChanged(ColorGradient *gradient);
@ -195,7 +195,7 @@ public Q_SLOTS:
void handleMultiHighlightGradientUpdate();
Q_SIGNALS:
void selectedPointChanged(QPointF position);
void selectedPointChanged(const QPointF &position);
void baseGradientChanged(ColorGradient *gradient);
void singleHighlightGradientChanged(ColorGradient *gradient);
void multiHighlightGradientChanged(ColorGradient *gradient);

2
tests/manual/directional/scatterdatamodifier.h
View File

@ -65,7 +65,7 @@ Q_SIGNALS:
void backgroundEnabledChanged(bool enabled);
void gridEnabledChanged(bool enabled);
void shadowQualityChanged(int quality);
void fontChanged(QFont font);
void fontChanged(const QFont &font);
private:
Q3DScatter *m_graph;