The earliest we can move this is right after `BuildInternals`. This
allows us to add function calls before navigating the `find_package`
tree of the dependents.
Task-number: QTBUG-135233
Change-Id: I0964165557da64c4753df637f773ccd1412fd5eb
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Apparently, a copy-paste error, which lead to selectedBarsChanged()
signal never being handled properly.
Amends 1a0063ed15.
Fixes: QTBUG-132357
Pick-to: 6.10 6.9 6.8 6.5
Change-Id: I7f305dbb7af1daadc8abf687b0dacbd0dbf3a603
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
The docs claim that the series takes ownership of the inserted bar set.
However, that didn't happen in practice. Fix by explicitly calling
setParent(this), like it's done for other similar operations.
Amends 978d41b59a.
Pick-to: 6.10 6.9 6.8 6.5
Change-Id: I19d1399195a63d096bb00b1a13d15e1b9a8d9493
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
The replace() overload taking a list of points did not consider the
fact that the new list can be shorter than the original.
If some points were selected before the replace() call, and there
are no points with such indexes in the new list, then selectedPoints()
was still reporting non-existent indexes.
This patch updates the logic of replace(QList<QPointF>) to also make
sure that all the non-existent indexes are removed from the set
that keeps track of the selected points.
Amends 86f3ac473a.
Fixes: QTBUG-132790
Pick-to: 6.10 6.9 6.8 6.5
Change-Id: Ief1d1791d09302b4f22ff65c978f6f7d60741ee3
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
The animation interpolation did not consider the alpha channel when
interpolating QPen and QBrush. As a result, the colors were always
considered opaque, even if the users specified a custom alpha channel.
Fix it by also interpolating the alpha channel.
Apparently, there is no possibility to unit-test the change, since
there's no API to access the PieSliceItem and its properties.
To test the fix, update the manual qmlchartproperties test with the
possibility to change the opacity of the slice for the PieChart.
Amends 7d415c8db7.
Fixes: QTBUG-135240
Pick-to: 6.10 6.9 6.8 6.5
Change-Id: I559067f11ad7fba1853e1af1fe49de228a6eb6f6
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
This is the result of running util/normalize on the code base. The
following manual edits were needed:
- folded long connect() lines
As a drive-by, re-flowed line-broken connect() statements to follow
canonical form
connect(sender, signal,
receiver, slot);
as opposed to, e.g.,
connect(sender, signal, receiver,
slot);
As another drive-by, port from .data() to std-compliant .get(). This
will help porting away from QSharedPointer and QScopedPointer, going
forward.
Pick-to: 6.10 6.9 6.8 6.5
Change-Id: I948549e3eb041509059f85d2aeab8ec9c403db7c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
If the polar chart gets cleared, the old series is still drawn, because
the m_linePathPolarLeft/Right are not cleared properly.
Pick-to: 6.10 6.9 6.8 6.5
Fixes: QTBUG-136770
Change-Id: I2ff4946c6948a40b6766cba069e3698d65cbfedd
Reviewed-by: Janne Roine <janne.roine@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Because QtGraphs has inherited many of its classes
from QtCharts, the modules have many classes with the same
name. Therefore, mixing QtCharts and QtGraphs headers in
the same TU violates ODR. This patch includes the check for that and
fails compilation with an error message.
Pick-to: 6.8 6.9
Fixes: QTBUG-135691
Change-Id: Ic612ec36b1369ceee0eef83220c41e75f38a611e
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Example makes Http GET request, response text gets parsed into JSON object and the JSON object is passed on to parsing function which parses the data for chart series
Task-number: QTBUG-135749
Pick-to: 6.9 6.8
Change-Id: I53503e44b4adb86c1fce48cd6a72a9c624bf7592
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Between 1.0 and 1.1 version of charts, two qml types changed names,
but were still backed up by the same C++ type. To avoid duplicate
entries for same C++ type in plugins.qmltypes, we just provide two
exports for the same C++ type. This will unify the version numbers
for the combined types as well, but this shouldn't be a problem.
Fixes: QTBUG-115358
Pick-to: 6.9 6.8
Change-Id: I5f8d91fd4902f9f29b589d9f7abb08071105829b
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
`git-review` is a command line tool for interacting with Gerrit.
Some IDEs offer support for this tool, either natively or through
plugins. The tool relies on a configuration file, .gitreview. Adding
this configuration file to our repositories simplifies initial setup
for contributors that use the tool directly or through their IDE of
choice.
The configuration file adds a remote called 'gerrit'. This is the
default for the tool, and also the name set for
codereview.qt-project.org by Qt's `init-repository` script. Thus,
the configuration should work seamlessly alongside other repository
helpers.
Task-number: QTBUG-132604
Pick-to: 6.9 6.8
Change-Id: I4199d36f3601889345832b13651354d4027cb669
Reviewed-by: Samuel Gaist <samuel.gaist@idiap.ch>
A QUIP 18[1] update sets git files, REUSE.toml and licenseRule.json
as infrastructure type files. They are licensed with:
LicenseRef-Qt-Commercial OR BSD-3-Clause
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.9 6.8
Change-Id: I81597d6a4f75b1d27cc1fbcf1abfca6a7dddc577
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
The documentation mentions both a namespace that has been removed
and the use of the module include which should be avoided in user code.
This patch removes both, and adds CMake usage for the module.
Pick-to: 6.9 6.8
Change-Id: I378fbcaffa3edc5bdb94cdb7e05c9876b2418931
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
This includes:
- turning VERIFY_SOURCE_SBOM ON
- adding rules to the licenseRule.json files
- correcting the licensing given via REUSE.toml files
A lot of files are skipped during the license test,
but all are present in the source SBOM.
This is why corrections are needed before turning the
source SBOM check on.
Task-number: QTBUG-131434
Pick-to: 6.9 6.8
Change-Id: I7880a9c8fbda06422a09cf70ac9ffbed750cd781
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Qt Submodule Update Bot
Tor Arne Vestbø
Lucie Gérard
Cristian Le
Jani Heikkinen
Ivan Solovev
Marc Mutz
Antti Määttä
Sami Varanka
Niko Korkala
Volker Hilsheimer
Miikka Heikkinen
Paul Wicking
Samuel Gaist
Liang Qi
Tomi Korpipaa
David Boddie