mirror of https://github.com/qt/qtbase.git
d65a45d2bc
Information property lists (Info.plist) files are part of application bundles on Apple platforms and contain basic information about the application, such as the name of the application's executable. The Info.plist file can have multiple formats, such as binary or XML. Makefiles generated by qmake convert Info.plist files to XML by default, so that variables in the Info.plist can be substituted with values defined by qmake, such as the name of the application's executable. This is important if users use external tools such as Xcode for modifying the Info.plist file, which may save it in binary format. To convert the formats, the plutil tool shipped with macOS (or the Xcode command-line tools) is used. The Unix tool sed is then used to actually substitute variables. If the Info.plist file is invalid, e.g., due to an invalid tag name, the plutil invocation fails. However, the converted plist is piped into sed for variable substitution. The plutil command will simply write an error message to standard out and return with a non-zero exit code. Due to the pipe chain, make will not fail and the error message will end up in the Info.plist in the built application bundle. The application bundle is then invalid as well, as vital information such as the name of the executable of the application is missing. The change ensures that the pipe chain fails, if plutil exits with a non-zero exit code. The issue was introduced with my solution for QTBUG-45357. Beforehand, Info.plists and mistakes therein were simply copied into the application bundle. [ChangeLog][qmake] Fail builds on Apple platforms if the Info.plist is invalid instead of generating corrupt application bundles. Pick-to: 6.5 6.9 6.10 Change-Id: Ibdb2a18e9bbf35a654af8534aa61188f8389c55a Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> |
||
|---|---|---|
| .github/workflows | ||
| LICENSES | ||
| bin | ||
| cmake | ||
| coin | ||
| config.tests | ||
| dist | ||
| doc | ||
| examples | ||
| lib | ||
| libexec | ||
| mkspecs | ||
| qmake | ||
| src | ||
| tests | ||
| util | ||
| .cmake.conf | ||
| .gitattributes | ||
| .gitignore | ||
| .gitreview | ||
| .tag | ||
| CMakeLists.txt | ||
| REUSE.toml | ||
| config_help.txt | ||
| configure | ||
| configure.bat | ||
| configure.cmake | ||
| dependencies.yaml | ||
| licenseRule.json | ||
| qt_cmdline.cmake | ||