mirror of https://github.com/qt/qtbase.git
772b62c91e
Clang was already doing it, but GCC (at least in LTO mode) wasn't and
was repeatedly calling qGetProp(). This has the benefit that, in most
cases, the input character whose property we seek is UTF-16, so dead
code-elimination removes the extra branch - this can happen when QString
functions go through the QChar front-end, like QChar::isSpace() or
isSymbol(), which route through the char32_t overload.
This forced inling allows us to remove the UCS2 overloads of qGetProp()
and properties(), because the same const-propagation will apply to all
but one of the places where UTF-16 code units were being compared. The
16-bit qGetProp() was only used in qstring.cpp's convertCase_helper(),
whose 16-bit overload was only used in foldCase(). The one exception to
this is qtextengine.cpp's QBidiAlgorithm::resolveN0():
const QUnicodeTables::Properties *p = QUnicodeTables::properties(char16_t{text[pos].unicode()});
This will now call the full UTF-32 overload.
Pick-to: 6.10
Change-Id: Ifa4f2d77475877f26be2fffd9a987ff994dc8ef1
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
|
||
|---|---|---|
| .github/workflows | ||
| LICENSES | ||
| bin | ||
| cmake | ||
| coin | ||
| config.tests | ||
| dist | ||
| doc | ||
| examples | ||
| lib | ||
| libexec | ||
| mkspecs | ||
| qmake | ||
| src | ||
| tests | ||
| util | ||
| .cmake.conf | ||
| .gitattributes | ||
| .gitignore | ||
| .gitreview | ||
| .tag | ||
| CMakeLists.txt | ||
| REUSE.toml | ||
| config_help.txt | ||
| configure | ||
| configure.bat | ||
| configure.cmake | ||
| dependencies.yaml | ||
| licenseRule.json | ||
| qt_cmdline.cmake | ||