From 6db355c6cd1c668ee79bcdccfdc4d5cbc379833f Mon Sep 17 00:00:00 2001
From: Assam Boudjelthia <assam.boudjelthia@qt.io>
Date: Wed, 10 Sep 2025 16:33:37 +0300
Subject: [PATCH] AndroidTestRunner: don't try to grant non-dangerous
 permissions

To avoid warnings like:
 Unable to grant 'android.permission.INTERNET' to
'org.qtproject.example.tst_android'. Probably the Android version
mismatch.

First, get the full list of dangerous permissions and check
for each permission if it's dangerous or not before granting it.

Change-Id: I84b214773c4cceb17f96284f9fb9a0d2d519933a
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
---
 src/tools/androidtestrunner/main.cpp | 47 ++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/src/tools/androidtestrunner/main.cpp b/src/tools/androidtestrunner/main.cpp
index 0e04d10e692..4f7e889a976 100644
--- a/src/tools/androidtestrunner/main.cpp
+++ b/src/tools/androidtestrunner/main.cpp
@@ -328,6 +328,50 @@ static bool processAndroidManifest()
     return true;
 }
 
+static QStringList queryDangerousPermissions()
+{
+    QByteArray output;
+    const QStringList args({ "shell"_L1, "dumpsys"_L1, "package"_L1, "permissions"_L1 });
+    if (!execAdbCommand(args, &output, false)) {
+        qWarning("Failed to query permissions via dumpsys");
+        return {};
+    }
+
+    /*
+     * Permissions section from this command look like:
+     *
+     * Permission [android.permission.INTERNET] (c8cafdc):
+     *     sourcePackage=android
+     *     uid=1000 gids=[3003] type=0 prot=normal|instant
+     *     perm=PermissionInfo{5f5bfbb android.permission.INTERNET}
+     *     flags=0x0
+     */
+     const static QRegularExpression regex("^\\s*permission\\s+([A-Za-z0-9._]+):"_L1);
+    QStringList dangerousPermissions;
+    QString currentPerm;
+
+    const QStringList lines = QString::fromUtf8(output).split(u'\n');
+    for (const QString &line : lines) {
+        QRegularExpressionMatch match = regex.match(line);
+        if (match.hasMatch()) {
+            currentPerm = match.captured(1);
+            continue;
+        }
+
+        int protIndex = line.indexOf("prot="_L1);
+        if (protIndex == -1)
+            continue;
+
+        QString protectionTypes = line.mid(protIndex + 5).trimmed();
+        if (protectionTypes.contains("dangerous"_L1, Qt::CaseInsensitive)) {
+            dangerousPermissions.append(currentPerm);
+            currentPerm.clear();
+        }
+    }
+
+    return dangerousPermissions;
+}
+
 static void setOutputFile(QString file, QString format)
 {
     if (format.isEmpty())
@@ -938,7 +982,10 @@ int main(int argc, char *argv[])
             return EXIT_ERROR;
     }
 
+    const QStringList dangerousPermisisons = queryDangerousPermissions();
     for (const auto &permission : g_options.permissions) {
+        if (!dangerousPermisisons.contains(permission))
+            continue;
         if (!execAdbCommand({ "shell"_L1, "pm"_L1, "grant"_L1, g_options.package, permission },
                             nullptr)) {
             qWarning("Unable to grant '%s' to '%s'. Probably the Android version mismatch.",