qiurui
/
qtbase
mirror of https://github.com/qt/qtbase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Get rid of empty optional methods in tst_QSqlQuery 

No need for a virtual do-nothing destructor in a class that isn't
inherited from. Defining an empty init merely makes QTest go to the
trouble of calling it, which it could just as well skip.

Change-Id: Ifd44c473c05fdeaaa7923d2ccdd0a13c8921b6bd
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
This commit is contained in:
Edward Welbourne 2022-02-01 14:45:53 +01:00
parent 0828014b44
commit 69e445721c
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp
View File

@ -41,12 +41,10 @@ class tst_QSqlQuery : public QObject
public:
tst_QSqlQuery();
virtual ~tst_QSqlQuery();
public slots:
void initTestCase();
void cleanupTestCase();
void init();
void cleanup();
private slots:
@ -289,10 +287,6 @@ tst_QSqlQuery::tst_QSqlQuery()
qtest = qTableName("qtest", __FILE__, static_qtest_db);
}
tst_QSqlQuery::~tst_QSqlQuery()
{
}
void tst_QSqlQuery::initTestCase()
{
QVERIFY(dbs.open());
@ -317,10 +311,6 @@ void tst_QSqlQuery::cleanupTestCase()
dbs.close();
}
void tst_QSqlQuery::init()
{
}
void tst_QSqlQuery::cleanup()
{
if (QTest::currentTestFunction() == QLatin1String("crashQueryOnCloseDatabase"))