From 419c99f83511e80cffed899a6e6f424280c471f6 Mon Sep 17 00:00:00 2001 From: Ahmad Samir Date: Sun, 11 Dec 2022 15:21:40 +0200 Subject: [PATCH] QByteArrayApiSymmetry: silence two clang warnings tests/auto/corelib/text/qbytearrayapisymmetry/tst_qbytearrayapisymmetry.cpp:1174:80: warning: overflow in expression; result is -9223372036854775808 with type 'long long' [-Winteger-overflow] const qlonglong longMaxPlusOne = static_cast(Bounds::max()) + 1; tests/auto/corelib/text/qbytearrayapisymmetry/tst_qbytearrayapisymmetry.cpp:1175:81: warning: overflow in expression; result is 9223372036854775807 with type 'long long' [-Winteger-overflow] const qlonglong longMinMinusOne = static_cast(Bounds::min()) - 1; I usually build with GCC, but building with Clang for clazy-standalone, so I saw these two warnings 500+ times, enough already. :) Change-Id: Idd86af568ffe89ae49b2a3f9bbeedf312de5e631 Reviewed-by: Thiago Macieira --- .../text/qbytearrayapisymmetry/tst_qbytearrayapisymmetry.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/auto/corelib/text/qbytearrayapisymmetry/tst_qbytearrayapisymmetry.cpp b/tests/auto/corelib/text/qbytearrayapisymmetry/tst_qbytearrayapisymmetry.cpp index 514314d0f34..21c35d7b487 100644 --- a/tests/auto/corelib/text/qbytearrayapisymmetry/tst_qbytearrayapisymmetry.cpp +++ b/tests/auto/corelib/text/qbytearrayapisymmetry/tst_qbytearrayapisymmetry.cpp @@ -1171,8 +1171,13 @@ void tst_QByteArrayApiSymmetry::toLong_data() const QTest::newRow("int32 max dec") << QByteArray("2147483647") << 10 << long(B32::max()) << true; if constexpr (sizeof(long) < sizeof(qlonglong)) { + QT_WARNING_PUSH + // See: https://github.com/llvm/llvm-project/issues/59448 + QT_WARNING_DISABLE_CLANG("-Winteger-overflow") const qlonglong longMaxPlusOne = static_cast(Bounds::max()) + 1; const qlonglong longMinMinusOne = static_cast(Bounds::min()) - 1; + QT_WARNING_POP + QTest::newRow("long max + 1") << QByteArray::number(longMaxPlusOne) << 10 << 0L << false; QTest::newRow("long min - 1") << QByteArray::number(longMinMinusOne) << 10 << 0L << false; }