qtbase/src/corelib/thread/qmutex.h

358 lines
8.8 KiB
C
Raw Normal View History

// Copyright (C) 2016 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
#ifndef QMUTEX_H
#define QMUTEX_H
#include <QtCore/qglobal.h>
#include <QtCore/qatomic.h>
#include <QtCore/qdeadlinetimer.h>
#include <QtCore/qtsan_impl.h>
#include <chrono>
QT_BEGIN_NAMESPACE
#if QT_CONFIG(thread) || defined(Q_QDOC)
class QMutex;
class QRecursiveMutex;
class QMutexPrivate;
class Q_CORE_EXPORT QBasicMutex
{
Q_DISABLE_COPY_MOVE(QBasicMutex)
protected:
static constexpr bool FutexAlwaysAvailable =
#if defined(Q_OS_FREEBSD) || defined(Q_OS_LINUX) || defined(Q_OS_WIN) // these platforms use futex
true
#else
false
#endif
;
public:
constexpr QBasicMutex()
: d_ptr(nullptr)
{}
// BasicLockable concept
inline void lock() noexcept(FutexAlwaysAvailable) {
QtTsan::mutexPreLock(this, 0u);
if (!fastTryLock())
lockInternal();
QtTsan::mutexPostLock(this, 0u, 0);
}
// BasicLockable concept
inline void unlock() noexcept {
Q_ASSERT(d_ptr.loadRelaxed()); //mutex must be locked
QtTsan::mutexPreUnlock(this, 0u);
if constexpr (FutexAlwaysAvailable) {
// we always unlock if we have futexes
if (QMutexPrivate *d = d_ptr.fetchAndStoreRelease(nullptr); d != dummyLocked())
unlockInternalFutex(d); // was contended
} else {
// if we don't have futexes, we can only unlock if not contended
if (QMutexPrivate *d; !d_ptr.testAndSetRelease(dummyLocked(), nullptr, d))
unlockInternal(d); // was contended
}
QtTsan::mutexPostUnlock(this, 0u);
}
bool tryLock() noexcept {
unsigned tsanFlags = QtTsan::TryLock;
QtTsan::mutexPreLock(this, tsanFlags);
const bool success = fastTryLock();
if (!success)
tsanFlags |= QtTsan::TryLockFailed;
QtTsan::mutexPostLock(this, tsanFlags, 0);
return success;
}
// Lockable concept
bool try_lock() noexcept { return tryLock(); }
private:
QMutex & QReadWriteLock: do a memory read before CAS The testAndSet operation is expensive if the lock is contended: attempting to CAS that lock will cause the cacheline containing the lock to be brought to the current CPU's most local cache in exclusive mode, which in turn causes the CPU that has the lock to stall when it attempts to release it. That's not desirable if we were just trying an untimed tryLock*. In the case of timed, contended tryLocks or unconditional locks, we still need to perform an atomic operation to indicate we're about to wait. For that case, this patch reduces the minimum number of atomic operations from 2 to 1, which is a gain even in the case where no other thread has changed the lock status at all. In case they have, either by more threads attempting to lock or by the one that has the lock unlocking it, this avoids the cacheline bouncing around between the multiple CPUs between those two atomic operations. For QMutex, that second atomic is a fetchAndStore, not testAndSet. The above explanation is valid for architectures with Compare-And-Swap instructions, such as x86 and ARMv8.1. For architectures using Load Linked/Store Conditional instructions, the explanation doesn't apply but the benefits still should because we avoid the expense of the LL. See similar change to pthread_mutex_lock in https://sourceware.org/git/?p=glibc.git;a=commit;h=d672a98a1af106bd68deb15576710cd61363f7a6 Change-Id: I3d728c4197df49169066fffd1756dcc26b2cf5f3 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
2023-04-17 23:30:38 +00:00
inline bool fastTryLock() noexcept
{
if (d_ptr.loadRelaxed() != nullptr)
return false;
return d_ptr.testAndSetAcquire(nullptr, dummyLocked());
}
#if QT_CORE_REMOVED_SINCE(6, 10)
inline bool fastTryUnlock() noexcept {
return d_ptr.testAndSetRelease(dummyLocked(), nullptr);
}
#endif
void lockInternal() noexcept(FutexAlwaysAvailable);
bool lockInternal(QDeadlineTimer timeout) noexcept(FutexAlwaysAvailable);
#if QT_VERSION < QT_VERSION_CHECK(7, 0, 0)
bool lockInternal(int timeout) noexcept(FutexAlwaysAvailable);
void unlockInternal() noexcept;
#endif
void unlockInternalFutex(void *d) noexcept;
void unlockInternal(void *d) noexcept;
#if QT_CORE_REMOVED_SINCE(6, 9)
void destroyInternal(QMutexPrivate *d);
#endif
void destroyInternal(void *d);
QBasicAtomicPointer<QMutexPrivate> d_ptr;
static inline QMutexPrivate *dummyLocked() {
return reinterpret_cast<QMutexPrivate *>(quintptr(1));
}
friend class QMutex;
friend class QMutexPrivate;
};
class Q_CORE_EXPORT QMutex : public QBasicMutex
{
public:
constexpr QMutex() = default;
~QMutex()
{
QMutexPrivate *d = d_ptr.loadRelaxed();
if (d)
destroyInternal(d);
}
#ifdef Q_QDOC
inline void lock() noexcept(FutexAlwaysAvailable);
inline void unlock() noexcept;
bool tryLock() noexcept;
#endif
// Lockable concept
bool try_lock() noexcept { return tryLock(); }
using QBasicMutex::tryLock;
bool tryLock(int timeout) noexcept(FutexAlwaysAvailable)
{
return tryLock(QDeadlineTimer(timeout));
}
bool tryLock(QDeadlineTimer timeout) noexcept(FutexAlwaysAvailable)
{
unsigned tsanFlags = QtTsan::TryLock;
QtTsan::mutexPreLock(this, tsanFlags);
bool success = fastTryLock();
if (success) {
QtTsan::mutexPostLock(this, tsanFlags, 0);
return success;
}
success = lockInternal(timeout);
if (!success)
tsanFlags |= QtTsan::TryLockFailed;
QtTsan::mutexPostLock(this, tsanFlags, 0);
return success;
}
// TimedLockable concept
template <class Rep, class Period>
bool try_lock_for(std::chrono::duration<Rep, Period> duration)
{
return tryLock(QDeadlineTimer(duration));
}
// TimedLockable concept
template<class Clock, class Duration>
bool try_lock_until(std::chrono::time_point<Clock, Duration> timePoint)
{
return tryLock(QDeadlineTimer(timePoint));
}
};
class Q_CORE_EXPORT QRecursiveMutex
{
Q_DISABLE_COPY_MOVE(QRecursiveMutex)
// written to by the thread that first owns 'mutex';
// read during attempts to acquire ownership of 'mutex' from any other thread:
QAtomicPointer<void> owner = nullptr;
// only ever accessed from the thread that owns 'mutex':
uint count = 0;
QMutex mutex;
static constexpr bool LockIsNoexcept = noexcept(std::declval<QMutex>().lock());
public:
constexpr QRecursiveMutex() = default;
~QRecursiveMutex();
// BasicLockable concept
void lock() noexcept(LockIsNoexcept)
{ tryLock(QDeadlineTimer(QDeadlineTimer::Forever)); }
QT_CORE_INLINE_SINCE(6, 6)
bool tryLock(int timeout) noexcept(LockIsNoexcept);
bool tryLock(QDeadlineTimer timer = {}) noexcept(LockIsNoexcept);
// BasicLockable concept
void unlock() noexcept;
// Lockable concept
bool try_lock() noexcept(LockIsNoexcept) { return tryLock(); }
// TimedLockable concept
template <class Rep, class Period>
bool try_lock_for(std::chrono::duration<Rep, Period> duration)
{
return tryLock(QDeadlineTimer(duration));
}
// TimedLockable concept
template<class Clock, class Duration>
bool try_lock_until(std::chrono::time_point<Clock, Duration> timePoint)
{
return tryLock(QDeadlineTimer(timePoint));
}
};
#if QT_CORE_INLINE_IMPL_SINCE(6, 6)
bool QRecursiveMutex::tryLock(int timeout) noexcept(LockIsNoexcept)
{
return tryLock(QDeadlineTimer(timeout));
}
#endif
template <typename Mutex>
class QMutexLocker
{
#ifdef Q_CC_GHS
// internal compiler error otherwise
static constexpr bool LockIsNoexcept = false;
#else
static constexpr bool LockIsNoexcept = noexcept(std::declval<Mutex>().lock());
#endif
public:
Short live Q_NODISCARD_CTOR [ChangeLog][QtCore] Introduced Q_NODISCARD_CTOR which resolves to [[nodiscard]] attribute for constructors on compilers that support it, and does nothing on other compilers. Using [[nodiscard]] attribute on a constructor is a C++20 feature, however in practice it is supported on most of the compilers that we use in Qt 6. Clang generates a [-Wunused-value] warning, GCC and MinGW generate a [-Wunused-result] warnings, and MSVC generates a C4834 warning. However, there are some exceptions. The Integrity compiler provides the following warning: "tst_qglobal.cpp", line 699: warning #3435-D: the "nodiscard" attribute doesn't apply to constructors, destructors, or routines with void return type [[nodiscard]] explicit Test(int val) : m_val(val) {} The QNX compiler (QCC 8.3.0) and GCC 9.3.1 on OpenSUSE generate the [-Wattributes] warning: tst_qglobal.cpp: In member function 'void tst_QGlobal::nodiscardConstructor()': tst_qglobal.cpp:699:44: warning: 'nodiscard' attribute applied to 'tst_QGlobal::nodiscardConstructor()::Test::Test(int)' with void return type [-Wattributes] [[nodiscard]] explicit Test(int val) : m_val(val) {} These warnings will lead to build failures when compiled with -warnings-are-errors flag, so for these compilers the macro does not do anything. An attempt to use __attribute__((__warn_unused_result__)) was also unsuccessful on these compilers, so this patch goes for an easy solution, and simply checks __has_cpp_attribute(nodiscard) >= 201907L to decide if the attribute is supported or not. This commit also introduces a syntax-only test, and also applies the new macro to QMutexLocker, because not all platforms in the CI build and run unit tests. Fixes: QTBUG-104161 Change-Id: Ib4230661a5ad5e8af0d67b21b034486ebcd67562 Reviewed-by: Marc Mutz <marc.mutz@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-04-06 11:00:25 +00:00
Q_NODISCARD_CTOR
inline explicit QMutexLocker(Mutex *mutex) noexcept(LockIsNoexcept)
{
m_mutex = mutex;
if (Q_LIKELY(mutex)) {
mutex->lock();
m_isLocked = true;
}
}
Short live Q_NODISCARD_CTOR [ChangeLog][QtCore] Introduced Q_NODISCARD_CTOR which resolves to [[nodiscard]] attribute for constructors on compilers that support it, and does nothing on other compilers. Using [[nodiscard]] attribute on a constructor is a C++20 feature, however in practice it is supported on most of the compilers that we use in Qt 6. Clang generates a [-Wunused-value] warning, GCC and MinGW generate a [-Wunused-result] warnings, and MSVC generates a C4834 warning. However, there are some exceptions. The Integrity compiler provides the following warning: "tst_qglobal.cpp", line 699: warning #3435-D: the "nodiscard" attribute doesn't apply to constructors, destructors, or routines with void return type [[nodiscard]] explicit Test(int val) : m_val(val) {} The QNX compiler (QCC 8.3.0) and GCC 9.3.1 on OpenSUSE generate the [-Wattributes] warning: tst_qglobal.cpp: In member function 'void tst_QGlobal::nodiscardConstructor()': tst_qglobal.cpp:699:44: warning: 'nodiscard' attribute applied to 'tst_QGlobal::nodiscardConstructor()::Test::Test(int)' with void return type [-Wattributes] [[nodiscard]] explicit Test(int val) : m_val(val) {} These warnings will lead to build failures when compiled with -warnings-are-errors flag, so for these compilers the macro does not do anything. An attempt to use __attribute__((__warn_unused_result__)) was also unsuccessful on these compilers, so this patch goes for an easy solution, and simply checks __has_cpp_attribute(nodiscard) >= 201907L to decide if the attribute is supported or not. This commit also introduces a syntax-only test, and also applies the new macro to QMutexLocker, because not all platforms in the CI build and run unit tests. Fixes: QTBUG-104161 Change-Id: Ib4230661a5ad5e8af0d67b21b034486ebcd67562 Reviewed-by: Marc Mutz <marc.mutz@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-04-06 11:00:25 +00:00
Q_NODISCARD_CTOR
inline QMutexLocker(QMutexLocker &&other) noexcept
: m_mutex(std::exchange(other.m_mutex, nullptr)),
m_isLocked(std::exchange(other.m_isLocked, false))
{}
QT_MOVE_ASSIGNMENT_OPERATOR_IMPL_VIA_MOVE_AND_SWAP(QMutexLocker)
inline ~QMutexLocker()
{
if (m_isLocked)
unlock();
}
inline bool isLocked() const noexcept
{
return m_isLocked;
}
inline void unlock() noexcept
{
Q_ASSERT(m_isLocked);
m_mutex->unlock();
m_isLocked = false;
}
inline void relock() noexcept(LockIsNoexcept)
{
Q_ASSERT(!m_isLocked);
m_mutex->lock();
m_isLocked = true;
}
inline void swap(QMutexLocker &other) noexcept
{
qt_ptr_swap(m_mutex, other.m_mutex);
std::swap(m_isLocked, other.m_isLocked);
}
Mutex *mutex() const
{
return m_mutex;
}
private:
Q_DISABLE_COPY(QMutexLocker)
Mutex *m_mutex;
bool m_isLocked = false;
};
#else // !QT_CONFIG(thread) && !Q_QDOC
class QMutex
{
public:
constexpr QMutex() noexcept { }
inline void lock() noexcept {}
inline bool tryLock(int timeout = 0) noexcept { Q_UNUSED(timeout); return true; }
inline bool try_lock() noexcept { return true; }
inline void unlock() noexcept {}
template <class Rep, class Period>
inline bool try_lock_for(std::chrono::duration<Rep, Period> duration) noexcept
{
Q_UNUSED(duration);
return true;
}
template<class Clock, class Duration>
inline bool try_lock_until(std::chrono::time_point<Clock, Duration> timePoint) noexcept
{
Q_UNUSED(timePoint);
return true;
}
private:
Q_DISABLE_COPY(QMutex)
};
class QRecursiveMutex : public QMutex {};
template <typename Mutex>
class QMutexLocker
{
public:
Short live Q_NODISCARD_CTOR [ChangeLog][QtCore] Introduced Q_NODISCARD_CTOR which resolves to [[nodiscard]] attribute for constructors on compilers that support it, and does nothing on other compilers. Using [[nodiscard]] attribute on a constructor is a C++20 feature, however in practice it is supported on most of the compilers that we use in Qt 6. Clang generates a [-Wunused-value] warning, GCC and MinGW generate a [-Wunused-result] warnings, and MSVC generates a C4834 warning. However, there are some exceptions. The Integrity compiler provides the following warning: "tst_qglobal.cpp", line 699: warning #3435-D: the "nodiscard" attribute doesn't apply to constructors, destructors, or routines with void return type [[nodiscard]] explicit Test(int val) : m_val(val) {} The QNX compiler (QCC 8.3.0) and GCC 9.3.1 on OpenSUSE generate the [-Wattributes] warning: tst_qglobal.cpp: In member function 'void tst_QGlobal::nodiscardConstructor()': tst_qglobal.cpp:699:44: warning: 'nodiscard' attribute applied to 'tst_QGlobal::nodiscardConstructor()::Test::Test(int)' with void return type [-Wattributes] [[nodiscard]] explicit Test(int val) : m_val(val) {} These warnings will lead to build failures when compiled with -warnings-are-errors flag, so for these compilers the macro does not do anything. An attempt to use __attribute__((__warn_unused_result__)) was also unsuccessful on these compilers, so this patch goes for an easy solution, and simply checks __has_cpp_attribute(nodiscard) >= 201907L to decide if the attribute is supported or not. This commit also introduces a syntax-only test, and also applies the new macro to QMutexLocker, because not all platforms in the CI build and run unit tests. Fixes: QTBUG-104161 Change-Id: Ib4230661a5ad5e8af0d67b21b034486ebcd67562 Reviewed-by: Marc Mutz <marc.mutz@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-04-06 11:00:25 +00:00
Q_NODISCARD_CTOR
inline explicit QMutexLocker(Mutex *) noexcept {}
inline ~QMutexLocker() noexcept {}
inline void unlock() noexcept {}
void relock() noexcept {}
inline Mutex *mutex() const noexcept { return nullptr; }
private:
Q_DISABLE_COPY(QMutexLocker)
};
typedef QMutex QBasicMutex;
#endif // !QT_CONFIG(thread) && !Q_QDOC
QT_END_NAMESPACE
#endif // QMUTEX_H