In Qt 5, the flag to write the BOM was a negative: if IgnoreHeader
wasn't set, we would write it. That was the default in Qt 5 because
DefaultConversion was 0. But now it's a positive flag, DefaultConversion
was updated to set it, but we forgot to use it in the constructors of
these two classes.
[ChangeLog][Qt5CoreCompat][QTextEncoder] Fixed a bug that caused
QTextEncoder not to write the Byte Order Mark for UTF codecs when the
constructor without explicit flags was used.
Fixes: QTBUG-122795
Pick-to: 6.5 6.7
Change-Id: If1bf59ecbe014b569ba1fffd17c459af4e0e00c9
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
The license test in qtqa reads this file
in order to check the validity of the license used.
This file reproduce the QUIP-18 [1] rules, with some exceptions.
Each entry in the file corresponds to a set of licensing rules.
A set of licensing rules can depend on the file ending,
registered in "file_pattern_ending". The last entry in the
file has no "file_pattern_ending", it sets the rules for the
files whose licensing does not depend on their ending.
The license to be used depends on the location
of the file within the Qt module repository.
Let's call this "<true_location>".
The "<true_location>" can also correspond to a file name,
offering flexibility for exceptions to the rule.
The "<true_location>" are registered in "location".
For each "<true_location>" there is a
"file type" entry and a "spdx" entry.
The "spdx" entry gives the rule:
the expected license tag(s) in SPDX format
for the file ending (if applicable) and "<true_location>".
The "file type" informs on the QUIP-18 type
the tested file corresponds to. It is purely informational
for the reader.
The set of rules are tested in order of appearance
in the json file. For this reason, a more constraining
ending (like "special.txt") needs to appear in
a "file_pattern_ending" located before
the "file_pattern_ending" of a less constraining ending (like ".txt").
Also, a file ending cannot be present in two "file_pattern_ending".
"file_pattern_ending" and "spdx" should list strings.
"<true_location>" can be regular expressions.
During the test the deeper "<true_location>" are
checked first. The order is which they appear in the json file
does not matter.
To test this file, run
QT_MODULE_TO_TEST=../qt5compat perl tests/prebuild/license/tst_licenses.pl
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.7
Task-number: QTBUG-121039
Change-Id: I17df769c1b8edc8dcb65e36d0585d9d4a1b3ff8c
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
Use NO_GENERATE_CPP_EXPORTS explicitly for modules that don't need
the autogenerated exports header file.
Task-number: QTBUG-90492
Change-Id: I9476dff5af1cc6c042b406cfda501ec874014083
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
According to QUIP-18 [1], all test files should be
LicenseRef-Qt-Commercial OR GPL-3.0-only
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.7
Task-number: QTBUG-121787
Change-Id: I96d027035cd43d3244fb2c2b89fdcff406d7d801
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
According to QUIP-18 [1], all tool files
should be
LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.7
Task-number: QTBUG-121787
Change-Id: I349ce25d8713aa7834317fc8460952b7bfb2c5fb
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
According to QUIP-18 [1]
all file under snippets or examples should be
LicenseRef-Qt-Commercial OR BSD-3-Clause
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.7
Task-number: QTBUG-121787
Change-Id: I58b6175b10be2463d4bc8034ad08432e0b3e77d7
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
It did, in Qt 5, but the test, if ever there was one, was lost when
QStringRef moved out of QtCore.
Pick-to: 6.7 6.6 6.5 6.2
Change-Id: I3440074eb8678adaf317ff888c9f11d1a1e4c8ec
Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
By adding it to the default build flags via .cmake.conf.
This disables the 3-arg QObject::connect() overload:
QObject::connect(sender, signal, functor)
For details see:
https://lists.qt-project.org/pipermail/development/2023-July/044141.html
No changes required.
Task-number: QTBUG-116296
Change-Id: I3225d98df5b067d73619b1e46fffed23dae5e7bd
Reviewed-by: Sona Kurazyan <kurazyan.sona@gmail.com>
"binded" is quite rare in the documentation, I could only find it four
times (included this one).
Change-Id: If951959b5d03488b6bee3e91bab6e7f9a54a2fd4
Reviewed-by: Luca Di Sera <luca.disera@qt.io>
The author most likely meant to use \image, based on the HTML render at
https://doc.qt.io/qt-6/qml-qt5compat-graphicaleffects-gaussianblur.html.
Also, this case generated invalid DocBook output.
Change-Id: Ib399f58e242211be0d677979676cff7a0e8bf458
Pick-to: 6.7 6.6 6.5
Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io>
Qt Submodule Update Bot
Thiago Macieira
Lucie Gérard
Alexey Edelev
Marc Mutz
Ahmad Samir
Ievgenii Meshcheriakov
Joerg Bornemann
Thibaut Cuvelier
Jani Heikkinen