`git-review` is a command line tool for interacting with Gerrit.
Some IDEs offer support for this tool, either natively or through
plugins. The tool relies on a configuration file, .gitreview. Adding
this configuration file to our repositories simplifies initial setup
for contributors that use the tool directly or through their IDE of
choice.
The configuration file adds a remote called 'gerrit'. This is the
default for the tool, and also the name set for
codereview.qt-project.org by Qt's `init-repository` script. Thus,
the configuration should work seamlessly alongside other repository
helpers.
As the file format doesn't seem to be designed with comments in mind,
add it to the other version control system exemptions in REUSE.toml.
Task-number: QTBUG-132604
Pick-to: 6.9 6.8
Change-Id: I4296d81b07bf3b0300693d4914b7eb64eeb25474
Reviewed-by: Samuel Gaist <samuel.gaist@idiap.ch>
ConversionFlag enum values are documented as a type alias under its
corresponding QFlags class.
ConverterState has an empty typealias documentation.
Both are only built, if Qt is configured without QT_CONFIG(textcodec).
The documentation, however, is built unconditionally.
Wrapping documentation in an ifdef still results in warnings.
Remove documentation altogether, because enum values are
self-explanatory.
Task-number: QTBUG-133892
Pick-to: 6.8
Change-Id: I870effd6654f0cda161e2128ccb9e51ac491a34b
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
(cherry picked from commit db733a992e)
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
This commit fixes the tree broken with 616754.
Fixes: QTBUG-132209
Pick-to: 6.9 6.8
Change-Id: I57846f54928f6ac32234748d08db244f917720ce
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
Currently there are two pages that describe the Qt Graphical Effects
module, namely, qtgraphicaleffects5-index.html and
graphicaleffects5.html. These pages contain most of the same
information.
This patch merges the information from both pages into one page,
namely, qtgraphicaleffects5-index.html. It keeps the categorization of
types from graphicaleffects5.html. It deletes redundant information on the page,
graphicaleffects5.html.
Fixes: QTBUG-132209
Pick-to: 6.7 6.8 6.9
Change-Id: I05eef8a4eaf7d86fbd18d08e58eb5ff7a0a9bb09
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
Fix the delayed marking of QFile::open() as [[nodiscard]] in this
module, too.
Pick-to: 6.9 6.8 6.5
Change-Id: I7b1d76cc23c2ce1dfb8c03ca945dcecb6c54988f
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Marking the whole module as QT_NO_SCOPED_POINTER is still blocked
by QtCore headers not being QT_NO_SCOPED_POINTER-clean.
Pick-to: 6.9 6.8
Task-number: QTBUG-132215
Change-Id: I0759032f028595b6957b125245d3ff9d302274bd
Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
QNX, too believes that QASV{QStringRef} is still ambiguous, even after
qtbase/a0e65398483729259cf58781949133c6055fdc7c and
qt5compat/5f94627eda523112116917ca08e6d0ab281bd5ea. Comment the test
out for all compilers except non-QNX GCC for now.
Task-number: QTBUG-122797
Pick-to: 6.9 6.8 6.5
Change-Id: I8563d48015babdbb79e107e7f5bfc063cc3dbc06
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
QRegExpEngine's size is already prety large, and QRegExpCharClass
isn't huge (2 QLists and an int + bool (the latter could probably be
packed into the former), so the space overhead isn't much,
pecentage-wise.
This is in preparation of adding QT_NO_SCOPED_POINTER.
Pick-to: 6.9 6.8
Task-number: QTBUG-132215
Change-Id: I3e71e631231baf6451b70a08ec6a288b369c6e49
Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
MSVC believes that QASV{QStringRef} is still ambiguous, even after
qtbase/a0e65398483729259cf58781949133c6055fdc7c and
qt5compat/5f94627eda523112116917ca08e6d0ab281bd5ea. Comment the test
out for MSVCfor now.
Reopens: QTBUG-122797
Pick-to: 6.9 6.8 6.5
Change-Id: I1be144b15bc6245fb36a3bd9abac6685844fd7d5
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Like for the conversion to QStringView, the conversion to
QAnyStringView was hitting the QASV{container} ctor, which doesn't
deal with QString(Ref)'s funny isNull()-but-data()-!=-nullptr
bug^Wpolicy, leading to null-ness being lost in the conversion.
At some point, it didn't even compile (cf. QTBUG-122797), though this
author could not reproduce the issue after fixing QTBUG-122798.
Fix by providing an implicit conversion operator to
QAnyStringView. This fixes the issue for conversion, but if a user
forces construction (e.g. using QAnyStringView{sr}), then the
QASV{container} ctor is still chosen, and still breaks
null-less. QStringView has the same problem, at the moment.
Fixing that requires changes in QtBase, so guard dependent code with
a macro that a fixed QtCore will set, incl. in QStringRef::operator
QASV() itself.
[ChangeLog][QtCore5Compat][QStringRef] Fixed missing conversion to
QAnyStringView.
Task-number: QTBUG-122797
Pick-to: 6.9 6.8 6.5
Change-Id: Ic848332e8f9e052d1359fa4532131e93e1b5c13c
Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
When QStringRef was moved out of QtCore, QStringRef (which needs the
same special isNull() handling that QString also needs, due to the
never-nullptr data() bug^Wpolicy) was dropped from QStringView's
if_qstring_like constraint, and the replacement QStringRef::operator
QStringView() didn't take the issue into account for all cases:
A QStringRef with a nullptr string() will create a null QStringView,
but a likewise isNull() QStringRef constructed over an isNull()
QString will create a non-null QStringView (over
QStringRef::data()::_empty).
Fix by checking for QStringRef::isNull() instead of just !m_string in
operator QStringView().
Amends 80ffb97660.
[ChangeLog][QtCore5Compat][QStringRef] Fixed a Qt 6 regression where
conversion to QStringView would no longer preserve nullness.
Task-number: QTBUG-122798
Pick-to: 6.9 6.8 6.5
Change-Id: Ie28e02c6553271a2cb6e8e6816de8c79b8c84b31
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
It did, in Qt 5, but the test, if ever there was one, got lost when
QStringRef moved out of QtCore. Subsequently, the property was
broken.
Task-number: QTBUG-122798
Pick-to: 6.9 6.8 6.5
Change-Id: I517307c5f999457e353b9cf7200158d99fecd3ac
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
So it's easier to see what the error is.
Drive-by make it compile with Qt 5.
Pick-to: 6.8
Change-Id: I2fe31a7ad762bdd38ca3fffd9f903b5e64da4691
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
REUSE.toml files are read by reuse to complement or override the
copyright and licensing information found in file.
The use of REUSE.toml files was introduced in REUSE version 3.1.0a1.
This reuse version is compatible with reuse specification
version 3.2 [1].
With this commit's files,
* The SPDX document generated by reuse spdx conforms to SPDX 2.3,
* The reuse lint command reports that the Qt project is reuse compliant.
In order to be reuse compliant all the licenses referenced in file
or within a REUSE.toml file must be present in the LICENSES
directory at the base of the module.
The missing licenses are added.
[1]: https://reuse.software/spec-3.2/
Task-number: QTBUG-124453
Task-number: QTBUG-125211
Pick-to: 6.8
Change-Id: I330938ead940b59054750a0e2bdb5c1936e146a5
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Include documentation testing steps in coin/module_config.yaml and
set the warning limit to zero.
Task-number: QTBUG-130559
Change-Id: I31797453b155504ba7498dc87fc1fb511d0e88d6
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Instead of #ifdef, use constexpr-if to ensure both endian paths are
seen by all compilers.
Pick-to: 6.8
Task-number: QTBUG-130392
Change-Id: Id40769becdc68a20aee7d0dbc8fe7ca497a97384
Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
Don't cast qle_ushort to QChar. The implicit conversion to int, which
this relies on, has been disabled as of
qtbase/9ef4c123c39c642357c9e8530d59f32f220a7824.
Cast it to char16_t instead, which is the future-proof way to do such
things.
Pick-to: 6.8
Fixes: QTBUG-130392
Change-Id: Ie2691d4dca072b0da8af86e8df0b97c661d88f14
Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
Brian Kernigham said the one thing he'd do differently in Unix if he had
the chance to do it all over again was to add the "e" to creat().
Change-Id: Ifa343726f2065e2fb4bafffd1c7a96a741c664da
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Complements dd0ddad631 and makes
QTextCodec::{to,from}Unicode also use the flag. Same reasoning as that
commit.
The changes to the tests are to make it compatible with what QTextCodec
did in Qt 5: the stateless fromUnicode() conversion did add BOMs, so we
match Qt 5's behavior here. That includes conversions of empty strings,
which QStringView() on a null pointer is.
In fact, I think commit 3695cd090b is
wrong in returning an empty QByteArray(). It went in because:
a) the BOM behavior was different until the fix in this commit and in
commit dd0ddad631
b) the test was not backported to Qt 5, which would have identified the
difference in behavior
I'm not fixing that difference in behavior because there's no Qt 5 code
to be compatible with, as Qt 5 crashed when attempting to convert null
pointers. The behavior of converting an empty QStringView() remains the
same (just no longer tested).
[ChangeLog][Qt5CoreCompat][QTextCodec] Fixed a bug that caused
QTextCodec not to write the Byte Order Mark for UTF codecs. QTextCodec
now has the same behavior as Qt 5.x.
Task-number: QTBUG-122795
Pick-to: 6.5 6.7 6.8
Change-Id: If05cb740b64f42eba21efffd17d13d0145f74945
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Paul Wicking
Axel Spoerl
David Boddie
Qt Submodule Update Bot
Alexei Cazacov
Safiyyah Moosa
Marc Mutz
Jani Heikkinen
Thiago Macieira
Lucie Gérard
Topi Reinio