That includes .qdoc files as well as snippets.
QUIP: 23
Task-number: QTBUG-135745
Pick-to: 6.10 6.8
Change-Id: I701c49578a872dd6c6e385d68ed3db0005522abf
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
These headers contain macros and inline functions that are no longer
trivial, and are probably used in many QTextCodec implementations.
Some of this stuff could be de-inlined, so leave a comment.
QUIP: 23
Task-number: QTBUG-135745
Pick-to: 6.10 6.8
Change-Id: I8a7d7afd51b4ddab56c87ee42e5b3c0ab4c6aa01
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
They either contain only declarations, or only trivial implementation
(like inline forwarders from virtual name() to static _name()).
A follow-up patch will handle the remaining headers that don't fit
these categories.
QUIP: 23
Task-number: QTBUG-135745
Pick-to: 6.10 6.8
Change-Id: I7f9035a8491de14ad57acf084f77604869ec484b
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Destructors of virtual classes should be out-of-line, to avoid
-Wweak-vtables, and all the complications weak vtables entail.
Task-number: QTBUG-45582
Task-number: QTBUG-140401
Pick-to: 6.10 6.8 6.5
Change-Id: I6bf136d6c5f6b78829fbe179cf7f713d0e05cc68
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Amends b4f927dc94, see that commit for
rationale.
Task-number: QTBUG-97601
Pick-to: 6.10 6.8 6.5
Change-Id: I06ab5f2a8e59f08846eade2cc97f531093477ee3
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
This class does not handle external input, so is significant
(the default).
Task-number: QTBUG-135745
Pick-to: 6.10 6.8
Change-Id: I95cde0545782400bdbb0e53d5a559f28a1184f06
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
QStringConverter is, so these should be, too.
Task-number: QTBUG-135745
Pick-to: 6.10 6.8
Change-Id: I2360bf3ae5ee280dd81f482999f4620c7ffd5134
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
There doesn't seem to be a generator that creates this file, so that
can't be the reason to have it as a separate header.
There's also only qeuckrcodec.cpp which includes the header, so
multiple users, too, can't be the reason.
Since there's no reason to have it as a separate header, don't. Inline
the contents into qeuckrcodec.cpp.
As a drive-by, make the table constexpr instead of just const.
This avoids having to mark the file with Qt-Security headers.
Task-number: QTBUG-135745
Pick-to: 6.10 6.8
Change-Id: Ie0487bc62ab2e88727bbfa442ab85549670bbf57
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
QDom and QXmlStreamReader are, too.
The public header is trivial-impl-only, but the private one has some
more implementation.
I didn't check whether it's beyond anyone's limit for trivial
implementation, because I think this header should be inlined into its
only #include'er, qxml.cpp.
Add a comment to that effect, and leave the header as "critical".
Task-number: QTBUG-135745
Pick-to: 6.10.0 6.10 6.9 6.8
Change-Id: Ic02450967b483add4225e8c27c7b4b6eddb68640
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
QString and QStringView are, too.
The header contains a smidge too much implementation to mark it
trivial-impl-only, add a comment to de-inline such stuff.
Task-number: QTBUG-135745
Pick-to: 6.10.0 6.10 6.9 6.8
Change-Id: I55a664d4e71ecf2bf754389a30ec13ee2e9b9e8a
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
QRegularExpression is, too, and, unlike QRegularExpression, this class
does the pattern parsing and matching completely by itself
(QRegularExpression hands it over to libpcre).
The header only contains trivial forwarders between (char*, int) and
(QString) overloads, so mark it as trivial-impl-only.
Task-number: QTBUG-135745
Pick-to: 6.10 6.10.0 6.9 6.8
Change-Id: I65a9e2b521919d3f6eb604560bba701f46f8d0d8
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
The \generatelist command takes an optional argument
that affect how the members are listed, for example,
`classesbymodule` which creates an annotated list of
the classes in a named C++ module.
`groupsbymodule` is not recognized or documented. QDoc
falls back to generating a list of all members of a
group in this case. While the end result is correct,
this relies on an undocumented feature that is likely
to change and break.
Replace these instances with an explicit \annotatedlist
command that produces the same output.
Pick-to: 6.10
Task-number: QTBUG-138901
Change-Id: I4486d19f59c6c1fd085f15a6a296226a6a8a20b0
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Add textual description for javaiterators1.png in the QtCore5Compat
documentation to ensure QDoc generates alt text.
Pick-to: 6.10 6.9 6.8
Fixes: QTBUG-136146
Change-Id: I8474cbcf0900ea117e1e6e78aff8b8b2b985085b
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
The earliest we can move this is right after `BuildInternals`. This
allows us to add function calls before navigating the `find_package`
tree of the dependents.
Task-number: QTBUG-135233
Change-Id: I74d73979b4084ddf535bd1e3b41bbf91dbc0a22e
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
The ColorOverlay documentation incorrectly stated that the color format
is RGBA .The fix changed to ARGB as per the actual usage and QML color
format specification.
Pick-to: 6.10 6.9
Fixes: QTBUG-71541
Change-Id: If0ddacb1baba696b7095f6494629feb5cee78238
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
[ChangeLog][Third-Party Code] Added PURL and CPE information to the
attribution files of 3rd party sources.
Pick-to: 6.5 6.8 6.9 6.10
Fixes: QTBUG-137188
Task-number: QTBUG-129602
Change-Id: I3b7282ae913af1028072825e0bae1a6927002535
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Since 6.10, QDoc is capable of generating links to the declaration in
the source code for each documented C++ API entity in their `Detailed
description`.
Add the required configuration to enable this feature for Qt 5 Core
Compatibility APIs.
Change-Id: Ic88dc5e1595c19e0a82aa6797ff300638d046e8b
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Qt lite configurations may disable XML altogether (-no-feature-xml).
Sax autotests link and rely on XML => disable tests when XML is
disabled.
Fixes: QTBUG-136673
Change-Id: Idd837781651d2b834a28ee8cd52516886a95b744
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Marc Mutz
Qt Submodule Update Bot
Topi Reinio
Lucie Gérard
Dheerendra Purohit
Cristian Le
Jani Heikkinen
Alexandru Croitor
Juha Vuolle