From 42f2fff72ba5439a44d330ba0051aee806ed13b1 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Fri, 19 Sep 2025 15:29:52 +0200 Subject: [PATCH] Mark remaining QTextCodec headers are security-critical These headers contain macros and inline functions that are no longer trivial, and are probably used in many QTextCodec implementations. Some of this stuff could be de-inlined, so leave a comment. QUIP: 23 Task-number: QTBUG-135745 Pick-to: 6.10 6.8 Change-Id: I8a7d7afd51b4ddab56c87ee42e5b3c0ab4c6aa01 Reviewed-by: Ivan Solovev --- src/core5/codecs/qcodecmacros_p.h | 1 + src/core5/codecs/qtextcodec.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/core5/codecs/qcodecmacros_p.h b/src/core5/codecs/qcodecmacros_p.h index 7982ffe..0fb1ca2 100644 --- a/src/core5/codecs/qcodecmacros_p.h +++ b/src/core5/codecs/qcodecmacros_p.h @@ -1,5 +1,6 @@ // Copyright (C) 2023 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:data-parser #ifndef QCODECMACROS_P_H #define QCODECMACROS_P_H diff --git a/src/core5/codecs/qtextcodec.h b/src/core5/codecs/qtextcodec.h index b21393f..bf7513a 100644 --- a/src/core5/codecs/qtextcodec.h +++ b/src/core5/codecs/qtextcodec.h @@ -1,5 +1,7 @@ // Copyright (C) 2018 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only +// Qt-Security score:critical reason:data-parser +// ### de-inline more functions #ifndef QTEXTCODEC_H #define QTEXTCODEC_H