qiurui
/
qt3d
mirror of https://github.com/qt/qt3d.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GLTFGeometryLoader: prevent early return on option bufferview target property 

The glTF specs mention that the target property on a buffer view is not
required:
https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#reference-bufferview

Therefore, since the parser would return early if no target was specified,
preventing any mesh from being loaded. This patch removes the target checking
which serves no purpose.

Pick-to: 6.4 5.15
Change-Id: I7b1781060b79d1d102c1366dc1884a9f283a7f9f
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
This commit is contained in:
Paul Lemire 2022-10-13 07:33:07 +02:00
parent d8efe38791
commit cffc59ff37
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp
View File

@ -306,15 +306,6 @@ void GLTFGeometryLoader::processJSONBufferViewV2(const QJsonObject &json)
} }
const auto bufferData = m_gltf2.m_bufferDatas[bufferIndex]; const auto bufferData = m_gltf2.m_bufferDatas[bufferIndex];
int target = json.value(KEY_TARGET).toInt();
switch (target) {
case GL_ARRAY_BUFFER:
case GL_ELEMENT_ARRAY_BUFFER:
break;
default:
return;
}
quint64 offset = 0; quint64 offset = 0;
const auto byteOffset = json.value(KEY_BYTE_OFFSET); const auto byteOffset = json.value(KEY_BYTE_OFFSET);
if (!byteOffset.isUndefined()) { if (!byteOffset.isUndefined()) {