Eric Dumazet c92e8c02fe tcp/dccp: fix ireq->opt races ... syzkaller found another bug in DCCP/TCP stacks [1] For the reasons explained in commit ce1050089c ("tcp/dccp: fix ireq->pktopts race"), we need to make sure we do not access ireq->opt unless we own the request sock. Note the opt field is renamed to ireq_opt to ease grep games. [1] BUG: KASAN: use-after-free in ip_queue_xmit+0x1687/0x18e0 net/ipv4/ip_output.c:474 Read of size 1 at addr ffff8801c951039c by task syz-executor5/3295 CPU: 1 PID: 3295 Comm: syz-executor5 Not tainted 4.14.0-rc4+ #80 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:16 [inline] dump_stack+0x194/0x257 lib/dump_stack.c:52 print_address_description+0x73/0x250 mm/kasan/report.c:252 kasan_report_error mm/kasan/report.c:351 [inline] kasan_report+0x25b/0x340 mm/kasan/report.c:409 __asan_report_load1_noabort+0x14/0x20 mm/kasan/report.c:427 ip_queue_xmit+0x1687/0x18e0 net/ipv4/ip_output.c:474 tcp_transmit_skb+0x1ab7/0x3840 net/ipv4/tcp_output.c:1135 tcp_send_ack.part.37+0x3bb/0x650 net/ipv4/tcp_output.c:3587 tcp_send_ack+0x49/0x60 net/ipv4/tcp_output.c:3557 __tcp_ack_snd_check+0x2c6/0x4b0 net/ipv4/tcp_input.c:5072 tcp_ack_snd_check net/ipv4/tcp_input.c:5085 [inline] tcp_rcv_state_process+0x2eff/0x4850 net/ipv4/tcp_input.c:6071 tcp_child_process+0x342/0x990 net/ipv4/tcp_minisocks.c:816 tcp_v4_rcv+0x1827/0x2f80 net/ipv4/tcp_ipv4.c:1682 ip_local_deliver_finish+0x2e2/0xba0 net/ipv4/ip_input.c:216 NF_HOOK include/linux/netfilter.h:249 [inline] ip_local_deliver+0x1ce/0x6e0 net/ipv4/ip_input.c:257 dst_input include/net/dst.h:464 [inline] ip_rcv_finish+0x887/0x19a0 net/ipv4/ip_input.c:397 NF_HOOK include/linux/netfilter.h:249 [inline] ip_rcv+0xc3f/0x1820 net/ipv4/ip_input.c:493 __netif_receive_skb_core+0x1a3e/0x34b0 net/core/dev.c:4476 __netif_receive_skb+0x2c/0x1b0 net/core/dev.c:4514 netif_receive_skb_internal+0x10b/0x670 net/core/dev.c:4587 netif_receive_skb+0xae/0x390 net/core/dev.c:4611 tun_rx_batched.isra.50+0x5ed/0x860 drivers/net/tun.c:1372 tun_get_user+0x249c/0x36d0 drivers/net/tun.c:1766 tun_chr_write_iter+0xbf/0x160 drivers/net/tun.c:1792 call_write_iter include/linux/fs.h:1770 [inline] new_sync_write fs/read_write.c:468 [inline] __vfs_write+0x68a/0x970 fs/read_write.c:481 vfs_write+0x18f/0x510 fs/read_write.c:543 SYSC_write fs/read_write.c:588 [inline] SyS_write+0xef/0x220 fs/read_write.c:580 entry_SYSCALL_64_fastpath+0x1f/0xbe RIP: 0033:0x40c341 RSP: 002b:00007f469523ec10 EFLAGS: 00000293 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 0000000000718000 RCX: 000000000040c341 RDX: 0000000000000037 RSI: 0000000020004000 RDI: 0000000000000015 RBP: 0000000000000086 R08: 0000000000000000 R09: 0000000000000000 R10: 00000000000f4240 R11: 0000000000000293 R12: 00000000004b7fd1 R13: 00000000ffffffff R14: 0000000020000000 R15: 0000000000025000 Allocated by task 3295: save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:59 save_stack+0x43/0xd0 mm/kasan/kasan.c:447 set_track mm/kasan/kasan.c:459 [inline] kasan_kmalloc+0xad/0xe0 mm/kasan/kasan.c:551 __do_kmalloc mm/slab.c:3725 [inline] __kmalloc+0x162/0x760 mm/slab.c:3734 kmalloc include/linux/slab.h:498 [inline] tcp_v4_save_options include/net/tcp.h:1962 [inline] tcp_v4_init_req+0x2d3/0x3e0 net/ipv4/tcp_ipv4.c:1271 tcp_conn_request+0xf6d/0x3410 net/ipv4/tcp_input.c:6283 tcp_v4_conn_request+0x157/0x210 net/ipv4/tcp_ipv4.c:1313 tcp_rcv_state_process+0x8ea/0x4850 net/ipv4/tcp_input.c:5857 tcp_v4_do_rcv+0x55c/0x7d0 net/ipv4/tcp_ipv4.c:1482 tcp_v4_rcv+0x2d10/0x2f80 net/ipv4/tcp_ipv4.c:1711 ip_local_deliver_finish+0x2e2/0xba0 net/ipv4/ip_input.c:216 NF_HOOK include/linux/netfilter.h:249 [inline] ip_local_deliver+0x1ce/0x6e0 net/ipv4/ip_input.c:257 dst_input include/net/dst.h:464 [inline] ip_rcv_finish+0x887/0x19a0 net/ipv4/ip_input.c:397 NF_HOOK include/linux/netfilter.h:249 [inline] ip_rcv+0xc3f/0x1820 net/ipv4/ip_input.c:493 __netif_receive_skb_core+0x1a3e/0x34b0 net/core/dev.c:4476 __netif_receive_skb+0x2c/0x1b0 net/core/dev.c:4514 netif_receive_skb_internal+0x10b/0x670 net/core/dev.c:4587 netif_receive_skb+0xae/0x390 net/core/dev.c:4611 tun_rx_batched.isra.50+0x5ed/0x860 drivers/net/tun.c:1372 tun_get_user+0x249c/0x36d0 drivers/net/tun.c:1766 tun_chr_write_iter+0xbf/0x160 drivers/net/tun.c:1792 call_write_iter include/linux/fs.h:1770 [inline] new_sync_write fs/read_write.c:468 [inline] __vfs_write+0x68a/0x970 fs/read_write.c:481 vfs_write+0x18f/0x510 fs/read_write.c:543 SYSC_write fs/read_write.c:588 [inline] SyS_write+0xef/0x220 fs/read_write.c:580 entry_SYSCALL_64_fastpath+0x1f/0xbe Freed by task 3306: save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:59 save_stack+0x43/0xd0 mm/kasan/kasan.c:447 set_track mm/kasan/kasan.c:459 [inline] kasan_slab_free+0x71/0xc0 mm/kasan/kasan.c:524 __cache_free mm/slab.c:3503 [inline] kfree+0xca/0x250 mm/slab.c:3820 inet_sock_destruct+0x59d/0x950 net/ipv4/af_inet.c:157 __sk_destruct+0xfd/0x910 net/core/sock.c:1560 sk_destruct+0x47/0x80 net/core/sock.c:1595 __sk_free+0x57/0x230 net/core/sock.c:1603 sk_free+0x2a/0x40 net/core/sock.c:1614 sock_put include/net/sock.h:1652 [inline] inet_csk_complete_hashdance+0xd5/0xf0 net/ipv4/inet_connection_sock.c:959 tcp_check_req+0xf4d/0x1620 net/ipv4/tcp_minisocks.c:765 tcp_v4_rcv+0x17f6/0x2f80 net/ipv4/tcp_ipv4.c:1675 ip_local_deliver_finish+0x2e2/0xba0 net/ipv4/ip_input.c:216 NF_HOOK include/linux/netfilter.h:249 [inline] ip_local_deliver+0x1ce/0x6e0 net/ipv4/ip_input.c:257 dst_input include/net/dst.h:464 [inline] ip_rcv_finish+0x887/0x19a0 net/ipv4/ip_input.c:397 NF_HOOK include/linux/netfilter.h:249 [inline] ip_rcv+0xc3f/0x1820 net/ipv4/ip_input.c:493 __netif_receive_skb_core+0x1a3e/0x34b0 net/core/dev.c:4476 __netif_receive_skb+0x2c/0x1b0 net/core/dev.c:4514 netif_receive_skb_internal+0x10b/0x670 net/core/dev.c:4587 netif_receive_skb+0xae/0x390 net/core/dev.c:4611 tun_rx_batched.isra.50+0x5ed/0x860 drivers/net/tun.c:1372 tun_get_user+0x249c/0x36d0 drivers/net/tun.c:1766 tun_chr_write_iter+0xbf/0x160 drivers/net/tun.c:1792 call_write_iter include/linux/fs.h:1770 [inline] new_sync_write fs/read_write.c:468 [inline] __vfs_write+0x68a/0x970 fs/read_write.c:481 vfs_write+0x18f/0x510 fs/read_write.c:543 SYSC_write fs/read_write.c:588 [inline] SyS_write+0xef/0x220 fs/read_write.c:580 entry_SYSCALL_64_fastpath+0x1f/0xbe Fixes: e994b2f0fb ("tcp: do not lock listener to process SYN packets") Fixes: 079096f103 ("tcp/dccp: install syn_recv requests into ehash table") Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-10-21 01:33:19 +01:00
..
9p	…
bluetooth	Bluetooth: make baswap src const	2017-09-01 22:49:47 +02:00
caif	…
iucv	…
netfilter	netfilter: nat: Revert "netfilter: nat: convert nat bysrc hash to rhashtable"	2017-09-08 18:55:50 +02:00
netns	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2017-09-03 17:08:42 -07:00
nfc	…
phonet	…
sctp	sctp: fix an use-after-free issue in sctp_sock_dump	2017-09-15 14:47:49 -07:00
tc_act	net: sched: add couple of goto_chain helpers	2017-08-23 20:44:32 -07:00
6lowpan.h	…
Space.h	…
act_api.h	net_sched: get rid of tcfa_rcu	2017-09-12 20:41:02 -07:00
addrconf.h	…
af_ieee802154.h	…
af_rxrpc.h	rxrpc: Allow failed client calls to be retried	2017-08-29 10:55:20 +01:00
af_unix.h	…
af_vsock.h	…
ah.h	…
arp.h	…
atmclip.h	…
ax25.h	…
ax88796.h	…
bond_3ad.h	…
bond_alb.h	…
bond_options.h	…
bonding.h	…
busy_poll.h	…
calipso.h	…
cfg80211-wext.h	…
cfg80211.h	…
cfg802154.h	…
checksum.h	…
cipso_ipv4.h	…
cls_cgroup.h	…
codel.h	…
codel_impl.h	…
codel_qdisc.h	…
compat.h	…
datalink.h	…
dcbevent.h	…
dcbnl.h	…
devlink.h	devlink: Add IPv6 header for dpipe	2017-08-31 14:42:19 -07:00
dn.h	…
dn_dev.h	…
dn_fib.h	…
dn_neigh.h	…
dn_nsp.h	…
dn_route.h	…
dsa.h	net: dsa: Allow switch drivers to indicate number of TX queues	2017-09-05 11:53:34 -07:00
dsfield.h	…
dst.h	net: prevent dst uses after free	2017-09-21 20:42:15 -07:00
dst_cache.h	…
dst_metadata.h	…
dst_ops.h	…
erspan.h	gre: introduce native tunnel support for ERSPAN	2017-08-22 14:29:30 -07:00
esp.h	…
ethoc.h	…
fib_notifier.h	net: Add module reference to FIB notifiers	2017-09-01 20:33:42 -07:00
fib_rules.h	…
firewire.h	…
flow.h	net: Extend struct flowi6 with multipath hash	2017-08-24 18:21:17 -07:00
flow_dissector.h	flow_dissector: Cleanup control flow	2017-09-05 11:40:08 -07:00
fou.h	…
fq.h	…
fq_impl.h	…
garp.h	…
gen_stats.h	…
genetlink.h	…
geneve.h	…
gre.h	…
gro_cells.h	…
gtp.h	…
gue.h	…
hwbm.h	…
icmp.h	…
ieee80211_radiotap.h	…
ieee802154_netdev.h	…
if_inet6.h	…
ife.h	…
ila.h	…
inet6_connection_sock.h	…
inet6_hashtables.h	…
inet_common.h	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
inet_connection_sock.h	…
inet_ecn.h	…
inet_frag.h	Revert "net: fix percpu memory leaks"	2017-09-03 11:01:05 -07:00
inet_hashtables.h	…
inet_sock.h	tcp/dccp: fix ireq->opt races	2017-10-21 01:33:19 +01:00
inet_timewait_sock.h	…
inetpeer.h	…
ip.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-08-21 17:06:42 -07:00
ip6_checksum.h	…
ip6_fib.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-01 17:42:05 -07:00
ip6_route.h	ipv6: Use rt6i_idev index for echo replies to a local address	2017-08-29 15:32:25 -07:00
ip6_tunnel.h	…
ip_fib.h	…
ip_tunnels.h	gre: add collect_md mode to ERSPAN tunnel	2017-08-28 15:04:52 -07:00
ip_vs.h	…
ipcomp.h	…
ipconfig.h	…
ipv6.h	…
ipx.h	…
iw_handler.h	…
kcm.h	…
l3mdev.h	…
lapb.h	…
lib80211.h	…
llc.h	…
llc_c_ac.h	…
llc_c_ev.h	…
llc_c_st.h	…
llc_conn.h	…
llc_if.h	…
llc_pdu.h	…
llc_s_ac.h	…
llc_s_ev.h	…
llc_s_st.h	…
llc_sap.h	…
lwtunnel.h	…
mac80211.h	mac80211: fix VLAN handling with TXQs	2017-09-05 11:28:43 +02:00
mac802154.h	…
mip6.h	…
mld.h	…
mpls.h	…
mpls_iptunnel.h	…
mrp.h	…
ncsi.h	net/ncsi: fix ncsi_vlan_rx_{add,kill}_vid references	2017-09-05 09:11:45 -07:00
ndisc.h	…
neighbour.h	…
net_namespace.h	…
net_ratelimit.h	…
netevent.h	…
netlabel.h	…
netlink.h	netlink: fix nla_put_{u8,u16,u32} for KASAN	2017-09-25 20:18:27 -07:00
netprio_cgroup.h	…
netrom.h	…
nexthop.h	…
nl802154.h	…
nsh.h	net: add NSH header structures and helpers	2017-08-29 15:16:52 -07:00
p8022.h	…
ping.h	…
pkt_cls.h	…
pkt_sched.h	…
pptp.h	…
protocol.h	IPv4: early demux can return an error code	2017-10-01 03:55:47 +01:00
psample.h	…
psnap.h	…
raw.h	…
rawv6.h	…
red.h	…
regulatory.h	…
request_sock.h	…
rose.h	…
route.h	udp: perform source validation for mcast early demux	2017-10-01 03:55:47 +01:00
rtnetlink.h	…
sch_generic.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-09-01 17:42:05 -07:00
scm.h	…
secure_seq.h	…
seg6.h	ipv6: sr: add support for ip4ip6 encapsulation	2017-08-25 17:10:23 -07:00
seg6_hmac.h	…
slhc_vj.h	…
smc.h	…
snmp.h	…
sock.h	net: prevent dst uses after free	2017-09-21 20:42:15 -07:00
sock_reuseport.h	…
stp.h	…
strparser.h	strparser: initialize all callbacks	2017-08-24 21:57:50 -07:00
switchdev.h	…
tcp.h	bpf: avoid preempt enable/disable in sockmap using tcp_skb_cb region	2017-10-20 13:01:29 +01:00
tcp_states.h	…
timewait_sock.h	…
tls.h	…
transp_v6.h	…
tso.h	net: define the TSO header size in net/tso.h	2017-08-23 20:42:09 -07:00
tun_proto.h	vxlan: factor out VXLAN-GPE next protocol	2017-08-29 15:16:52 -07:00
udp.h	IPv4: early demux can return an error code	2017-10-01 03:55:47 +01:00
udp_tunnel.h	…
udplite.h	…
vsock_addr.h	…
vxlan.h	vxlan: factor out VXLAN-GPE next protocol	2017-08-29 15:16:52 -07:00
wext.h	…
wimax.h	…
x25.h	…
x25device.h	…
xfrm.h	xfrm: Add support for network devices capable of removing the ESP trailer	2017-08-31 09:04:03 +02:00