Chen Yu e16c7b0778 kthread: fix task state in kthread worker if being frozen ... When analyzing a kernel waring message, Peter pointed out that there is a race condition when the kworker is being frozen and falls into try_to_freeze() with TASK_INTERRUPTIBLE, which could trigger a might_sleep() warning in try_to_freeze(). Although the root cause is not related to freeze()[1], it is still worthy to fix this issue ahead. One possible race scenario: CPU 0 CPU 1 ----- ----- // kthread_worker_fn set_current_state(TASK_INTERRUPTIBLE); suspend_freeze_processes() freeze_processes static_branch_inc(&freezer_active); freeze_kernel_threads pm_nosig_freezing = true; if (work) { //false __set_current_state(TASK_RUNNING); } else if (!freezing(current)) //false, been frozen freezing(): if (static_branch_unlikely(&freezer_active)) if (pm_nosig_freezing) return true; schedule() } // state is still TASK_INTERRUPTIBLE try_to_freeze() might_sleep() <--- warning Fix this by explicitly set the TASK_RUNNING before entering try_to_freeze(). Link: https://lore.kernel.org/lkml/Zs2ZoAcUsZMX2B%2FI@chenyu5-mobl2/ [1] Link: https://lkml.kernel.org/r/20240827112308.181081-1-yu.c.chen@intel.com Fixes: b56c0d8937 ("kthread: implement kthread_worker") Signed-off-by: Chen Yu <yu.c.chen@intel.com> Suggested-by: Peter Zijlstra <peterz@infradead.org> Suggested-by: Andrew Morton <akpm@linux-foundation.org> Cc: Andreas Gruenbacher <agruenba@redhat.com> Cc: David Gow <davidgow@google.com> Cc: Mateusz Guzik <mjguzik@gmail.com> Cc: Mickaël Salaün <mic@digikod.net> Cc: Tejun Heo <tj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>		2024-09-01 20:43:41 -07:00
..
bpf	bpf: Fix a kernel verifier crash in stacksafe()	2024-08-12 18:09:48 -07:00
cgroup	cgroup/cpuset: Eliminate unncessary sched domains rebuilds in hotplug	2024-08-05 10:54:25 -10:00
configs	mm/slab: Plumb kmem_buckets into __do_kmalloc_node()	2024-07-03 12:24:19 +02:00
debug	…
dma	dma-debug: avoid deadlock between dma debug vs printk and netconsole	2024-08-06 10:29:32 -07:00
entry	…
events	perf/bpf: Don't call bpf_overflow_handler() for tracing events	2024-08-13 10:25:28 -07:00
futex	fault-inject: improve build for CONFIG_FAULT_INJECTION=n	2024-09-01 20:43:33 -07:00
gcov	…
irq	genirq/irqdesc: Honor caller provided affinity in alloc_desc()	2024-08-07 17:27:00 +02:00
kcsan	…
livepatch	…
locking	locking/ww_mutex/test: add MODULE_DESCRIPTION()	2024-09-01 20:43:31 -07:00
module	module: make waiting for a concurrent module loader interruptible	2024-08-09 08:33:28 -07:00
power	mm: remove the implementation of swap_free() and always use swap_free_nr()	2024-07-03 19:30:01 -07:00
printk	printk/panic: Allow cpu backtraces to be written into ringbuffer during panic	2024-08-13 14:16:22 +02:00
rcu	Merge branches 'doc.2024.06.06a', 'fixes.2024.07.04a', 'mb.2024.06.28a', 'nocb.2024.06.03a', 'rcu-tasks.2024.06.06a', 'rcutorture.2024.06.06a' and 'srcu.2024.06.18a' into HEAD	2024-07-04 13:54:17 -07:00
sched	profiling: remove profile=sleep support	2024-08-04 13:36:28 -07:00
time	timekeeping: Fix bogus clock_was_set() invocation in do_adjtimex()	2024-08-05 16:14:14 +02:00
trace	tracing: Return from tracing_buffers_read() if the file has been closed	2024-08-09 12:59:35 -04:00
.gitignore	…
Kconfig.freezer	…
Kconfig.hz	…
Kconfig.kexec	…
Kconfig.locks	…
Kconfig.preempt	…
Makefile	…
acct.c	…
async.c	…
audit.c	…
audit.h	…
audit_fsnotify.c	…
audit_tree.c	…
audit_watch.c	…
auditfilter.c	…
auditsc.c	…
backtracetest.c	…
bounds.c	…
capability.c	…
cfi.c	…
compat.c	…
configs.c	…
context_tracking.c	…
cpu.c	cpu/SMT: Enable SMT only if a core is online	2024-08-13 10:31:24 +10:00
cpu_pm.c	…
crash_core.c	Document/kexec: generalize crash hotplug description	2024-09-01 20:43:37 -07:00
crash_reserve.c	crash: fix crash memory reserve exceed system memory bug	2024-09-01 20:43:30 -07:00
cred.c	…
delayacct.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
dma.c	…
elfcorehdr.c	…
exec_domain.c	…
exit.c	- 875fa64577da ("mm/hugetlb_vmemmap: fix race with speculative PFN	2024-07-21 17:15:46 -07:00
exit.h	…
extable.c	…
fail_function.c	…
fork.c	Revert "pidfd: prevent creation of pidfds for kthreads"	2024-08-21 22:32:58 +02:00
freezer.c	…
gen_kheaders.sh	…
groups.c	…
hung_task.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
iomem.c	…
irq_work.c	…
jump_label.c	jump_label: Fix the fix, brown paper bags galore	2024-07-31 12:57:39 +02:00
kallsyms.c	kallsyms: Match symbols exactly with CONFIG_LTO_CLANG	2024-08-15 09:33:35 -07:00
kallsyms_internal.h	kallsyms: get rid of code for absolute kallsyms	2024-07-20 16:33:21 +09:00
kallsyms_selftest.c	kallsyms: Match symbols exactly with CONFIG_LTO_CLANG	2024-08-15 09:33:35 -07:00
kallsyms_selftest.h	…
kcmp.c	…
kcov.c	kcov: properly check for softirq context	2024-08-07 18:33:56 -07:00
kexec.c	…
kexec_core.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
kexec_elf.c	…
kexec_file.c	…
kexec_internal.h	kexec: use atomic_try_cmpxchg_acquire() in kexec_trylock()	2024-09-01 20:43:23 -07:00
kheaders.c	…
kprobes.c	kprobes: Fix to check symbol prefixes correctly	2024-08-05 14:04:03 +09:00
ksyms_common.c	…
ksysfs.c	profiling: remove prof_cpu_mask	2024-07-29 10:45:54 -07:00
kthread.c	kthread: fix task state in kthread worker if being frozen	2024-09-01 20:43:41 -07:00
latencytop.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
module_signature.c	…
notifier.c	…
nsproxy.c	…
numa.c	…
padata.c	padata: Fix possible divide-by-0 panic in padata_mt_helper()	2024-08-07 18:33:56 -07:00
panic.c	printk/panic: Allow cpu backtraces to be written into ringbuffer during panic	2024-08-13 14:16:22 +02:00
params.c	…
pid.c	…
pid_namespace.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
pid_sysctl.h	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
profile.c	profiling: remove profile=sleep support	2024-08-04 13:36:28 -07:00
ptrace.c	…
range.c	…
reboot.c	…
regset.c	…
relay.c	…
resource.c	…
resource_kunit.c	…
rseq.c	…
scftorture.c	…
scs.c	…
seccomp.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
signal.c	kernel: rerun task_work while freezing in get_signal()	2024-07-11 01:51:44 -06:00
smp.c	smp: Add missing destroy_work_on_stack() call in smp_call_on_cpu()	2024-07-10 22:40:39 +02:00
smpboot.c	…
smpboot.h	…
softirq.c	…
stackleak.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
stacktrace.c	…
static_call.c	…
static_call_inline.c	…
stop_machine.c	…
sys.c	…
sys_ni.c	Probes updates for v6.11:	2024-07-18 12:19:20 -07:00
sysctl-test.c	…
sysctl.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
task_work.c	task_work: make TWA_NMI_CURRENT handling conditional on IRQ_WORK	2024-07-29 12:05:06 -07:00
taskstats.c	…
torture.c	…
tracepoint.c	…
tsacct.c	tsacct: replace strncpy() with strscpy()	2024-07-12 16:39:53 -07:00
ucount.c	…
uid16.c	…
uid16.h	…
umh.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
up.c	…
user-return-notifier.c	…
user.c	…
user_namespace.c	…
usermode_driver.c	…
utsname.c	…
utsname_sysctl.c	sysctl: treewide: constify the ctl_table argument of proc_handlers	2024-07-24 20:59:29 +02:00
vhost_task.c	…
vmcore_info.c	kallsyms: get rid of code for absolute kallsyms	2024-07-20 16:33:21 +09:00
watch_queue.c	…
watchdog.c	watchdog: handle the ENODEV failure case of lockup_detector_delay_init() separately	2024-09-01 20:43:32 -07:00
watchdog_buddy.c	…
watchdog_perf.c	watchdog/perf: properly initialize the turbo mode timestamp and rearm counter	2024-07-17 21:11:34 -07:00
workqueue.c	workqueue: Correct declaration of cpu_pwq in struct workqueue_struct	2024-08-05 18:34:02 -10:00
workqueue_internal.h	…