genirq/chip: Rework irq_set_chip()

Use the new guards to get and lock the interrupt descriptor and tidy up the
code.

Fixup the kernel doc comment while at it.

No functional change.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065421.295400891@linutronix.de
This commit is contained in:
Thomas Gleixner 2025-04-29 08:55:19 +02:00
parent e7c6542557
commit 46ff4d11f0
1 changed files with 12 additions and 16 deletions

View File

@ -34,26 +34,22 @@ struct irqaction chained_action = {
}; };
/** /**
* irq_set_chip - set the irq chip for an irq * irq_set_chip - set the irq chip for an irq
* @irq: irq number * @irq: irq number
* @chip: pointer to irq chip description structure * @chip: pointer to irq chip description structure
*/ */
int irq_set_chip(unsigned int irq, const struct irq_chip *chip) int irq_set_chip(unsigned int irq, const struct irq_chip *chip)
{ {
unsigned long flags; int ret = -EINVAL;
struct irq_desc *desc = irq_get_desc_lock(irq, &flags, 0);
if (!desc) scoped_irqdesc_get_and_lock(irq, 0) {
return -EINVAL; scoped_irqdesc->irq_data.chip = (struct irq_chip *)(chip ?: &no_irq_chip);
ret = 0;
desc->irq_data.chip = (struct irq_chip *)(chip ?: &no_irq_chip); }
irq_put_desc_unlock(desc, flags); /* For !CONFIG_SPARSE_IRQ make the irq show up in allocated_irqs. */
/* if (!ret)
* For !CONFIG_SPARSE_IRQ make the irq show up in irq_mark_irq(irq);
* allocated_irqs. return ret;
*/
irq_mark_irq(irq);
return 0;
} }
EXPORT_SYMBOL(irq_set_chip); EXPORT_SYMBOL(irq_set_chip);