2021-07-03 14:56:17 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
|
rust: add #[export] macro
Rust has two different tools for generating function declarations to
call across the FFI boundary:
* bindgen. Generates Rust declarations from a C header.
* cbindgen. Generates C headers from Rust declarations.
However, we only use bindgen in the kernel. This means that when C code
calls a Rust function by name, its signature must be duplicated in both
Rust code and a C header, and the signature needs to be kept in sync
manually.
Introducing cbindgen as a mandatory dependency to build the kernel would
be a rather complex and large change, so we do not consider that at this
time. Instead, to eliminate this manual checking, introduce a new macro
that verifies at compile time that the two function declarations use the
same signature. The idea is to run the C declaration through bindgen,
and then have rustc verify that the function pointers have the same
type.
The signature must still be written twice, but at least you can no
longer get it wrong. If the signatures don't match, you will get errors
that look like this:
error[E0308]: `if` and `else` have incompatible types
--> <linux>/rust/kernel/print.rs:22:22
|
21 | #[export]
| --------- expected because of this
22 | unsafe extern "C" fn rust_fmt_argument(
| ^^^^^^^^^^^^^^^^^ expected `u8`, found `i8`
|
= note: expected fn item `unsafe extern "C" fn(*mut u8, *mut u8, *mut c_void) -> *mut u8 {bindings::rust_fmt_argument}`
found fn item `unsafe extern "C" fn(*mut i8, *mut i8, *const c_void) -> *mut i8 {print::rust_fmt_argument}`
It is unfortunate that the error message starts out by saying "`if` and
`else` have incompatible types", but I believe the rest of the error
message is reasonably clear and not too confusing.
Reviewed-by: Tamir Duberstein <tamird@gmail.com>
Reviewed-by: Andreas Hindborg <a.hindborg@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Link: https://lore.kernel.org/r/20250303-export-macro-v3-3-41fbad85a27f@google.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
2025-03-03 08:45:14 +00:00
|
|
|
use proc_macro::{token_stream, Group, Ident, TokenStream, TokenTree};
|
2021-07-03 14:56:17 +00:00
|
|
|
|
|
|
|
pub(crate) fn try_ident(it: &mut token_stream::IntoIter) -> Option<String> {
|
|
|
|
if let Some(TokenTree::Ident(ident)) = it.next() {
|
|
|
|
Some(ident.to_string())
|
|
|
|
} else {
|
|
|
|
None
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
pub(crate) fn try_literal(it: &mut token_stream::IntoIter) -> Option<String> {
|
|
|
|
if let Some(TokenTree::Literal(literal)) = it.next() {
|
|
|
|
Some(literal.to_string())
|
|
|
|
} else {
|
|
|
|
None
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-11-10 16:41:19 +00:00
|
|
|
pub(crate) fn try_string(it: &mut token_stream::IntoIter) -> Option<String> {
|
|
|
|
try_literal(it).and_then(|string| {
|
|
|
|
if string.starts_with('\"') && string.ends_with('\"') {
|
|
|
|
let content = &string[1..string.len() - 1];
|
|
|
|
if content.contains('\\') {
|
|
|
|
panic!("Escape sequences in string literals not yet handled");
|
|
|
|
}
|
|
|
|
Some(content.to_string())
|
|
|
|
} else if string.starts_with("r\"") {
|
|
|
|
panic!("Raw string literals are not yet handled");
|
2021-07-03 14:56:17 +00:00
|
|
|
} else {
|
|
|
|
None
|
|
|
|
}
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
pub(crate) fn expect_ident(it: &mut token_stream::IntoIter) -> String {
|
|
|
|
try_ident(it).expect("Expected Ident")
|
|
|
|
}
|
|
|
|
|
|
|
|
pub(crate) fn expect_punct(it: &mut token_stream::IntoIter) -> char {
|
|
|
|
if let TokenTree::Punct(punct) = it.next().expect("Reached end of token stream for Punct") {
|
|
|
|
punct.as_char()
|
|
|
|
} else {
|
|
|
|
panic!("Expected Punct");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-11-10 16:41:19 +00:00
|
|
|
pub(crate) fn expect_string(it: &mut token_stream::IntoIter) -> String {
|
|
|
|
try_string(it).expect("Expected string")
|
|
|
|
}
|
|
|
|
|
|
|
|
pub(crate) fn expect_string_ascii(it: &mut token_stream::IntoIter) -> String {
|
|
|
|
let string = try_string(it).expect("Expected string");
|
|
|
|
assert!(string.is_ascii(), "Expected ASCII string");
|
|
|
|
string
|
2021-07-03 14:56:17 +00:00
|
|
|
}
|
|
|
|
|
2023-03-23 12:35:10 +00:00
|
|
|
pub(crate) fn expect_group(it: &mut token_stream::IntoIter) -> Group {
|
|
|
|
if let TokenTree::Group(group) = it.next().expect("Reached end of token stream for Group") {
|
|
|
|
group
|
|
|
|
} else {
|
|
|
|
panic!("Expected Group");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-07-03 14:56:17 +00:00
|
|
|
pub(crate) fn expect_end(it: &mut token_stream::IntoIter) {
|
|
|
|
if it.next().is_some() {
|
|
|
|
panic!("Expected end");
|
|
|
|
}
|
|
|
|
}
|
2023-04-24 08:11:38 +00:00
|
|
|
|
rust: add #[export] macro
Rust has two different tools for generating function declarations to
call across the FFI boundary:
* bindgen. Generates Rust declarations from a C header.
* cbindgen. Generates C headers from Rust declarations.
However, we only use bindgen in the kernel. This means that when C code
calls a Rust function by name, its signature must be duplicated in both
Rust code and a C header, and the signature needs to be kept in sync
manually.
Introducing cbindgen as a mandatory dependency to build the kernel would
be a rather complex and large change, so we do not consider that at this
time. Instead, to eliminate this manual checking, introduce a new macro
that verifies at compile time that the two function declarations use the
same signature. The idea is to run the C declaration through bindgen,
and then have rustc verify that the function pointers have the same
type.
The signature must still be written twice, but at least you can no
longer get it wrong. If the signatures don't match, you will get errors
that look like this:
error[E0308]: `if` and `else` have incompatible types
--> <linux>/rust/kernel/print.rs:22:22
|
21 | #[export]
| --------- expected because of this
22 | unsafe extern "C" fn rust_fmt_argument(
| ^^^^^^^^^^^^^^^^^ expected `u8`, found `i8`
|
= note: expected fn item `unsafe extern "C" fn(*mut u8, *mut u8, *mut c_void) -> *mut u8 {bindings::rust_fmt_argument}`
found fn item `unsafe extern "C" fn(*mut i8, *mut i8, *const c_void) -> *mut i8 {print::rust_fmt_argument}`
It is unfortunate that the error message starts out by saying "`if` and
`else` have incompatible types", but I believe the rest of the error
message is reasonably clear and not too confusing.
Reviewed-by: Tamir Duberstein <tamird@gmail.com>
Reviewed-by: Andreas Hindborg <a.hindborg@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Link: https://lore.kernel.org/r/20250303-export-macro-v3-3-41fbad85a27f@google.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
2025-03-03 08:45:14 +00:00
|
|
|
/// Given a function declaration, finds the name of the function.
|
|
|
|
pub(crate) fn function_name(input: TokenStream) -> Option<Ident> {
|
|
|
|
let mut input = input.into_iter();
|
|
|
|
while let Some(token) = input.next() {
|
|
|
|
match token {
|
|
|
|
TokenTree::Ident(i) if i.to_string() == "fn" => {
|
|
|
|
if let Some(TokenTree::Ident(i)) = input.next() {
|
|
|
|
return Some(i);
|
|
|
|
}
|
|
|
|
return None;
|
|
|
|
}
|
|
|
|
_ => continue,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
None
|
|
|
|
}
|
rust: kunit: support KUnit-mapped `assert!` macros in `#[test]`s
The KUnit `#[test]` support that landed recently is very basic and does
not map the `assert*!` macros into KUnit like the doctests do, so they
panic at the moment.
Thus implement the custom mapping in a similar way to doctests, reusing
the infrastructure there.
In Rust 1.88.0, the `file()` method in `Span` may be stable [1]. However,
it was changed recently (from `SourceFile`), so we need to do something
different in previous versions. Thus create a helper for it and use it
to get the path.
With this, a failing test suite like:
#[kunit_tests(my_test_suite)]
mod tests {
use super::*;
#[test]
fn my_first_test() {
assert_eq!(42, 43);
}
#[test]
fn my_second_test() {
assert!(42 >= 43);
}
}
will properly map back to KUnit, printing something like:
[ 1.924325] KTAP version 1
[ 1.924421] # Subtest: my_test_suite
[ 1.924506] # speed: normal
[ 1.924525] 1..2
[ 1.926385] # my_first_test: ASSERTION FAILED at rust/kernel/lib.rs:251
[ 1.926385] Expected 42 == 43 to be true, but is false
[ 1.928026] # my_first_test.speed: normal
[ 1.928075] not ok 1 my_first_test
[ 1.928723] # my_second_test: ASSERTION FAILED at rust/kernel/lib.rs:256
[ 1.928723] Expected 42 >= 43 to be true, but is false
[ 1.929834] # my_second_test.speed: normal
[ 1.929868] not ok 2 my_second_test
[ 1.930032] # my_test_suite: pass:0 fail:2 skip:0 total:2
[ 1.930153] # Totals: pass:0 fail:2 skip:0 total
Link: https://github.com/rust-lang/rust/pull/140514 [1]
Reviewed-by: David Gow <davidgow@google.com>
Acked-by: Danilo Krummrich <dakr@kernel.org>
Link: https://lore.kernel.org/r/20250502215133.1923676-2-ojeda@kernel.org
[ Required `KUNIT=y` like for doctests. Used the `cfg_attr` from the
TODO comment and clarified its comment now that the stabilization is
in beta and thus quite likely stable in Rust 1.88.0. Simplified the
`new_body` code by introducing a new variable. Added
`#[allow(clippy::incompatible_msrv)]`. - Miguel ]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
2025-05-02 21:51:26 +00:00
|
|
|
|
|
|
|
pub(crate) fn file() -> String {
|
|
|
|
#[cfg(not(CONFIG_RUSTC_HAS_SPAN_FILE))]
|
|
|
|
{
|
|
|
|
proc_macro::Span::call_site()
|
|
|
|
.source_file()
|
|
|
|
.path()
|
|
|
|
.to_string_lossy()
|
|
|
|
.into_owned()
|
|
|
|
}
|
|
|
|
|
|
|
|
#[cfg(CONFIG_RUSTC_HAS_SPAN_FILE)]
|
|
|
|
#[allow(clippy::incompatible_msrv)]
|
|
|
|
{
|
|
|
|
proc_macro::Span::call_site().file()
|
|
|
|
}
|
|
|
|
}
|