mirror of git://sourceware.org/git/glibc.git
423c2b9d08
TS 18661-1 defines fromfp functions (fromfp, fromfpx, ufromfp, ufromfpx, and float and long double variants) to convert from floating-point to an integer type with any signedness and any given width up to that of intmax_t, in any of the five IEEE rounding modes (the usual four for binary floating point, plus rounding to nearest with ties rounding away from zero), with control of whether in-range non-integer values should result in the "inexact" exception being raised. This patch implements these functions for glibc. These implementations are (apart from raising exceptions) pure integer implementations; it's entirely possible optimized versions could be devised for some architectures. A common math/fromfp.h header provides various common helper code that can readily be shared between the implementations for different types. For each type, the bulk of the implementation is also shared between the four functions, with wrappers that define UNSIGNED and INEXACT macros appropriately before including the main implementation. As the functions return intmax_t and uintmax_t without math.h being allowed to expose those typedef names, they are declared using __intmax_t and __uintmax_t as obtained from <bits/types.h>. The FP_INT_* rounding direction macros are defined as ascending integers in the order the names are listed in the TS; I see no significant value in allowing architectures to vary the values of them. The libm-test machinery is duly adapted to handle unsigned int arguments, and intmax_t and uintmax_t results. Because each test input is generally tested for four functions, five rounding modes and several different widths, the libm-test.inc additions are very large. Thus, the diffs in the body of this message exclude the libm-test.inc changes, with the full patch being attached gzipped. The bulk of the new tests were generated (expanded from a test input plus rounding results and information about where it lies in the relevant interval between integers, to libm-test tests for all relevant combinations of function, rounding direction and width) by a script that's included in the patch as math/gen-fromfp-tests.py (input data math/gen-fromfp-tests-inputs); as an ad hoc script that's not really expected to be rerun, it's not very polished, but it's at least plausibly useful for adding any further tests for these functions in future. I may split the libm-test tests up by function in future (so both libm-test.inc and auto-libm-test-out are split into separate files, and the tests for each function are also built and run separately), but not for 2.25. For no obvious reason, adding tgmath tests for the new functions resulted in -Wuninitialized errors from test-tgmath.c about the variable i being used uninitialized. Those errors were correct - the variable is read by the frexp version in test-tgmath.c (where real frexp would write through that pointer instead of reading it) - but I don't know why this patch would result in the pre-existing issue being newly detected. The patch initializes the variable to avoid those errors. With these changes, glibc 2.25 should have all the library features from TS 18661-1 other than the functions that round result to narrower type (and constant rounding directions, but I'm considering those mainly a compiler feature not a library one). Tested for x86_64, x86, mips64 and powerpc. * math/bits/mathcalls.h [__GLIBC_USE (IEC_60559_BFP_EXT)] (fromfp): New declaration. [__GLIBC_USE (IEC_60559_BFP_EXT)] (fromfpx): Likewise. [__GLIBC_USE (IEC_60559_BFP_EXT)] (ufromfp): Likewise. [__GLIBC_USE (IEC_60559_BFP_EXT)] (ufromfpx): Likewise. * math/tgmath.h (__TGMATH_TERNARY_FIRST_REAL_RET_ONLY): New macro. [__GLIBC_USE (IEC_60559_BFP_EXT)] (fromfp): Likewise. [__GLIBC_USE (IEC_60559_BFP_EXT)] (ufromfp): Likewise. [__GLIBC_USE (IEC_60559_BFP_EXT)] (fromfpx): Likewise. [__GLIBC_USE (IEC_60559_BFP_EXT)] (ufromfpx): Likewise. * math/math.h: Include <bits/types.h>. [__GLIBC_USE (IEC_60559_BFP_EXT)] (FP_INT_UPWARD): New enum constant and macro. (FP_INT_DOWNWARD): Likewise. (FP_INT_TOWARDZERO): Likewise. (FP_INT_TONEARESTFROMZERO): Likewise. (FP_INT_TONEAREST): Likewise. * math/Versions (fromfp): New libm symbol at version GLIBC_2.25. (fromfpf): Likewise. (fromfpl): Likewise. (ufromfp): Likewise. (ufromfpf): Likewise. (ufromfpl): Likewise. (fromfpx): Likewise. (fromfpxf): Likewise. (fromfpxl): Likewise. (ufromfpx): Likewise. (ufromfpxf): Likewise. (ufromfpxl): Likewise. * math/Makefile (libm-calls): Add s_fromfpF, s_ufromfpF, s_fromfpxF and s_ufromfpxF. * math/gen-fromfp-tests.py: New file. * math/gen-fromfp-tests-inputs: Likewise. * math/libm-test.inc: Include <stdint.h> (check_intmax_t): New function. (check_uintmax_t): Likewise. (struct test_fiu_M_data): New type. (struct test_fiu_U_data): Likewise. (RUN_TEST_fiu_M): New macro. (RUN_TEST_LOOP_fiu_M): Likewise. (RUN_TEST_fiu_U): Likewise. (RUN_TEST_LOOP_fiu_U): Likewise. (fromfp_test_data): New array. (fromfp_test): New function. (fromfpx_test_data): New array. (fromfpx_test): New function. (ufromfp_test_data): New array. (ufromfp_test): New function. (ufromfpx_test_data): New array. (ufromfpx_test): New function. (main): Call fromfp_test, fromfpx_test, ufromfp_test and ufromfpx_test. * math/gen-libm-test.pl (parse_args): Handle u, M and U descriptor characters. * math/test-tgmath-ret.c: Include <stdint.h>. (rm): New variable. (width): Likewise. (CHECK_RET_CONST_TYPE): Take extra arguments and pass them to called function. (CHECK_RET_CONST_FLOAT): Take extra arguments and pass them to CHECK_RET_CONST_TYPE. (CHECK_RET_CONST_DOUBLE): Likewise. (CHECK_RET_CONST_LDOUBLE): Likewise. (CHECK_RET_CONST): Take extra arguments and pass them to calls macros. (fromfp): New CHECK_RET_CONST call. (ufromfp): Likewise. (fromfpx): Likewise. (ufromfpx): Likewise. (do_test): Call check_return_fromfp, check_return_ufromfp, check_return_fromfpx and check_return_ufromfpx. * math/test-tgmath.c: Include <stdint.h> (NCALLS): Increase to 138. (F(compile_test)): Initialize i. Call fromfp functions. (F(fromfp)): New function. (F(fromfpx)): Likewise. (F(ufromfp)): Likewise. (F(ufromfpx)): Likewise. * manual/arith.texi (Rounding Functions): Document FP_INT_UPWARD, FP_INT_DOWNWARD, FP_INT_TOWARDZERO, FP_INT_TONEARESTFROMZERO, FP_INT_TONEAREST, fromfp, fromfpf, fromfpl, ufromfp, ufromfpf, ufromfpl, fromfpx, fromfpxf, fromfpxl, ufromfpx, ufromfpxf and ufromfpxl. * manual/libm-err-tab.pl (@all_functions): Add fromfp, fromfpx, ufromfp and ufromfpx. * math/fromfp.h: New file. * sysdeps/ieee754/dbl-64/s_fromfp.c: Likewise. * sysdeps/ieee754/dbl-64/s_fromfp_main.c: Likewise. * sysdeps/ieee754/dbl-64/s_fromfpx.c: Likewise. * sysdeps/ieee754/dbl-64/s_ufromfp.c: Likewise. * sysdeps/ieee754/dbl-64/s_ufromfpx.c: Likewise. * sysdeps/ieee754/flt-32/s_fromfpf.c: Likewise. * sysdeps/ieee754/flt-32/s_fromfpf_main.c: Likewise. * sysdeps/ieee754/flt-32/s_fromfpxf.c: Likewise. * sysdeps/ieee754/flt-32/s_ufromfpf.c: Likewise. * sysdeps/ieee754/flt-32/s_ufromfpxf.c: Likewise. * sysdeps/ieee754/ldbl-128/s_fromfpl.c: Likewise. * sysdeps/ieee754/ldbl-128/s_fromfpl_main.c: Likewise. * sysdeps/ieee754/ldbl-128/s_fromfpxl.c: Likewise. * sysdeps/ieee754/ldbl-128/s_ufromfpl.c: Likewise. * sysdeps/ieee754/ldbl-128/s_ufromfpxl.c: Likewise. * sysdeps/ieee754/ldbl-128ibm/s_fromfpl.c: Likewise. * sysdeps/ieee754/ldbl-128ibm/s_fromfpl_main.c: Likewise. * sysdeps/ieee754/ldbl-128ibm/s_fromfpxl.c: Likewise. * sysdeps/ieee754/ldbl-128ibm/s_ufromfpl.c: Likewise. * sysdeps/ieee754/ldbl-128ibm/s_ufromfpxl.c: Likewise. * sysdeps/ieee754/ldbl-96/s_fromfpl.c: Likewise. * sysdeps/ieee754/ldbl-96/s_fromfpl_main.c: Likewise. * sysdeps/ieee754/ldbl-96/s_fromfpxl.c: Likewise. * sysdeps/ieee754/ldbl-96/s_ufromfpl.c: Likewise. * sysdeps/ieee754/ldbl-96/s_ufromfpxl.c: Likewise. * sysdeps/ieee754/ldbl-opt/Makefile (libnldbl-calls): Add fromfp, ufromfp, fromfpx and ufromfpx. (CFLAGS-nldbl-fromfp.c): New variable. (CFLAGS-nldbl-fromfpx.c): Likewise. (CFLAGS-nldbl-ufromfp.c): Likewise. (CFLAGS-nldbl-ufromfpx.c): Likewise. * sysdeps/ieee754/ldbl-opt/nldbl-compat.h: Include <stdint.h>. * sysdeps/ieee754/ldbl-opt/nldbl-fromfp.c: New file. * sysdeps/ieee754/ldbl-opt/nldbl-fromfpx.c: Likewise. * sysdeps/ieee754/ldbl-opt/nldbl-ufromfp.c: Likewise. * sysdeps/ieee754/ldbl-opt/nldbl-ufromfpx.c: Likewise. * sysdeps/nacl/libm.abilist: Update. * sysdeps/unix/sysv/linux/aarch64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/alpha/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/arm/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/hppa/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/i386/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/ia64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/m68k/coldfire/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/m68k/m680x0/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/microblaze/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/mips/mips32/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/mips/mips64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/nios2/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/libm-le.abilist: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/sh/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/tile/tilepro/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/x86_64/64/libm.abilist: Likewise. * sysdeps/unix/sysv/linux/x86_64/x32/libm.abilist: Likewise. |
||
|---|---|---|
| .. | ||
| aarch64 | ||
| alpha | ||
| arm | ||
| bits | ||
| generic | ||
| hppa | ||
| i386 | ||
| ia64 | ||
| include/sys | ||
| m68k | ||
| microblaze | ||
| mips | ||
| net | ||
| netash | ||
| netatalk | ||
| netax25 | ||
| neteconet | ||
| netinet | ||
| netipx | ||
| netiucv | ||
| netpacket | ||
| netrom | ||
| netrose | ||
| nfs | ||
| nios2 | ||
| powerpc | ||
| s390 | ||
| scsi | ||
| sh | ||
| sparc | ||
| sys | ||
| tile | ||
| wordsize-64 | ||
| x86 | ||
| x86_64 | ||
| Implies | ||
| Makefile | ||
| Versions | ||
| _G_config.h | ||
| _exit.c | ||
| a.out.h | ||
| accept.c | ||
| accept4.c | ||
| access.c | ||
| adjtime.c | ||
| aio_misc.h | ||
| aio_sigqueue.c | ||
| arch-fork.h | ||
| bind.c | ||
| check_native.c | ||
| check_pf.c | ||
| clock.c | ||
| clock_getcpuclockid.c | ||
| clock_getres.c | ||
| clock_gettime.c | ||
| clock_nanosleep.c | ||
| clock_settime.c | ||
| cmsg_nxthdr.c | ||
| configure | ||
| configure.ac | ||
| connect.c | ||
| createthread.c | ||
| default-sched.h | ||
| device-nrs.h | ||
| dl-brk.c | ||
| dl-execstack.c | ||
| dl-fxstatat64.c | ||
| dl-getcwd.c | ||
| dl-librecon.h | ||
| dl-openat64.c | ||
| dl-opendir.c | ||
| dl-origin.c | ||
| dl-osinfo.h | ||
| dl-sbrk.c | ||
| dl-sysdep.c | ||
| dl-sysdep.h | ||
| dl-vdso.c | ||
| dl-vdso.h | ||
| dl-writev.h | ||
| epoll_pwait.c | ||
| errqueue.h | ||
| eventfd_read.c | ||
| eventfd_write.c | ||
| exit-thread.h | ||
| faccessat.c | ||
| fallocate.c | ||
| fallocate64.c | ||
| fatal-prepare.h | ||
| fchmodat.c | ||
| fcntl.c | ||
| fd_to_filename.h | ||
| fexecve.c | ||
| fips-private.h | ||
| fpathconf.c | ||
| fstatfs64.c | ||
| fstatvfs.c | ||
| fstatvfs64.c | ||
| ftime.c | ||
| ftruncate.c | ||
| ftruncate64.c | ||
| futex-internal.h | ||
| futimens.c | ||
| futimes.c | ||
| futimesat.c | ||
| fxstat.c | ||
| fxstat64.c | ||
| fxstatat.c | ||
| fxstatat64.c | ||
| gai_sigqueue.c | ||
| getclktck.c | ||
| getcwd.c | ||
| getdents.c | ||
| getdents64.c | ||
| getdirentries.c | ||
| getdirentries64.c | ||
| getdtsz.c | ||
| getentropy.c | ||
| gethostid.c | ||
| getipv4sourcefilter.c | ||
| getloadavg.c | ||
| getlogin.c | ||
| getlogin_r.c | ||
| getpagesize.c | ||
| getpeername.c | ||
| getpriority.c | ||
| getpt.c | ||
| getrandom.c | ||
| getrlimit.c | ||
| getrlimit64.c | ||
| getsockname.c | ||
| getsockopt.c | ||
| getsourcefilter.c | ||
| getsysstats.c | ||
| gettimeofday.c | ||
| grantpt.c | ||
| if_index.c | ||
| ifaddrs.c | ||
| ifreq.c | ||
| internal_statvfs.c | ||
| internal_statvfs64.c | ||
| ipc_ops.h | ||
| ipc_priv.h | ||
| kernel-features.h | ||
| kernel-posix-cpu-timers.h | ||
| kernel-posix-timers.h | ||
| kernel_sigaction.h | ||
| kernel_stat.h | ||
| kernel_termios.h | ||
| ldd-rewrite.sed | ||
| lddlibc4.c | ||
| ldsodefs.h | ||
| libc_fatal.c | ||
| linux_fsinfo.h | ||
| listen.c | ||
| local-setxid.h | ||
| lowlevellock-futex.h | ||
| lseek.c | ||
| lseek64.c | ||
| lutimes.c | ||
| lxstat.c | ||
| lxstat64.c | ||
| malloc-sysdep.h | ||
| mmap64.c | ||
| mq_close.c | ||
| mq_getattr.c | ||
| mq_notify.c | ||
| mq_open.c | ||
| mq_receive.c | ||
| mq_send.c | ||
| mq_unlink.c | ||
| msgctl.c | ||
| msgget.c | ||
| msgrcv.c | ||
| msgsnd.c | ||
| netlink_assert_response.c | ||
| netlinkaccess.h | ||
| nice.c | ||
| not-cancel.h | ||
| nptl-signals.h | ||
| nscd_setup_thread.c | ||
| ntp_gettime.c | ||
| ntp_gettimex.c | ||
| open64.c | ||
| openat.c | ||
| openat64.c | ||
| opendir.c | ||
| opensock.c | ||
| pathconf.c | ||
| pathconf.h | ||
| paths.h | ||
| personality.c | ||
| posix_fadvise.c | ||
| posix_fadvise64.c | ||
| posix_fallocate.c | ||
| posix_fallocate64.c | ||
| posix_madvise.c | ||
| ppoll.c | ||
| pread.c | ||
| pread64.c | ||
| preadv.c | ||
| preadv64.c | ||
| prlimit.c | ||
| prof-freq.c | ||
| profil.c | ||
| pselect.c | ||
| pt-raise.c | ||
| pthread-pids.h | ||
| pthread_getaffinity.c | ||
| pthread_getcpuclockid.c | ||
| pthread_getname.c | ||
| pthread_kill.c | ||
| pthread_setaffinity.c | ||
| pthread_setname.c | ||
| pthread_sigmask.c | ||
| pthread_sigqueue.c | ||
| ptrace.c | ||
| ptsname.c | ||
| pwrite.c | ||
| pwrite64.c | ||
| pwritev.c | ||
| pwritev64.c | ||
| raise.c | ||
| readahead.c | ||
| readdir64.c | ||
| readdir64_r.c | ||
| readonly-area.c | ||
| reboot.c | ||
| recv.c | ||
| recvfrom.c | ||
| recvmmsg.c | ||
| recvmsg.c | ||
| remove.c | ||
| rename.c | ||
| renameat.c | ||
| sa_len.c | ||
| safe-fatal.h | ||
| sched_getaffinity.c | ||
| sched_getcpu.c | ||
| sched_setaffinity.c | ||
| segfault.c | ||
| semctl.c | ||
| semget.c | ||
| semop.c | ||
| semtimedop.c | ||
| send.c | ||
| sendmmsg.c | ||
| sendmsg.c | ||
| sendto.c | ||
| setegid.c | ||
| seteuid.c | ||
| setgid.c | ||
| setgroups.c | ||
| sethostid.c | ||
| setipv4sourcefilter.c | ||
| setregid.c | ||
| setresgid.c | ||
| setresuid.c | ||
| setreuid.c | ||
| setrlimit.c | ||
| setrlimit64.c | ||
| setsockopt.c | ||
| setsourcefilter.c | ||
| setuid.c | ||
| shlib-versions | ||
| shm-directory.c | ||
| shmat.c | ||
| shmctl.c | ||
| shmdt.c | ||
| shmget.c | ||
| shutdown.c | ||
| sigaction.c | ||
| siglist.h | ||
| signal.c | ||
| signalfd.c | ||
| sigpending.c | ||
| sigprocmask.c | ||
| sigqueue.c | ||
| sigreturn.c | ||
| sigset-cvt-mask.h | ||
| sigstack.c | ||
| sigsuspend.c | ||
| sigtimedwait.c | ||
| sigwait.c | ||
| sigwaitinfo.c | ||
| sizes.h | ||
| socket.c | ||
| socketcall.h | ||
| socketpair.c | ||
| spawni.c | ||
| speed.c | ||
| statfs64.c | ||
| statvfs.c | ||
| statvfs64.c | ||
| sync_file_range.c | ||
| syscalls.list | ||
| sysconf.c | ||
| sysctl.c | ||
| sysctl.mk | ||
| sysdep-vdso.h | ||
| sysdep.h | ||
| syslog.c | ||
| system.c | ||
| tcdrain.c | ||
| tcflow.c | ||
| tcflush.c | ||
| tcgetattr.c | ||
| tcgetpgrp.c | ||
| tcsendbrk.c | ||
| tcsetattr.c | ||
| tcsetpgrp.c | ||
| termio.h | ||
| time.c | ||
| timer_create.c | ||
| timer_delete.c | ||
| timer_getoverr.c | ||
| timer_gettime.c | ||
| timer_routines.c | ||
| timer_settime.c | ||
| times.c | ||
| timespec_get.c | ||
| truncate.c | ||
| truncate64.c | ||
| tst-affinity-pid.c | ||
| tst-affinity.c | ||
| tst-align-clone.c | ||
| tst-clone.c | ||
| tst-clone2.c | ||
| tst-fallocate-common.c | ||
| tst-fallocate.c | ||
| tst-fallocate64.c | ||
| tst-fanotify.c | ||
| tst-getpid1.c | ||
| tst-personality.c | ||
| tst-quota.c | ||
| tst-setgetname.c | ||
| tst-skeleton-affinity.c | ||
| tst-skeleton-thread-affinity.c | ||
| tst-sync_file_range.c | ||
| tst-thread-affinity-pthread.c | ||
| tst-thread-affinity-pthread2.c | ||
| tst-thread-affinity-sched.c | ||
| ttyname.c | ||
| ttyname_r.c | ||
| ualarm.c | ||
| umount.S | ||
| umount2.S | ||
| unlockpt.c | ||
| updwtmp.c | ||
| ustat.c | ||
| utimensat.c | ||
| utimes.c | ||
| utmp_file.c | ||
| vfork.c | ||
| wait.c | ||
| wait3.c | ||
| waitid.c | ||
| waitpid.c | ||
| xmknod.c | ||
| xmknodat.c | ||
| xstat.c | ||
| xstat64.c | ||
| xstatconv.c | ||
| xstatconv.h | ||