mirror of git://sourceware.org/git/glibc.git
a5721ebc68
For arguments with X^2 + Y^2 close to 1, clog and clog10 avoid large errors from log(hypot) by computing X^2 + Y^2 - 1 in a way that avoids cancellation error and then using log1p. However, the thresholds for using that approach still result in log being used on argument as large as sqrt(13/16) > 0.9, leading to significant errors, in some cases above the 9ulp maximum allowed in glibc libm. This patch arranges for the approach using log1p to be used in any cases where |X|, |Y| < 1 and X^2 + Y^2 >= 0.5 (with the existing allowance for cases where one of X and Y is very small), adjusting the __x2y2m1 functions to work with the wider range of inputs. This way, log only gets used on arguments below sqrt(1/2) (or substantially above 1), where the error involved is much less. Tested for x86_64, x86, mips64 and powerpc. For the ulps regeneration I removed the existing clog and clog10 ulps before regenerating to allow any reduced ulps to appear. Tests added include those found by random test generation to produce large ulps either before or after the patch, and some found by trying inputs close to the (0.75, 0.5) threshold where the potential errors from using log are largest. [BZ #19016] * sysdeps/generic/math_private.h (__x2y2m1f): Update comment to allow more cases with X^2 + Y^2 >= 0.5. * sysdeps/ieee754/dbl-64/x2y2m1.c (__x2y2m1): Likewise. Add -1 as normal element in sum instead of special-casing based on values of arguments. * sysdeps/ieee754/dbl-64/x2y2m1f.c (__x2y2m1f): Update comment. * sysdeps/ieee754/ldbl-128/x2y2m1l.c (__x2y2m1l): Likewise. Add -1 as normal element in sum instead of special-casing based on values of arguments. * sysdeps/ieee754/ldbl-128ibm/x2y2m1l.c (__x2y2m1l): Likewise. * sysdeps/ieee754/ldbl-96/x2y2m1.c [FLT_EVAL_METHOD != 0] (__x2y2m1): Update comment. * sysdeps/ieee754/ldbl-96/x2y2m1l.c (__x2y2m1l): Likewise. Add -1 as normal element in sum instead of special-casing based on values of arguments. * math/s_clog.c (__clog): Handle more cases using log1p without hypot. * math/s_clog10.c (__clog10): Likewise. * math/s_clog10f.c (__clog10f): Likewise. * math/s_clog10l.c (__clog10l): Likewise. * math/s_clogf.c (__clogf): Likewise. * math/s_clogl.c (__clogl): Likewise. * math/auto-libm-test-in: Add more tests of clog and clog10. * math/auto-libm-test-out: Regenerated. * sysdeps/i386/fpu/libm-test-ulps: Update. * sysdeps/x86_64/fpu/libm-test-ulps: Likewise. |
||
|---|---|---|
| .. | ||
| fpu | ||
| i586 | ||
| i686 | ||
| i786 | ||
| nptl | ||
| sys | ||
| Implies | ||
| Makefile | ||
| Versions | ||
| ____longjmp_chk.S | ||
| __longjmp.S | ||
| abort-instr.h | ||
| add_n.S | ||
| addmul_1.S | ||
| asm-syntax.h | ||
| atomic-machine.h | ||
| backtrace.c | ||
| bcopy.S | ||
| bsd-_setjmp.S | ||
| bsd-setjmp.S | ||
| bzero.S | ||
| cacheinfo.c | ||
| configure | ||
| configure.ac | ||
| crti.S | ||
| crtn.S | ||
| dl-irel.h | ||
| dl-lookupcfg.h | ||
| dl-machine.h | ||
| dl-procinfo.c | ||
| dl-procinfo.h | ||
| dl-tls.h | ||
| dl-tlsdesc.S | ||
| dl-tlsdesc.h | ||
| dl-trampoline.S | ||
| ffs.c | ||
| gccframe.h | ||
| gmp-mparam.h | ||
| htonl.S | ||
| htons.S | ||
| i386-mcount.S | ||
| init-arch.h | ||
| jmpbuf-offsets.h | ||
| jmpbuf-unwind.h | ||
| ldbl2mpn.c | ||
| ldsodefs.h | ||
| link-defines.sym | ||
| lshift.S | ||
| machine-gmon.h | ||
| memchr.S | ||
| memcmp.S | ||
| memcopy.h | ||
| memcpy.S | ||
| memcpy_chk.S | ||
| memmove.S | ||
| memmove_chk.S | ||
| mempcpy.S | ||
| mempcpy_chk.S | ||
| memset.S | ||
| memset_chk.S | ||
| memusage.h | ||
| mp_clz_tab.c | ||
| mul_1.S | ||
| preconfigure | ||
| pthread_spin_trylock.S | ||
| rawmemchr.S | ||
| rshift.S | ||
| setfpucw.c | ||
| setjmp.S | ||
| stackguard-macros.h | ||
| stackinfo.h | ||
| start.S | ||
| stpcpy.S | ||
| stpncpy.S | ||
| strcat.S | ||
| strchr.S | ||
| strchrnul.S | ||
| strcspn.S | ||
| string-inlines.c | ||
| strlen.S | ||
| strlen.c | ||
| strpbrk.S | ||
| strrchr.S | ||
| strspn.S | ||
| strtok.S | ||
| strtok_r.S | ||
| sub_n.S | ||
| submul_1.S | ||
| sysdep.h | ||
| tls-macros.h | ||
| tlsdesc.c | ||
| tlsdesc.sym | ||
| tst-audit.h | ||
| tst-audit3.c | ||
| tst-audit3.h | ||
| tst-auditmod3a.c | ||
| tst-auditmod3b.c | ||
| tst-ld-sse-use.sh | ||
| tst-stack-align.h | ||