mirror of git://sourceware.org/git/glibc.git
392b3f0971
The CORE-MATH implementation is correctly rounded (for any rounding mode).
This can be checked by exhaustive tests in a few minutes since there are
less than 2^32 values to check against for example GNU MPFR.
This patch also adds some bench values for tgammaf.
Tested on x86_64 and x86 (cfarm26).
With the initial GNU libc code it gave on an Intel(R) Core(TM) i7-8700:
"tgammaf": {
"": {
"duration": 3.50188e+09,
"iterations": 2e+07,
"max": 602.891,
"min": 65.1415,
"mean": 175.094
}
}
With the new code:
"tgammaf": {
"": {
"duration": 3.30825e+09,
"iterations": 5e+07,
"max": 211.592,
"min": 32.0325,
"mean": 66.1649
}
}
With the initial GNU libc code it gave on cfarm26 (i686):
"tgammaf": {
"": {
"duration": 3.70505e+09,
"iterations": 6e+06,
"max": 2420.23,
"min": 243.154,
"mean": 617.509
}
}
With the new code:
"tgammaf": {
"": {
"duration": 3.24497e+09,
"iterations": 1.8e+07,
"max": 1238.15,
"min": 101.155,
"mean": 180.276
}
}
Signed-off-by: Alexei Sibidanov <sibid@uvic.ca>
Signed-off-by: Paul Zimmermann <Paul.Zimmermann@inria.fr>
Changes in v2:
- include <math.h> (fix the linknamespace failures)
- restored original benchtests/strcoll-inputs/filelist#en_US.UTF-8 file
- restored original wrapper code (math/w_tgammaf_compat.c),
except for the dealing with the sign
- removed the tgammaf/float entries in all libm-test-ulps files
- address other comments from Joseph Myers
(https://sourceware.org/pipermail/libc-alpha/2024-July/158736.html)
Changes in v3:
- pass NULL argument for signgam from w_tgammaf_compat.c
- use of math_narrow_eval
- added more comments
Changes in v4:
- initialize local_signgam to 0 in math/w_tgamma_template.c
- replace sysdeps/ieee754/dbl-64/gamma_productf.c by dummy file
Changes in v5:
- do not mention local_signgam any more in math/w_tgammaf_compat.c
- initialize local_signgam to 1 instead of 0 in w_tgamma_template.c
and added comment
Changes in v6:
- pass NULL as 2nd argument of __ieee754_gammaf_r in
w_tgammaf_compat.c, and check for NULL in e_gammaf_r.c
Changes in v7:
- added Signed-off-by line for Alexei Sibidanov (author of the code)
Changes in v8:
- added Signed-off-by line for Paul Zimmermann (submitted of the patch)
Changes in v9:
- address comments from review by Adhemerval Zanella
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
|
||
|---|---|---|
| .. | ||
| Makefile | ||
| asincos.tbl | ||
| atnat.h | ||
| atnat2.h | ||
| branred.c | ||
| branred.h | ||
| dbl2mpn.c | ||
| dla.h | ||
| e_acos.c | ||
| e_acosh.c | ||
| e_asin.c | ||
| e_atan2.c | ||
| e_atanh.c | ||
| e_cosh.c | ||
| e_exp.c | ||
| e_exp2.c | ||
| e_exp10.c | ||
| e_exp_data.c | ||
| e_fmod.c | ||
| e_gamma_r.c | ||
| e_hypot.c | ||
| e_ilogb.c | ||
| e_j0.c | ||
| e_j1.c | ||
| e_jn.c | ||
| e_lgamma_r.c | ||
| e_log.c | ||
| e_log2.c | ||
| e_log2_data.c | ||
| e_log10.c | ||
| e_log_data.c | ||
| e_pow.c | ||
| e_pow_log_data.c | ||
| e_remainder.c | ||
| e_sinh.c | ||
| e_sqrt.c | ||
| gamma_product.c | ||
| gamma_productf.c | ||
| k_rem_pio2.c | ||
| k_tan.c | ||
| lgamma_neg.c | ||
| lgamma_product.c | ||
| math_config.h | ||
| math_err.c | ||
| mpn2dbl.c | ||
| mydefs.h | ||
| powtwo.tbl | ||
| root.tbl | ||
| s_asinh.c | ||
| s_atan.c | ||
| s_cbrt.c | ||
| s_ceil.c | ||
| s_copysign.c | ||
| s_cos.c | ||
| s_erf.c | ||
| s_expm1.c | ||
| s_f32xaddf64.c | ||
| s_f32xdivf64.c | ||
| s_f32xfmaf64.c | ||
| s_f32xmulf64.c | ||
| s_f32xsqrtf64.c | ||
| s_f32xsubf64.c | ||
| s_fabs.c | ||
| s_fadd.c | ||
| s_fdiv.c | ||
| s_ffma.c | ||
| s_finite.c | ||
| s_floor.c | ||
| s_fma.c | ||
| s_fmaf.c | ||
| s_fmul.c | ||
| s_fpclassify.c | ||
| s_frexp.c | ||
| s_fromfp.c | ||
| s_fromfp_main.c | ||
| s_fromfpx.c | ||
| s_fsqrt.c | ||
| s_fsub.c | ||
| s_getpayload.c | ||
| s_isinf.c | ||
| s_isnan.c | ||
| s_issignaling.c | ||
| s_llrint.c | ||
| s_llround.c | ||
| s_log1p.c | ||
| s_logb.c | ||
| s_lrint.c | ||
| s_lround.c | ||
| s_modf.c | ||
| s_nearbyint.c | ||
| s_nexttoward.c | ||
| s_nextup.c | ||
| s_remquo.c | ||
| s_rint.c | ||
| s_round.c | ||
| s_roundeven.c | ||
| s_scalbln.c | ||
| s_scalbn.c | ||
| s_setpayload.c | ||
| s_setpayload_main.c | ||
| s_setpayloadsig.c | ||
| s_signbit.c | ||
| s_sin.c | ||
| s_sincos.c | ||
| s_tan.c | ||
| s_tanh.c | ||
| s_totalorder.c | ||
| s_totalordermag.c | ||
| s_trunc.c | ||
| s_ufromfp.c | ||
| s_ufromfpx.c | ||
| sincostab.c | ||
| uasncs.h | ||
| uatan.tbl | ||
| urem.h | ||
| usncs.h | ||
| utan.h | ||
| utan.tbl | ||
| w_exp.c | ||
| w_exp2.c | ||
| w_exp10.c | ||
| w_fmod.c | ||
| w_hypot.c | ||
| w_log.c | ||
| w_log2.c | ||
| w_pow.c | ||
| x2y2m1.c | ||
| x2y2m1f.c | ||