mirror of git://sourceware.org/git/glibc.git
27f10a0963
As noted in bug 13888, and as I noted previously in <https://sourceware.org/ml/libc-alpha/2000-10/msg00111.html>, various tests used hardcoded paths in /tmp, so posing issues for simultaneous test runs from different build directories. This patch fixes such uses of hardcoded file names to put them in the build directory instead (in the case of stdio-common/bug5 the file names are changed as well, to avoid a conflict with the name bug5.out also used for the automatic test output redirection). It also fixes test-installation.pl likewise (that was using filenames with $$ in them rather than strictly hardcoded names, but that's still not good practice for temporary file naming). Note that my list of files changed is not identical to that in bug 13888. I added tst-spawn3.c and test-installation.pl, and removed some tests that seem to me (now) to create temporary files securely (simply using /tmp is not itself a problem if the temporary files are handled properly with mkstemp; I haven't checked whether those tests used to do things insecurely). conformtest is not changed because the makefiles always pass a --tmpdir option so the /tmp default is irrelevant, and for the same reason there is no actual problem with nptl/tst-umask1.c because again the makefiles always override the default. nptl/sockperf.c is ignored because there is no code to run it; probably that file should actually be removed. Some tests use the mktemp function, but I think they all use it in a way that *is* secure (for generating names for directories / sockets / fifos / symlinks, where the operation using the name will not follow symlinks and so there is no potential for a symlink attack on the account running the testsuite). Some tests use the tmpnam function to generate temporary file names. This is in principle insecure, but not addressed by this patch (I consider it a separate issue from the fully hardcoded paths). Tested for x86_64. [BZ #13888] * posix/Makefile (CFLAGS-tst-spawn3.c): New variable. * posix/tst-spawn3.c (do_test): Put tst-spwan3.pid in OBJPFX, not /tmp. * scripts/test-installation.pl: Put temporary files in build directory, not /tmp. * stdio-common/Makefile (CFLAGS-bug3.c): New variable. (CFLAGS-bug4.c): Likewise. (CFLAGS-bug5.c): Likewise. (CFLAGS-test-fseek.c): Likewise. (CFLAGS-test-popen.c): Likewise. (CFLAGS-test_rdwr.c): Likewise. * stdio-common/bug3.c (main): Put temporary file in OBJPFX, not /tmp. * stdio-common/bug4.c (main): Likewise. * stdio-common/bug5.c (main): Likewise. * stdio-common/test-fseek.c (TESTFILE): Likewise. * stdio-common/test-popen.c (do_test): Likewise. * stdio-common/test_rdwr.c (main): Likewise. |
||
|---|---|---|
| .. | ||
| abi-versions.awk | ||
| abilist.awk | ||
| backport-support.sh | ||
| build-many-glibcs.py | ||
| check-c++-types.sh | ||
| check-execstack.awk | ||
| check-initfini.awk | ||
| check-installed-headers.sh | ||
| check-local-headers.sh | ||
| check-localplt.awk | ||
| check-textrel.awk | ||
| config-uname.sh | ||
| config.guess | ||
| config.sub | ||
| cpp | ||
| cross-test-ssh.sh | ||
| documented.sh | ||
| evaluate-test.sh | ||
| firstversions.awk | ||
| gen-as-const.awk | ||
| gen-libc-abis | ||
| gen-libc-modules.awk | ||
| gen-posix-conf-vars.awk | ||
| gen-py-const.awk | ||
| gen-rrtypes.py | ||
| gen-sorted.awk | ||
| gen-tunables.awk | ||
| install-sh | ||
| lib-names.awk | ||
| list-fixed-bugs.py | ||
| list-sources.sh | ||
| localplt.awk | ||
| merge-test-results.sh | ||
| mkinstalldirs | ||
| move-if-change | ||
| output-format.sed | ||
| pylint | ||
| pylintrc | ||
| rellns-sh | ||
| soversions.awk | ||
| sysd-rules.awk | ||
| test-installation.pl | ||
| test_printers_common.py | ||
| test_printers_exceptions.py | ||
| update-abilist.sh | ||
| update-copyrights | ||
| versionlist.awk | ||
| versions.awk | ||