Fix multiple memory leaks in the locale program:
1. PUT (xstrdup (...)) leaks when tsearch finds a duplicate entry,
since tsearch returns the existing node and the newly allocated
string is orphaned. Introduce PUT_UNIQUE, which looks the name up
with GET first and only allocates when it is actually inserted.
2. String literals "POSIX" and "C" passed to PUT cannot be freed by
tdestroy. They now go through PUT_UNIQUE, which duplicates them,
so tdestroy (all_data, free) is safe.
3. Add tdestroy (all_data, free) at the end of write_locales and
write_charmaps to free the search trees.
4. Free dirents[cnt] entries in the scandir loop (only the dirents
array pointer was freed, not the individual entries).
5. Free alias_path allocated by argz_create_sep in write_locales.
Before this change "locale -a" leaked 74 bytes in 3 blocks directly
and 835 bytes in 49 blocks indirectly, and "locale -m" leaked 2190
bytes in 227 blocks. Both are valgrind-clean afterwards.
These leaks were reported by Arjun Shankar via GCC -fanalyzer
(OpenScanHub/Fedora).
Resolves: BZ #33972
Signed-off-by: Ruslan Valiyev <linuxoid@gmail.com>
Reviewed-by: Arjun Shankar <arjun@redhat.com>
Ruslan Valiyev
e474366724